@ryuenn3123/agentic-senior-core 2.5.14 → 2.5.16

package/scripts/release-gate.mjs

@@ -33,6 +33,8 @@ const FRONTEND_AUDIT_SCRIPT_PATH = 'scripts/frontend-usability-audit.mjs';
 const DOCUMENTATION_BOUNDARY_AUDIT_SCRIPT_PATH = 'scripts/documentation-boundary-audit.mjs';
 const CONTEXT_TRIGGERED_AUDIT_SCRIPT_PATH = 'scripts/context-triggered-audit.mjs';
 const RULES_GUARDIAN_AUDIT_SCRIPT_PATH = 'scripts/rules-guardian-audit.mjs';
+const EXPLAIN_ON_DEMAND_AUDIT_SCRIPT_PATH = 'scripts/explain-on-demand-audit.mjs';
+const SINGLE_SOURCE_LAZY_LOADING_AUDIT_SCRIPT_PATH = 'scripts/single-source-lazy-loading-audit.mjs';
 const BACKEND_ARCHITECTURE_RULE_PATH = '.agent-context/rules/architecture.md';
 const BACKEND_REVIEW_CHECKLIST_PATH = '.agent-context/review-checklists/pr-checklist.md';
 const REFACTOR_PROMPT_PATH = '.agent-context/prompts/refactor.md';
@@ -63,6 +65,8 @@ const REQUIRED_FRONTEND_EXCELLENCE_RUBRIC_SNIPPETS = [
   'Typography Quality',
   'Color System Diversity and Contrast',
   'Interaction Choreography',
+  'Language and Content Consistency',
+  'Text Contrast and Collision Safety',
   'UX Narrative and Conversion Clarity',
   'Template Diversity and Originality',
   'Low-Diversity Template Output Policy',
@@ -509,6 +513,166 @@ function runReleaseGate() {
     }
   }
 
+  const explainOnDemandAuditExecution = runMachineReadableScript(
+    EXPLAIN_ON_DEMAND_AUDIT_SCRIPT_PATH,
+    ['--mode', 'default', '--workflow', 'pr-preparation']
+  );
+  if (!explainOnDemandAuditExecution.report) {
+    const failureDetails = explainOnDemandAuditExecution.executionErrorMessage
+      ? `Explain-on-demand audit execution failed before producing a machine-readable report: ${explainOnDemandAuditExecution.executionErrorMessage}`
+      : 'Explain-on-demand audit did not produce machine-readable JSON output';
+    pushResult(results, false, 'explain-on-demand-audit', failureDetails);
+  } else {
+    diagnostics.explainOnDemandAudit = explainOnDemandAuditExecution.report;
+    pushResult(
+      results,
+      true,
+      'explain-on-demand-audit',
+      `explain-on-demand-audit executed (passed=${explainOnDemandAuditExecution.report.passed}, mode=${explainOnDemandAuditExecution.report.mode}, failures=${explainOnDemandAuditExecution.report.failureCount})`
+    );
+
+    const defaultHiddenStatePolicyPassed = explainOnDemandAuditExecution.report?.responsePolicy?.defaultModeExposesStateInternals === false
+      && explainOnDemandAuditExecution.report?.defaultResponse?.containsStateInternals === false;
+
+    if (defaultHiddenStatePolicyPassed) {
+      pushResult(
+        results,
+        true,
+        'explain-on-demand-default-hidden-state',
+        'Default response mode hides unnecessary state-file internals'
+      );
+    } else {
+      pushResult(
+        results,
+        false,
+        'explain-on-demand-default-hidden-state',
+        'Default response mode exposes state internals or visibility flags are inconsistent'
+      );
+    }
+
+    const diagnosticExplicitRequestPolicyPassed = explainOnDemandAuditExecution.report?.responsePolicy?.diagnosticRequiresExplicitRequest === true;
+
+    if (diagnosticExplicitRequestPolicyPassed) {
+      pushResult(
+        results,
+        true,
+        'explain-on-demand-explicit-request-gate',
+        'State internals are gated behind explicit diagnostic request'
+      );
+    } else {
+      pushResult(
+        results,
+        false,
+        'explain-on-demand-explicit-request-gate',
+        'Explain-on-demand policy does not require explicit diagnostic request'
+      );
+    }
+
+    const diagnosticExplainabilityPassed = explainOnDemandAuditExecution.report?.diagnosticMode?.canExplainStateDecisions === true;
+
+    if (diagnosticExplainabilityPassed) {
+      pushResult(
+        results,
+        true,
+        'explain-on-demand-diagnostic-explainability',
+        'Diagnostic mode can explain relevant state decisions when requested'
+      );
+    } else {
+      pushResult(
+        results,
+        false,
+        'explain-on-demand-diagnostic-explainability',
+        'Explain-on-demand audit cannot provide diagnostic state decision explanations'
+      );
+    }
+
+    if (explainOnDemandAuditExecution.report.passed === true) {
+      pushResult(
+        results,
+        true,
+        'explain-on-demand-hard-rule',
+        'Explain-on-demand hard-rule passed'
+      );
+    } else {
+      const failedAuditDetails = Array.isArray(explainOnDemandAuditExecution.report.failures)
+        ? explainOnDemandAuditExecution.report.failures.join('; ')
+        : 'Unknown explain-on-demand audit failures';
+      pushResult(
+        results,
+        false,
+        'explain-on-demand-hard-rule',
+        `Explain-on-demand audit failed: ${failedAuditDetails}`
+      );
+    }
+  }
+
+  const singleSourceLazyLoadingAuditExecution = runMachineReadableScript(
+    SINGLE_SOURCE_LAZY_LOADING_AUDIT_SCRIPT_PATH,
+    ['--workflow', 'pr-preparation']
+  );
+  if (!singleSourceLazyLoadingAuditExecution.report) {
+    const failureDetails = singleSourceLazyLoadingAuditExecution.executionErrorMessage
+      ? `Single-source lazy-loading audit execution failed before producing a machine-readable report: ${singleSourceLazyLoadingAuditExecution.executionErrorMessage}`
+      : 'Single-source lazy-loading audit did not produce machine-readable JSON output';
+    pushResult(results, false, 'single-source-lazy-loading-audit', failureDetails);
+  } else {
+    diagnostics.singleSourceLazyLoadingAudit = singleSourceLazyLoadingAuditExecution.report;
+    pushResult(
+      results,
+      true,
+      'single-source-lazy-loading-audit',
+      `single-source-lazy-loading-audit executed (passed=${singleSourceLazyLoadingAuditExecution.report.passed}, failures=${singleSourceLazyLoadingAuditExecution.report.failureCount})`
+    );
+
+    if (singleSourceLazyLoadingAuditExecution.report?.canonicalSource?.enforced === true) {
+      pushResult(
+        results,
+        true,
+        'canonical-rule-source-hard-rule',
+        'Canonical rule source is explicitly defined and enforced'
+      );
+    } else {
+      pushResult(
+        results,
+        false,
+        'canonical-rule-source-hard-rule',
+        'Canonical rule source enforcement failed in single-source lazy-loading audit'
+      );
+    }
+
+    if (singleSourceLazyLoadingAuditExecution.report?.lazyRuleLoading?.enforced === true) {
+      pushResult(
+        results,
+        true,
+        'lazy-rule-loading-hard-rule',
+        'Language-specific guidance is loaded lazily by detected scope'
+      );
+    } else {
+      pushResult(
+        results,
+        false,
+        'lazy-rule-loading-hard-rule',
+        'Lazy rule loading enforcement failed in single-source lazy-loading audit'
+      );
+    }
+
+    if (singleSourceLazyLoadingAuditExecution.report?.duplicationPolicy?.noConflictingDuplicates === true) {
+      pushResult(
+        results,
+        true,
+        'no-conflicting-duplicate-rule-instructions',
+        'No conflicting duplicate rule instructions detected in normal flow'
+      );
+    } else {
+      pushResult(
+        results,
+        false,
+        'no-conflicting-duplicate-rule-instructions',
+        'Conflicting duplicate rule instructions detected by single-source lazy-loading audit'
+      );
+    }
+  }
+
   const frontendParityChecklistContent = readText(FRONTEND_PARITY_CHECKLIST_PATH);
   if (!frontendParityChecklistContent) {
     pushResult(results, false, 'frontend-parity-checklist-exists', `Missing ${FRONTEND_PARITY_CHECKLIST_PATH}`);