@ryuenn3123/agentic-senior-core 2.0.4 → 2.0.7

package/scripts/validate.mjs

@@ -16,12 +16,14 @@
 import { readdir, readFile, stat } from 'node:fs/promises';
 import { dirname, join, relative, resolve } from 'node:path';
 import { fileURLToPath } from 'node:url';
+import { createHash } from 'node:crypto';
 import { validateSkillTopicContent } from './skill-tier-policy.mjs';
 import { calculateTrustScore } from './trust-scorer.mjs';
 
 const SCRIPT_FILE_PATH = fileURLToPath(import.meta.url);
 const ROOT_DIR = resolve(dirname(SCRIPT_FILE_PATH), '..');
 const AGENT_CONTEXT_DIR = join(ROOT_DIR, '.agent-context');
+const CANONICAL_INSTRUCTION_PATH = join(ROOT_DIR, '.instructions.md');
 const PACKAGE_JSON_PATH = join(ROOT_DIR, 'package.json');
 const CHANGELOG_PATH = join(ROOT_DIR, 'CHANGELOG.md');
 const README_PATH = join(ROOT_DIR, 'README.md');
@@ -32,6 +34,11 @@ const GENERATED_RULE_FILES = ['.cursorrules', '.windsurfrules'];
 const ALLOWED_SEVERITIES = new Set(['critical', 'high', 'medium', 'low']);
 const OVERRIDE_WARNING_WINDOW_DAYS = 30;
 const SUPPORTED_COMPATIBILITY_PLATFORMS = new Set(['windows', 'linux', 'macos']);
+const THIN_ADAPTER_PATHS = [
+  'AGENTS.md',
+  '.github/copilot-instructions.md',
+  '.gemini/instructions.md',
+];
 
 const validationResult = {
   passed: 0,
@@ -102,6 +109,10 @@ function warn(message) {
   console.log(`  WARN ${message}`);
 }
 
+function normalizeLineEndings(content) {
+  return content.replace(/\r\n/g, '\n').replace(/\r/g, '\n');
+}
+
 async function validateRequiredFiles() {
   console.log('\nChecking required files...');
 
@@ -112,6 +123,7 @@ async function validateRequiredFiles() {
     'scripts/detection-benchmark.mjs',
     'scripts/benchmark-gate.mjs',
     'scripts/benchmark-intelligence.mjs',
+    'scripts/governance-weekly-report.mjs',
     'scripts/frontend-usability-audit.mjs',
     'scripts/release-gate.mjs',
     'scripts/generate-sbom.mjs',
@@ -139,6 +151,7 @@ async function validateRequiredFiles() {
     '.github/workflows/release-gate.yml',
     '.github/workflows/sbom-compliance.yml',
     '.github/workflows/benchmark-intelligence.yml',
+    '.github/workflows/governance-weekly-report.yml',
     'tests/cli-smoke.test.mjs',
     'tests/llm-judge.test.mjs',
     'tests/enterprise-ops.test.mjs',
@@ -674,6 +687,52 @@ async function validateMcpConfiguration() {
   }
 }
 
+async function validateInstructionAdapters() {
+  console.log('\nChecking instruction adapter consolidation...');
+
+  const canonicalInstructionContent = normalizeLineEndings(await readTextFile(CANONICAL_INSTRUCTION_PATH));
+  const canonicalSnapshotHash = createHash('sha256').update(canonicalInstructionContent).digest('hex');
+
+  for (const thinAdapterPath of THIN_ADAPTER_PATHS) {
+    const absoluteAdapterPath = join(ROOT_DIR, thinAdapterPath);
+
+    if (!(await fileExists(absoluteAdapterPath))) {
+      fail(`Missing thin adapter file: ${thinAdapterPath}`);
+      continue;
+    }
+
+    const thinAdapterContent = await readTextFile(absoluteAdapterPath);
+
+    if (
+      thinAdapterContent.includes('Adapter Mode: thin')
+      && thinAdapterContent.includes('Adapter Source: .instructions.md')
+    ) {
+      pass(`${thinAdapterPath} declares thin adapter metadata`);
+    } else {
+      fail(`${thinAdapterPath} must declare Adapter Mode: thin and Adapter Source: .instructions.md`);
+    }
+
+    const hashMatch = thinAdapterContent.match(/Canonical Snapshot SHA256:\s*([a-f0-9]{64})/);
+    if (!hashMatch) {
+      fail(`${thinAdapterPath} must declare Canonical Snapshot SHA256`);
+      continue;
+    }
+
+    if (hashMatch[1] === canonicalSnapshotHash) {
+      pass(`${thinAdapterPath} canonical hash matches .instructions.md`);
+    } else {
+      fail(`${thinAdapterPath} canonical hash drift detected (expected ${canonicalSnapshotHash})`);
+    }
+
+    const thinAdapterLineCount = thinAdapterContent.split(/\r?\n/u).length;
+    if (thinAdapterLineCount <= 80) {
+      pass(`${thinAdapterPath} remains thin (${thinAdapterLineCount} lines)`);
+    } else {
+      fail(`${thinAdapterPath} is too large for thin-adapter mode (${thinAdapterLineCount} lines)`);
+    }
+  }
+}
+
 async function validateTrustTierSchema() {
   console.log('\nChecking marketplace trust tier schema...');
 
@@ -741,29 +800,32 @@ async function validateEvidenceBundles() {
       .filter(dirent => dirent.isDirectory())
       .map(dirent => dirent.name);
 
-  // We only DEMAND evidence from official skills if they want to be considered "Verified".
-  // Let's at least enforce they don't throw errors when scored.
-  // And specifically, 'cli' has a mocked evidence bundle, so it should score Verified.
+  const requiredVerifiedSkillNames = new Set([
+    'cli',
+    'frontend',
+    'fullstack',
+    'distribution',
+    'review-quality',
+  ]);
+
   for (const skillName of skillDirs) {
-      if (skillName === 'cli') {
-          try {
-             const result = await calculateTrustScore(join(skillsDir, skillName));
-             if (result.tier === 'verified') {
-                 pass(`Skill "${skillName}" achieved Verified trust tier (Score: ${result.score})`);
-             } else {
-                 fail(`Skill "${skillName}" failed to reach Verified tier. Got ${result.tier} (Score: ${result.score})`);
-                 console.log(result.dimensions);
-             }
-          } catch (err) {
-             fail(`Skill "${skillName}" scorer crashed: ${err.message}`);
-          }
-      } else {
-          try {
-             const result = await calculateTrustScore(join(skillsDir, skillName));
-             pass(`Skill "${skillName}" parses successfully as ${result.tier} tier`);
-          } catch (err) {
-             fail(`Skill "${skillName}" scorer crashed: ${err.message}`);
-          }
+      try {
+         const result = await calculateTrustScore(join(skillsDir, skillName));
+
+         if (requiredVerifiedSkillNames.has(skillName)) {
+           if (result.tier === 'verified') {
+             pass(`Skill "${skillName}" achieved Verified trust tier (Score: ${result.score})`);
+           } else {
+             fail(`Skill "${skillName}" failed to reach Verified tier. Got ${result.tier} (Score: ${result.score})`);
+             continue;
+           }
+
+           continue;
+         }
+
+         pass(`Skill "${skillName}" parses successfully as ${result.tier} tier`);
+      } catch (err) {
+         fail(`Skill "${skillName}" scorer crashed: ${err.message}`);
       }
   }
 }
@@ -786,6 +848,7 @@ async function main() {
   await validateVersionConsistency();
   await validateDocumentationFlow();
   await validateMcpConfiguration();
+  await validateInstructionAdapters();
   await validateTrustTierSchema();
   await validateEvidenceBundles();