@rytass/bpm-core-nestjs-module 0.13.1 → 0.13.2

package/CHANGELOG.md

@@ -1,3 +1,14 @@
+## 0.13.2 (2026-09-04)
+
+### 🩹 Fixes
+
+- **organization:** stop a deleted org unit from burning its code forever ([0f6897f](https://github.com/Rytass/BPMCore/commit/0f6897f))
+
+### ❤️ Thank You
+
+- Chia Yu Pai @fantasywind
+- Claude Opus 5
+
 ## 0.13.1 (2026-09-04)
 
 ### 🩹 Fixes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@rytass/bpm-core-nestjs-module",
-  "version": "0.13.1",
+  "version": "0.13.2",
   "description": "Embeddable NestJS BPM approval workflow module: workflow engine, approval templates, forms, organization/member contracts, attachments, signatures, notifications, delegation, and TypeORM migrations.",
   "keywords": [
     "bpm",
@@ -155,7 +155,7 @@
     "@nestjs/core": ">=10.0.0",
     "@nestjs/graphql": ">=12.0.0",
     "@nestjs/typeorm": ">=10.0.0",
-    "@rytass/bpm-core-shared": "^0.13.1",
+    "@rytass/bpm-core-shared": "^0.13.2",
     "@rytass/secret-adapter-vault-nestjs": ">=0.4.5",
     "express": ">=4.0.0",
     "graphql": ">=16.0.0",

package/src/lib/migrations/0000000022000-org-unit-code-active-unique.d.ts

@@ -0,0 +1,26 @@
+import { MigrationInterface, QueryRunner } from 'typeorm';
+/**
+ * Scopes the org unit code uniqueness to rows that are not soft-deleted.
+ *
+ * `org_units.code` was created as a plain `UNIQUE` column while
+ * `deleteOrgUnit` only soft-deletes and `assertOrgUnitCodeAvailable` looks for
+ * a clash among rows with `deleted_at IS NULL`. The two disagreed: the service
+ * cleared a recycled code, and the insert was then rejected by the database
+ * with a raw `duplicate key value violates unique constraint
+ * "org_units_code_key"` — naming a row no query can return, because it is soft
+ * deleted. Every deleted unit permanently consumed its code, which broke the
+ * ordinary "close a department and recreate it under the same code" operation.
+ *
+ * The partial index makes the schema agree with the service. Nothing about
+ * `assertOrgUnitCodeAvailable` changes; it was already the intended contract.
+ */
+export declare class OrgUnitCodeActiveUnique0000000022000 implements MigrationInterface {
+    name: string;
+    up(queryRunner: QueryRunner): Promise<void>;
+    /**
+     * Restoring the global constraint fails if any code has been reused since
+     * `up()` ran — which is precisely the operation this migration exists to
+     * allow. Free the duplicate codes first if you genuinely need to go back.
+     */
+    down(queryRunner: QueryRunner): Promise<void>;
+}

package/src/lib/migrations/0000000022000-org-unit-code-active-unique.js

@@ -0,0 +1,80 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.OrgUnitCodeActiveUnique0000000022000 = void 0;
+/**
+ * Scopes the org unit code uniqueness to rows that are not soft-deleted.
+ *
+ * `org_units.code` was created as a plain `UNIQUE` column while
+ * `deleteOrgUnit` only soft-deletes and `assertOrgUnitCodeAvailable` looks for
+ * a clash among rows with `deleted_at IS NULL`. The two disagreed: the service
+ * cleared a recycled code, and the insert was then rejected by the database
+ * with a raw `duplicate key value violates unique constraint
+ * "org_units_code_key"` — naming a row no query can return, because it is soft
+ * deleted. Every deleted unit permanently consumed its code, which broke the
+ * ordinary "close a department and recreate it under the same code" operation.
+ *
+ * The partial index makes the schema agree with the service. Nothing about
+ * `assertOrgUnitCodeAvailable` changes; it was already the intended contract.
+ */
+class OrgUnitCodeActiveUnique0000000022000 {
+    constructor() {
+        this.name = 'OrgUnitCodeActiveUnique0000000022000';
+    }
+    async up(queryRunner) {
+        // The constraint is auto-named `org_units_code_key` by PostgreSQL, but it
+        // is looked up by shape rather than by that name so a database created
+        // through any other path still converges here.
+        await queryRunner.query(`
+      DO $$
+      DECLARE
+        target regclass := to_regclass('org_units');
+        existing_constraint text;
+      BEGIN
+        IF target IS NULL THEN
+          RETURN;
+        END IF;
+
+        SELECT con.conname INTO existing_constraint
+        FROM pg_constraint con
+        WHERE con.conrelid = target
+          AND con.contype = 'u'
+          AND con.conkey = ARRAY[(
+            SELECT att.attnum
+            FROM pg_attribute att
+            WHERE att.attrelid = target
+              AND att.attname = 'code'
+              AND NOT att.attisdropped
+          )]::smallint[];
+
+        IF existing_constraint IS NOT NULL THEN
+          EXECUTE format(
+            'ALTER TABLE %s DROP CONSTRAINT %I', target::text, existing_constraint
+          );
+        END IF;
+      END $$
+    `);
+        // Safe on an existing database: the constraint just dropped already
+        // guaranteed global uniqueness, so the live rows cannot collide.
+        await queryRunner.query(`
+      CREATE UNIQUE INDEX IF NOT EXISTS "org_units_code_active_key"
+      ON "org_units" ("code")
+      WHERE "deleted_at" IS NULL
+    `);
+    }
+    /**
+     * Restoring the global constraint fails if any code has been reused since
+     * `up()` ran — which is precisely the operation this migration exists to
+     * allow. Free the duplicate codes first if you genuinely need to go back.
+     */
+    async down(queryRunner) {
+        await queryRunner.query(`
+      DROP INDEX IF EXISTS "org_units_code_active_key"
+    `);
+        await queryRunner.query(`
+      ALTER TABLE "org_units"
+      ADD CONSTRAINT "org_units_code_key" UNIQUE ("code")
+    `);
+    }
+}
+exports.OrgUnitCodeActiveUnique0000000022000 = OrgUnitCodeActiveUnique0000000022000;
+//# sourceMappingURL=0000000022000-org-unit-code-active-unique.js.map

package/src/lib/migrations/0000000022000-org-unit-code-active-unique.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"0000000022000-org-unit-code-active-unique.js","sourceRoot":"","sources":["../../../../../../libs/bpm-core/src/lib/migrations/0000000022000-org-unit-code-active-unique.ts"],"names":[],"mappings":";;;AAEA;;;;;;;;;;;;;;GAcG;AACH,MAAa,oCAAoC;IAAjD;QACE,SAAI,GAAG,sCAAsC,CAAC;IA4DhD,CAAC;IA1DC,KAAK,CAAC,EAAE,CAAC,WAAwB;QAC/B,0EAA0E;QAC1E,uEAAuE;QACvE,+CAA+C;QAC/C,MAAM,WAAW,CAAC,KAAK,CAAC;;;;;;;;;;;;;;;;;;;;;;;;;;;;KA4BvB,CAAC,CAAC;QAEH,oEAAoE;QACpE,iEAAiE;QACjE,MAAM,WAAW,CAAC,KAAK,CAAC;;;;KAIvB,CAAC,CAAC;IACL,CAAC;IAED;;;;OAIG;IACH,KAAK,CAAC,IAAI,CAAC,WAAwB;QACjC,MAAM,WAAW,CAAC,KAAK,CAAC;;KAEvB,CAAC,CAAC;QAEH,MAAM,WAAW,CAAC,KAAK,CAAC;;;KAGvB,CAAC,CAAC;IACL,CAAC;CACF;AA7DD,oFA6DC"}

package/src/lib/migrations/index.d.ts

@@ -22,3 +22,4 @@ export * from './0000000018000-notification-archive';
 export * from './0000000019000-approval-template-activation';
 export * from './0000000020000-form-data-option-snapshots';
 export * from './0000000021000-notification-silenced';
+export * from './0000000022000-org-unit-code-active-unique';

package/src/lib/migrations/index.js

@@ -24,6 +24,7 @@ const _0000000018000_notification_archive_1 = require("./0000000018000-notificat
 const _0000000019000_approval_template_activation_1 = require("./0000000019000-approval-template-activation");
 const _0000000020000_form_data_option_snapshots_1 = require("./0000000020000-form-data-option-snapshots");
 const _0000000021000_notification_silenced_1 = require("./0000000021000-notification-silenced");
+const _0000000022000_org_unit_code_active_unique_1 = require("./0000000022000-org-unit-code-active-unique");
 exports.BPM_CORE_MIGRATIONS = [
     _0000000000001_enable_postgres_extensions_1.EnablePostgresExtensions0000000000001,
     _0000000001000_identity_organization_foundation_1.IdentityOrganizationFoundation0000000001000,
@@ -47,6 +48,7 @@ exports.BPM_CORE_MIGRATIONS = [
     _0000000019000_approval_template_activation_1.ApprovalTemplateActivation0000000019000,
     _0000000020000_form_data_option_snapshots_1.FormDataOptionSnapshots0000000020000,
     _0000000021000_notification_silenced_1.NotificationSilenced0000000021000,
+    _0000000022000_org_unit_code_active_unique_1.OrgUnitCodeActiveUnique0000000022000,
 ];
 tslib_1.__exportStar(require("./0000000000001-enable-postgres-extensions"), exports);
 tslib_1.__exportStar(require("./0000000001000-identity-organization-foundation"), exports);
@@ -70,4 +72,5 @@ tslib_1.__exportStar(require("./0000000018000-notification-archive"), exports);
 tslib_1.__exportStar(require("./0000000019000-approval-template-activation"), exports);
 tslib_1.__exportStar(require("./0000000020000-form-data-option-snapshots"), exports);
 tslib_1.__exportStar(require("./0000000021000-notification-silenced"), exports);
+tslib_1.__exportStar(require("./0000000022000-org-unit-code-active-unique"), exports);
 //# sourceMappingURL=index.js.map

package/src/lib/migrations/index.js.map

@@ -1 +1 @@
-{"version":3,"file":"index.js","sourceRoot":"","sources":["../../../../../../libs/bpm-core/src/lib/migrations/index.ts"],"names":[],"mappings":";;;;AACA,0GAAmG;AACnG,sHAA+G;AAC/G,oGAA6F;AAC7F,8GAAuG;AACvG,0GAAmG;AACnG,sFAAgF;AAChF,wFAAkF;AAClF,kGAA4F;AAC5F,8GAAuG;AACvG,oFAA8E;AAC9E,4GAAqG;AACrG,sHAA8G;AAC9G,8GAAuG;AACvG,kGAA2F;AAC3F,oGAA8F;AAC9F,kIAA0H;AAC1H,8GAAsG;AACtG,sFAAgF;AAChF,8FAAwF;AACxF,8GAAuG;AACvG,0GAAkG;AAClG,gGAA0F;AAE7E,QAAA,mBAAmB,GAA8C;IAC5E,iFAAqC;IACrC,6FAA2C;IAC3C,2EAAkC;IAClC,qFAAuC;IACvC,iFAAqC;IACrC,8DAA4B;IAC5B,gEAA6B;IAC7B,0EAAkC;IAClC,qFAAuC;IACvC,4DAA2B;IAC3B,mFAAsC;IACtC,4FAA0C;IAC1C,qFAAuC;IACvC,yEAAiC;IACjC,4EAAmC;IACnC,wGAAgD;IAChD,oFAAsC;IACtC,8DAA4B;IAC5B,sEAAgC;IAChC,qFAAuC;IACvC,gFAAoC;IACpC,wEAAiC;CAClC,CAAC;AAEF,qFAA2D;AAC3D,2FAAiE;AACjE,kFAAwD;AACxD,uFAA6D;AAC7D,qFAA2D;AAC3D,2EAAiD;AACjD,4EAAkD;AAClD,iFAAuD;AACvD,uFAA6D;AAC7D,0EAAgD;AAChD,sFAA4D;AAC5D,2FAAiE;AACjE,uFAA6D;AAC7D,iFAAuD;AACvD,kFAAwD;AACxD,iGAAuE;AACvE,uFAA6D;AAC7D,2EAAiD;AACjD,+EAAqD;AACrD,uFAA6D;AAC7D,qFAA2D;AAC3D,gFAAsD"}
+{"version":3,"file":"index.js","sourceRoot":"","sources":["../../../../../../libs/bpm-core/src/lib/migrations/index.ts"],"names":[],"mappings":";;;;AACA,0GAAmG;AACnG,sHAA+G;AAC/G,oGAA6F;AAC7F,8GAAuG;AACvG,0GAAmG;AACnG,sFAAgF;AAChF,wFAAkF;AAClF,kGAA4F;AAC5F,8GAAuG;AACvG,oFAA8E;AAC9E,4GAAqG;AACrG,sHAA8G;AAC9G,8GAAuG;AACvG,kGAA2F;AAC3F,oGAA8F;AAC9F,kIAA0H;AAC1H,8GAAsG;AACtG,sFAAgF;AAChF,8FAAwF;AACxF,8GAAuG;AACvG,0GAAkG;AAClG,gGAA0F;AAC1F,4GAAmG;AAEtF,QAAA,mBAAmB,GAA8C;IAC5E,iFAAqC;IACrC,6FAA2C;IAC3C,2EAAkC;IAClC,qFAAuC;IACvC,iFAAqC;IACrC,8DAA4B;IAC5B,gEAA6B;IAC7B,0EAAkC;IAClC,qFAAuC;IACvC,4DAA2B;IAC3B,mFAAsC;IACtC,4FAA0C;IAC1C,qFAAuC;IACvC,yEAAiC;IACjC,4EAAmC;IACnC,wGAAgD;IAChD,oFAAsC;IACtC,8DAA4B;IAC5B,sEAAgC;IAChC,qFAAuC;IACvC,gFAAoC;IACpC,wEAAiC;IACjC,iFAAoC;CACrC,CAAC;AAEF,qFAA2D;AAC3D,2FAAiE;AACjE,kFAAwD;AACxD,uFAA6D;AAC7D,qFAA2D;AAC3D,2EAAiD;AACjD,4EAAkD;AAClD,iFAAuD;AACvD,uFAA6D;AAC7D,0EAAgD;AAChD,sFAA4D;AAC5D,2FAAiE;AACjE,uFAA6D;AAC7D,iFAAuD;AACvD,kFAAwD;AACxD,iGAAuE;AACvE,uFAA6D;AAC7D,2EAAiD;AACjD,+EAAqD;AACrD,uFAA6D;AAC7D,qFAA2D;AAC3D,gFAAsD;AACtD,sFAA4D"}

package/src/lib/organization/org-unit.entity.d.ts

@@ -1,4 +1,13 @@
 import { OrgUnitTypeEnum } from './organization.enums';
+/**
+ * Codes are unique among *live* units only.
+ *
+ * A plain `unique: true` on `code` would outlive the soft delete and burn the
+ * code forever, while `assertOrgUnitCodeAvailable` — which ignores
+ * soft-deleted rows — would keep clearing it and let the insert fail in the
+ * driver instead. Keep this partial index in step with migration
+ * `OrgUnitCodeActiveUnique0000000022000`.
+ */
 export declare class OrgUnitEntity {
     id: string;
     parentId: string | null;

package/src/lib/organization/org-unit.entity.js

@@ -5,6 +5,15 @@ const tslib_1 = require("tslib");
 const graphql_1 = require("@nestjs/graphql");
 const typeorm_1 = require("typeorm");
 const organization_enums_1 = require("./organization.enums");
+/**
+ * Codes are unique among *live* units only.
+ *
+ * A plain `unique: true` on `code` would outlive the soft delete and burn the
+ * code forever, while `assertOrgUnitCodeAvailable` — which ignores
+ * soft-deleted rows — would keep clearing it and let the insert fail in the
+ * driver instead. Keep this partial index in step with migration
+ * `OrgUnitCodeActiveUnique0000000022000`.
+ */
 let OrgUnitEntity = class OrgUnitEntity {
 };
 exports.OrgUnitEntity = OrgUnitEntity;
@@ -19,7 +28,7 @@ tslib_1.__decorate([
     tslib_1.__metadata("design:type", Object)
 ], OrgUnitEntity.prototype, "parentId", void 0);
 tslib_1.__decorate([
-    (0, typeorm_1.Column)('text', { unique: true }),
+    (0, typeorm_1.Column)('text'),
     (0, graphql_1.Field)(),
     tslib_1.__metadata("design:type", String)
 ], OrgUnitEntity.prototype, "code", void 0);
@@ -58,6 +67,10 @@ tslib_1.__decorate([
     tslib_1.__metadata("design:type", Date)
 ], OrgUnitEntity.prototype, "updatedAt", void 0);
 exports.OrgUnitEntity = OrgUnitEntity = tslib_1.__decorate([
+    (0, typeorm_1.Index)('org_units_code_active_key', ['code'], {
+        unique: true,
+        where: '"deleted_at" IS NULL',
+    }),
     (0, typeorm_1.Entity)('org_units'),
     (0, graphql_1.ObjectType)('OrgUnit')
 ], OrgUnitEntity);

package/src/lib/organization/org-unit.entity.js.map

@@ -1 +1 @@
-{"version":3,"file":"org-unit.entity.js","sourceRoot":"","sources":["../../../../../../libs/bpm-core/src/lib/organization/org-unit.entity.ts"],"names":[],"mappings":";;;;AAAA,6CAAwD;AACxD,qCAOiB;AACjB,6DAAuD;AAIhD,IAAM,aAAa,GAAnB,MAAM,aAAa;CAuCzB,CAAA;AAvCY,sCAAa;AAGxB;IAFC,IAAA,gCAAsB,EAAC,MAAM,CAAC;IAC9B,IAAA,eAAK,EAAC,GAAG,EAAE,CAAC,YAAE,CAAC;;yCACJ;AAIZ;IAFC,IAAA,gBAAM,EAAC,MAAM,EAAE,EAAE,IAAI,EAAE,WAAW,EAAE,QAAQ,EAAE,IAAI,EAAE,CAAC;IACrD,IAAA,eAAK,EAAC,GAAG,EAAE,CAAC,YAAE,EAAE,EAAE,QAAQ,EAAE,IAAI,EAAE,CAAC;;+CACX;AAIzB;IAFC,IAAA,gBAAM,EAAC,MAAM,EAAE,EAAE,MAAM,EAAE,IAAI,EAAE,CAAC;IAChC,IAAA,eAAK,GAAE;;2CACM;AAId;IAFC,IAAA,gBAAM,EAAC,MAAM,CAAC;IACd,IAAA,eAAK,GAAE;;2CACM;AAId;IAFC,IAAA,gBAAM,EAAC,MAAM,CAAC;IACd,IAAA,eAAK,EAAC,GAAG,EAAE,CAAC,oCAAe,CAAC;;2CACN;AAIvB;IAFC,IAAA,gBAAM,EAAC,OAAO,CAAC;IACf,IAAA,eAAK,GAAE;;2CACM;AAGd;IADC,IAAA,gBAAM,EAAC,OAAO,EAAE,EAAE,OAAO,EAAE,EAAE,EAAE,CAAC;;+CACY;AAI7C;IAFC,IAAA,0BAAgB,EAAC,EAAE,IAAI,EAAE,YAAY,EAAE,IAAI,EAAE,aAAa,EAAE,CAAC;IAC7D,IAAA,eAAK,EAAC,GAAG,EAAE,CAAC,IAAI,EAAE,EAAE,QAAQ,EAAE,IAAI,EAAE,CAAC;;gDACd;AAIxB;IAFC,IAAA,0BAAgB,EAAC,EAAE,IAAI,EAAE,YAAY,EAAE,IAAI,EAAE,aAAa,EAAE,CAAC;IAC7D,IAAA,eAAK,GAAE;sCACI,IAAI;gDAAC;AAIjB;IAFC,IAAA,0BAAgB,EAAC,EAAE,IAAI,EAAE,YAAY,EAAE,IAAI,EAAE,aAAa,EAAE,CAAC;IAC7D,IAAA,eAAK,GAAE;sCACI,IAAI;gDAAC;wBAtCN,aAAa;IAFzB,IAAA,gBAAM,EAAC,WAAW,CAAC;IACnB,IAAA,oBAAU,EAAC,SAAS,CAAC;GACT,aAAa,CAuCzB"}
+{"version":3,"file":"org-unit.entity.js","sourceRoot":"","sources":["../../../../../../libs/bpm-core/src/lib/organization/org-unit.entity.ts"],"names":[],"mappings":";;;;AAAA,6CAAwD;AACxD,qCAQiB;AACjB,6DAAuD;AAEvD;;;;;;;;GAQG;AAOI,IAAM,aAAa,GAAnB,MAAM,aAAa;CAuCzB,CAAA;AAvCY,sCAAa;AAGxB;IAFC,IAAA,gCAAsB,EAAC,MAAM,CAAC;IAC9B,IAAA,eAAK,EAAC,GAAG,EAAE,CAAC,YAAE,CAAC;;yCACJ;AAIZ;IAFC,IAAA,gBAAM,EAAC,MAAM,EAAE,EAAE,IAAI,EAAE,WAAW,EAAE,QAAQ,EAAE,IAAI,EAAE,CAAC;IACrD,IAAA,eAAK,EAAC,GAAG,EAAE,CAAC,YAAE,EAAE,EAAE,QAAQ,EAAE,IAAI,EAAE,CAAC;;+CACX;AAIzB;IAFC,IAAA,gBAAM,EAAC,MAAM,CAAC;IACd,IAAA,eAAK,GAAE;;2CACM;AAId;IAFC,IAAA,gBAAM,EAAC,MAAM,CAAC;IACd,IAAA,eAAK,GAAE;;2CACM;AAId;IAFC,IAAA,gBAAM,EAAC,MAAM,CAAC;IACd,IAAA,eAAK,EAAC,GAAG,EAAE,CAAC,oCAAe,CAAC;;2CACN;AAIvB;IAFC,IAAA,gBAAM,EAAC,OAAO,CAAC;IACf,IAAA,eAAK,GAAE;;2CACM;AAGd;IADC,IAAA,gBAAM,EAAC,OAAO,EAAE,EAAE,OAAO,EAAE,EAAE,EAAE,CAAC;;+CACY;AAI7C;IAFC,IAAA,0BAAgB,EAAC,EAAE,IAAI,EAAE,YAAY,EAAE,IAAI,EAAE,aAAa,EAAE,CAAC;IAC7D,IAAA,eAAK,EAAC,GAAG,EAAE,CAAC,IAAI,EAAE,EAAE,QAAQ,EAAE,IAAI,EAAE,CAAC;;gDACd;AAIxB;IAFC,IAAA,0BAAgB,EAAC,EAAE,IAAI,EAAE,YAAY,EAAE,IAAI,EAAE,aAAa,EAAE,CAAC;IAC7D,IAAA,eAAK,GAAE;sCACI,IAAI;gDAAC;AAIjB;IAFC,IAAA,0BAAgB,EAAC,EAAE,IAAI,EAAE,YAAY,EAAE,IAAI,EAAE,aAAa,EAAE,CAAC;IAC7D,IAAA,eAAK,GAAE;sCACI,IAAI;gDAAC;wBAtCN,aAAa;IANzB,IAAA,eAAK,EAAC,2BAA2B,EAAE,CAAC,MAAM,CAAC,EAAE;QAC5C,MAAM,EAAE,IAAI;QACZ,KAAK,EAAE,sBAAsB;KAC9B,CAAC;IACD,IAAA,gBAAM,EAAC,WAAW,CAAC;IACnB,IAAA,oBAAU,EAAC,SAAS,CAAC;GACT,aAAa,CAuCzB"}