@ryanfw/prompt-orchestration-pipeline 1.3.2 → 1.3.4

package/src/core/status-writer.ts

@@ -1,6 +1,5 @@
 import { rename, unlink, mkdir, open } from "node:fs/promises";
 import { basename, dirname, join } from "node:path";
-import { createJobLogger } from "./logger";
 import type { NormalizedError } from "./pipeline-runner";
 
 export type JobState = "pending" | "running" | "waiting" | "done" | "failed";
@@ -12,6 +11,7 @@ export interface GateInfo {
   message: string;
   artifacts?: string[];
   requestedAt: string;
+  kind?: "approval" | "control_invalid";
 }
 
 export interface FilesManifest {
@@ -37,6 +37,7 @@ export interface TaskEntry {
   skipReason?: string;
   skippedBy?: string;
   controlApplied?: boolean;
+  controlError?: { message: string; violations?: string[] };
   stageLogPath?: string;
   errorContext?: Record<string, unknown>;
   files?: FilesManifest;
@@ -96,6 +97,7 @@ function clearResetTaskMetadata(task: TaskEntry): void {
   delete task.retrying;
   delete task.nextRetryAt;
   delete task.lastRetryError;
+  delete task.controlError;
 }
 
 export function validateFilePath(filename: string): boolean {
@@ -199,18 +201,37 @@ export async function flushJobStatus(jobDir: string): Promise<void> {
 
 const writeQueues = new Map<string, Promise<StatusSnapshot>>();
 
-export async function readJobStatus(jobDir: string): Promise<StatusSnapshot | null> {
+export type StatusReadResult =
+  | { ok: true; value: StatusSnapshot }
+  | { ok: false; reason: "missing" | "corrupt" };
+
+export async function readJobStatusResult(jobDir: string): Promise<StatusReadResult> {
   if (typeof jobDir !== "string" || jobDir.length === 0) {
     throw new Error("jobDir must be a non-empty string");
   }
 
   const statusPath = join(jobDir, STATUS_FILENAME);
   try {
-    const text = await Bun.file(statusPath).text();
-    const raw = JSON.parse(text);
-    return validateStatusSnapshot(raw, jobDir);
+    const raw = JSON.parse(await Bun.file(statusPath).text());
+    return { ok: true, value: validateStatusSnapshot(raw, jobDir) };
+  } catch (err: unknown) {
+    if ((err as NodeJS.ErrnoException).code === "ENOENT") return { ok: false, reason: "missing" };
+    if (err instanceof SyntaxError) return { ok: false, reason: "corrupt" };
+    throw err;
+  }
+}
+
+/** @deprecated conflates missing and corrupt as null; use readJobStatusResult. */
+export async function readJobStatus(jobDir: string): Promise<StatusSnapshot | null> {
+  if (typeof jobDir !== "string" || jobDir.length === 0) {
+    throw new Error("jobDir must be a non-empty string");
+  }
+
+  try {
+    const result = await readJobStatusResult(jobDir);
+    return result.ok ? result.value : null;
   } catch (err) {
-    console.warn(`readJobStatus: could not read ${statusPath}`, err);
+    console.warn(`readJobStatus: could not read status for ${jobDir}`, err);
     return null;
   }
 }
@@ -253,13 +274,6 @@ export function updateTaskStatus(jobDir: string, taskId: string, taskUpdateFn: T
 
     await atomicWrite(statusPath, JSON.stringify(snapshot, null, 2));
 
-    const logger = createJobLogger("status-writer", jobId);
-    try {
-      logger.sse("task:updated", { jobId, taskId, task: snapshot.tasks[taskId] });
-    } catch (err) {
-      logger.error("SSE task:updated emission failed", err);
-    }
-
     return snapshot;
   }
 }
@@ -411,26 +425,6 @@ export function writeJobStatus(jobDir: string, updateFn: StatusUpdateFn): Promis
 
     await atomicWrite(statusPath, JSON.stringify(snapshot, null, 2));
 
-    const logger = createJobLogger("status-writer", jobId);
-    try {
-      logger.sse("state:change", { path: statusPath, id: snapshot.id, jobId });
-    } catch (err) {
-      logger.error("SSE state:change emission failed", err);
-    }
-
-    if (snapshot.lifecycleBlockReason) {
-      try {
-        logger.sse("lifecycle_block", {
-          jobId,
-          taskId: snapshot.lifecycleBlockTaskId,
-          op: snapshot.lifecycleBlockOp,
-          reason: snapshot.lifecycleBlockReason,
-        });
-      } catch (err) {
-        logger.error("SSE lifecycle_block emission failed", err);
-      }
-    }
-
     return snapshot;
   }
 }