@ryanatkn/gro 0.130.0 → 0.130.1

package/dist/package.js

@@ -1,7 +1,7 @@
 // generated by src/lib/package.gen.ts
 export const package_json = {
     name: '@ryanatkn/gro',
-    version: '0.130.0',
+    version: '0.130.1',
     description: 'task runner and toolkit extending SvelteKit',
     motto: 'generate, run, optimize',
     glyph: '🌰',
@@ -266,7 +266,7 @@ export const package_json = {
 };
 export const src_json = {
     name: '@ryanatkn/gro',
-    version: '0.130.0',
+    version: '0.130.1',
     modules: {
         '.': {
             path: 'index.ts',

package/dist/publish.task.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"publish.task.d.ts","sourceRoot":"../src/lib/","sources":["publish.task.ts"],"names":[],"mappings":"AACA,OAAO,EAAC,CAAC,EAAC,MAAM,KAAK,CAAC;AAItB,OAAO,EAAa,KAAK,IAAI,EAAC,MAAM,WAAW,CAAC;AAwBhD,eAAO,MAAM,IAAI;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;EA2BP,CAAC;AACX,MAAM,MAAM,IAAI,GAAG,CAAC,CAAC,KAAK,CAAC,OAAO,IAAI,CAAC,CAAC;AAExC,eAAO,MAAM,IAAI,EAAE,IAAI,CAAC,IAAI,CAsI3B,CAAC"}
+{"version":3,"file":"publish.task.d.ts","sourceRoot":"../src/lib/","sources":["publish.task.ts"],"names":[],"mappings":"AACA,OAAO,EAAC,CAAC,EAAC,MAAM,KAAK,CAAC;AAItB,OAAO,EAAa,KAAK,IAAI,EAAC,MAAM,WAAW,CAAC;AAwBhD,eAAO,MAAM,IAAI;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;EA2BP,CAAC;AACX,MAAM,MAAM,IAAI,GAAG,CAAC,CAAC,KAAK,CAAC,OAAO,IAAI,CAAC,CAAC;AAExC,eAAO,MAAM,IAAI,EAAE,IAAI,CAAC,IAAI,CA+I3B,CAAC"}

package/dist/publish.task.js

@@ -79,6 +79,7 @@ export const task = {
             await invoke_task('check', { workspace: true });
         }
         let version;
+        let optional_and_version_unchanged = false;
         // Bump the version so the package.json is updated before building:
         // TODO problem here is build may fail and put us in a bad state,
         // but I don't see how we could do this to robustly
@@ -116,16 +117,24 @@ export const task = {
                 // The version didn't change.
                 // For now this is the best detection we have for a no-op `changeset version`.
                 if (optional) {
-                    return; // exit gracefully
+                    optional_and_version_unchanged = true;
                 }
                 else {
+                    // Doesn't build if the version didn't change and publishing isn't optional.
                     throw new Task_Error(`\`${changeset_cli} version\` failed: are there any changes?`);
                 }
             }
         }
+        // Build after the version is bumped so the new version is in the build as needed.
         if (build) {
             await invoke_task('build');
         }
+        // Return early if there are no changes and publishing is optional, but after building,
+        // so if callers want to optimize away building
+        // they need to do so manually like in `gro release`.
+        // TODO this could be cleaned up if tasks had a return value to callers, it could specifiy that it didn't build
+        if (optional_and_version_unchanged)
+            return;
         if (dry) {
             log.info('publishing branch ' + branch);
             log.info(green('dry run complete!'));

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ryanatkn/gro",
-  "version": "0.130.0",
+  "version": "0.130.1",
   "description": "task runner and toolkit extending SvelteKit",
   "motto": "generate, run, optimize",
   "glyph": "🌰",

package/src/lib/package.ts

@@ -5,7 +5,7 @@ import type {Src_Json} from './src_json.js';
 
 export const package_json = {
 	name: '@ryanatkn/gro',
-	version: '0.130.0',
+	version: '0.130.1',
 	description: 'task runner and toolkit extending SvelteKit',
 	motto: 'generate, run, optimize',
 	glyph: '🌰',
@@ -272,7 +272,7 @@ export const package_json = {
 
 export const src_json = {
 	name: '@ryanatkn/gro',
-	version: '0.130.0',
+	version: '0.130.1',
 	modules: {
 		'.': {
 			path: 'index.ts',

package/src/lib/publish.task.ts

@@ -114,6 +114,7 @@ export const task: Task<Args> = {
 		}
 
 		let version!: string;
+		let optional_and_version_unchanged = false;
 
 		// Bump the version so the package.json is updated before building:
 		// TODO problem here is build may fail and put us in a bad state,
@@ -159,17 +160,25 @@ export const task: Task<Args> = {
 				// The version didn't change.
 				// For now this is the best detection we have for a no-op `changeset version`.
 				if (optional) {
-					return; // exit gracefully
+					optional_and_version_unchanged = true;
 				} else {
+					// Doesn't build if the version didn't change and publishing isn't optional.
 					throw new Task_Error(`\`${changeset_cli} version\` failed: are there any changes?`);
 				}
 			}
 		}
 
+		// Build after the version is bumped so the new version is in the build as needed.
 		if (build) {
 			await invoke_task('build');
 		}
 
+		// Return early if there are no changes and publishing is optional, but after building,
+		// so if callers want to optimize away building
+		// they need to do so manually like in `gro release`.
+		// TODO this could be cleaned up if tasks had a return value to callers, it could specifiy that it didn't build
+		if (optional_and_version_unchanged) return;
+
 		if (dry) {
 			log.info('publishing branch ' + branch);
 			log.info(green('dry run complete!'));