@ryan_nookpi/pi-extension-ask-user-question 0.3.4 → 0.3.5

package/controller.test.ts

@@ -66,6 +66,18 @@ describe("ask-user-question/controller", () => {
 		expect(empty.done).not.toHaveBeenCalled();
 	});
 
+	it("invalidates cached lines when render width changes (terminal resize)", () => {
+		const setup = createController([{ id: "text", type: "text", prompt: "Explain" }]);
+		const wide = setup.controller.render(70);
+		const narrow = setup.controller.render(34);
+		expect(narrow).not.toBe(wide);
+		for (const line of narrow) {
+			expect(line.length).toBeLessThanOrEqual(34);
+		}
+		const narrowAgain = setup.controller.render(34);
+		expect(narrowAgain).toBe(narrow);
+	});
+
 	it("handles text questions, submission, cancellation, and editor fallback submit", () => {
 		const first = createController([{ id: "text", type: "text", prompt: "Explain", default: "seed" }]);
 		expect(first.editor.getText()).toBe("seed");

package/controller.ts

@@ -37,6 +37,7 @@ export function createFormController(input: CreateFormControllerInput): FormCont
 	let otherMode = false;
 	let otherQuestionId: string | null = null;
 	let cachedLines: string[] | undefined;
+	let cachedWidth: number | undefined;
 
 	function getCurrentQuestion(): NormalizedQuestion | undefined {
 		return questions[currentTab];
@@ -44,6 +45,7 @@ export function createFormController(input: CreateFormControllerInput): FormCont
 
 	function refresh(): void {
 		cachedLines = undefined;
+		cachedWidth = undefined;
 		input.requestRender();
 	}
 
@@ -116,7 +118,8 @@ export function createFormController(input: CreateFormControllerInput): FormCont
 
 	return {
 		render(width) {
-			if (cachedLines) return cachedLines;
+			if (cachedLines && cachedWidth === width) return cachedLines;
+			cachedWidth = width;
 			cachedLines = renderForm({
 				title: input.title,
 				description: input.description,
@@ -134,6 +137,7 @@ export function createFormController(input: CreateFormControllerInput): FormCont
 		},
 		invalidate() {
 			cachedLines = undefined;
+			cachedWidth = undefined;
 		},
 		handleInput(data) {
 			if (otherMode) {

package/form-ui.test.ts

@@ -66,6 +66,32 @@ describe("ask-user-question/form-ui", () => {
 		expect(result).toEqual({ title: "Title", questions, answers: [], cancelled: true });
 	});
 
+	it("coerces unexpected native bridge answers into safe form results", async () => {
+		const questions = normalizeQuestions([
+			{ id: "choice", type: "radio", prompt: "Pick", options: [{ value: "a", label: "A" }] },
+			{ id: "single", type: "checkbox", prompt: "Single", options: [{ value: "solo", label: "Solo" }] },
+			{ id: "missing", type: "checkbox", prompt: "Missing", options: [{ value: "x", label: "X" }] },
+		]);
+		const askUserQuestion = vi.fn(async () => ({ choice: 123, single: "solo" }));
+		const ctx = {
+			hasUI: true,
+			ui: { askUserQuestion },
+		} as unknown as ExtensionContext;
+
+		const result = await runAskUserQuestionForm(ctx, {}, questions);
+
+		expect(result).toEqual({
+			title: undefined,
+			questions,
+			answers: [
+				{ id: "choice", type: "radio", value: "", wasCustom: false },
+				{ id: "single", type: "checkbox", value: ["solo"], wasCustom: false },
+				{ id: "missing", type: "checkbox", value: [], wasCustom: false },
+			],
+			cancelled: false,
+		});
+	});
+
 	it("wires the custom UI factory to the controller", async () => {
 		const questions = normalizeQuestions([{ id: "text", type: "text", prompt: "Explain", default: "seed" }]);
 		let captured: FormResult | undefined;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ryan_nookpi/pi-extension-ask-user-question",
-  "version": "0.3.4",
+  "version": "0.3.5",
   "description": "AskUserQuestion tool extension for pi.",
   "license": "MIT",
   "repository": {