@rvoh/psychic 1.8.2 → 1.8.4

package/dist/cjs/src/openapi-renderer/endpoint.js

@@ -215,7 +215,8 @@ class OpenapiEndpointRenderer {
      * while parsing the responses and provided callback function.
      */
     toSchemaObject({ openapiName, renderOpts, alreadyExtractedDescendantSerializers, renderedSchemasOpenapi, serializersAppearingInHandWrittenOpenapi, }) {
-        const serializers = this.getSerializerClasses() ?? [];
+        const serializers = this.extractSerializerFromSerializableArgument() ??
+            [];
         serializersToSchemaObjects(this.controllerClass, this.action, [...serializers, ...serializersAppearingInHandWrittenOpenapi], {
             openapiName,
             renderOpts,
@@ -617,7 +618,7 @@ class OpenapiEndpointRenderer {
      * if it was not passed.
      */
     get defaultStatus() {
-        if (!this.getSerializerClasses())
+        if (!this.dreamsOrSerializers)
             return 204;
         return 200;
     }
@@ -628,7 +629,7 @@ class OpenapiEndpointRenderer {
      * Openapi decorator.
      */
     parseSerializerResponseShape({ renderOpts, }) {
-        const serializerClasses = this.getSerializerClasses();
+        const serializerClasses = this.extractSerializerFromSerializableArgument();
         if (!serializerClasses)
             return {
                 referencedSerializers: [],
@@ -765,7 +766,11 @@ class OpenapiEndpointRenderer {
      * attached dream or view model to identify a serializer
      * match.
      */
-    getSerializerClasses() {
+    extractSerializerFromSerializableArgument() {
+        if (this.status === 204)
+            return null;
+        if (this.openapiResponseProvidedForStatus(this.status))
+            return null;
         if (!this.dreamsOrSerializers)
             return null;
         const serializers = (0, dream_1.compact)([this.dreamsOrSerializers]
@@ -778,6 +783,11 @@ class OpenapiEndpointRenderer {
         });
         return serializers;
     }
+    openapiResponseProvidedForStatus(status) {
+        if (status === undefined)
+            return false;
+        return !!this.responses?.[status];
+    }
     /**
      * @internal
      *

package/dist/cjs/src/psychic-app/index.js

@@ -97,10 +97,12 @@ class PsychicApp {
             dreamApp.set('logger', psychicApp.logger);
             dreamApp.set('packageManager', psychicApp.packageManager);
             (0, cache_js_1.cachePsychicApp)(psychicApp);
-            // routes _must_ be built before openapi
-            // cache can be processed
-            await psychicApp.buildRoutesCache();
-            psychicApp.buildOpenapiCache();
+            if (!opts.bypassModelIntegrityCheck) {
+                // routes _must_ be built before openapi
+                // cache can be processed
+                await psychicApp.buildRoutesCache();
+                psychicApp.buildOpenapiCache();
+            }
         });
         return psychicApp;
     }

package/dist/esm/src/openapi-renderer/endpoint.js

@@ -209,7 +209,8 @@ export default class OpenapiEndpointRenderer {
      * while parsing the responses and provided callback function.
      */
     toSchemaObject({ openapiName, renderOpts, alreadyExtractedDescendantSerializers, renderedSchemasOpenapi, serializersAppearingInHandWrittenOpenapi, }) {
-        const serializers = this.getSerializerClasses() ?? [];
+        const serializers = this.extractSerializerFromSerializableArgument() ??
+            [];
         serializersToSchemaObjects(this.controllerClass, this.action, [...serializers, ...serializersAppearingInHandWrittenOpenapi], {
             openapiName,
             renderOpts,
@@ -611,7 +612,7 @@ export default class OpenapiEndpointRenderer {
      * if it was not passed.
      */
     get defaultStatus() {
-        if (!this.getSerializerClasses())
+        if (!this.dreamsOrSerializers)
             return 204;
         return 200;
     }
@@ -622,7 +623,7 @@ export default class OpenapiEndpointRenderer {
      * Openapi decorator.
      */
     parseSerializerResponseShape({ renderOpts, }) {
-        const serializerClasses = this.getSerializerClasses();
+        const serializerClasses = this.extractSerializerFromSerializableArgument();
         if (!serializerClasses)
             return {
                 referencedSerializers: [],
@@ -759,7 +760,11 @@ export default class OpenapiEndpointRenderer {
      * attached dream or view model to identify a serializer
      * match.
      */
-    getSerializerClasses() {
+    extractSerializerFromSerializableArgument() {
+        if (this.status === 204)
+            return null;
+        if (this.openapiResponseProvidedForStatus(this.status))
+            return null;
         if (!this.dreamsOrSerializers)
             return null;
         const serializers = compact([this.dreamsOrSerializers]
@@ -772,6 +777,11 @@ export default class OpenapiEndpointRenderer {
         });
         return serializers;
     }
+    openapiResponseProvidedForStatus(status) {
+        if (status === undefined)
+            return false;
+        return !!this.responses?.[status];
+    }
     /**
      * @internal
      *

package/dist/esm/src/psychic-app/index.js

@@ -68,10 +68,12 @@ export default class PsychicApp {
             dreamApp.set('logger', psychicApp.logger);
             dreamApp.set('packageManager', psychicApp.packageManager);
             cachePsychicApp(psychicApp);
-            // routes _must_ be built before openapi
-            // cache can be processed
-            await psychicApp.buildRoutesCache();
-            psychicApp.buildOpenapiCache();
+            if (!opts.bypassModelIntegrityCheck) {
+                // routes _must_ be built before openapi
+                // cache can be processed
+                await psychicApp.buildRoutesCache();
+                psychicApp.buildOpenapiCache();
+            }
         });
         return psychicApp;
     }

package/dist/types/src/openapi-renderer/endpoint.d.ts

@@ -287,7 +287,8 @@ export default class OpenapiEndpointRenderer<DreamsOrSerializersOrViewModels ext
      * attached dream or view model to identify a serializer
      * match.
      */
-    private getSerializerClasses;
+    private extractSerializerFromSerializableArgument;
+    private openapiResponseProvidedForStatus;
     /**
      * @internal
      *

package/package.json

@@ -2,7 +2,7 @@
   "type": "module",
   "name": "@rvoh/psychic",
   "description": "Typescript web framework",
-  "version": "1.8.2",
+  "version": "1.8.4",
   "author": "RVOHealth",
   "repository": {
     "type": "git",
@@ -96,4 +96,4 @@
     "winston": "^3.14.2"
   },
   "packageManager": "yarn@4.7.0"
-}
+}

package/CHANGELOG.md

@@ -1,266 +0,0 @@
-## 1.8.2
-
-- openapi validation properly coerces non-array query params to arrays when validating, since both express and ajv fail to do this under the hood properly. This solves issues where sending up array params with only a single item in them are not treated as arrays.
-
-## 1.8.1
-
-- do not coerce types in ajv when processing request or response bodies during validation. Type coercion will still happen for headers and query params, since they will need to respect the schema type specified in the openapi docuement.
-
-## 1.8.0
-
-- remove unused `clientRoot` config
-
-## 1.7.2
-
-- generate admin routes in routes.admin.ts (requires `routes.admin.ts` next to `routes.ts`)
-
-## 1.7.1
-
-- compute openapi doc during intiialization, rather than problematically reading from a file cache
-
-## 1.7.0
-
-- `sanitizeResponseJson` config to automatically escape `<`, `>`, `&`, `/`, `\`, `'`, and `"` unicode representations when rendering json to satisfy security reviews (e.g., a pentest report recently called this out on one of our applications). For all practical purposes, this doesn't protect against anything (now that we have the `nosniff` header) since `JSON.parse` on the other end restores the original, dangerous string. Modern front end web frameworks already handle safely displaying arbitrary content, so further sanitization generally isn't needed. This version does provide the `sanitizeString` function that could be used to sanitize individual strings, replacing the above characters with string representations of the unicode characters that will survive Psychic converting to json and then parsing that json (i.e.: `<` will end up as the string "\u003c")
-
-- Fix openapi serializer fallback issue introduced in 1.6.3, where we mistakenly double render data that has already been serialized.
-
-## 1.6.4
-
-Raise an exception if attempting to import an openapi file during PsychicApp.init when in production. We will still swallow the exception in non-prod environments so that one can create a new openapi configuration and run sync without getting an error.
-
-## 1.6.3
-
-- castParam accepts raw openapi shapes as type arguments, correctly casting the result to an interface representing the provided openapi shape.
-
-```ts
-class MyController extends ApplicationController {
-  public index() {
-    const myParam = this.castParam('myParam', {
-      type: 'array',
-      items: {
-        anyOf: [{ type: 'string' }, { type: 'number' }],
-      },
-    })
-    myParam[0] // string | number
-  }
-}
-```
-
-- simplify the needlessly-robust new psychic router patterns by making expressApp optional, essentially reverting us back to the same psychic router we had prior to the recent openapi validation changes.
-
-- fallback to serializer specified in openapi decorator before falling back to dream serializer when rendering dreams
-
-## 1.6.2
-
-fix OpenAPI spec generation by DRYing up generation of request and response body
-
-## 1.6.1
-
-fix issue preventing validation fallbacks from properly overriding on OpenAPI decorator calls when explicitly opting out of validation
-
-## 1.6.0
-
-enables validation to be added to both openapi configurations, as well as to `OpenAPI` decorator calls, enabling the developer to granularly control validation logic for their endpoints.
-
-To leverage global config:
-
-```ts
-// conf/app.ts
-export default async (psy: PsychicApp) => {
-  ...
-
-  psy.set('openapi', {
-    // ...
-    validate: {
-      headers: true,
-      requestBody: true,
-      query: true,
-      responseBody: AppEnv.isTest,
-    },
-  })
-}
-```
-
-To leverage endpoint config:
-
-```ts
-// controllers/PetsController
-export default class PetsController {
-  @OpenAPI(Pet, {
-    ...
-    validate: {
-      headers: true,
-      requestBody: true,
-      query: true,
-      responseBody: AppEnv.isTest,
-    }
-  })
-  public async index() {
-    ...
-  }
-}
-```
-
-This PR additionally formally introduces a new possible error type for 400 status codes, and to help distinguish, it also introduces a `type` field, which can be either `openapi` or `dream` to aid the developer in easily handling the various cases.
-
-We have made a conscious decision to render openapi errors in the exact format that ajv returns, since it empowers the developer to utilize tools which can already respond to ajv errors.
-
-For added flexibility, this PR includes the ability to provide configuration overrides for the ajv instance, as well as the ability to provide an initialization function to override ajv behavior, since much of the configuration for ajv is driven by method calls, rather than simple config.
-
-```ts
-// controllers/PetsController
-export default class PetsController {
-  @OpenAPI(Pet, {
-    ...
-    validate: {
-      ajvOptions: {
-        // this is off by default, but you will
-        // always want to keep this off in prod
-        // to avoid DoS vulnerabilities
-        allErrors: AppEnv.isTest,
-
-        // provide a custom init function to further
-        // configure your ajv instance before validating
-        init: ajv => {
-          ajv.addFormat('myFormat', {
-            type: 'string',
-            validate: data => MY_FORMAT_REGEX.test(data),
-          })
-        }
-      }
-    }
-  })
-  public async index() {
-    ...
-  }
-}
-```
-
-## 1.5.5
-
-- ensure that openapi-typescript and typescript are not required dependencies when running migrations with --skip-sync flag
-
-## 1.5.4
-
-- fix issue when providing the `including` argument exclusively to an OpenAPI decorator's `requestBody`
-
-## 1.5.3
-
-- add missing peer dependency for openapi-typescript, allow BIGINT type when generating openapi-typescript bigints
-
-## 1.5.2
-
-- ensure that bigints are converted to number | string when generating openapi-typescript type files
-
-## 1.5.1
-
-- fix issue with enum syncing related to multi-db engine support regression
-
-## 1.5.0
-
-- add support for multiple database engines in dream
-
-## 1.2.3
-
-- add support for the connectionName argument when generating a resource
-
-## 1.2.2
-
-- bump supertest and express-session to close dependabot issues [53](https://github.com/rvohealth/psychic/security/dependabot/53), [56](https://github.com/rvohealth/psychic/security/dependabot/56), and [57](https://github.com/rvohealth/psychic/security/dependabot/57)
-
-## 1.2.1
-
-- add ability to set custom import extension, which will be used when generating new files for your application
-
-## 1.2.0
-
-- update for Dream 1.4.0
-
-## 1.1.11
-
-- 400 is more appropriate than 422 for `DataTypeColumnTypeMismatch`
-
-## 1.1.10
-
-- Don't include deletedAt in generated create/update actions in resource specs since deletedAt is for deleting
-
-- return 422 if Dream throws `NotNullViolation` or `CheckConstraintViolation`
-
-## 1.1.9
-
-- return 422 if dream throws `DataTypeColumnTypeMismatch`, which happens when a dream is saved to the database with data that cannot be inserted into the respective columns, usually because of a type mismatch.
-
-- castParam will now encase params in an array when being explicitly casted as an array type, bypassing a known bug in express from causing arrays with single items in them to be treated as non-arrays.
-
-## 1.1.8
-
-- Tap into CliFileWriter provided by dream to tap into file reversion for sync files, since the auto-sync function in psychic can fail and leave your file tree in a bad state.
-
-## 1.1.7
-
-- Add support for middleware arrays, enabling express plugins like passport
-
-## 1.1.6
-
-- fix regression caused by missing --schema-only option in psychic cli
-
-## 1.1.5
-
-- pass packageManager through to dream, now that it accepts a packageManager setting.
-- update dream shadowing within psychic application initialization to take place after initializers and plugins are processed, so that those initializers and plugins have an opportunity to adjust the settings.
-
-## 1.1.4
-
-- fix regressions to redux bindings caused by default openapi path location changes
-- resource generator can handle prefixing slashes
-
-## 1.1.3
-
-- fix more minor issues with redux openapi bindings
-
-## 1.1.2
-
-- Fix various issues with openapi redux bindings
-- raise hard exception if accidentally using openapi route params in an expressjs route path
-
-## 1.1.1
-
-Fix route printing regression causing route printouts to show the path instead of the action
-
-## v1.1.0
-
-Provides easier access to express middleware by exposing `PsychicApp#use`, which enables a developer to provide express middleware directly through the psychcic application, without tapping into any hooks.
-
-```ts
-psy.use((_, res) => {
-  res.send(
-    'this will be run after psychic middleware (i.e. cors and bodyParser) are processed, but before routes are processed',
-  )
-})
-```
-
-Some middleware needs to be run before other middleware, so we expose an optional first argument which can be provided so explicitly send your middleware into express at various stages of the psychic configuration process. For example, to inject your middleware before cors and bodyParser are configured, provide `before-middleware` as the first argument. To initialize your middleware after the psychic default middleware, but before your routes have been processed, provide `after-middleware` as the first argument (or simply provide a callback function directly, since this is the default). To run after routes have been processed, provide `after-routes` as the first argument.
-
-```ts
-psy.use('before-middleware', (_, res) => {
-  res.send('this will be run before psychic has configured any default middleware')
-})
-
-psy.use('after-middleware', (_, res) => {
-  res.send('this will be run after psychic has configured default middleware')
-})
-
-psy.use('after-routes', (_, res) => {
-  res.send('this will be run after psychic has processed all the routes in your conf/routes.ts file')
-})
-```
-
-Additionally, a new overload has been added to all CRUD methods on the PsychicRouter class, enabling you to provide RequestHandler middleware directly to psychic, like so:
-
-```ts
-// conf/routes.ts
-
-r.get('helloworld', (req, res, next) => {
-  res.json({ hello: 'world' })
-})
-```