@rushstack/rush-http-build-cache-plugin 5.113.3 → 5.114.0

package/.eslintrc.js

@@ -0,0 +1,12 @@
+// This is a workaround for https://github.com/eslint/eslint/issues/3458
+require('local-node-rig/profiles/default/includes/eslint/patch/modern-module-resolution');
+// This is a workaround for https://github.com/microsoft/rushstack/issues/3021
+require('local-node-rig/profiles/default/includes/eslint/patch/custom-config-package-names');
+
+module.exports = {
+  extends: [
+    'local-node-rig/profiles/default/includes/eslint/profile/node-trusted-tool',
+    'local-node-rig/profiles/default/includes/eslint/mixins/friendly-locals'
+  ],
+  parserOptions: { tsconfigRootDir: __dirname }
+};

package/.rush/temp/operation/_phase_build/all.log

@@ -1,6 +1,7 @@
 Invoking: heft run --only build -- --clean --production
  ---- build started ---- 
 [build:typescript] Using TypeScript version 5.3.3
+[build:lint] Using ESLint version 8.7.0
 [build:typescript] Copied 1 folder or file and linked 0 files
- ---- build finished (7.625s) ---- 
--------------------- Finished (7.65s) --------------------
+ ---- build finished (8.378s) ---- 
+-------------------- Finished (8.405s) --------------------

package/.rush/temp/operation/_phase_build/state.json

@@ -1,3 +1,3 @@
 {
-  "nonCachedDurationMs": 8718.858224999974
+  "nonCachedDurationMs": 8918.654504999984
 }

package/.rush/temp/operation/_phase_test/all.log

@@ -5,11 +5,11 @@ The provided list of phases does not contain all phase dependencies. You may nee
 [test:jest] 
 [test:jest] Run start. 1 test suite
 [test:jest] START lib/test/HttpBuildCacheProvider.test.js
-[test:jest] PASS lib/test/HttpBuildCacheProvider.test.js (duration: 1.043s, 2 passed, 0 failed)
+[test:jest] PASS lib/test/HttpBuildCacheProvider.test.js (duration: 1.559s, 2 passed, 0 failed)
 [test:jest] 
 [test:jest] Tests finished:
 [test:jest]   Successes: 2
 [test:jest]   Failures: 0
 [test:jest]   Total: 2
- ---- test finished (2.830s) ---- 
--------------------- Finished (2.838s) --------------------
+ ---- test finished (3.393s) ---- 
+-------------------- Finished (3.401s) --------------------

package/.rush/temp/operation/_phase_test/state.json

@@ -1,3 +1,3 @@
 {
-  "nonCachedDurationMs": 3387.866452999995
+  "nonCachedDurationMs": 3955.134612999973
 }

package/.rush/temp/{rushstack+rush-http-build-cache-plugin-_phase_build-7181ffda50e9cb42b5cdec91b6f8aec77466b67a.tar.log → rushstack+rush-http-build-cache-plugin-_phase_build-bdf30e460f994579fa5d5b8a382c75152ff42394.tar.log}

@@ -1,5 +1,5 @@
-Start time: Wed Jan 31 2024 22:24:09 GMT+0000 (Coordinated Universal Time)
-Invoking "/usr/bin/tar -c -f /mnt/vss/_work/1/s/common/temp/build-cache/rushstack+rush-http-build-cache-plugin-_phase_build-7181ffda50e9cb42b5cdec91b6f8aec77466b67a-eba7de86e1ed8589.temp -z --files-from=-"
+Start time: Mon Feb 19 2024 21:52:42 GMT+0000 (Coordinated Universal Time)
+Invoking "/usr/bin/tar -c -f /mnt/vss/_work/1/s/common/temp/build-cache/rushstack+rush-http-build-cache-plugin-_phase_build-bdf30e460f994579fa5d5b8a382c75152ff42394-16011c4a1d5735d8.temp -z --files-from=-"
 
 ======= BEGIN PROCESS INPUT ======
 .rush/temp/operation/_phase_build/all.log
@@ -21,6 +21,7 @@ lib/test/HttpBuildCacheProvider.test.d.ts
 lib/test/HttpBuildCacheProvider.test.d.ts.map
 lib/test/HttpBuildCacheProvider.test.js
 lib/test/HttpBuildCacheProvider.test.js.map
+temp/build/lint/_eslint-it73M-Rx.json
 temp/build/typescript/ts_l9Fw4VUO.json
 ======== END PROCESS INPUT =======
 ======= BEGIN PROCESS OUTPUT =======

package/.rush/temp/{rushstack+rush-http-build-cache-plugin-_phase_build-7181ffda50e9cb42b5cdec91b6f8aec77466b67a.untar.log → rushstack+rush-http-build-cache-plugin-_phase_build-bdf30e460f994579fa5d5b8a382c75152ff42394.untar.log}

@@ -1,5 +1,5 @@
-Start time: Wed Jan 31 2024 22:25:46 GMT+0000 (Coordinated Universal Time)
-Invoking "/usr/bin/tar -x -m -f /mnt/vss/_work/1/s/common/temp/build-cache/rushstack+rush-http-build-cache-plugin-_phase_build-7181ffda50e9cb42b5cdec91b6f8aec77466b67a"
+Start time: Mon Feb 19 2024 21:54:24 GMT+0000 (Coordinated Universal Time)
+Invoking "/usr/bin/tar -x -m -f /mnt/vss/_work/1/s/common/temp/build-cache/rushstack+rush-http-build-cache-plugin-_phase_build-bdf30e460f994579fa5d5b8a382c75152ff42394"
 
 ======= BEGIN PROCESS INPUT ======
 

package/.rush/temp/{rushstack+rush-http-build-cache-plugin-_phase_test-14d46fb78397843cb544549cec510f0927403668.tar.log → rushstack+rush-http-build-cache-plugin-_phase_test-76e145455db25f136523ab72c2aaed644e2abb26.tar.log}

@@ -1,5 +1,5 @@
-Start time: Wed Jan 31 2024 22:24:13 GMT+0000 (Coordinated Universal Time)
-Invoking "/usr/bin/tar -c -f /mnt/vss/_work/1/s/common/temp/build-cache/rushstack+rush-http-build-cache-plugin-_phase_test-14d46fb78397843cb544549cec510f0927403668-88d64189a1079a05.temp -z --files-from=-"
+Start time: Mon Feb 19 2024 21:52:46 GMT+0000 (Coordinated Universal Time)
+Invoking "/usr/bin/tar -c -f /mnt/vss/_work/1/s/common/temp/build-cache/rushstack+rush-http-build-cache-plugin-_phase_test-76e145455db25f136523ab72c2aaed644e2abb26-577bbcf170c05a4e.temp -z --files-from=-"
 
 ======= BEGIN PROCESS INPUT ======
 .rush/temp/operation/_phase_test/all.log

package/.rush/temp/{rushstack+rush-http-build-cache-plugin-_phase_test-14d46fb78397843cb544549cec510f0927403668.untar.log → rushstack+rush-http-build-cache-plugin-_phase_test-76e145455db25f136523ab72c2aaed644e2abb26.untar.log}

@@ -1,5 +1,5 @@
-Start time: Wed Jan 31 2024 22:25:46 GMT+0000 (Coordinated Universal Time)
-Invoking "/usr/bin/tar -x -m -f /mnt/vss/_work/1/s/common/temp/build-cache/rushstack+rush-http-build-cache-plugin-_phase_test-14d46fb78397843cb544549cec510f0927403668"
+Start time: Mon Feb 19 2024 21:54:24 GMT+0000 (Coordinated Universal Time)
+Invoking "/usr/bin/tar -x -m -f /mnt/vss/_work/1/s/common/temp/build-cache/rushstack+rush-http-build-cache-plugin-_phase_test-76e145455db25f136523ab72c2aaed644e2abb26"
 
 ======= BEGIN PROCESS INPUT ======
 

package/.rush/temp/shrinkwrap-deps.json

@@ -1,5 +1,5 @@
 {
-  "../../rush-plugins/rush-http-build-cache-plugin": "../../rush-plugins/rush-http-build-cache-plugin:wkU2mpQR1DX7ls+8BHx7XqvloykJ25/+5Ip9S5dWEMs=:",
+  "../../rush-plugins/rush-http-build-cache-plugin": "../../rush-plugins/rush-http-build-cache-plugin:cNBg/EFP7SVuA8cyjjufadM11GkM/nl9F4T8neVJTL0=:",
   "/@types/node-fetch@2.6.2": "sha512-DHqhlq5jeESLy19TYhLakJ07kNumXWjcDdxXsLUMJZ6ue8VZJj4kLPQVE/2mdHh3xZziNF1xppu5lwmS53HR+A==",
   "/@types/node@18.17.15": "sha512-2yrWpBk32tvV/JAd3HNHWuZn/VDN1P+72hWirHnvsvTGSqbANi+kSeuQR9yAHnbvaBvHDsoTdXV0Fe+iRtHLKA==",
   "/agent-base@6.0.2": "sha512-RZNwNclF7+MS/8bDg70amg32dyeZGZxiDuQmZxKLAlQjr3jGyLx+4Kkk58UO7D2QdgFIQCovuSuZESne6RG6XQ==",

package/coverage/HttpBuildCacheProvider.ts.html

@@ -23,9 +23,9 @@
         <div class='clearfix'>
             
             <div class='fl pad1y space-right2'>
-                <span class="strong">65.09% </span>
+                <span class="strong">64.89% </span>
                 <span class="quiet">Statements</span>
-                <span class='fraction'>276/424</span>
+                <span class='fraction'>281/433</span>
             </div>
         
             
@@ -44,9 +44,9 @@
         
             
             <div class='fl pad1y space-right2'>
-                <span class="strong">65.09% </span>
+                <span class="strong">64.89% </span>
                 <span class="quiet">Lines</span>
-                <span class='fraction'>276/424</span>
+                <span class='fraction'>281/433</span>
             </div>
         
             
@@ -487,7 +487,21 @@
 <a name='L422'></a><a href='#L422'>422</a>
 <a name='L423'></a><a href='#L423'>423</a>
 <a name='L424'></a><a href='#L424'>424</a>
-<a name='L425'></a><a href='#L425'>425</a></td><td class="line-coverage quiet"><span class="cline-any cline-yes">1x</span>
+<a name='L425'></a><a href='#L425'>425</a>
+<a name='L426'></a><a href='#L426'>426</a>
+<a name='L427'></a><a href='#L427'>427</a>
+<a name='L428'></a><a href='#L428'>428</a>
+<a name='L429'></a><a href='#L429'>429</a>
+<a name='L430'></a><a href='#L430'>430</a>
+<a name='L431'></a><a href='#L431'>431</a>
+<a name='L432'></a><a href='#L432'>432</a>
+<a name='L433'></a><a href='#L433'>433</a>
+<a name='L434'></a><a href='#L434'>434</a></td><td class="line-coverage quiet"><span class="cline-any cline-yes">1x</span>
+<span class="cline-any cline-yes">1x</span>
+<span class="cline-any cline-yes">1x</span>
+<span class="cline-any cline-yes">1x</span>
+<span class="cline-any cline-yes">1x</span>
+<span class="cline-any cline-yes">1x</span>
 <span class="cline-any cline-yes">1x</span>
 <span class="cline-any cline-yes">1x</span>
 <span class="cline-any cline-yes">1x</span>
@@ -660,6 +674,10 @@
 <span class="cline-any cline-no">&nbsp;</span>
 <span class="cline-any cline-no">&nbsp;</span>
 <span class="cline-any cline-no">&nbsp;</span>
+<span class="cline-any cline-no">&nbsp;</span>
+<span class="cline-any cline-no">&nbsp;</span>
+<span class="cline-any cline-no">&nbsp;</span>
+<span class="cline-any cline-no">&nbsp;</span>
 <span class="cline-any cline-yes">1x</span>
 <span class="cline-any cline-yes">1x</span>
 <span class="cline-any cline-no">&nbsp;</span>
@@ -911,15 +929,20 @@
 <span class="cline-any cline-yes">1x</span>
 <span class="cline-any cline-yes">1x</span>
 <span class="cline-any cline-yes">1x</span>
-<span class="cline-any cline-neutral">&nbsp;</span></td><td class="text"><pre class="prettyprint lang-js">import { ITerminal, Executable, Async } from '@rushstack/node-core-library';
+<span class="cline-any cline-neutral">&nbsp;</span></td><td class="text"><pre class="prettyprint lang-js">// Copyright (c) Microsoft Corporation. All rights reserved. Licensed under the MIT license.
+// See LICENSE in the project root for license information.
+&nbsp;
+import { Executable, Async } from '@rushstack/node-core-library';
+import type { ITerminal } from '@rushstack/terminal';
 import {
-  ICloudBuildCacheProvider,
-  ICredentialCacheEntry,
+  type ICloudBuildCacheProvider,
+  type ICredentialCacheEntry,
   CredentialCache,
-  RushSession,
+  type RushSession,
   EnvironmentConfiguration
 } from '@rushstack/rush-sdk';
-import fetch, { BodyInit, Response } from 'node-fetch';
+import fetch, { type BodyInit, type Response } from 'node-fetch';
+import type { SpawnSyncReturns } from 'child_process';
 &nbsp;
 enum CredentialsOptions {
   Optional,
@@ -956,7 +979,7 @@ export interface IHttpBuildCacheProviderOptions {
 }
 &nbsp;
 const MAX_HTTP_CACHE_ATTEMPTS: number = 3;
-const DEFAULT_MIN_HTTP_RETRY_DELAY_MS = 2500;
+const DEFAULT_MIN_HTTP_RETRY_DELAY_MS: number = 2500;
 &nbsp;
 export class HttpBuildCacheProvider implements ICloudBuildCacheProvider {
   private readonly _pluginName: string;
@@ -994,7 +1017,7 @@ export class HttpBuildCacheProvider implements ICloudBuildCacheProvider {
     cacheId: string
   ): Promise&lt;Buffer | undefined&gt; {
     try {
-      const result = await this._http({
+      const result: boolean | Buffer = await this._http({
         terminal: terminal,
         relUrl: `${this._cacheKeyPrefix}${cacheId}`,
         method: 'GET',
@@ -1024,7 +1047,7 @@ export class HttpBuildCacheProvider implements ICloudBuildCacheProvider {
 <span class="cstat-no" title="statement not covered" >    terminal.writeDebugLine('Uploading object with cacheId: ', cacheId);</span>
 <span class="cstat-no" title="statement not covered" ></span>
 <span class="cstat-no" title="statement not covered" >    try {</span>
-<span class="cstat-no" title="statement not covered" >      const result = await this._http({</span>
+<span class="cstat-no" title="statement not covered" >      const result: boolean | Buffer = await this._http({</span>
 <span class="cstat-no" title="statement not covered" >        terminal: terminal,</span>
 <span class="cstat-no" title="statement not covered" >        relUrl: `${this._cacheKeyPrefix}${cacheId}`,</span>
 <span class="cstat-no" title="statement not covered" >        method: this._uploadMethod,</span>
@@ -1067,9 +1090,13 @@ export class HttpBuildCacheProvider implements ICloudBuildCacheProvider {
 <span class="cstat-no" title="statement not covered" ></span>
 <span class="cstat-no" title="statement not covered" >    const cmd: string = `${this._tokenHandler.exec} ${(this._tokenHandler.args || []).join(' ')}`;</span>
 <span class="cstat-no" title="statement not covered" >    terminal.writeVerboseLine(`Running '${cmd}' to get credentials`);</span>
-<span class="cstat-no" title="statement not covered" >    const result = Executable.spawnSync(this._tokenHandler.exec, this._tokenHandler.args || [], {</span>
-<span class="cstat-no" title="statement not covered" >      currentWorkingDirectory: this._rushProjectRoot</span>
-<span class="cstat-no" title="statement not covered" >    });</span>
+<span class="cstat-no" title="statement not covered" >    const result: SpawnSyncReturns&lt;string&gt; = Executable.spawnSync(</span>
+<span class="cstat-no" title="statement not covered" >      this._tokenHandler.exec,</span>
+<span class="cstat-no" title="statement not covered" >      this._tokenHandler.args || [],</span>
+<span class="cstat-no" title="statement not covered" >      {</span>
+<span class="cstat-no" title="statement not covered" >        currentWorkingDirectory: this._rushProjectRoot</span>
+<span class="cstat-no" title="statement not covered" >      }</span>
+<span class="cstat-no" title="statement not covered" >    );</span>
 <span class="cstat-no" title="statement not covered" ></span>
 <span class="cstat-no" title="statement not covered" >    terminal.writeErrorLine(result.stderr);</span>
 <span class="cstat-no" title="statement not covered" ></span>
@@ -1077,7 +1104,7 @@ export class HttpBuildCacheProvider implements ICloudBuildCacheProvider {
 <span class="cstat-no" title="statement not covered" >      throw new Error(`Could not obtain credentials. The command '${cmd}' failed.`);</span>
 <span class="cstat-no" title="statement not covered" >    }</span>
 <span class="cstat-no" title="statement not covered" ></span>
-<span class="cstat-no" title="statement not covered" >    const credential = result.stdout.trim();</span>
+<span class="cstat-no" title="statement not covered" >    const credential: string = result.stdout.trim();</span>
 <span class="cstat-no" title="statement not covered" >    terminal.writeVerboseLine('Got credentials');</span>
 <span class="cstat-no" title="statement not covered" ></span>
 <span class="cstat-no" title="statement not covered" >    await this.updateCachedCredentialAsync(terminal, credential);</span>
@@ -1122,9 +1149,9 @@ export class HttpBuildCacheProvider implements ICloudBuildCacheProvider {
     credentialOptions?: CredentialsOptions;
   }): Promise&lt;Buffer | boolean&gt; {
     const { terminal, relUrl, method, body, warningText, readBody, credentialOptions } = options;
-    const safeCredentialOptions = credentialOptions ?? CredentialsOptions.Optional;
-    const credentials = await this._tryGetCredentials(safeCredentialOptions);
-    const url = new URL(relUrl, this._url).href;
+    const safeCredentialOptions: CredentialsOptions = credentialOptions ?? CredentialsOptions.Optional;
+    const credentials: string | undefined = await this._tryGetCredentials(safeCredentialOptions);
+    const url: string = new URL(relUrl, this._url).href;
 &nbsp;
     const headers: Record&lt;string, string&gt; = {};
     if (typeof credentials === 'string') <span class="branch-0 cbranch-no" title="branch not covered" >{</span>
@@ -1137,11 +1164,11 @@ export class HttpBuildCacheProvider implements ICloudBuildCacheProvider {
 <span class="cstat-no" title="statement not covered" >      }</span>
 <span class="cstat-no" title="statement not covered" >    }</span>
 &nbsp;
-    const bodyLength = (body<span class="branch-0 cbranch-no" title="branch not covered" > as { length: number })?.length </span>|| 'unknown';
+    const bodyLength: number | 'unknown' = (body<span class="branch-0 cbranch-no" title="branch not covered" > as { length: number })?.length </span>|| 'unknown';
 &nbsp;
     terminal.writeDebugLine(`[http-build-cache] request: ${method} ${url} ${bodyLength} bytes`);
 &nbsp;
-    const response = await fetch(url, {
+    const response: Response = await fetch(url, {
       method: method,
       headers: headers,
       body: body,
@@ -1149,7 +1176,7 @@ export class HttpBuildCacheProvider implements ICloudBuildCacheProvider {
     });
 &nbsp;
     if (!response.ok) {
-      const isNonCredentialResponse = response.status &gt;= 500 &amp;&amp; response.status &lt; 600;
+      const isNonCredentialResponse: boolean = response.status &gt;= 500 &amp;&amp; response.status &lt; 600;
 &nbsp;
       if (
         !isNonCredentialResponse &amp;&amp;
@@ -1168,8 +1195,8 @@ export class HttpBuildCacheProvider implements ICloudBuildCacheProvider {
         // Pause a bit before retrying in case the server is busy
         // Add some random jitter to the retry so we can spread out load on the remote service
         // A proper solution might add exponential back off in case the retry count is high (10 or more)
-        const factor = 1.0 + Math.random(); // A random number between 1.0 and 2.0
-        const retryDelay = Math.floor(factor * this._minHttpRetryDelayMs);
+        const factor: number = 1.0 + Math.random(); // A random number between 1.0 and 2.0
+        const retryDelay: number = Math.floor(factor * this._minHttpRetryDelayMs);
 &nbsp;
         await Async.sleep(retryDelay);
 &nbsp;
@@ -1342,7 +1369,7 @@ export class HttpBuildCacheProvider implements ICloudBuildCacheProvider {
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
-                at 2024-01-31T22:24:13.079Z
+                at 2024-02-19T21:52:46.098Z
             </div>
         <script src="prettify.js"></script>
         <script>

package/coverage/RushHttpBuildCachePlugin.ts.html

@@ -229,7 +229,7 @@
 <span class="cstat-no" title="statement not covered" >// See LICENSE in the project root for license information.</span>
 <span class="cstat-no" title="statement not covered" ></span>
 <span class="cstat-no" title="statement not covered" >import type { IRushPlugin, RushSession, RushConfiguration } from '@rushstack/rush-sdk';</span>
-<span class="cstat-no" title="statement not covered" >import type { HttpBuildCacheProvider, IHttpBuildCacheProviderOptions } from './HttpBuildCacheProvider';</span>
+<span class="cstat-no" title="statement not covered" >import type { IHttpBuildCacheProviderOptions } from './HttpBuildCacheProvider';</span>
 <span class="cstat-no" title="statement not covered" ></span>
 <span class="cstat-no" title="statement not covered" >const PLUGIN_NAME: string = 'HttpBuildCachePlugin';</span>
 <span class="cstat-no" title="statement not covered" ></span>
@@ -313,7 +313,7 @@
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
-                at 2024-01-31T22:24:13.079Z
+                at 2024-02-19T21:52:46.098Z
             </div>
         <script src="prettify.js"></script>
         <script>