@runtypelabs/persona 4.24.0 → 4.26.0

package/src/ui.history-confirm-fallback.test.ts

@@ -0,0 +1,142 @@
+// @vitest-environment jsdom
+
+/**
+ * Version skew on the CDN: a fresh `index.global.js` paired with a cached
+ * `history-view.js` that predates the `showHistoryConfirm` export. Own file
+ * because `loadHistoryView` memoizes the resolved module per module graph.
+ */
+
+import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
+
+import { createAgentExperience } from "./ui";
+import { createHistoryView } from "./components/history-view";
+import { setHistoryViewLoader } from "./history-view-loader";
+import type { HistoryViewOptions } from "./history-view-entry";
+import { setHistoryProviderFactory } from "./internal/history-provider-registry";
+import {
+  createDemoHistoryProvider,
+  type DemoHistoryConversationSeed,
+} from "./internal/demo-history-provider";
+
+const SEEDS: DemoHistoryConversationSeed[] = [
+  {
+    id: "conv-a",
+    title: "Order status",
+    targetId: null,
+    messages: [{ id: "a1", role: "user", content: "where is my order" }],
+  },
+];
+
+const flush = async (times = 12) => {
+  for (let i = 0; i < times; i += 1) {
+    // eslint-disable-next-line no-await-in-loop
+    await Promise.resolve();
+  }
+};
+
+type HistoryViewModule = Awaited<
+  ReturnType<Parameters<typeof setHistoryViewLoader>[0]>
+>;
+
+describe("history confirm with a stale chunk", () => {
+  let controller: ReturnType<typeof createAgentExperience> | null = null;
+  let mount: HTMLElement | null = null;
+
+  beforeEach(() => {
+    window.scrollTo = vi.fn();
+    setHistoryProviderFactory(() =>
+      createDemoHistoryProvider({ conversations: SEEDS })
+    );
+  });
+
+  afterEach(() => {
+    setHistoryProviderFactory(null);
+    controller?.destroy();
+    controller = null;
+    mount?.remove();
+    mount = null;
+    document.body.innerHTML = "";
+    vi.restoreAllMocks();
+  });
+
+  // Runs first: a resolved chunk is memoized for the rest of the module graph,
+  // so the rejecting loader only takes effect before any successful load.
+  it("falls back to the native confirm when the chunk fails to load", async () => {
+    setHistoryViewLoader(async () => {
+      throw new Error("chunk fetch failed");
+    });
+    mount = document.createElement("div");
+    document.body.appendChild(mount);
+    controller = createAgentExperience(mount, {
+      apiUrl: "https://api.example.com/chat",
+      launcher: { enabled: false },
+      persistState: false,
+      features: { history: { enabled: true } },
+    } as unknown as Parameters<typeof createAgentExperience>[1]);
+    await controller.openConversation("conv-a");
+    await flush();
+
+    // The title-menu delete needs no history view: it goes straight to the
+    // confirm, whose chunk load rejects.
+    const deleteFromTitleMenu = () =>
+      mount!
+        .querySelector('[data-persona-theme-zone="header"]')!
+        .dispatchEvent(
+          new CustomEvent("persona:title-menu-builtin", {
+            bubbles: true,
+            detail: { actionId: "delete" },
+          })
+        );
+    const listIds = async () =>
+      (await controller!.listConversations({ limit: 10 })).items.map(
+        (item) => item.id
+      );
+
+    const confirmSpy = vi.spyOn(window, "confirm").mockReturnValue(false);
+    deleteFromTitleMenu();
+    await flush();
+    expect(confirmSpy).toHaveBeenCalledTimes(1);
+    expect(await listIds()).toContain("conv-a");
+
+    confirmSpy.mockReturnValue(true);
+    deleteFromTitleMenu();
+    await flush();
+    expect(confirmSpy).toHaveBeenCalledTimes(2);
+    expect(await listIds()).not.toContain("conv-a");
+  });
+
+  it("falls back to the native confirm when the chunk lacks showHistoryConfirm", async () => {
+    let viewOptions: HistoryViewOptions | null = null;
+    // Older chunk shape: no showHistoryConfirm export.
+    setHistoryViewLoader(
+      async () =>
+        ({
+          createHistoryView: (options: HistoryViewOptions) => {
+            viewOptions = options;
+            return createHistoryView(options);
+          },
+        }) as unknown as HistoryViewModule
+    );
+    mount = document.createElement("div");
+    document.body.appendChild(mount);
+    controller = createAgentExperience(mount, {
+      apiUrl: "https://api.example.com/chat",
+      launcher: { enabled: false },
+      persistState: false,
+      features: { history: { enabled: true } },
+    } as unknown as Parameters<typeof createAgentExperience>[1]);
+
+    mount.querySelector<HTMLButtonElement>("[data-persona-history-toggle]")!.click();
+    await flush();
+    expect(viewOptions).not.toBeNull();
+    const requestClear = viewOptions!.onRequestClearHistory!;
+
+    const confirmSpy = vi.spyOn(window, "confirm").mockReturnValue(false);
+    await expect(requestClear()).resolves.toBe("cancelled");
+    expect(confirmSpy).toHaveBeenCalledTimes(1);
+
+    confirmSpy.mockReturnValue(true);
+    await expect(requestClear()).resolves.toBe("cleared");
+    expect(confirmSpy).toHaveBeenCalledTimes(2);
+  });
+});

package/src/ui.history-controller.test.ts

@@ -13,6 +13,7 @@ import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
 import { createAgentExperience } from "./ui";
 import { initAgentWidget } from "./runtime/init";
 import { createHistoryView } from "./components/history-view";
+import { showHistoryConfirm } from "./components/history-confirm-dialog";
 import { setHistoryViewLoader } from "./history-view-loader";
 import { setHistoryProviderFactory } from "./internal/history-provider-registry";
 import {
@@ -87,7 +88,7 @@ const setup = (
 describe("history controller API", () => {
   beforeEach(() => {
     window.scrollTo = vi.fn();
-    setHistoryViewLoader(async () => ({ createHistoryView }));
+    setHistoryViewLoader(async () => ({ createHistoryView, showHistoryConfirm }));
   });
 
   afterEach(() => {

package/src/ui.history-lifecycle.test.ts

@@ -52,6 +52,7 @@ vi.mock("./utils/visitor-store", async (importOriginal) => {
 
 import { createAgentExperience } from "./ui";
 import { createHistoryView } from "./components/history-view";
+import { showHistoryConfirm } from "./components/history-confirm-dialog";
 import { setHistoryViewLoader } from "./history-view-loader";
 import { setHistoryProviderFactory } from "./internal/history-provider-registry";
 import { createDemoHistoryProvider } from "./internal/demo-history-provider";
@@ -109,7 +110,7 @@ const mount = (config: Record<string, unknown>) => {
 describe("history controller lifecycle", () => {
   beforeEach(() => {
     window.scrollTo = vi.fn();
-    setHistoryViewLoader(async () => ({ createHistoryView }));
+    setHistoryViewLoader(async () => ({ createHistoryView, showHistoryConfirm }));
     installFetch();
   });
 

package/src/ui.history-render-hooks.test.ts

@@ -11,6 +11,7 @@ import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
 
 import { createAgentExperience } from "./ui";
 import { createHistoryView } from "./components/history-view";
+import { showHistoryConfirm } from "./components/history-confirm-dialog";
 import { setHistoryViewLoader } from "./history-view-loader";
 import { setHistoryProviderFactory } from "./internal/history-provider-registry";
 import {
@@ -127,7 +128,7 @@ const fullViewPlugin = (
 describe("history render hooks", () => {
   beforeEach(() => {
     window.scrollTo = vi.fn();
-    setHistoryViewLoader(async () => ({ createHistoryView }));
+    setHistoryViewLoader(async () => ({ createHistoryView, showHistoryConfirm }));
   });
 
   afterEach(() => {

package/src/ui.history-shell.test.ts

@@ -13,6 +13,7 @@ import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
 
 import { createAgentExperience } from "./ui";
 import { createHistoryView } from "./components/history-view";
+import { showHistoryConfirm } from "./components/history-confirm-dialog";
 import { setHistoryViewLoader } from "./history-view-loader";
 import { setHistoryProviderFactory } from "./internal/history-provider-registry";
 import {
@@ -169,7 +170,7 @@ describe("history shell", () => {
   beforeEach(() => {
     window.scrollTo = vi.fn();
     // The loader's production path is a sibling-URL / external-subpath import.
-    setHistoryViewLoader(async () => ({ createHistoryView }));
+    setHistoryViewLoader(async () => ({ createHistoryView, showHistoryConfirm }));
   });
 
   afterEach(() => {

package/src/ui.rail-overlay.test.ts

@@ -12,6 +12,7 @@ import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
 
 import { createAgentExperience } from "./ui";
 import { createHistoryView } from "./components/history-view";
+import { showHistoryConfirm } from "./components/history-confirm-dialog";
 import { setHistoryViewLoader } from "./history-view-loader";
 import { setHistoryProviderFactory } from "./internal/history-provider-registry";
 import {
@@ -53,7 +54,7 @@ const wait = (ms: number) =>
 /** Past the 300ms pointer-out grace. */
 const GRACE = 380;
 
-const loadHistoryChunk = vi.fn(async () => ({ createHistoryView }));
+const loadHistoryChunk = vi.fn(async () => ({ createHistoryView, showHistoryConfirm }));
 
 const setup = (
   options: {

package/src/ui.rail-resize.test.ts

@@ -10,6 +10,7 @@ import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
 
 import { createAgentExperience } from "./ui";
 import { createHistoryView } from "./components/history-view";
+import { showHistoryConfirm } from "./components/history-confirm-dialog";
 import { setHistoryViewLoader } from "./history-view-loader";
 import { setHistoryProviderFactory } from "./internal/history-provider-registry";
 import {
@@ -103,7 +104,7 @@ const drag = (handle: HTMLElement, dx: number, opts?: { hold?: boolean }) => {
 describe("rail resize handle", () => {
   beforeEach(() => {
     window.scrollTo = vi.fn();
-    setHistoryViewLoader(async () => ({ createHistoryView }));
+    setHistoryViewLoader(async () => ({ createHistoryView, showHistoryConfirm }));
   });
 
   afterEach(() => {

package/src/ui.rail-trigger-pending.test.ts

@@ -13,6 +13,7 @@ import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
 
 import { createAgentExperience } from "./ui";
 import { createHistoryView } from "./components/history-view";
+import { showHistoryConfirm } from "./components/history-confirm-dialog";
 import { setHistoryViewLoader } from "./history-view-loader";
 import { setHistoryProviderFactory } from "./internal/history-provider-registry";
 import { createDemoHistoryProvider } from "./internal/demo-history-provider";
@@ -103,7 +104,7 @@ describe("rail trigger during a docking open", () => {
     setHistoryViewLoader(
       () =>
         new Promise((resolve) => {
-          release = () => resolve({ createHistoryView });
+          release = () => resolve({ createHistoryView, showHistoryConfirm });
         })
     );
     const { controller: ctl } = setup();