@runfusion/fusion 0.47.0 → 0.48.0

package/dist/bin.js

@@ -71211,9 +71211,6 @@ function evaluateInterpreterCutoverReadiness(input) {
   if (!input.authoritativeFlagEnabled) {
     reasons.push("experimentalFeatures.workflowInterpreterAuthoritative is disabled");
   }
-  if (!input.dualObserveEnabled) {
-    reasons.push("experimentalFeatures.workflowInterpreterDualObserve is disabled");
-  }
   const paritySummary = input.paritySummary;
   if (!paritySummary) {
     reasons.push("workflow parity summary unavailable");
@@ -160189,7 +160186,6 @@ var init_workflow_authoritative_driver = __esm({
     "use strict";
     init_src();
     init_logger2();
-    init_workflow_parity_observer();
     init_workflow_graph_task_runner();
     AUTHORITATIVE_WORKFLOW_ID = "workflow-interpreter-authoritative";
     WorkflowAuthoritativeDriver = class {
@@ -160216,13 +160212,8 @@ var init_workflow_authoritative_driver = __esm({
           settings,
           WORKFLOW_INTERPRETER_AUTHORITATIVE_FLAG
         );
-        const dualObserveEnabled = isExperimentalFeatureEnabled(
-          settings,
-          WORKFLOW_INTERPRETER_DUAL_OBSERVE_FLAG
-        );
         const readiness = evaluateInterpreterCutoverReadiness({
           authoritativeFlagEnabled,
-          dualObserveEnabled,
           paritySummary,
           minimumObservedRuns: this.deps.minimumObservedRuns
         });
@@ -183130,8 +183121,8 @@ async function getFirstQuestionFromAgent(session, message) {
     }
   }
   if (!parsed) {
-    sessions.delete(session.id);
-    unpersistSession(session.id);
+    const errorMessage = buildRetryableParseErrorMessage(lastError);
+    setSessionError(session, errorMessage);
     try {
       await session.agent.session.dispose?.();
     } catch (disposeErr) {
@@ -183142,9 +183133,7 @@ async function getFirstQuestionFromAgent(session, message) {
       });
     }
     session.agent = void 0;
-    throw new Error(
-      `Failed to get first question from AI: ${lastError?.message || "Unknown error"}`
-    );
+    throw new Error(`Failed to get first question from AI: ${errorMessage}`);
   }
   if (parsed.type === "complete") {
     const summary = parsed.data;
@@ -183515,6 +183504,10 @@ async function maybeNotifyPlanningAwaitingInput(session, question) {
     });
   }
 }
+function buildRetryableParseErrorMessage(error) {
+  const baseMessage = (error?.message || "Failed to parse AI response").replace(/\s*Please try again\.?\s*$/i, "").trim();
+  return `${baseMessage}. Retry this planning session or start a new one.`;
+}
 function setSessionError(session, message) {
   session.error = message;
   session.updatedAt = /* @__PURE__ */ new Date();
@@ -183647,18 +183640,12 @@ async function continueAgentConversation(session, message) {
         }
       }
       if (!parsed) {
-        const errorMsg = `${lastError?.message || "Failed to parse AI response"} You can try responding again or start a new planning session.`;
+        const errorMsg = buildRetryableParseErrorMessage(lastError);
         diagnostics2.error(
           "All parse attempts exhausted for session",
           { sessionId: session.id, message: errorMsg, operation: "parse-exhausted" }
         );
-        session.error = errorMsg;
-        session.updatedAt = /* @__PURE__ */ new Date();
-        persistSession(session, "error", errorMsg);
-        planningStreamManager.broadcast(session.id, {
-          type: "error",
-          data: errorMsg
-        });
+        setSessionError(session, errorMsg);
         return;
       }
       if (parsed.type === "question") {
@@ -183695,13 +183682,33 @@ async function continueAgentConversation(session, message) {
     setSessionError(session, errorMessage);
   }
 }
+function isPlanningResponseShape(parsed) {
+  if (typeof parsed !== "object" || parsed === null || !("type" in parsed) || !("data" in parsed)) {
+    return false;
+  }
+  const typed = parsed;
+  return (typed.type === "question" || typed.type === "complete") && typed.data !== null && typed.data !== void 0;
+}
+function parseJsonCandidateForShape(candidate) {
+  try {
+    return JSON.parse(candidate);
+  } catch {
+    try {
+      return JSON.parse(repairJson2(candidate));
+    } catch {
+      return void 0;
+    }
+  }
+}
 function extractJsonCandidate2(text) {
   if (!text || !text.trim()) return null;
-  const codeBlockMatch = text.match(/```(?:json)?\s*([\s\S]*?)\s*```/);
-  if (codeBlockMatch?.[1]) {
-    const candidate = codeBlockMatch[1].trim();
-    if (candidate.startsWith("{")) return candidate;
-  }
+  const codeBlockMatches = [...text.matchAll(/```(?:json)?\s*([\s\S]*?)\s*```/g)];
+  const codeBlockCandidates = codeBlockMatches.map((match) => match[1]?.trim()).filter((candidate) => Boolean(candidate?.startsWith("{")));
+  const planningCodeBlock = codeBlockCandidates.find(
+    (candidate) => isPlanningResponseShape(parseJsonCandidateForShape(candidate))
+  );
+  if (planningCodeBlock) return planningCodeBlock;
+  if (codeBlockCandidates.length > 0) return codeBlockCandidates[0];
   const candidates = [];
   for (let i = 0; i < text.length; i++) {
     if (text[i] === "{") {
@@ -183727,19 +183734,18 @@ function extractJsonCandidate2(text) {
         if (ch === "}") depth--;
         if (depth === 0) {
           const candidate = text.slice(i, j2 + 1).trim();
-          try {
-            JSON.parse(candidate);
-            candidates.push({ start: i, end: j2, text: candidate });
-          } catch {
-          }
+          candidates.push({ start: i, end: j2, text: candidate, parsed: parseJsonCandidateForShape(candidate) });
           break;
         }
       }
     }
   }
-  if (candidates.length > 0) {
-    candidates.sort((a, b2) => b2.text.length - a.text.length);
-    return candidates[0].text;
+  const planningCandidate = candidates.find((candidate) => isPlanningResponseShape(candidate.parsed));
+  if (planningCandidate) return planningCandidate.text;
+  const validCandidates = candidates.filter((candidate) => candidate.parsed !== void 0);
+  if (validCandidates.length > 0) {
+    validCandidates.sort((a, b2) => b2.text.length - a.text.length || a.start - b2.start);
+    return validCandidates[0].text;
   }
   const trimmed = text.trim();
   if (trimmed.startsWith("{")) return trimmed;
@@ -183824,11 +183830,8 @@ function parseAgentResponse2(text) {
       );
     }
   }
-  if (typeof parsed === "object" && parsed !== null && "type" in parsed && "data" in parsed) {
-    const typed = parsed;
-    if ((typed.type === "question" || typed.type === "complete") && typed.data !== null && typed.data !== void 0) {
-      return parsed;
-    }
+  if (isPlanningResponseShape(parsed)) {
+    return parsed;
   }
   diagnostics2.error("Invalid response structure from AI", { parsedSnippet: JSON.stringify(parsed).slice(0, 500), operation: "parse-validate" });
   throw new Error("AI returned an invalid response structure. Please try again.");
@@ -190655,6 +190658,13 @@ function parseIssueUrl(stdout) {
     url
   };
 }
+function requireNonEmptyPrBody(body) {
+  const trimmed = body?.trim() ?? "";
+  if (!trimmed) {
+    throw new Error("PR body is required when creating a pull request");
+  }
+  return trimmed;
+}
 function normalizeCheckState(state) {
   switch ((state ?? "").toLowerCase()) {
     case "success":
@@ -191133,6 +191143,7 @@ var init_github = __esm({
       createPrWithGh(params) {
         const { owner: paramOwner, repo: paramRepo, title, body, head, base, draft, reviewers } = params;
         const { owner, repo } = this.resolveRepo(paramOwner, paramRepo);
+        const prBody = requireNonEmptyPrBody(body);
         const args = [
           "pr",
           "create",
@@ -191141,11 +191152,10 @@ var init_github = __esm({
           "--title",
           title,
           "--head",
-          head
+          head,
+          "--body",
+          prBody
         ];
-        if (body) {
-          args.push("--body", body);
-        }
         if (base) {
           args.push("--base", base);
         }
@@ -191175,6 +191185,7 @@ var init_github = __esm({
       async createPrWithApi(params) {
         const { owner: paramOwner, repo: paramRepo, title, body, head, base = "main", draft, reviewers } = params;
         const { owner, repo } = this.resolveRepo(paramOwner, paramRepo);
+        const prBody = requireNonEmptyPrBody(body);
         const url = `${this.baseUrl}/repos/${encodeURIComponent(owner)}/${encodeURIComponent(repo)}/pulls`;
         const headers = this.buildHeaders();
         const response = await fetch(url, {
@@ -191182,7 +191193,7 @@ var init_github = __esm({
           headers,
           body: JSON.stringify({
             title,
-            body: body || "",
+            body: prBody,
             head,
             base,
             draft: draft === true
@@ -195704,7 +195715,7 @@ import { promisify as promisify54 } from "node:util";
 import { exec as execCb } from "node:child_process";
 import { access as access9, readFile as readFile27 } from "node:fs/promises";
 import { join as join63 } from "node:path";
-function buildFallback(task) {
+function buildFallbackPrMetadata(task) {
   return {
     title: task.title ?? task.id,
     body: [
@@ -195808,12 +195819,13 @@ Closes ${taskId}`.trim()]
   return out.join("\n");
 }
 async function runCommand(command, cwd, signal) {
-  const { stdout } = await execAsync36(command, {
+  const commandPromise = execAsync36(command, {
     cwd,
     timeout: 15e3,
     maxBuffer: 10 * 1024 * 1024,
     signal
   });
+  const { stdout } = signal ? await raceWithAbort(commandPromise, signal) : await commandPromise;
   return stdout.trim();
 }
 function createAbortError3() {
@@ -195827,19 +195839,41 @@ function throwIfAborted3(signal) {
   }
   throw signal.reason instanceof Error ? signal.reason : createAbortError3();
 }
-function waitForAbort(signal) {
-  return new Promise((_3, reject2) => {
-    if (signal.aborted) {
-      reject2(signal.reason instanceof Error ? signal.reason : createAbortError3());
-      return;
-    }
-    signal.addEventListener(
-      "abort",
-      () => reject2(signal.reason instanceof Error ? signal.reason : createAbortError3()),
-      { once: true }
+function getAbortReason(signal) {
+  return signal.reason instanceof Error ? signal.reason : createAbortError3();
+}
+function raceWithAbort(operation, signal) {
+  if (signal.aborted) {
+    return Promise.reject(getAbortReason(signal));
+  }
+  return new Promise((resolve70, reject2) => {
+    const cleanup = () => signal.removeEventListener("abort", onAbort);
+    const onAbort = () => {
+      cleanup();
+      reject2(getAbortReason(signal));
+    };
+    signal.addEventListener("abort", onAbort, { once: true });
+    Promise.resolve(operation).then(
+      (value) => {
+        cleanup();
+        resolve70(value);
+      },
+      (error) => {
+        cleanup();
+        reject2(error);
+      }
     );
   });
 }
+function disposeSessionBestEffort(session) {
+  try {
+    const disposeResult = session.dispose?.();
+    if (disposeResult && typeof disposeResult.catch === "function") {
+      void disposeResult.catch(() => void 0);
+    }
+  } catch {
+  }
+}
 function isAbortLikeError(error) {
   return Boolean(
     error && typeof error === "object" && ("name" in error ? error.name === "AbortError" : false)
@@ -195858,7 +195892,7 @@ async function resolveBaseBranch(task, repoRoot, signal) {
 }
 async function generatePrMetadata(input) {
   const { task, repoRoot, settings, signal, timeoutMs = PR_METADATA_TIMEOUT_MS } = input;
-  const fallback2 = buildFallback(task);
+  const fallback2 = buildFallbackPrMetadata(task);
   const controller = new AbortController();
   const abortFromCaller = () => controller.abort(signal?.reason instanceof Error ? signal.reason : createAbortError3());
   const timeoutId = setTimeout(() => controller.abort(createAbortError3()), timeoutMs);
@@ -195873,24 +195907,24 @@ async function generatePrMetadata(input) {
   }
   try {
     throwIfAborted3(combinedSignal);
-    const baseBranch = await resolveBaseBranch(task, repoRoot, combinedSignal);
-    const [logOut, diffStatOut] = await Promise.all([
+    const baseBranch = await raceWithAbort(resolveBaseBranch(task, repoRoot, combinedSignal), combinedSignal);
+    const [logOut, diffStatOut] = await raceWithAbort(Promise.all([
       runCommand(`git log --no-merges ${baseBranch}..HEAD --format=%s%n%b`, repoRoot, combinedSignal).catch(() => ""),
       runCommand(`git diff --stat ${baseBranch}..HEAD`, repoRoot, combinedSignal).catch(() => "")
-    ]);
+    ]), combinedSignal);
     let promptContent = "";
     try {
       const promptPath = join63(repoRoot, ".fusion", "tasks", task.id, "PROMPT.md");
-      promptContent = (await readFile27(promptPath, "utf8")).trim();
+      promptContent = (await raceWithAbort(readFile27(promptPath, "utf8"), combinedSignal)).trim();
     } catch {
       promptContent = "";
     }
     const templatePath = join63(repoRoot, ".github", "pull_request_template.md");
-    const templateExists = await access9(templatePath).then(() => true).catch(() => false);
-    const template = templateExists ? await readFile27(templatePath, "utf8") : "";
+    const templateExists = await raceWithAbort(access9(templatePath).then(() => true).catch(() => false), combinedSignal);
+    const template = templateExists ? await raceWithAbort(readFile27(templatePath, "utf8"), combinedSignal) : "";
     const model = resolveTitleSummarizerSettingsModel(settings);
     let aiText = "";
-    const { session } = await createFnAgent2({
+    const { session } = await raceWithAbort(createFnAgent2({
       cwd: repoRoot,
       tools: "readonly",
       defaultProvider: model.provider,
@@ -195903,7 +195937,7 @@ async function generatePrMetadata(input) {
       onText: (delta) => {
         aiText += delta;
       }
-    });
+    }), combinedSignal);
     try {
       const contextPrompt = [
         `Task ID: ${task.id}`,
@@ -195918,15 +195952,12 @@ async function generatePrMetadata(input) {
         promptContent || "(none)"
       ].join("\n\n");
       throwIfAborted3(combinedSignal);
-      await Promise.race([
+      await raceWithAbort(
         session.prompt(contextPrompt, { signal: combinedSignal }),
-        waitForAbort(combinedSignal)
-      ]);
+        combinedSignal
+      );
     } finally {
-      try {
-        session.dispose();
-      } catch {
-      }
+      disposeSessionBestEffort(session);
     }
     const parsed = parseAiResult(aiText);
     if (!parsed) {
@@ -199940,13 +199971,18 @@ ${body}`;
     try {
       const { store: scopedStore } = await getProjectContext3(req);
       const { title, body, base } = req.body;
-      if (!title || typeof title !== "string") {
-        throw badRequest("title is required and must be a string");
-      }
       const task = await scopedStore.getTask(req.params.id);
       if (task.column !== "in-review") {
         throw badRequest("Task must be in 'in-review' column to create a PR");
       }
+      if (!title || typeof title !== "string") {
+        throw badRequest("title is required and must be a string");
+      }
+      if (!body || typeof body !== "string" || !body.trim()) {
+        throw badRequest("body is required and must be a non-empty string");
+      }
+      const prTitle = title.trim();
+      const prBody = body.trim();
       const existingPrs = getTaskPrList(task);
       const branchName = `fusion/${task.id.toLowerCase()}`;
       let owner;
@@ -199983,8 +200019,8 @@ ${body}`;
         prInfo = await client.createPr({
           owner,
           repo,
-          title,
-          body,
+          title: prTitle,
+          body: prBody,
           head: branchName,
           base
         });
@@ -200125,19 +200161,48 @@ ${body}`;
   });
   router.post("/tasks/:id/pr/generate-metadata", async (req, res) => {
     const controller = new AbortController();
-    const abortRequest = () => controller.abort();
-    req.on("close", abortRequest);
+    let responseCompleted = false;
+    const abortRequest = () => {
+      if (!responseCompleted && !controller.signal.aborted) {
+        const error = new Error("PR metadata request aborted");
+        error.name = "AbortError";
+        controller.abort(error);
+      }
+    };
+    const markCompleted = () => {
+      responseCompleted = true;
+    };
+    req.on("aborted", abortRequest);
+    res.on("close", abortRequest);
+    res.on("finish", markCompleted);
     try {
       const { store: scopedStore } = await getProjectContext3(req);
       const task = await scopedStore.getTask(req.params.id);
       const settings = await scopedStore.getSettings();
-      const metadata = await generatePrMetadata({
+      let timeoutId;
+      const generatorPromise = generatePrMetadata({
         task,
         repoRoot: scopedStore.getRootDir(),
         settings,
-        signal: controller.signal
+        signal: controller.signal,
+        timeoutMs: PR_METADATA_ROUTE_TIMEOUT_MS
+      });
+      void generatorPromise.catch(() => void 0);
+      const timeoutFallbackPromise = new Promise((resolve70) => {
+        timeoutId = setTimeout(() => {
+          abortRequest();
+          resolve70(buildFallbackPrMetadata(task));
+        }, PR_METADATA_ROUTE_TIMEOUT_MS);
       });
-      if (req.destroyed || res.writableEnded || res.writableFinished || controller.signal.aborted) {
+      let metadata;
+      try {
+        metadata = await Promise.race([generatorPromise, timeoutFallbackPromise]);
+      } finally {
+        if (timeoutId) {
+          clearTimeout(timeoutId);
+        }
+      }
+      if (res.writableEnded || res.writableFinished || res.destroyed) {
         return;
       }
       res.json(metadata);
@@ -200150,7 +200215,9 @@ ${body}`;
       }
       rethrowAsApiError9(err, "Failed to generate PR metadata");
     } finally {
-      req.off("close", abortRequest);
+      req.removeListener("aborted", abortRequest);
+      res.removeListener("close", abortRequest);
+      res.removeListener("finish", markCompleted);
     }
   });
   router.get("/tasks/:id/pr/preflight", async (req, res) => {
@@ -200719,7 +200786,7 @@ ${body}`;
     }
   });
 }
-var execAsync37, PR_ROUTE_MAX_BUFFER_BYTES, PR_PREFLIGHT_TIMEOUT_MS, PR_OPTIONS_TIMEOUT_MS, SAFE_GIT_REF_PATTERN, GITHUB_TRACKING_RECONCILE_INTERVAL_MS, RECENT_ISSUES_CACHE_TTL_MS, recentIssuesCache, prRouteCommandRunner, batchImportWindowMs, batchImportInstances, batchImportCleanupInterval;
+var execAsync37, PR_ROUTE_MAX_BUFFER_BYTES, PR_PREFLIGHT_TIMEOUT_MS, PR_OPTIONS_TIMEOUT_MS, PR_METADATA_ROUTE_TIMEOUT_MS, SAFE_GIT_REF_PATTERN, GITHUB_TRACKING_RECONCILE_INTERVAL_MS, RECENT_ISSUES_CACHE_TTL_MS, recentIssuesCache, prRouteCommandRunner, batchImportWindowMs, batchImportInstances, batchImportCleanupInterval;
 var init_register_git_github = __esm({
   "../dashboard/src/routes/register-git-github.ts"() {
     "use strict";
@@ -200743,6 +200810,7 @@ var init_register_git_github = __esm({
     PR_ROUTE_MAX_BUFFER_BYTES = 10 * 1024 * 1024;
     PR_PREFLIGHT_TIMEOUT_MS = 15e3;
     PR_OPTIONS_TIMEOUT_MS = 1e4;
+    PR_METADATA_ROUTE_TIMEOUT_MS = 25e3;
     SAFE_GIT_REF_PATTERN = /^[A-Za-z0-9._/-]+$/;
     GITHUB_TRACKING_RECONCILE_INTERVAL_MS = 15 * 60 * 1e3;
     RECENT_ISSUES_CACHE_TTL_MS = 6e4;