@runchr/gstack-antigravity 0.1.1 → 0.1.3

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Potentially problematic release.


This version of @runchr/gstack-antigravity might be problematic. Click here for more details.

Files changed (229) hide show
  1. package/.agents/skills/gstack/.agents/skills/gstack/SKILL.md +651 -0
  2. package/.agents/skills/gstack/.agents/skills/gstack-autoplan/SKILL.md +678 -0
  3. package/.agents/skills/gstack/.agents/skills/gstack-benchmark/SKILL.md +482 -0
  4. package/.agents/skills/gstack/.agents/skills/gstack-browse/SKILL.md +511 -0
  5. package/.agents/skills/gstack/.agents/skills/gstack-canary/SKILL.md +486 -0
  6. package/.agents/skills/gstack/.agents/skills/gstack-careful/SKILL.md +50 -0
  7. package/.agents/skills/gstack/.agents/skills/gstack-cso/SKILL.md +607 -0
  8. package/.agents/skills/gstack/.agents/skills/gstack-design-consultation/SKILL.md +615 -0
  9. package/.agents/skills/gstack/.agents/skills/gstack-design-review/SKILL.md +988 -0
  10. package/.agents/skills/gstack/.agents/skills/gstack-document-release/SKILL.md +604 -0
  11. package/.agents/skills/gstack/.agents/skills/gstack-freeze/SKILL.md +67 -0
  12. package/.agents/skills/gstack/.agents/skills/gstack-guard/SKILL.md +62 -0
  13. package/.agents/skills/gstack/.agents/skills/gstack-investigate/SKILL.md +415 -0
  14. package/.agents/skills/gstack/.agents/skills/gstack-land-and-deploy/SKILL.md +873 -0
  15. package/.agents/skills/gstack/.agents/skills/gstack-office-hours/SKILL.md +986 -0
  16. package/.agents/skills/gstack/.agents/skills/gstack-plan-ceo-review/SKILL.md +1268 -0
  17. package/.agents/skills/gstack/.agents/skills/gstack-plan-design-review/SKILL.md +668 -0
  18. package/.agents/skills/gstack/.agents/skills/gstack-plan-eng-review/SKILL.md +826 -0
  19. package/.agents/skills/gstack/.agents/skills/gstack-qa/SKILL.md +1006 -0
  20. package/.agents/skills/gstack/.agents/skills/gstack-qa-only/SKILL.md +626 -0
  21. package/.agents/skills/gstack/.agents/skills/gstack-retro/SKILL.md +1065 -0
  22. package/.agents/skills/gstack/.agents/skills/gstack-review/SKILL.md +704 -0
  23. package/.agents/skills/gstack/.agents/skills/gstack-setup-browser-cookies/SKILL.md +325 -0
  24. package/.agents/skills/gstack/.agents/skills/gstack-setup-deploy/SKILL.md +450 -0
  25. package/.agents/skills/gstack/.agents/skills/gstack-ship/SKILL.md +1312 -0
  26. package/.agents/skills/gstack/.agents/skills/gstack-unfreeze/SKILL.md +36 -0
  27. package/.agents/skills/gstack/.agents/skills/gstack-upgrade/SKILL.md +220 -0
  28. package/.agents/skills/gstack/.env.example +5 -0
  29. package/.agents/skills/gstack/.github/workflows/skill-docs.yml +17 -0
  30. package/.agents/skills/gstack/AGENTS.md +49 -0
  31. package/.agents/skills/gstack/ARCHITECTURE.md +359 -0
  32. package/.agents/skills/gstack/BROWSER.md +271 -0
  33. package/.agents/skills/gstack/CHANGELOG.md +800 -0
  34. package/.agents/skills/gstack/CLAUDE.md +284 -0
  35. package/.agents/skills/gstack/CONTRIBUTING.md +370 -0
  36. package/.agents/skills/gstack/ETHOS.md +129 -0
  37. package/.agents/skills/gstack/LICENSE +21 -0
  38. package/.agents/skills/gstack/README.md +228 -0
  39. package/.agents/skills/gstack/SKILL.md +657 -0
  40. package/.agents/skills/gstack/SKILL.md.tmpl +281 -0
  41. package/.agents/skills/gstack/TODOS.md +564 -0
  42. package/.agents/skills/gstack/VERSION +1 -0
  43. package/.agents/skills/gstack/autoplan/SKILL.md +689 -0
  44. package/.agents/skills/gstack/autoplan/SKILL.md.tmpl +416 -0
  45. package/.agents/skills/gstack/benchmark/SKILL.md +489 -0
  46. package/.agents/skills/gstack/benchmark/SKILL.md.tmpl +233 -0
  47. package/.agents/skills/gstack/bin/dev-setup +68 -0
  48. package/.agents/skills/gstack/bin/dev-teardown +56 -0
  49. package/.agents/skills/gstack/bin/gstack-analytics +191 -0
  50. package/.agents/skills/gstack/bin/gstack-community-dashboard +113 -0
  51. package/.agents/skills/gstack/bin/gstack-config +38 -0
  52. package/.agents/skills/gstack/bin/gstack-diff-scope +71 -0
  53. package/.agents/skills/gstack/bin/gstack-global-discover.ts +591 -0
  54. package/.agents/skills/gstack/bin/gstack-repo-mode +93 -0
  55. package/.agents/skills/gstack/bin/gstack-review-log +9 -0
  56. package/.agents/skills/gstack/bin/gstack-review-read +12 -0
  57. package/.agents/skills/gstack/bin/gstack-slug +15 -0
  58. package/.agents/skills/gstack/bin/gstack-telemetry-log +158 -0
  59. package/.agents/skills/gstack/bin/gstack-telemetry-sync +127 -0
  60. package/.agents/skills/gstack/bin/gstack-update-check +196 -0
  61. package/.agents/skills/gstack/browse/SKILL.md +517 -0
  62. package/.agents/skills/gstack/browse/SKILL.md.tmpl +141 -0
  63. package/.agents/skills/gstack/browse/bin/find-browse +21 -0
  64. package/.agents/skills/gstack/browse/bin/remote-slug +14 -0
  65. package/.agents/skills/gstack/browse/scripts/build-node-server.sh +48 -0
  66. package/.agents/skills/gstack/browse/src/browser-manager.ts +634 -0
  67. package/.agents/skills/gstack/browse/src/buffers.ts +137 -0
  68. package/.agents/skills/gstack/browse/src/bun-polyfill.cjs +109 -0
  69. package/.agents/skills/gstack/browse/src/cli.ts +420 -0
  70. package/.agents/skills/gstack/browse/src/commands.ts +111 -0
  71. package/.agents/skills/gstack/browse/src/config.ts +150 -0
  72. package/.agents/skills/gstack/browse/src/cookie-import-browser.ts +417 -0
  73. package/.agents/skills/gstack/browse/src/cookie-picker-routes.ts +207 -0
  74. package/.agents/skills/gstack/browse/src/cookie-picker-ui.ts +541 -0
  75. package/.agents/skills/gstack/browse/src/find-browse.ts +61 -0
  76. package/.agents/skills/gstack/browse/src/meta-commands.ts +269 -0
  77. package/.agents/skills/gstack/browse/src/platform.ts +17 -0
  78. package/.agents/skills/gstack/browse/src/read-commands.ts +335 -0
  79. package/.agents/skills/gstack/browse/src/server.ts +369 -0
  80. package/.agents/skills/gstack/browse/src/snapshot.ts +398 -0
  81. package/.agents/skills/gstack/browse/src/url-validation.ts +91 -0
  82. package/.agents/skills/gstack/browse/src/write-commands.ts +352 -0
  83. package/.agents/skills/gstack/browse/test/bun-polyfill.test.ts +72 -0
  84. package/.agents/skills/gstack/browse/test/commands.test.ts +1836 -0
  85. package/.agents/skills/gstack/browse/test/config.test.ts +250 -0
  86. package/.agents/skills/gstack/browse/test/cookie-import-browser.test.ts +397 -0
  87. package/.agents/skills/gstack/browse/test/cookie-picker-routes.test.ts +205 -0
  88. package/.agents/skills/gstack/browse/test/find-browse.test.ts +50 -0
  89. package/.agents/skills/gstack/browse/test/fixtures/basic.html +33 -0
  90. package/.agents/skills/gstack/browse/test/fixtures/cursor-interactive.html +22 -0
  91. package/.agents/skills/gstack/browse/test/fixtures/dialog.html +15 -0
  92. package/.agents/skills/gstack/browse/test/fixtures/empty.html +2 -0
  93. package/.agents/skills/gstack/browse/test/fixtures/forms.html +55 -0
  94. package/.agents/skills/gstack/browse/test/fixtures/qa-eval-checkout.html +108 -0
  95. package/.agents/skills/gstack/browse/test/fixtures/qa-eval-spa.html +98 -0
  96. package/.agents/skills/gstack/browse/test/fixtures/qa-eval.html +51 -0
  97. package/.agents/skills/gstack/browse/test/fixtures/responsive.html +49 -0
  98. package/.agents/skills/gstack/browse/test/fixtures/snapshot.html +55 -0
  99. package/.agents/skills/gstack/browse/test/fixtures/spa.html +24 -0
  100. package/.agents/skills/gstack/browse/test/fixtures/states.html +17 -0
  101. package/.agents/skills/gstack/browse/test/fixtures/upload.html +25 -0
  102. package/.agents/skills/gstack/browse/test/gstack-config.test.ts +125 -0
  103. package/.agents/skills/gstack/browse/test/gstack-update-check.test.ts +467 -0
  104. package/.agents/skills/gstack/browse/test/handoff.test.ts +235 -0
  105. package/.agents/skills/gstack/browse/test/path-validation.test.ts +63 -0
  106. package/.agents/skills/gstack/browse/test/platform.test.ts +37 -0
  107. package/.agents/skills/gstack/browse/test/snapshot.test.ts +467 -0
  108. package/.agents/skills/gstack/browse/test/test-server.ts +57 -0
  109. package/.agents/skills/gstack/browse/test/url-validation.test.ts +72 -0
  110. package/.agents/skills/gstack/canary/SKILL.md +493 -0
  111. package/.agents/skills/gstack/canary/SKILL.md.tmpl +220 -0
  112. package/.agents/skills/gstack/careful/SKILL.md +59 -0
  113. package/.agents/skills/gstack/careful/SKILL.md.tmpl +57 -0
  114. package/.agents/skills/gstack/careful/bin/check-careful.sh +112 -0
  115. package/.agents/skills/gstack/codex/SKILL.md +677 -0
  116. package/.agents/skills/gstack/codex/SKILL.md.tmpl +356 -0
  117. package/.agents/skills/gstack/conductor.json +6 -0
  118. package/.agents/skills/gstack/cso/SKILL.md +615 -0
  119. package/.agents/skills/gstack/cso/SKILL.md.tmpl +376 -0
  120. package/.agents/skills/gstack/design-consultation/SKILL.md +625 -0
  121. package/.agents/skills/gstack/design-consultation/SKILL.md.tmpl +369 -0
  122. package/.agents/skills/gstack/design-review/SKILL.md +998 -0
  123. package/.agents/skills/gstack/design-review/SKILL.md.tmpl +262 -0
  124. package/.agents/skills/gstack/docs/images/github-2013.png +0 -0
  125. package/.agents/skills/gstack/docs/images/github-2026.png +0 -0
  126. package/.agents/skills/gstack/docs/skills.md +877 -0
  127. package/.agents/skills/gstack/document-release/SKILL.md +613 -0
  128. package/.agents/skills/gstack/document-release/SKILL.md.tmpl +357 -0
  129. package/.agents/skills/gstack/freeze/SKILL.md +82 -0
  130. package/.agents/skills/gstack/freeze/SKILL.md.tmpl +80 -0
  131. package/.agents/skills/gstack/freeze/bin/check-freeze.sh +68 -0
  132. package/.agents/skills/gstack/gstack-upgrade/SKILL.md +226 -0
  133. package/.agents/skills/gstack/gstack-upgrade/SKILL.md.tmpl +224 -0
  134. package/.agents/skills/gstack/guard/SKILL.md +82 -0
  135. package/.agents/skills/gstack/guard/SKILL.md.tmpl +80 -0
  136. package/.agents/skills/gstack/investigate/SKILL.md +435 -0
  137. package/.agents/skills/gstack/investigate/SKILL.md.tmpl +196 -0
  138. package/.agents/skills/gstack/land-and-deploy/SKILL.md +880 -0
  139. package/.agents/skills/gstack/land-and-deploy/SKILL.md.tmpl +575 -0
  140. package/.agents/skills/gstack/office-hours/SKILL.md +996 -0
  141. package/.agents/skills/gstack/office-hours/SKILL.md.tmpl +624 -0
  142. package/.agents/skills/gstack/package.json +55 -0
  143. package/.agents/skills/gstack/plan-ceo-review/SKILL.md +1277 -0
  144. package/.agents/skills/gstack/plan-ceo-review/SKILL.md.tmpl +838 -0
  145. package/.agents/skills/gstack/plan-design-review/SKILL.md +676 -0
  146. package/.agents/skills/gstack/plan-design-review/SKILL.md.tmpl +314 -0
  147. package/.agents/skills/gstack/plan-eng-review/SKILL.md +836 -0
  148. package/.agents/skills/gstack/plan-eng-review/SKILL.md.tmpl +279 -0
  149. package/.agents/skills/gstack/qa/SKILL.md +1016 -0
  150. package/.agents/skills/gstack/qa/SKILL.md.tmpl +316 -0
  151. package/.agents/skills/gstack/qa/references/issue-taxonomy.md +85 -0
  152. package/.agents/skills/gstack/qa/templates/qa-report-template.md +126 -0
  153. package/.agents/skills/gstack/qa-only/SKILL.md +633 -0
  154. package/.agents/skills/gstack/qa-only/SKILL.md.tmpl +101 -0
  155. package/.agents/skills/gstack/retro/SKILL.md +1072 -0
  156. package/.agents/skills/gstack/retro/SKILL.md.tmpl +833 -0
  157. package/.agents/skills/gstack/review/SKILL.md +849 -0
  158. package/.agents/skills/gstack/review/SKILL.md.tmpl +259 -0
  159. package/.agents/skills/gstack/review/TODOS-format.md +62 -0
  160. package/.agents/skills/gstack/review/checklist.md +190 -0
  161. package/.agents/skills/gstack/review/design-checklist.md +132 -0
  162. package/.agents/skills/gstack/review/greptile-triage.md +220 -0
  163. package/.agents/skills/gstack/scripts/analytics.ts +190 -0
  164. package/.agents/skills/gstack/scripts/dev-skill.ts +82 -0
  165. package/.agents/skills/gstack/scripts/eval-compare.ts +96 -0
  166. package/.agents/skills/gstack/scripts/eval-list.ts +116 -0
  167. package/.agents/skills/gstack/scripts/eval-select.ts +86 -0
  168. package/.agents/skills/gstack/scripts/eval-summary.ts +187 -0
  169. package/.agents/skills/gstack/scripts/eval-watch.ts +172 -0
  170. package/.agents/skills/gstack/scripts/gen-skill-docs.ts +2414 -0
  171. package/.agents/skills/gstack/scripts/skill-check.ts +167 -0
  172. package/.agents/skills/gstack/setup +269 -0
  173. package/.agents/skills/gstack/setup-browser-cookies/SKILL.md +330 -0
  174. package/.agents/skills/gstack/setup-browser-cookies/SKILL.md.tmpl +74 -0
  175. package/.agents/skills/gstack/setup-deploy/SKILL.md +459 -0
  176. package/.agents/skills/gstack/setup-deploy/SKILL.md.tmpl +220 -0
  177. package/.agents/skills/gstack/ship/SKILL.md +1457 -0
  178. package/.agents/skills/gstack/ship/SKILL.md.tmpl +528 -0
  179. package/.agents/skills/gstack/supabase/config.sh +10 -0
  180. package/.agents/skills/gstack/supabase/functions/community-pulse/index.ts +59 -0
  181. package/.agents/skills/gstack/supabase/functions/telemetry-ingest/index.ts +135 -0
  182. package/.agents/skills/gstack/supabase/functions/update-check/index.ts +37 -0
  183. package/.agents/skills/gstack/supabase/migrations/001_telemetry.sql +89 -0
  184. package/.agents/skills/gstack/test/analytics.test.ts +277 -0
  185. package/.agents/skills/gstack/test/codex-e2e.test.ts +197 -0
  186. package/.agents/skills/gstack/test/fixtures/coverage-audit-fixture.ts +76 -0
  187. package/.agents/skills/gstack/test/fixtures/eval-baselines.json +7 -0
  188. package/.agents/skills/gstack/test/fixtures/qa-eval-checkout-ground-truth.json +43 -0
  189. package/.agents/skills/gstack/test/fixtures/qa-eval-ground-truth.json +43 -0
  190. package/.agents/skills/gstack/test/fixtures/qa-eval-spa-ground-truth.json +43 -0
  191. package/.agents/skills/gstack/test/fixtures/review-eval-design-slop.css +86 -0
  192. package/.agents/skills/gstack/test/fixtures/review-eval-design-slop.html +41 -0
  193. package/.agents/skills/gstack/test/fixtures/review-eval-enum-diff.rb +30 -0
  194. package/.agents/skills/gstack/test/fixtures/review-eval-enum.rb +27 -0
  195. package/.agents/skills/gstack/test/fixtures/review-eval-vuln.rb +14 -0
  196. package/.agents/skills/gstack/test/gemini-e2e.test.ts +173 -0
  197. package/.agents/skills/gstack/test/gen-skill-docs.test.ts +1049 -0
  198. package/.agents/skills/gstack/test/global-discover.test.ts +187 -0
  199. package/.agents/skills/gstack/test/helpers/codex-session-runner.ts +282 -0
  200. package/.agents/skills/gstack/test/helpers/e2e-helpers.ts +239 -0
  201. package/.agents/skills/gstack/test/helpers/eval-store.test.ts +548 -0
  202. package/.agents/skills/gstack/test/helpers/eval-store.ts +689 -0
  203. package/.agents/skills/gstack/test/helpers/gemini-session-runner.test.ts +104 -0
  204. package/.agents/skills/gstack/test/helpers/gemini-session-runner.ts +201 -0
  205. package/.agents/skills/gstack/test/helpers/llm-judge.ts +130 -0
  206. package/.agents/skills/gstack/test/helpers/observability.test.ts +283 -0
  207. package/.agents/skills/gstack/test/helpers/session-runner.test.ts +96 -0
  208. package/.agents/skills/gstack/test/helpers/session-runner.ts +357 -0
  209. package/.agents/skills/gstack/test/helpers/skill-parser.ts +206 -0
  210. package/.agents/skills/gstack/test/helpers/touchfiles.ts +260 -0
  211. package/.agents/skills/gstack/test/hook-scripts.test.ts +373 -0
  212. package/.agents/skills/gstack/test/skill-e2e-browse.test.ts +293 -0
  213. package/.agents/skills/gstack/test/skill-e2e-deploy.test.ts +279 -0
  214. package/.agents/skills/gstack/test/skill-e2e-design.test.ts +614 -0
  215. package/.agents/skills/gstack/test/skill-e2e-plan.test.ts +538 -0
  216. package/.agents/skills/gstack/test/skill-e2e-qa-bugs.test.ts +194 -0
  217. package/.agents/skills/gstack/test/skill-e2e-qa-workflow.test.ts +412 -0
  218. package/.agents/skills/gstack/test/skill-e2e-review.test.ts +535 -0
  219. package/.agents/skills/gstack/test/skill-e2e-workflow.test.ts +586 -0
  220. package/.agents/skills/gstack/test/skill-e2e.test.ts +3325 -0
  221. package/.agents/skills/gstack/test/skill-llm-eval.test.ts +787 -0
  222. package/.agents/skills/gstack/test/skill-parser.test.ts +179 -0
  223. package/.agents/skills/gstack/test/skill-routing-e2e.test.ts +605 -0
  224. package/.agents/skills/gstack/test/skill-validation.test.ts +1520 -0
  225. package/.agents/skills/gstack/test/telemetry.test.ts +278 -0
  226. package/.agents/skills/gstack/test/touchfiles.test.ts +262 -0
  227. package/.agents/skills/gstack/unfreeze/SKILL.md +40 -0
  228. package/.agents/skills/gstack/unfreeze/SKILL.md.tmpl +38 -0
  229. package/package.json +2 -1
@@ -0,0 +1,259 @@
1
+ ---
2
+ name: review
3
+ version: 1.0.0
4
+ description: |
5
+ Pre-landing PR review. Analyzes diff against the base branch for SQL safety, LLM trust
6
+ boundary violations, conditional side effects, and other structural issues. Use when
7
+ asked to "review this PR", "code review", "pre-landing review", or "check my diff".
8
+ Proactively suggest when the user is about to merge or land code changes.
9
+ allowed-tools:
10
+ - Bash
11
+ - Read
12
+ - Edit
13
+ - Write
14
+ - Grep
15
+ - Glob
16
+ - Agent
17
+ - AskUserQuestion
18
+ - WebSearch
19
+ ---
20
+
21
+ {{PREAMBLE}}
22
+
23
+ {{BASE_BRANCH_DETECT}}
24
+
25
+ # Pre-Landing PR Review
26
+
27
+ You are running the `/review` workflow. Analyze the current branch's diff against the base branch for structural issues that tests don't catch.
28
+
29
+ ---
30
+
31
+ ## Step 1: Check branch
32
+
33
+ 1. Run `git branch --show-current` to get the current branch.
34
+ 2. If on the base branch, output: **"Nothing to review — you're on the base branch or have no changes against it."** and stop.
35
+ 3. Run `git fetch origin <base> --quiet && git diff origin/<base> --stat` to check if there's a diff. If no diff, output the same message and stop.
36
+
37
+ ---
38
+
39
+ ## Step 1.5: Scope Drift Detection
40
+
41
+ Before reviewing code quality, check: **did they build what was requested — nothing more, nothing less?**
42
+
43
+ 1. Read `TODOS.md` (if it exists). Read PR description (`gh pr view --json body --jq .body 2>/dev/null || true`).
44
+ Read commit messages (`git log origin/<base>..HEAD --oneline`).
45
+ **If no PR exists:** rely on commit messages and TODOS.md for stated intent — this is the common case since /review runs before /ship creates the PR.
46
+ 2. Identify the **stated intent** — what was this branch supposed to accomplish?
47
+ 3. Run `git diff origin/<base> --stat` and compare the files changed against the stated intent.
48
+ 4. Evaluate with skepticism:
49
+
50
+ **SCOPE CREEP detection:**
51
+ - Files changed that are unrelated to the stated intent
52
+ - New features or refactors not mentioned in the plan
53
+ - "While I was in there..." changes that expand blast radius
54
+
55
+ **MISSING REQUIREMENTS detection:**
56
+ - Requirements from TODOS.md/PR description not addressed in the diff
57
+ - Test coverage gaps for stated requirements
58
+ - Partial implementations (started but not finished)
59
+
60
+ 5. Output (before the main review begins):
61
+ ```
62
+ Scope Check: [CLEAN / DRIFT DETECTED / REQUIREMENTS MISSING]
63
+ Intent: <1-line summary of what was requested>
64
+ Delivered: <1-line summary of what the diff actually does>
65
+ [If drift: list each out-of-scope change]
66
+ [If missing: list each unaddressed requirement]
67
+ ```
68
+
69
+ 6. This is **INFORMATIONAL** — does not block the review. Proceed to Step 2.
70
+
71
+ ---
72
+
73
+ ## Step 2: Read the checklist
74
+
75
+ Read `.claude/skills/review/checklist.md`.
76
+
77
+ **If the file cannot be read, STOP and report the error.** Do not proceed without the checklist.
78
+
79
+ ---
80
+
81
+ ## Step 2.5: Check for Greptile review comments
82
+
83
+ Read `.claude/skills/review/greptile-triage.md` and follow the fetch, filter, classify, and **escalation detection** steps.
84
+
85
+ **If no PR exists, `gh` fails, API returns an error, or there are zero Greptile comments:** Skip this step silently. Greptile integration is additive — the review works without it.
86
+
87
+ **If Greptile comments are found:** Store the classifications (VALID & ACTIONABLE, VALID BUT ALREADY FIXED, FALSE POSITIVE, SUPPRESSED) — you will need them in Step 5.
88
+
89
+ ---
90
+
91
+ ## Step 3: Get the diff
92
+
93
+ Fetch the latest base branch to avoid false positives from stale local state:
94
+
95
+ ```bash
96
+ git fetch origin <base> --quiet
97
+ ```
98
+
99
+ Run `git diff origin/<base>` to get the full diff. This includes both committed and uncommitted changes against the latest base branch.
100
+
101
+ ---
102
+
103
+ ## Step 4: Two-pass review
104
+
105
+ Apply the checklist against the diff in two passes:
106
+
107
+ 1. **Pass 1 (CRITICAL):** SQL & Data Safety, Race Conditions & Concurrency, LLM Output Trust Boundary, Enum & Value Completeness
108
+ 2. **Pass 2 (INFORMATIONAL):** Conditional Side Effects, Magic Numbers & String Coupling, Dead Code & Consistency, LLM Prompt Issues, Test Gaps, View/Frontend, Performance & Bundle Impact
109
+
110
+ **Enum & Value Completeness requires reading code OUTSIDE the diff.** When the diff introduces a new enum value, status, tier, or type constant, use Grep to find all files that reference sibling values, then Read those files to check if the new value is handled. This is the one category where within-diff review is insufficient.
111
+
112
+ **Search-before-recommending:** When recommending a fix pattern (especially for concurrency, caching, auth, or framework-specific behavior):
113
+ - Verify the pattern is current best practice for the framework version in use
114
+ - Check if a built-in solution exists in newer versions before recommending a workaround
115
+ - Verify API signatures against current docs (APIs change between versions)
116
+
117
+ Takes seconds, prevents recommending outdated patterns. If WebSearch is unavailable, note it and proceed with in-distribution knowledge.
118
+
119
+ Follow the output format specified in the checklist. Respect the suppressions — do NOT flag items listed in the "DO NOT flag" section.
120
+
121
+ ---
122
+
123
+ ## Step 4.5: Design Review (conditional)
124
+
125
+ {{DESIGN_REVIEW_LITE}}
126
+
127
+ Include any design findings alongside the findings from Step 4. They follow the same Fix-First flow in Step 5 — AUTO-FIX for mechanical CSS fixes, ASK for everything else.
128
+
129
+ ---
130
+
131
+ ## Step 4.75: Test Coverage Diagram
132
+
133
+ {{TEST_COVERAGE_AUDIT_REVIEW}}
134
+
135
+ This step subsumes the "Test Gaps" category from Pass 2 — do not duplicate findings between the checklist Test Gaps item and this coverage diagram. Include any coverage gaps alongside the findings from Step 4 and Step 4.5. They follow the same Fix-First flow — gaps are INFORMATIONAL findings.
136
+
137
+ ---
138
+
139
+ ## Step 5: Fix-First Review
140
+
141
+ **Every finding gets action — not just critical ones.**
142
+
143
+ Output a summary header: `Pre-Landing Review: N issues (X critical, Y informational)`
144
+
145
+ ### Step 5a: Classify each finding
146
+
147
+ For each finding, classify as AUTO-FIX or ASK per the Fix-First Heuristic in
148
+ checklist.md. Critical findings lean toward ASK; informational findings lean
149
+ toward AUTO-FIX.
150
+
151
+ ### Step 5b: Auto-fix all AUTO-FIX items
152
+
153
+ Apply each fix directly. For each one, output a one-line summary:
154
+ `[AUTO-FIXED] [file:line] Problem → what you did`
155
+
156
+ ### Step 5c: Batch-ask about ASK items
157
+
158
+ If there are ASK items remaining, present them in ONE AskUserQuestion:
159
+
160
+ - List each item with a number, the severity label, the problem, and a recommended fix
161
+ - For each item, provide options: A) Fix as recommended, B) Skip
162
+ - Include an overall RECOMMENDATION
163
+
164
+ Example format:
165
+ ```
166
+ I auto-fixed 5 issues. 2 need your input:
167
+
168
+ 1. [CRITICAL] app/models/post.rb:42 — Race condition in status transition
169
+ Fix: Add `WHERE status = 'draft'` to the UPDATE
170
+ → A) Fix B) Skip
171
+
172
+ 2. [INFORMATIONAL] app/services/generator.rb:88 — LLM output not type-checked before DB write
173
+ Fix: Add JSON schema validation
174
+ → A) Fix B) Skip
175
+
176
+ RECOMMENDATION: Fix both — #1 is a real race condition, #2 prevents silent data corruption.
177
+ ```
178
+
179
+ If 3 or fewer ASK items, you may use individual AskUserQuestion calls instead of batching.
180
+
181
+ ### Step 5d: Apply user-approved fixes
182
+
183
+ Apply fixes for items where the user chose "Fix." Output what was fixed.
184
+
185
+ If no ASK items exist (everything was AUTO-FIX), skip the question entirely.
186
+
187
+ ### Verification of claims
188
+
189
+ Before producing the final review output:
190
+ - If you claim "this pattern is safe" → cite the specific line proving safety
191
+ - If you claim "this is handled elsewhere" → read and cite the handling code
192
+ - If you claim "tests cover this" → name the test file and method
193
+ - Never say "likely handled" or "probably tested" — verify or flag as unknown
194
+
195
+ **Rationalization prevention:** "This looks fine" is not a finding. Either cite evidence it IS fine, or flag it as unverified.
196
+
197
+ ### Greptile comment resolution
198
+
199
+ After outputting your own findings, if Greptile comments were classified in Step 2.5:
200
+
201
+ **Include a Greptile summary in your output header:** `+ N Greptile comments (X valid, Y fixed, Z FP)`
202
+
203
+ Before replying to any comment, run the **Escalation Detection** algorithm from greptile-triage.md to determine whether to use Tier 1 (friendly) or Tier 2 (firm) reply templates.
204
+
205
+ 1. **VALID & ACTIONABLE comments:** These are included in your findings — they follow the Fix-First flow (auto-fixed if mechanical, batched into ASK if not) (A: Fix it now, B: Acknowledge, C: False positive). If the user chooses A (fix), reply using the **Fix reply template** from greptile-triage.md (include inline diff + explanation). If the user chooses C (false positive), reply using the **False Positive reply template** (include evidence + suggested re-rank), save to both per-project and global greptile-history.
206
+
207
+ 2. **FALSE POSITIVE comments:** Present each one via AskUserQuestion:
208
+ - Show the Greptile comment: file:line (or [top-level]) + body summary + permalink URL
209
+ - Explain concisely why it's a false positive
210
+ - Options:
211
+ - A) Reply to Greptile explaining why this is incorrect (recommended if clearly wrong)
212
+ - B) Fix it anyway (if low-effort and harmless)
213
+ - C) Ignore — don't reply, don't fix
214
+
215
+ If the user chooses A, reply using the **False Positive reply template** from greptile-triage.md (include evidence + suggested re-rank), save to both per-project and global greptile-history.
216
+
217
+ 3. **VALID BUT ALREADY FIXED comments:** Reply using the **Already Fixed reply template** from greptile-triage.md — no AskUserQuestion needed:
218
+ - Include what was done and the fixing commit SHA
219
+ - Save to both per-project and global greptile-history
220
+
221
+ 4. **SUPPRESSED comments:** Skip silently — these are known false positives from previous triage.
222
+
223
+ ---
224
+
225
+ ## Step 5.5: TODOS cross-reference
226
+
227
+ Read `TODOS.md` in the repository root (if it exists). Cross-reference the PR against open TODOs:
228
+
229
+ - **Does this PR close any open TODOs?** If yes, note which items in your output: "This PR addresses TODO: <title>"
230
+ - **Does this PR create work that should become a TODO?** If yes, flag it as an informational finding.
231
+ - **Are there related TODOs that provide context for this review?** If yes, reference them when discussing related findings.
232
+
233
+ If TODOS.md doesn't exist, skip this step silently.
234
+
235
+ ---
236
+
237
+ ## Step 5.6: Documentation staleness check
238
+
239
+ Cross-reference the diff against documentation files. For each `.md` file in the repo root (README.md, ARCHITECTURE.md, CONTRIBUTING.md, CLAUDE.md, etc.):
240
+
241
+ 1. Check if code changes in the diff affect features, components, or workflows described in that doc file.
242
+ 2. If the doc file was NOT updated in this branch but the code it describes WAS changed, flag it as an INFORMATIONAL finding:
243
+ "Documentation may be stale: [file] describes [feature/component] but code changed in this branch. Consider running `/document-release`."
244
+
245
+ This is informational only — never critical. The fix action is `/document-release`.
246
+
247
+ If no documentation files exist, skip this step silently.
248
+
249
+ ---
250
+
251
+ {{ADVERSARIAL_STEP}}
252
+
253
+ ## Important Rules
254
+
255
+ - **Read the FULL diff before commenting.** Do not flag issues already addressed in the diff.
256
+ - **Fix-first, not read-only.** AUTO-FIX items are applied directly. ASK items are only applied after user approval. Never commit, push, or create PRs — that's /ship's job.
257
+ - **Be terse.** One line problem, one line fix. No preamble.
258
+ - **Only flag real problems.** Skip anything that's fine.
259
+ - **Use Greptile reply templates from greptile-triage.md.** Every reply includes evidence. Never post vague replies.
@@ -0,0 +1,62 @@
1
+ # TODOS.md Format Reference
2
+
3
+ Shared reference for the canonical TODOS.md format. Referenced by `/ship` (Step 5.5) and `/plan-ceo-review` (TODOS.md updates section) to ensure consistent TODO item structure.
4
+
5
+ ---
6
+
7
+ ## File Structure
8
+
9
+ ```markdown
10
+ # TODOS
11
+
12
+ ## <Skill/Component> ← e.g., ## Browse, ## Ship, ## Review, ## Infrastructure
13
+ <items sorted P0 first, then P1, P2, P3, P4>
14
+
15
+ ## Completed
16
+ <finished items with completion annotation>
17
+ ```
18
+
19
+ **Sections:** Organize by skill or component (`## Browse`, `## Ship`, `## Review`, `## QA`, `## Retro`, `## Infrastructure`). Within each section, sort items by priority (P0 at top).
20
+
21
+ ---
22
+
23
+ ## TODO Item Format
24
+
25
+ Each item is an H3 under its section:
26
+
27
+ ```markdown
28
+ ### <Title>
29
+
30
+ **What:** One-line description of the work.
31
+
32
+ **Why:** The concrete problem it solves or value it unlocks.
33
+
34
+ **Context:** Enough detail that someone picking this up in 3 months understands the motivation, the current state, and where to start.
35
+
36
+ **Effort:** S / M / L / XL
37
+ **Priority:** P0 / P1 / P2 / P3 / P4
38
+ **Depends on:** <prerequisites, or "None">
39
+ ```
40
+
41
+ **Required fields:** What, Why, Context, Effort, Priority
42
+ **Optional fields:** Depends on, Blocked by
43
+
44
+ ---
45
+
46
+ ## Priority Definitions
47
+
48
+ - **P0** — Blocking: must be done before next release
49
+ - **P1** — Critical: should be done this cycle
50
+ - **P2** — Important: do when P0/P1 are clear
51
+ - **P3** — Nice-to-have: revisit after adoption/usage data
52
+ - **P4** — Someday: good idea, no urgency
53
+
54
+ ---
55
+
56
+ ## Completed Item Format
57
+
58
+ When an item is completed, move it to the `## Completed` section preserving its original content and appending:
59
+
60
+ ```markdown
61
+ **Completed:** vX.Y.Z (YYYY-MM-DD)
62
+ ```
@@ -0,0 +1,190 @@
1
+ # Pre-Landing Review Checklist
2
+
3
+ ## Instructions
4
+
5
+ Review the `git diff origin/main` output for the issues listed below. Be specific — cite `file:line` and suggest fixes. Skip anything that's fine. Only flag real problems.
6
+
7
+ **Two-pass review:**
8
+ - **Pass 1 (CRITICAL):** Run SQL & Data Safety and LLM Output Trust Boundary first. Highest severity.
9
+ - **Pass 2 (INFORMATIONAL):** Run all remaining categories. Lower severity but still actioned.
10
+
11
+ All findings get action via Fix-First Review: obvious mechanical fixes are applied automatically,
12
+ genuinely ambiguous issues are batched into a single user question.
13
+
14
+ **Output format:**
15
+
16
+ ```
17
+ Pre-Landing Review: N issues (X critical, Y informational)
18
+
19
+ **AUTO-FIXED:**
20
+ - [file:line] Problem → fix applied
21
+
22
+ **NEEDS INPUT:**
23
+ - [file:line] Problem description
24
+ Recommended fix: suggested fix
25
+ ```
26
+
27
+ If no issues found: `Pre-Landing Review: No issues found.`
28
+
29
+ Be terse. For each issue: one line describing the problem, one line with the fix. No preamble, no summaries, no "looks good overall."
30
+
31
+ ---
32
+
33
+ ## Review Categories
34
+
35
+ ### Pass 1 — CRITICAL
36
+
37
+ #### SQL & Data Safety
38
+ - String interpolation in SQL (even if values are `.to_i`/`.to_f` — use parameterized queries (Rails: sanitize_sql_array/Arel; Node: prepared statements; Python: parameterized queries))
39
+ - TOCTOU races: check-then-set patterns that should be atomic `WHERE` + `update_all`
40
+ - Bypassing model validations for direct DB writes (Rails: update_column; Django: QuerySet.update(); Prisma: raw queries)
41
+ - N+1 queries: Missing eager loading (Rails: .includes(); SQLAlchemy: joinedload(); Prisma: include) for associations used in loops/views
42
+
43
+ #### Race Conditions & Concurrency
44
+ - Read-check-write without uniqueness constraint or catch duplicate key error and retry (e.g., `where(hash:).first` then `save!` without handling concurrent insert)
45
+ - find-or-create without unique DB index — concurrent calls can create duplicates
46
+ - Status transitions that don't use atomic `WHERE old_status = ? UPDATE SET new_status` — concurrent updates can skip or double-apply transitions
47
+ - Unsafe HTML rendering (Rails: .html_safe/raw(); React: dangerouslySetInnerHTML; Vue: v-html; Django: |safe/mark_safe) on user-controlled data (XSS)
48
+
49
+ #### LLM Output Trust Boundary
50
+ - LLM-generated values (emails, URLs, names) written to DB or passed to mailers without format validation. Add lightweight guards (`EMAIL_REGEXP`, `URI.parse`, `.strip`) before persisting.
51
+ - Structured tool output (arrays, hashes) accepted without type/shape checks before database writes.
52
+
53
+ #### Enum & Value Completeness
54
+ When the diff introduces a new enum value, status string, tier name, or type constant:
55
+ - **Trace it through every consumer.** Read (don't just grep — READ) each file that switches on, filters by, or displays that value. If any consumer doesn't handle the new value, flag it. Common miss: adding a value to the frontend dropdown but the backend model/compute method doesn't persist it.
56
+ - **Check allowlists/filter arrays.** Search for arrays or `%w[]` lists containing sibling values (e.g., if adding "revise" to tiers, find every `%w[quick lfg mega]` and verify "revise" is included where needed).
57
+ - **Check `case`/`if-elsif` chains.** If existing code branches on the enum, does the new value fall through to a wrong default?
58
+ To do this: use Grep to find all references to the sibling values (e.g., grep for "lfg" or "mega" to find all tier consumers). Read each match. This step requires reading code OUTSIDE the diff.
59
+
60
+ ### Pass 2 — INFORMATIONAL
61
+
62
+ #### Conditional Side Effects
63
+ - Code paths that branch on a condition but forget to apply a side effect on one branch. Example: item promoted to verified but URL only attached when a secondary condition is true — the other branch promotes without the URL, creating an inconsistent record.
64
+ - Log messages that claim an action happened but the action was conditionally skipped. The log should reflect what actually occurred.
65
+
66
+ #### Magic Numbers & String Coupling
67
+ - Bare numeric literals used in multiple files — should be named constants documented together
68
+ - Error message strings used as query filters elsewhere (grep for the string — is anything matching on it?)
69
+
70
+ #### Dead Code & Consistency
71
+ - Variables assigned but never read
72
+ - Version mismatch between PR title and VERSION/CHANGELOG files
73
+ - CHANGELOG entries that describe changes inaccurately (e.g., "changed from X to Y" when X never existed)
74
+ - Comments/docstrings that describe old behavior after the code changed
75
+
76
+ #### LLM Prompt Issues
77
+ - 0-indexed lists in prompts (LLMs reliably return 1-indexed)
78
+ - Prompt text listing available tools/capabilities that don't match what's actually wired up in the `tool_classes`/`tools` array
79
+ - Word/token limits stated in multiple places that could drift
80
+
81
+ #### Test Gaps
82
+ - Negative-path tests that assert type/status but not the side effects (URL attached? field populated? callback fired?)
83
+ - Assertions on string content without checking format (e.g., asserting title present but not URL format)
84
+ - `.expects(:something).never` missing when a code path should explicitly NOT call an external service
85
+ - Security enforcement features (blocking, rate limiting, auth) without integration tests verifying the enforcement path works end-to-end
86
+
87
+ #### Completeness Gaps
88
+ - Shortcut implementations where the complete version would cost <30 minutes CC time (e.g., partial enum handling, incomplete error paths, missing edge cases that are straightforward to add)
89
+ - Options presented with only human-team effort estimates — should show both human and CC+gstack time
90
+ - Test coverage gaps where adding the missing tests is a "lake" not an "ocean" (e.g., missing negative-path tests, missing edge case tests that mirror happy-path structure)
91
+ - Features implemented at 80-90% when 100% is achievable with modest additional code
92
+
93
+ #### Crypto & Entropy
94
+ - Truncation of data instead of hashing (last N chars instead of SHA-256) — less entropy, easier collisions
95
+ - `rand()` / `Random.rand` for security-sensitive values — use `SecureRandom` instead
96
+ - Non-constant-time comparisons (`==`) on secrets or tokens — vulnerable to timing attacks
97
+
98
+ #### Time Window Safety
99
+ - Date-key lookups that assume "today" covers 24h — report at 8am PT only sees midnight→8am under today's key
100
+ - Mismatched time windows between related features — one uses hourly buckets, another uses daily keys for the same data
101
+
102
+ #### Type Coercion at Boundaries
103
+ - Values crossing Ruby→JSON→JS boundaries where type could change (numeric vs string) — hash/digest inputs must normalize types
104
+ - Hash/digest inputs that don't call `.to_s` or equivalent before serialization — `{ cores: 8 }` vs `{ cores: "8" }` produce different hashes
105
+
106
+ #### View/Frontend
107
+ - Inline `<style>` blocks in partials (re-parsed every render)
108
+ - O(n*m) lookups in views (`Array#find` in a loop instead of `index_by` hash)
109
+ - Ruby-side `.select{}` filtering on DB results that could be a `WHERE` clause (unless intentionally avoiding leading-wildcard `LIKE`)
110
+
111
+ #### Performance & Bundle Impact
112
+ - New `dependencies` entries in package.json that are known-heavy: moment.js (→ date-fns, 330KB→22KB), lodash full (→ lodash-es or per-function imports), jquery, core-js full polyfill
113
+ - Significant lockfile growth (many new transitive dependencies from a single addition)
114
+ - Images added without `loading="lazy"` or explicit width/height attributes (causes layout shift / CLS)
115
+ - Large static assets committed to repo (>500KB per file)
116
+ - Synchronous `<script>` tags without async/defer
117
+ - CSS `@import` in stylesheets (blocks parallel loading — use bundler imports instead)
118
+ - `useEffect` with fetch that depends on another fetch result (request waterfall — combine or parallelize)
119
+ - Named → default import switches on tree-shakeable libraries (breaks tree-shaking)
120
+ - New `require()` calls in ESM codebases
121
+
122
+ **DO NOT flag:**
123
+ - devDependencies additions (don't affect production bundle)
124
+ - Dynamic `import()` calls (code splitting — these are good)
125
+ - Small utility additions (<5KB gzipped)
126
+ - Server-side-only dependencies
127
+
128
+ ---
129
+
130
+ ## Severity Classification
131
+
132
+ ```
133
+ CRITICAL (highest severity): INFORMATIONAL (lower severity):
134
+ ├─ SQL & Data Safety ├─ Conditional Side Effects
135
+ ├─ Race Conditions & Concurrency ├─ Magic Numbers & String Coupling
136
+ ├─ LLM Output Trust Boundary ├─ Dead Code & Consistency
137
+ └─ Enum & Value Completeness ├─ LLM Prompt Issues
138
+ ├─ Test Gaps
139
+ ├─ Completeness Gaps
140
+ ├─ Crypto & Entropy
141
+ ├─ Time Window Safety
142
+ ├─ Type Coercion at Boundaries
143
+ ├─ View/Frontend
144
+ └─ Performance & Bundle Impact
145
+
146
+ All findings are actioned via Fix-First Review. Severity determines
147
+ presentation order and classification of AUTO-FIX vs ASK — critical
148
+ findings lean toward ASK (they're riskier), informational findings
149
+ lean toward AUTO-FIX (they're more mechanical).
150
+ ```
151
+
152
+ ---
153
+
154
+ ## Fix-First Heuristic
155
+
156
+ This heuristic is referenced by both `/review` and `/ship`. It determines whether
157
+ the agent auto-fixes a finding or asks the user.
158
+
159
+ ```
160
+ AUTO-FIX (agent fixes without asking): ASK (needs human judgment):
161
+ ├─ Dead code / unused variables ├─ Security (auth, XSS, injection)
162
+ ├─ N+1 queries (missing eager loading) ├─ Race conditions
163
+ ├─ Stale comments contradicting code ├─ Design decisions
164
+ ├─ Magic numbers → named constants ├─ Large fixes (>20 lines)
165
+ ├─ Missing LLM output validation ├─ Enum completeness
166
+ ├─ Version/path mismatches ├─ Removing functionality
167
+ ├─ Variables assigned but never read └─ Anything changing user-visible
168
+ └─ Inline styles, O(n*m) view lookups behavior
169
+ ```
170
+
171
+ **Rule of thumb:** If the fix is mechanical and a senior engineer would apply it
172
+ without discussion, it's AUTO-FIX. If reasonable engineers could disagree about
173
+ the fix, it's ASK.
174
+
175
+ **Critical findings default toward ASK** (they're inherently riskier).
176
+ **Informational findings default toward AUTO-FIX** (they're more mechanical).
177
+
178
+ ---
179
+
180
+ ## Suppressions — DO NOT flag these
181
+
182
+ - "X is redundant with Y" when the redundancy is harmless and aids readability (e.g., `present?` redundant with `length > 20`)
183
+ - "Add a comment explaining why this threshold/constant was chosen" — thresholds change during tuning, comments rot
184
+ - "This assertion could be tighter" when the assertion already covers the behavior
185
+ - Suggesting consistency-only changes (wrapping a value in a conditional to match how another constant is guarded)
186
+ - "Regex doesn't handle edge case X" when the input is constrained and X never occurs in practice
187
+ - "Test exercises multiple guards simultaneously" — that's fine, tests don't need to isolate every guard
188
+ - Eval threshold changes (max_actionable, min scores) — these are tuned empirically and change constantly
189
+ - Harmless no-ops (e.g., `.reject` on an element that's never in the array)
190
+ - ANYTHING already addressed in the diff you're reviewing — read the FULL diff before commenting
@@ -0,0 +1,132 @@
1
+ # Design Review Checklist (Lite)
2
+
3
+ > **Subset of DESIGN_METHODOLOGY** — when adding items here, also update `generateDesignMethodology()` in `scripts/gen-skill-docs.ts`, and vice versa.
4
+
5
+ ## Instructions
6
+
7
+ This checklist applies to **source code in the diff** — not rendered output. Read each changed frontend file (full file, not just diff hunks) and flag anti-patterns.
8
+
9
+ **Trigger:** Only run this checklist if the diff touches frontend files. Use `gstack-diff-scope` to detect:
10
+
11
+ ```bash
12
+ source <(~/.claude/skills/gstack/bin/gstack-diff-scope <base> 2>/dev/null)
13
+ ```
14
+
15
+ If `SCOPE_FRONTEND=false`, skip the entire design review silently.
16
+
17
+ **DESIGN.md calibration:** If `DESIGN.md` or `design-system.md` exists in the repo root, read it first. All findings are calibrated against the project's stated design system. Patterns explicitly blessed in DESIGN.md are NOT flagged. If no DESIGN.md exists, use universal design principles.
18
+
19
+ ---
20
+
21
+ ## Confidence Tiers
22
+
23
+ Each item is tagged with a detection confidence level:
24
+
25
+ - **[HIGH]** — Reliably detectable via grep/pattern match. Definitive findings.
26
+ - **[MEDIUM]** — Detectable via pattern aggregation or heuristic. Flag as findings but expect some noise.
27
+ - **[LOW]** — Requires understanding visual intent. Present as: "Possible issue — verify visually or run /design-review."
28
+
29
+ ---
30
+
31
+ ## Classification
32
+
33
+ **AUTO-FIX** (mechanical CSS fixes only — HIGH confidence, no design judgment needed):
34
+ - `outline: none` without replacement → add `outline: revert` or `&:focus-visible { outline: 2px solid currentColor; }`
35
+ - `!important` in new CSS → remove and fix specificity
36
+ - `font-size` < 16px on body text → bump to 16px
37
+
38
+ **ASK** (everything else — requires design judgment):
39
+ - All AI slop findings, typography structure, spacing choices, interaction state gaps, DESIGN.md violations
40
+
41
+ **LOW confidence items** → present as "Possible: [description]. Verify visually or run /design-review." Never AUTO-FIX.
42
+
43
+ ---
44
+
45
+ ## Output Format
46
+
47
+ ```
48
+ Design Review: N issues (X auto-fixable, Y need input, Z possible)
49
+
50
+ **AUTO-FIXED:**
51
+ - [file:line] Problem → fix applied
52
+
53
+ **NEEDS INPUT:**
54
+ - [file:line] Problem description
55
+ Recommended fix: suggested fix
56
+
57
+ **POSSIBLE (verify visually):**
58
+ - [file:line] Possible issue — verify with /design-review
59
+ ```
60
+
61
+ If no issues found: `Design Review: No issues found.`
62
+
63
+ If no frontend files changed: skip silently, no output.
64
+
65
+ ---
66
+
67
+ ## Categories
68
+
69
+ ### 1. AI Slop Detection (6 items) — highest priority
70
+
71
+ These are the telltale signs of AI-generated UI that no designer at a respected studio would ship.
72
+
73
+ - **[MEDIUM]** Purple/violet/indigo gradient backgrounds or blue-to-purple color schemes. Look for `linear-gradient` with values in the `#6366f1`–`#8b5cf6` range, or CSS custom properties resolving to purple/violet.
74
+
75
+ - **[LOW]** The 3-column feature grid: icon-in-colored-circle + bold title + 2-line description, repeated 3x symmetrically. Look for a grid/flex container with exactly 3 children that each contain a circular element + heading + paragraph.
76
+
77
+ - **[LOW]** Icons in colored circles as section decoration. Look for elements with `border-radius: 50%` + a background color used as decorative containers for icons.
78
+
79
+ - **[HIGH]** Centered everything: `text-align: center` on all headings, descriptions, and cards. Grep for `text-align: center` density — if >60% of text containers use center alignment, flag it.
80
+
81
+ - **[MEDIUM]** Uniform bubbly border-radius on every element: same large radius (16px+) applied to cards, buttons, inputs, containers uniformly. Aggregate `border-radius` values — if >80% use the same value ≥16px, flag it.
82
+
83
+ - **[MEDIUM]** Generic hero copy: "Welcome to [X]", "Unlock the power of...", "Your all-in-one solution for...", "Revolutionize your...", "Streamline your workflow". Grep HTML/JSX content for these patterns.
84
+
85
+ ### 2. Typography (4 items)
86
+
87
+ - **[HIGH]** Body text `font-size` < 16px. Grep for `font-size` declarations on `body`, `p`, `.text`, or base styles. Values below 16px (or 1rem when base is 16px) are flagged.
88
+
89
+ - **[HIGH]** More than 3 font families introduced in the diff. Count distinct `font-family` declarations. Flag if >3 unique families appear across changed files.
90
+
91
+ - **[HIGH]** Heading hierarchy skipping levels: `h1` followed by `h3` without an `h2` in the same file/component. Check HTML/JSX for heading tags.
92
+
93
+ - **[HIGH]** Blacklisted fonts: Papyrus, Comic Sans, Lobster, Impact, Jokerman. Grep `font-family` for these names.
94
+
95
+ ### 3. Spacing & Layout (4 items)
96
+
97
+ - **[MEDIUM]** Arbitrary spacing values not on a 4px or 8px scale, when DESIGN.md specifies a spacing scale. Check `margin`, `padding`, `gap` values against the stated scale. Only flag when DESIGN.md defines a scale.
98
+
99
+ - **[MEDIUM]** Fixed widths without responsive handling: `width: NNNpx` on containers without `max-width` or `@media` breakpoints. Risk of horizontal scroll on mobile.
100
+
101
+ - **[MEDIUM]** Missing `max-width` on text containers: body text or paragraph containers with no `max-width` set, allowing lines >75 characters. Check for `max-width` on text wrappers.
102
+
103
+ - **[HIGH]** `!important` in new CSS rules. Grep for `!important` in added lines. Almost always a specificity escape hatch that should be fixed properly.
104
+
105
+ ### 4. Interaction States (3 items)
106
+
107
+ - **[MEDIUM]** Interactive elements (buttons, links, inputs) missing hover/focus states. Check if `:hover` and `:focus` or `:focus-visible` pseudo-classes exist for new interactive element styles.
108
+
109
+ - **[HIGH]** `outline: none` or `outline: 0` without a replacement focus indicator. Grep for `outline:\s*none` or `outline:\s*0`. This removes keyboard accessibility.
110
+
111
+ - **[LOW]** Touch targets < 44px on interactive elements. Check `min-height`/`min-width`/`padding` on buttons and links. Requires computing effective size from multiple properties — low confidence from code alone.
112
+
113
+ ### 5. DESIGN.md Violations (3 items, conditional)
114
+
115
+ Only apply if `DESIGN.md` or `design-system.md` exists:
116
+
117
+ - **[MEDIUM]** Colors not in the stated palette. Compare color values in changed CSS against the palette defined in DESIGN.md.
118
+
119
+ - **[MEDIUM]** Fonts not in the stated typography section. Compare `font-family` values against DESIGN.md's font list.
120
+
121
+ - **[MEDIUM]** Spacing values outside the stated scale. Compare `margin`/`padding`/`gap` values against DESIGN.md's spacing scale.
122
+
123
+ ---
124
+
125
+ ## Suppressions
126
+
127
+ Do NOT flag:
128
+ - Patterns explicitly documented in DESIGN.md as intentional choices
129
+ - Third-party/vendor CSS files (node_modules, vendor directories)
130
+ - CSS resets or normalize stylesheets
131
+ - Test fixture files
132
+ - Generated/minified CSS