@rulemetric/local 0.9.0 → 0.11.0

package/dist/supabase/migrations/00184_auto_accept_budget_settings.sql

@@ -0,0 +1,113 @@
+-- 00184 — the auto-accept budget becomes a setting, and the producer stops
+-- starving the source it was built to serve.
+--
+-- Three facts measured on 2026-08-12, all from the same project:
+--
+--   1. The per-window budget was counted by RAW project_path string equality.
+--      `/Code/agents/momento-mori` and `/Code/agents/momento-mori/apps/cli`
+--      are one repo and resolve to ONE projects row, but each drew its own
+--      allowance and each hit exactly 5/5 in the same 7 days — the repo
+--      adopted 10 rules under a policy that intends 5. Any repo whose
+--      sessions start in a subdirectory has as many budgets as it has
+--      subdirectories. Fixed in auto-accept-eligibility.ts by counting
+--      through instruction_suggestions.project_id; nothing to do here.
+--
+--   2. The budget was a compile-time constant, so raising it for one noisy
+--      repo meant a deploy. It is now a setting: NULL columns here mean "use
+--      the shipped default", per-project overrides live in
+--      projects.metadata.autoAcceptLimits and win over these.
+--
+--   3. THIS producer only ever queued a run when the project held a
+--      suggestion scoring >= 0.8. But GET /api/instruction-suggestions/
+--      auto-acceptable deliberately exempts insights-authored rows from the
+--      score gate (they are filed at 0.5 by the nomination endpoint). So in a
+--      project whose only proposals came from insights, the authoritative
+--      gate said "eligible" and this function never queued the job that would
+--      have asked it. Every insights nomination in such a project was
+--      unreachable — not declined, not surfaced, just never considered.
+
+-- ── Settable budget ─────────────────────────────────────────────────────────
+alter table public.profiles
+  add column if not exists auto_accept_min_score real,
+  add column if not exists auto_accept_max_per_run integer,
+  add column if not exists auto_accept_max_per_window integer,
+  add column if not exists auto_accept_window_days integer;
+
+comment on column public.profiles.auto_accept_min_score is
+  'Account override for the auto-accept score gate. NULL = shipped default (0.8). Bounded 0..1 by the API on read AND write — a settable brake still has to be a brake.';
+comment on column public.profiles.auto_accept_max_per_run is
+  'Account override for auto-accepts per nightly run per project. NULL = shipped default (3). Bounded 0..25.';
+comment on column public.profiles.auto_accept_max_per_window is
+  'Account override for auto-accepts per project per window. NULL = shipped default (15). Bounded 0..100. The brake on CLAUDE.md bloat: an over-large CLAUDE.md measured -22.1% (stratified, significant).';
+comment on column public.profiles.auto_accept_window_days is
+  'Account override for the budget window. NULL = shipped default (7). Bounded 1..90.';
+
+-- ── Producer ────────────────────────────────────────────────────────────────
+-- Same cheap-gates-only contract as 00170: this decides whether to ASK, never
+-- whether to adopt. The authoritative check stays server-side.
+create or replace function public.enqueue_auto_accept_suggestions()
+returns integer
+language plpgsql
+security definer
+set search_path = public
+as $$
+declare
+  queued integer;
+begin
+  with eligible as (
+    select s.user_id, s.project_path
+    from instruction_suggestions s
+    join profiles p on p.id = s.user_id
+    join instructions i on i.id = s.instruction_id
+    left join projects proj on proj.id = s.project_id
+    where
+          s.kind = 'add'
+      -- Score OR provenance. Insights nominations are filed at 0.5 by
+      -- POST /api/insights/recommendations/nominate and exempted from the
+      -- score gate by the authoritative endpoint; requiring 0.8 here made
+      -- that exemption unreachable in any project without a high-scoring
+      -- catalog proposal. The per-window budget still bounds what a run may
+      -- take, so a permissive trigger cannot become a permissive adoption.
+      and (s.score >= 0.8 or i.frontmatter->>'source' = 'insights')
+      -- Instruction bodies only, mirroring the endpoint: a skill pasted into
+      -- CLAUDE.md is a category error, and queueing a job that can only refuse
+      -- is how the loop reported "nothing eligible" for three days.
+      and i.type = 'instruction'
+      and i.archived = false
+      and s.accepted_at is null
+      and s.dismissed_at is null
+      and s.declined_at is null
+      and s.is_stale = false
+      -- Consent: per-project override wins, else the user default (true).
+      and coalesce(
+            proj.metadata->>'autoAcceptSuggestions',
+            p.auto_accept_suggestions::text
+          ) = 'true'
+      -- One in flight per (user, project), per the 00083/00086 pattern.
+      and not exists (
+        select 1 from agent_jobs j
+        where j.task_kind = 'cron_auto_accept_suggestions'
+          and j.status in ('pending', 'claimed', 'running')
+          and j.payload->>'projectPath' = s.project_path
+          and j.user_id = s.user_id
+      )
+    group by s.user_id, s.project_path
+  ),
+  ins as (
+    insert into agent_jobs (user_id, task_kind, status, payload, dedupe_key)
+    select e.user_id,
+           'cron_auto_accept_suggestions',
+           'pending',
+           jsonb_build_object('projectPath', e.project_path),
+           'auto-accept:' || e.user_id::text || ':' || e.project_path
+    from eligible e
+    returning 1
+  )
+  select count(*)::int into queued from ins;
+
+  return queued;
+end;
+$$;
+
+comment on function public.enqueue_auto_accept_suggestions() is
+  'Nightly producer for cron_auto_accept_suggestions. One row per (user, project) holding at least one consented ADD proposal that is either high-confidence (>= 0.8) or insights-authored, and whose instruction is a non-archived instruction body. Cheap gates only — the authoritative eligibility check is GET /api/instruction-suggestions/auto-acceptable, which also applies the per-project budget. Budget overrides: profiles.auto_accept_max_per_window (account) and projects.metadata.autoAcceptLimits (project). Turn it off for one repo: update projects set metadata = coalesce(metadata,''{}''::jsonb) || ''{"autoAcceptSuggestions":false}''::jsonb where id = ...; or globally: update profiles set auto_accept_suggestions = false where id = ...';