@rulebricks/cli 2.1.7 → 2.3.1

package/dist/lib/workloadIdentity.js

@@ -0,0 +1,323 @@
+/**
+ * Deploy-time workload-identity federation.
+ *
+ * cluster-setup provisions the deployment-independent infrastructure (one
+ * identity / role / service account, plus the bucket and DCR). The trust between
+ * that identity and a specific Kubernetes ServiceAccount is namespace-scoped, so
+ * it can only be created once the deployment namespace is known. This module
+ * creates that trust at `rulebricks deploy` time, which keeps cluster-setup
+ * generic and lets one cluster host many deployments.
+ *
+ *   Azure -> federated identity credential (subject = system:serviceaccount:ns:sa)
+ *   AWS   -> EKS Pod Identity association (namespace + serviceAccount -> role)
+ *   GCP   -> IAM workloadIdentityUser binding (member = ns/sa -> service account)
+ *
+ * All operations are idempotent, so it is safe to run on every deploy.
+ */
+import { exec } from "child_process";
+import { promisify } from "util";
+import { getNamespace, getReleaseName, } from "../types/index.js";
+import { approveCloudCommandOrThrow } from "./commandApproval.js";
+const execAsync = promisify(exec);
+const CLI_TIMEOUT = 60000;
+async function run(command, options) {
+    await approveCloudCommandOrThrow({
+        command,
+        intent: options.intent,
+        provider: options.provider,
+        mutating: options.mutating,
+    });
+    try {
+        const { stdout, stderr } = await execAsync(command, { timeout: CLI_TIMEOUT });
+        return { stdout, stderr, code: 0 };
+    }
+    catch (error) {
+        const e = error;
+        return {
+            stdout: e.stdout || "",
+            stderr: e.stderr || e.message || "command failed",
+            code: typeof e.code === "number" ? e.code : 1,
+        };
+    }
+}
+function shq(value) {
+    return `'${String(value).replace(/'/g, "'\\''")}'`;
+}
+export function isAwsPodIdentityCliUnsupported(stderr) {
+    return (/Invalid choice/i.test(stderr) &&
+        !/list-pod-identity-associations|create-pod-identity-association/i.test(stderr));
+}
+export function isAwsPodIdentityTrustPolicyInvalid(stderr) {
+    return /InvalidParameterException/i.test(stderr) && /Trust policy/i.test(stderr);
+}
+function awsPodIdentityUnsupportedMessage(stderr) {
+    const detail = stderr.trim().split("\n").slice(0, 4).join("\n");
+    return [
+        "Your installed AWS CLI does not support EKS Pod Identity association commands.",
+        "",
+        "Rulebricks AWS cluster setup uses EKS Pod Identity, so deploy needs AWS CLI v2 with:",
+        "  aws eks list-pod-identity-associations",
+        "  aws eks create-pod-identity-association",
+        "",
+        "Update or install AWS CLI v2, then rerun the deploy/init command.",
+        "",
+        "First check which AWS CLI your shell is using:",
+        "  which aws && aws --version",
+        "",
+        "On macOS with Homebrew:",
+        "  brew install awscli",
+        "  # or, if Homebrew already owns it:",
+        "  brew upgrade awscli",
+        "",
+        "Or install the official AWS CLI v2 package:",
+        "  curl \"https://awscli.amazonaws.com/AWSCLIV2.pkg\" -o \"/tmp/AWSCLIV2.pkg\"",
+        "  sudo installer -pkg /tmp/AWSCLIV2.pkg -target /",
+        "",
+        "If aws --version still shows an older binary after installing, update your PATH so the new aws comes first.",
+        "",
+        detail ? `AWS CLI output:\n${detail}` : "",
+    ]
+        .filter(Boolean)
+        .join("\n");
+}
+function awsPodIdentityInvalidTrustMessage(input) {
+    const expectedRole = `${input.cluster}-rulebricks`;
+    const detail = input.stderr.trim();
+    return [
+        `The IAM role selected for ${input.subject} cannot be used with EKS Pod Identity.`,
+        "",
+        `Selected role: ${input.roleArn}`,
+        `Expected role from Rulebricks cluster-setup: ${expectedRole}`,
+        "",
+        "The role trust policy must allow the EKS Pod Identity service principal:",
+        "  Principal: { Service: pods.eks.amazonaws.com }",
+        "  Actions: sts:AssumeRole and sts:TagSession",
+        "",
+        "Fix by selecting the RulebricksRoleArn output from the AWS cluster-setup stack,",
+        `or update that role's trust policy to match cluster-setup/aws/rulebricks-cluster.cfn.yaml.`,
+        "",
+        detail ? `AWS CLI output:\n${detail}` : "",
+    ]
+        .filter(Boolean)
+        .join("\n");
+}
+/**
+ * The SAs that need workload-identity trust, given the deployment config. Vector
+ * and the backup job use the storage identity; Prometheus uses the metrics
+ * identity (the consolidated setup makes these the same principal, but we read
+ * them independently so split setups still work).
+ */
+export function plannedBindings(config) {
+    const bindings = [];
+    const storage = config.storage;
+    const releaseName = getReleaseName(config.name);
+    const usesSecretAuth = storage?.cloudAuthMode === "secret";
+    const storagePrincipal = storage?.provider === "s3"
+        ? storage.awsIamRoleArn
+        : storage?.provider === "gcs"
+            ? storage.gcpServiceAccountEmail
+            : storage?.azureBlobClientId;
+    if (storage && !usesSecretAuth && storagePrincipal) {
+        bindings.push({ serviceAccount: "vector", principal: storagePrincipal });
+        // ClickHouse reads the decision-log archive straight from object storage
+        // (the rulebricks.decision_logs view / named collection), so it needs the
+        // same storage identity as Vector. Without this trust the cloud IdP rejects
+        // ClickHouse's token and every decision_logs query fails to authenticate.
+        bindings.push({
+            serviceAccount: `${releaseName}-clickhouse`,
+            principal: storagePrincipal,
+        });
+        if (config.backup?.enabled && config.database.type === "self-hosted") {
+            bindings.push({
+                serviceAccount: `${releaseName}-backup`,
+                principal: storagePrincipal,
+            });
+        }
+    }
+    // Workloads that talk directly to the managed broker each need the Kafka cloud
+    // identity under a token mechanism (AWS MSK IAM / GCP OAUTHBEARER). We give each
+    // its OWN service account and bind it here via Pod Identity - the chart no
+    // longer stamps an eks.amazonaws.com/role-arn annotation, so the association is
+    // the single source of credentials (no IRSA/annotation tug-of-war on a shared
+    // SA). HPS + the worker fleet produce/consume; the kafka-topic-provision
+    // pre-install hook creates the topics. (When no identity role is set the broker
+    // uses SCRAM/PLAIN secret auth, so there is no principal to bind.)
+    const kafka = config.externalServices?.kafka;
+    const kafkaPrincipal = kafka?.mode === "external"
+        ? (kafka.external?.identity?.awsRoleArn ??
+            kafka.external?.identity?.gcpServiceAccountEmail ??
+            kafka.external?.identity?.azureClientId)
+        : undefined;
+    if (kafkaPrincipal) {
+        for (const serviceAccount of [
+            `${releaseName}-hps`,
+            `${releaseName}-hps-worker`,
+            `${releaseName}-kafka-topic-provision`,
+        ]) {
+            bindings.push({ serviceAccount, principal: kafkaPrincipal });
+        }
+    }
+    const rw = config.features.monitoring?.remoteWrite;
+    const metricsPrincipal = rw?.destination === "aws-amp"
+        ? rw.awsRoleArn
+        : rw?.authType === "workload-identity"
+            ? rw.clientId
+            : undefined;
+    if (config.features.monitoring?.enabled &&
+        rw &&
+        rw.destination !== "generic" &&
+        rw.destination !== "grafana-cloud" &&
+        metricsPrincipal) {
+        bindings.push({ serviceAccount: "prometheus", principal: metricsPrincipal });
+    }
+    return bindings;
+}
+/**
+ * Ensures the per-namespace workload-identity trust exists for this deployment.
+ * No-op (with a `skipped` reason) for non-cloud providers or secret-based auth.
+ */
+export async function ensureWorkloadIdentityFederation(config) {
+    const provider = config.infrastructure.provider;
+    if (provider !== "azure" && provider !== "aws" && provider !== "gcp") {
+        return { created: [], existing: [], skipped: "non-cloud provider" };
+    }
+    const bindings = plannedBindings(config);
+    if (bindings.length === 0) {
+        return { created: [], existing: [], skipped: "no workload-identity service accounts" };
+    }
+    const namespace = getNamespace(config.name);
+    switch (provider) {
+        case "azure":
+            return ensureAzure(config, namespace, bindings);
+        case "aws":
+            return ensureAws(config, namespace, bindings);
+        case "gcp":
+            return ensureGcp(config, namespace, bindings);
+        default:
+            return { created: [], existing: [], skipped: "non-cloud provider" };
+    }
+}
+// ---------------------------------------------------------------------------
+// Azure: federated identity credentials on the user-assigned managed identity
+// ---------------------------------------------------------------------------
+async function ensureAzure(config, namespace, bindings) {
+    const rg = config.infrastructure.azureResourceGroup;
+    const cluster = config.infrastructure.clusterName;
+    if (!rg || !cluster) {
+        throw new Error("Azure resource group and cluster name are required to create federated credentials.");
+    }
+    const intent = "Configure workload identity (Azure)";
+    const issuerRes = await run(`az aks show --name ${shq(cluster)} --resource-group ${shq(rg)} --query oidcIssuerProfile.issuerUrl --output tsv`, { intent, provider: "azure" });
+    const issuer = issuerRes.stdout.trim();
+    if (!issuer) {
+        throw new Error(`Could not read the AKS OIDC issuer for ${cluster}/${rg}. Ensure the cluster has the OIDC issuer enabled. (${issuerRes.stderr.trim()})`);
+    }
+    // Resolve identity name once per distinct clientId (principal).
+    const identityNameByClientId = new Map();
+    const created = [];
+    const existing = [];
+    for (const binding of bindings) {
+        const clientId = binding.principal;
+        let identityName = identityNameByClientId.get(clientId);
+        if (!identityName) {
+            const nameRes = await run(`az identity list --resource-group ${shq(rg)} --query "[?clientId=='${clientId}'].name | [0]" --output tsv`, { intent, provider: "azure" });
+            identityName = nameRes.stdout.trim();
+            if (!identityName) {
+                throw new Error(`No user-assigned identity with client ID ${clientId} found in resource group ${rg}. Run cluster-setup first.`);
+            }
+            identityNameByClientId.set(clientId, identityName);
+        }
+        const subject = `system:serviceaccount:${namespace}:${binding.serviceAccount}`;
+        // Unique per (namespace, SA) so several deployments can share one identity.
+        const ficName = `${namespace}-${binding.serviceAccount}`.slice(0, 120);
+        const listRes = await run(`az identity federated-credential list --identity-name ${shq(identityName)} --resource-group ${shq(rg)} --query "[?subject=='${subject}'] | length(@)" --output tsv`, { intent, provider: "azure" });
+        if (listRes.stdout.trim() !== "0" && listRes.stdout.trim() !== "") {
+            existing.push(subject);
+            continue;
+        }
+        const createRes = await run(`az identity federated-credential create --name ${shq(ficName)} ` +
+            `--identity-name ${shq(identityName)} --resource-group ${shq(rg)} ` +
+            `--issuer ${shq(issuer)} --subject ${shq(subject)} ` +
+            `--audiences api://AzureADTokenExchange`, { intent, provider: "azure", mutating: true });
+        if (createRes.code !== 0) {
+            throw new Error(`Failed to create federated credential for ${subject}: ${createRes.stderr.trim()}`);
+        }
+        created.push(subject);
+    }
+    return { created, existing };
+}
+// ---------------------------------------------------------------------------
+// AWS: EKS Pod Identity associations
+// ---------------------------------------------------------------------------
+async function ensureAws(config, namespace, bindings) {
+    const cluster = config.infrastructure.clusterName;
+    const region = config.infrastructure.region;
+    if (!cluster || !region) {
+        throw new Error("EKS cluster name and region are required to create Pod Identity associations.");
+    }
+    const created = [];
+    const existing = [];
+    const intent = "Configure workload identity (AWS)";
+    for (const binding of bindings) {
+        const roleArn = binding.principal;
+        const subject = `${namespace}/${binding.serviceAccount}`;
+        const listRes = await run(`aws eks list-pod-identity-associations --cluster-name ${shq(cluster)} ` +
+            `--namespace ${shq(namespace)} --service-account ${shq(binding.serviceAccount)} ` +
+            `--region ${shq(region)} --query "associations | length(@)" --output text`, { intent, provider: "aws" });
+        if (listRes.code !== 0 && isAwsPodIdentityCliUnsupported(listRes.stderr)) {
+            throw new Error(awsPodIdentityUnsupportedMessage(listRes.stderr));
+        }
+        if (listRes.code === 0 && listRes.stdout.trim() !== "0" && listRes.stdout.trim() !== "") {
+            existing.push(subject);
+            continue;
+        }
+        const createRes = await run(`aws eks create-pod-identity-association --cluster-name ${shq(cluster)} ` +
+            `--namespace ${shq(namespace)} --service-account ${shq(binding.serviceAccount)} ` +
+            `--role-arn ${shq(roleArn)} --region ${shq(region)}`, { intent, provider: "aws", mutating: true });
+        if (createRes.code !== 0) {
+            if (isAwsPodIdentityCliUnsupported(createRes.stderr)) {
+                throw new Error(awsPodIdentityUnsupportedMessage(createRes.stderr));
+            }
+            if (isAwsPodIdentityTrustPolicyInvalid(createRes.stderr)) {
+                throw new Error(awsPodIdentityInvalidTrustMessage({
+                    stderr: createRes.stderr,
+                    subject,
+                    roleArn,
+                    cluster,
+                }));
+            }
+            // Treat an existing association as success (race / prior run).
+            if (/ResourceInUse|already exists/i.test(createRes.stderr)) {
+                existing.push(subject);
+                continue;
+            }
+            throw new Error(`Failed to create Pod Identity association for ${subject}: ${createRes.stderr.trim()}`);
+        }
+        created.push(subject);
+    }
+    return { created, existing };
+}
+// ---------------------------------------------------------------------------
+// GCP: IAM workloadIdentityUser bindings on the Google service account
+// ---------------------------------------------------------------------------
+async function ensureGcp(config, namespace, bindings) {
+    const project = config.infrastructure.gcpProjectId;
+    if (!project) {
+        throw new Error("GCP project ID is required to create Workload Identity bindings.");
+    }
+    const created = [];
+    const intent = "Configure workload identity (GCP)";
+    for (const binding of bindings) {
+        const gsa = binding.principal;
+        const member = `serviceAccount:${project}.svc.id.goog[${namespace}/${binding.serviceAccount}]`;
+        // add-iam-policy-binding is idempotent; re-adding an existing member is a no-op.
+        const res = await run(`gcloud iam service-accounts add-iam-policy-binding ${shq(gsa)} ` +
+            `--project ${shq(project)} --role roles/iam.workloadIdentityUser ` +
+            `--member ${shq(member)} --quiet`, { intent, provider: "gcp", mutating: true });
+        if (res.code !== 0) {
+            throw new Error(`Failed to bind Workload Identity for ${namespace}/${binding.serviceAccount}: ${res.stderr.trim()}`);
+        }
+        created.push(`${namespace}/${binding.serviceAccount}`);
+    }
+    return { created, existing: [] };
+}

package/dist/lib/workloadIdentity.test.d.ts

@@ -0,0 +1 @@
+export {};

package/dist/lib/workloadIdentity.test.js

@@ -0,0 +1,57 @@
+import test from "node:test";
+import assert from "node:assert/strict";
+import { isAwsPodIdentityCliUnsupported, isAwsPodIdentityTrustPolicyInvalid, plannedBindings, } from "./workloadIdentity.js";
+test("detects AWS CLI builds without EKS Pod Identity operations", () => {
+    const stderr = `usage: aws [options] <command> <subcommand> [<subcommand> ...] [parameters]
+aws: error: argument operation: Invalid choice, valid choices are:
+associate-encryption-config | create-addon | update-kubeconfig | get-token | wait | help`;
+    assert.equal(isAwsPodIdentityCliUnsupported(stderr), true);
+});
+test("does not flag regular Pod Identity command errors as unsupported CLI", () => {
+    assert.equal(isAwsPodIdentityCliUnsupported("An error occurred (AccessDeniedException) when calling the CreatePodIdentityAssociation operation"), false);
+    assert.equal(isAwsPodIdentityCliUnsupported("An error occurred (ResourceInUseException) when calling the CreatePodIdentityAssociation operation"), false);
+});
+test("detects AWS Pod Identity invalid trust policy failures", () => {
+    assert.equal(isAwsPodIdentityTrustPolicyInvalid("An error occurred (InvalidParameterException) when calling the CreatePodIdentityAssociation operation: Trust policy of the role provided is invalid."), true);
+    assert.equal(isAwsPodIdentityTrustPolicyInvalid("An error occurred (AccessDeniedException) when calling the CreatePodIdentityAssociation operation"), false);
+});
+test("external MSK IAM binds hps, worker, and topic-provision SAs (one association each)", () => {
+    const cfg = {
+        name: "aws-p1",
+        infrastructure: { provider: "aws", region: "us-east-1" },
+        database: { type: "self-hosted" },
+        features: { monitoring: {} },
+        externalServices: {
+            kafka: {
+                mode: "external",
+                external: {
+                    preset: "aws-msk-iam",
+                    identity: {
+                        awsRoleArn: "arn:aws:iam::123456789012:role/rulebricks-cluster-rulebricks",
+                    },
+                },
+            },
+        },
+    };
+    const bindings = plannedBindings(cfg);
+    const sas = bindings.map((b) => b.serviceAccount);
+    assert.ok(sas.some((s) => s.endsWith("-hps")), sas.join(","));
+    assert.ok(sas.some((s) => s.endsWith("-hps-worker")), sas.join(","));
+    assert.ok(sas.some((s) => s.endsWith("-kafka-topic-provision")), sas.join(","));
+    // Each kafka SA gets exactly one association, to the configured MSK role.
+    for (const b of bindings.filter((x) => x.serviceAccount.includes("-hps"))) {
+        assert.match(b.principal, /:role\/rulebricks-cluster-rulebricks$/);
+    }
+});
+test("embedded kafka creates no HPS/worker kafka bindings", () => {
+    const cfg = {
+        name: "aws-p1",
+        infrastructure: { provider: "aws", region: "us-east-1" },
+        database: { type: "self-hosted" },
+        features: { monitoring: {} },
+        externalServices: { kafka: { mode: "embedded" } },
+    };
+    const sas = plannedBindings(cfg).map((b) => b.serviceAccount);
+    assert.ok(!sas.some((s) => s.endsWith("-hps")), sas.join(","));
+    assert.ok(!sas.some((s) => s.endsWith("-hps-worker")), sas.join(","));
+});