@rudderhq/server 0.7.24-canary.2 → 0.7.24-canary.21

package/dist/services/goals.js

@@ -3,7 +3,10 @@ import { activateGoalSchema, parseLibraryEntryMentionHref, parseLibraryFileMenti
 import { and, asc, desc, eq, gt, inArray, isNotNull, isNull, lt, or, sql } from "drizzle-orm";
 import { createHash, randomUUID } from "node:crypto";
 import { badRequest, conflict, forbidden, notFound, unprocessable } from "../errors.js";
+import { publicGoalContractSummary, publicGoalRecord, publicGoalText } from "./goal-public-contract.js";
+import { lockNodeMutationAuthority } from "./organization-mutation-fence.js";
 import { buildDeferredWakePayload, readDeferredWakePayload } from "./runtime-kernel/heartbeat.sessions.js";
+export { publicGoalText } from "./goal-public-contract.js";
 function safeGoalShortRef(id) {
     try {
         return shortRefFor("goal", id);
@@ -258,111 +261,6 @@ function publicGoalOutcome(outcome) {
         return "Goal completed with a decision";
     return "Result needs more evidence";
 }
-const INTERNAL_GOAL_LANGUAGE = [
-    [/\bgoal\s+contract\b/gi, "Goal"],
-    [/\bcontract\s+revision\b/gi, "Goal update"],
-    [/\bcontracts?\b/gi, "agreement"],
-    [/\bobjective\s+mode\b/gi, "Goal type"],
-    [/\bevaluator\b/gi, "success check"],
-    [/\bevidence\s+requirements?\b/gi, "what we need to verify"],
-    [/\bautonomy\s+envelope\b/gi, "working boundaries"],
-    [/\bhuman\s+authorit(?:y|ies)\b/gi, "decisions that need you"],
-    [/\bcontinuation\b/gi, "next step"],
-    [/\bchange\s+proposal\b/gi, "Goal update"],
-    [/\bresult\s+proposal\b/gi, "result review"],
-    [/\bchange_proposal\b/gi, "Goal update"],
-    [/\bresult_proposal\b/gi, "result review"],
-    [/\bruntime\s+evidence\b/gi, "supporting evidence"],
-    [/\brun\s+evidence\b/gi, "supporting work"],
-    [/\bpara-memory-files\b/gi, "shared notes"],
-    [/\b(?:the\s+)?[`]?shared notes[`]?\s+skill\b/gi, "shared notes"],
-    [/\bdaily[- ]note\b/gi, "notes"],
-    [/\b(?:runtime\s+)?evidence\s+(?:demonstrates?|shows?)\s+that\b/gi, "Supporting work shows that"],
-];
-export function publicGoalText(value) {
-    const mapped = INTERNAL_GOAL_LANGUAGE.reduce((current, [pattern, replacement]) => current.replace(pattern, replacement), value);
-    return mapped
-        .replace(/\b(?:goal-feedback|goal-start|goal-change-decision|goal-result-evaluation):[0-9a-f-]{8,}\b/gi, "the related update")
-        .replace(/\b(?:artifact|run|issue|project|approval|decision|measurement|library-file|library-entry):\/\/[^\s)]+/gi, "supporting work")
-        .replace(/\b[0-9a-f]{8}-[0-9a-f-]{27,}\b/gi, "the related item")
-        .replace(/\b(?:feedback|activity|proposal|request|run)\s+(?:the related item|[0-9a-f-]{8,})\b/gi, "the related update");
-}
-function publicGoalToken(value) {
-    const known = {
-        bounded_reversible_work: "bounded, reversible work",
-        external_or_irreversible_action: "external or irreversible actions",
-        external_publication: "publishing externally",
-        authority_expansion: "expanding access",
-        acceptance: "accepting the result",
-        consequentialChanges: "consequential changes",
-        externalPublication: "publishing externally",
-    };
-    return known[value] ?? value.replace(/([a-z])([A-Z])/g, "$1 $2").replace(/[_-]+/g, " ").toLowerCase();
-}
-function publicGoalRecord(value) {
-    return value && typeof value === "object" && !Array.isArray(value)
-        ? value
-        : {};
-}
-function publicGoalStrings(value) {
-    return Array.isArray(value)
-        ? value.filter((item) => typeof item === "string" && item.trim().length > 0)
-        : [];
-}
-function publicGoalBoundarySummary(value) {
-    const record = publicGoalRecord(value);
-    const allowed = publicGoalStrings(record.allowed).map(publicGoalToken);
-    const approvals = publicGoalStrings(record.requiresHumanApproval).map(publicGoalToken);
-    const parts = [
-        allowed.length > 0 ? `The Agent may handle ${allowed.join(", ")}.` : null,
-        approvals.length > 0 ? `You will be asked before ${approvals.join(", ")}.` : null,
-    ].filter((part) => Boolean(part));
-    return parts.length > 0 ? parts.join(" ") : null;
-}
-function publicGoalAuthoritySummary(value) {
-    const decisions = Object.entries(publicGoalRecord(value))
-        .filter(([, entry]) => entry === "board_human" || entry === true)
-        .map(([key]) => publicGoalToken(key));
-    return decisions.length > 0 ? `You decide ${decisions.join(", ")}.` : null;
-}
-function publicGoalCompletionSummary(value) {
-    const record = publicGoalRecord(value);
-    const requiresEvidence = record.terminalEvidenceRequired === true;
-    const requiresAcceptance = record.humanAcceptanceRequired === true;
-    if (requiresEvidence && requiresAcceptance)
-        return "Supporting work is shown, and you accept the result.";
-    if (requiresEvidence)
-        return "Supporting work is shown before the result is considered ready.";
-    if (requiresAcceptance)
-        return "You accept the result when it is ready.";
-    return null;
-}
-function publicGoalContractSummary(value) {
-    const record = publicGoalRecord(value);
-    const outcomeStatement = typeof record.outcomeStatement === "string" && record.outcomeStatement.trim()
-        ? publicGoalText(record.outcomeStatement)
-        : null;
-    const criteria = Array.isArray(record.criteria)
-        ? record.criteria.flatMap((criterion) => {
-            const label = publicGoalRecord(criterion).label;
-            return typeof label === "string" && label.trim() ? [{ label: publicGoalText(label) }] : [];
-        })
-        : [];
-    const targetTime = typeof record.evaluationDeadline === "string"
-        ? record.evaluationDeadline
-        : typeof record.actionDeadline === "string" ? record.actionDeadline : null;
-    return {
-        ...(outcomeStatement ? { outcomeStatement } : {}),
-        ...(criteria.length > 0 ? { criteria } : {}),
-        ...(targetTime ? { targetTime } : {}),
-        ...(publicGoalBoundarySummary(record.autonomyEnvelope)
-            ? { boundarySummary: publicGoalBoundarySummary(record.autonomyEnvelope) } : {}),
-        ...(publicGoalAuthoritySummary(record.humanAuthorities)
-            ? { approvalSummary: publicGoalAuthoritySummary(record.humanAuthorities) } : {}),
-        ...(publicGoalCompletionSummary(record.evaluationPolicy)
-            ? { completionSummary: publicGoalCompletionSummary(record.evaluationPolicy) } : {}),
-    };
-}
 export function publicGoalView(goal) {
     const criteria = Array.isArray(goal.criteria)
         ? goal.criteria.flatMap((criterion) => {
@@ -1003,6 +901,14 @@ function assertSameResultProposalPayload(existing, input, candidateHash) {
     }
 }
 export function goalService(db) {
+    async function lockGoalNodeMutationAuthority(database, goalId) {
+        const scope = await database.select({ orgId: goals.orgId })
+            .from(goals)
+            .where(eq(goals.id, goalId))
+            .then((rows) => rows[0] ?? null);
+        if (scope)
+            await lockNodeMutationAuthority(database, scope.orgId);
+    }
     function facetFor(goal, pendingChange, readyResult, pendingWakeup = null, externalWorkFact = null) {
         if (goal.lifecycle === "closed")
             return "closed";
@@ -1763,18 +1669,24 @@ export function goalService(db) {
                 if (replay.status !== "completed" || !replay.goalId) {
                     throw conflict("Goal Start request has not completed");
                 }
-                const goal = await db.select().from(goals).where(and(eq(goals.id, replay.goalId), eq(goals.orgId, orgId))).then((rows) => rows[0] ?? null);
-                if (!goal)
-                    throw conflict("Completed Goal Start request has no Goal");
-                const dispatch = await ensureGoalWakeupIntent(db, goal, {
-                    event: "goal_started",
-                    eventId: replay.id,
-                    actor,
+                const replayGoalId = replay.goalId;
+                return db.transaction(async (tx) => {
+                    const database = tx;
+                    await lockNodeMutationAuthority(database, orgId);
+                    const goal = await database.select().from(goals).where(and(eq(goals.id, replayGoalId), eq(goals.orgId, orgId))).then((rows) => rows[0] ?? null);
+                    if (!goal)
+                        throw conflict("Completed Goal Start request has no Goal");
+                    const dispatch = await ensureGoalWakeupIntent(database, goal, {
+                        event: "goal_started",
+                        eventId: replay.id,
+                        actor,
+                    });
+                    return { goal, replayed: true, dispatch };
                 });
-                return { goal, replayed: true, dispatch };
             }
             return db.transaction(async (tx) => {
                 const database = tx;
+                await lockNodeMutationAuthority(database, orgId);
                 const owner = await requireInvokableOwner(database, orgId, input.packet.ownerAgentId);
                 if (!ownerCanAdvanceGoal(owner, {
                     title: input.packet.title,
@@ -1994,25 +1906,30 @@ export function goalService(db) {
             };
         }),
         create: async (orgId, data) => {
-            if (data.ownerAgentId)
-                await requireInvokableOwner(db, orgId, data.ownerAgentId);
-            return db.insert(goals).values({
-                orgId,
-                title: data.title,
-                description: data.description ?? null,
-                alignmentQuestion: data.alignmentQuestion ?? null,
-                evaluationDeadline: data.targetTime ?? null,
-                level: "task",
-                status: "planned",
-                lifecycle: "draft",
-                parentId: null,
-                ownerAgentId: data.ownerAgentId ?? null,
-                ownerAgentRuntimeOverrides: data.ownerAgentRuntimeOverrides ?? null,
-            }).returning().then((rows) => rows[0]);
+            return db.transaction(async (tx) => {
+                const database = tx;
+                await lockNodeMutationAuthority(database, orgId);
+                if (data.ownerAgentId)
+                    await requireInvokableOwner(database, orgId, data.ownerAgentId);
+                return database.insert(goals).values({
+                    orgId,
+                    title: data.title,
+                    description: data.description ?? null,
+                    alignmentQuestion: data.alignmentQuestion ?? null,
+                    evaluationDeadline: data.targetTime ?? null,
+                    level: "task",
+                    status: "planned",
+                    lifecycle: "draft",
+                    parentId: null,
+                    ownerAgentId: data.ownerAgentId ?? null,
+                    ownerAgentRuntimeOverrides: data.ownerAgentRuntimeOverrides ?? null,
+                }).returning().then((rows) => rows[0]);
+            });
         },
         update: async (id, data, actorAgentId = null) => {
             return db.transaction(async (tx) => {
                 const database = tx;
+                await lockGoalNodeMutationAuthority(database, id);
                 const current = await requireGoalForUpdate(database, id);
                 assertGoalOwner(current, actorAgentId);
                 if (current.lifecycle === "closed") {
@@ -2057,7 +1974,9 @@ export function goalService(db) {
             }
             await requireInvokableOwner(db, current.orgId, input.ownerAgentId);
             const result = await db.transaction(async (tx) => {
-                const [goal] = await tx.update(goals).set({
+                const database = tx;
+                await lockNodeMutationAuthority(database, current.orgId);
+                const [goal] = await database.update(goals).set({
                     outcomeStatement: input.outcomeStatement,
                     objectiveMode: input.objectiveMode,
                     lifecycle: "active",
@@ -2079,21 +1998,21 @@ export function goalService(db) {
                 }).where(and(eq(goals.id, id), eq(goals.lifecycle, "draft"))).returning();
                 if (!goal)
                     throw conflict("Goal changed before activation; reload and retry");
-                await tx.insert(goalOwnerAssignments).values({
+                await database.insert(goalOwnerAssignments).values({
                     orgId: current.orgId,
                     goalId: id,
                     agentId: input.ownerAgentId,
                     assignedByAuthorityRef: "activation",
                     assignmentRevision: 1,
                 });
-                await tx.insert(goalPlans).values({
+                await database.insert(goalPlans).values({
                     orgId: current.orgId,
                     goalId: id,
                     revision: 1,
                     ...input.initialPlan,
                     createdByAgentId: actorAgentId,
                 });
-                await tx.insert(goalActivities).values({
+                await database.insert(goalActivities).values({
                     orgId: current.orgId,
                     goalId: id,
                     contractRevision: 1,
@@ -2110,6 +2029,7 @@ export function goalService(db) {
         updatePlan: async (id, input, actorAgentId = null) => {
             return db.transaction(async (tx) => {
                 const database = tx;
+                await lockGoalNodeMutationAuthority(database, id);
                 const current = await requireGoalForUpdate(database, id);
                 assertCanonicalActiveGoal(current);
                 assertGoalOwner(current, actorAgentId);
@@ -2143,6 +2063,7 @@ export function goalService(db) {
             });
             return db.transaction(async (tx) => {
                 const database = tx;
+                await lockGoalNodeMutationAuthority(database, id);
                 const current = await requireGoalForUpdate(database, id);
                 assertCanonicalActiveGoal(current);
                 assertGoalOwner(current, actorAgentId);
@@ -2247,6 +2168,7 @@ export function goalService(db) {
         createActivity: async (id, input, actorAgentId = null) => {
             return db.transaction(async (tx) => {
                 const database = tx;
+                await lockGoalNodeMutationAuthority(database, id);
                 const current = await requireGoalForUpdate(database, id);
                 assertCanonicalActiveGoal(current);
                 assertGoalOwner(current, actorAgentId);
@@ -2294,6 +2216,7 @@ export function goalService(db) {
         feedback: async (id, input, actorUserId) => {
             return db.transaction(async (tx) => {
                 const database = tx;
+                await lockGoalNodeMutationAuthority(database, id);
                 const current = await requireGoalForUpdate(database, id);
                 return recordFeedback(database, current, input, actorUserId);
             });
@@ -2304,6 +2227,7 @@ export function goalService(db) {
             const normalizedPatch = normalizeContractPatch(input.afterContract);
             return db.transaction(async (tx) => {
                 const database = tx;
+                await lockGoalNodeMutationAuthority(database, id);
                 const current = await requireGoalForUpdate(database, id);
                 assertCanonicalActiveGoal(current);
                 assertGoalOwner(current, actorAgentId);
@@ -2414,6 +2338,7 @@ export function goalService(db) {
                     .where(eq(goalChangeProposals.id, proposalId)).then((rows) => rows[0] ?? null);
                 if (!proposal)
                     throw notFound("Goal change proposal not found");
+                await lockNodeMutationAuthority(database, proposal.orgId);
                 const approval = await database.select().from(approvals).where(and(eq(approvals.id, proposal.approvalId), eq(approvals.orgId, proposal.orgId))).then((rows) => rows[0] ?? null);
                 if (!approval || approval.type !== "goal_change") {
                     throw unprocessable("Goal change proposal approval is invalid");
@@ -2581,6 +2506,7 @@ export function goalService(db) {
                 // deadlock on heartbeat_runs.agent_id foreign-key checks.
                 await database.select({ id: agents.id }).from(agents)
                     .where(eq(agents.id, actorAgentId)).for("update");
+                await lockGoalNodeMutationAuthority(database, id);
                 const current = await requireGoalForUpdate(database, id);
                 assertGoalOwner(current, actorAgentId);
                 if (actorRunId)
@@ -2667,6 +2593,7 @@ export function goalService(db) {
                     .where(eq(goalResultProposals.id, proposalId)).then((rows) => rows[0] ?? null);
                 if (!proposal)
                     throw notFound("Goal Result Proposal not found");
+                await lockNodeMutationAuthority(database, proposal.orgId);
                 const current = await requireGoalForUpdate(database, proposal.goalId);
                 if (current.orgId !== proposal.orgId)
                     throw unprocessable("Goal Result Proposal organization mismatch");
@@ -2741,6 +2668,7 @@ export function goalService(db) {
                     .where(eq(goalResultProposals.id, proposalId)).then((rows) => rows[0] ?? null);
                 if (!proposal)
                     throw notFound("Goal Result Proposal not found");
+                await lockNodeMutationAuthority(database, proposal.orgId);
                 if (proposal.status === "rejected") {
                     if (proposal.rejectionFeedback !== input.feedback) {
                         throw conflict("Goal Result Proposal rejection was replayed with different feedback");
@@ -2789,6 +2717,7 @@ export function goalService(db) {
         assignOwner: async (id, input, actorAgentId = null) => {
             return db.transaction(async (tx) => {
                 const database = tx;
+                await lockGoalNodeMutationAuthority(database, id);
                 const current = await requireGoalForUpdate(database, id);
                 assertCanonicalActiveGoal(current);
                 assertGoalOwner(current, actorAgentId);
@@ -2820,6 +2749,7 @@ export function goalService(db) {
         setFocus: async (id, focus, actorAgentId = null) => {
             return db.transaction(async (tx) => {
                 const database = tx;
+                await lockGoalNodeMutationAuthority(database, id);
                 const candidate = await requireGoal(database, id);
                 await database.execute(sql `select id from organizations where id = ${candidate.orgId} for update`);
                 const current = await requireGoalForUpdate(database, id);
@@ -2838,16 +2768,21 @@ export function goalService(db) {
         evaluate: async (id, input, actorAgentId = null) => {
             return db.transaction(async (tx) => {
                 const database = tx;
+                await lockGoalNodeMutationAuthority(database, id);
                 const current = await requireGoalForUpdate(database, id);
                 return evaluateInTransaction(database, current, input, actorAgentId);
             });
         },
         remove: async (id) => {
-            const existing = await requireGoal(db, id);
-            const dependencies = await getGoalDependencies(db, existing);
-            if (!dependencies.canDelete)
-                throw conflict("Only an unlinked draft Goal can be deleted", dependencies);
-            return db.delete(goals).where(eq(goals.id, id)).returning().then((rows) => rows[0] ?? null);
+            return db.transaction(async (tx) => {
+                const database = tx;
+                await lockGoalNodeMutationAuthority(database, id);
+                const existing = await requireGoalForUpdate(database, id);
+                const dependencies = await getGoalDependencies(database, existing);
+                if (!dependencies.canDelete)
+                    throw conflict("Only an unlinked draft Goal can be deleted", dependencies);
+                return database.delete(goals).where(eq(goals.id, id)).returning().then((rows) => rows[0] ?? null);
+            });
         },
     };
 }