@rudderhq/server 0.7.2 → 0.7.3

package/dist/services/issues.js

@@ -1,4 +1,4 @@
-import { agents, assets, documents, executionWorkspaces, goals, heartbeatRuns, issueAttachments, issueComments, issueDocuments, issueFollows, issueLabels, issueReadStates, issues, labels, organizationIssuePrefixAliases, organizationMemberships, organizations, projectWorkspaces, projects } from "@rudderhq/db";
+import { activityLog, agents, assets, documents, executionWorkspaces, goals, heartbeatRuns, issueAttachments, issueComments, issueDocuments, issueFollows, issueLabels, issueReadStates, issues, labels, organizationIssuePrefixAliases, organizationMemberships, organizations, projectWorkspaces, projects } from "@rudderhq/db";
 import { and, asc, desc, eq, inArray, isNull, ne, or, sql } from "drizzle-orm";
 import { conflict, notFound, unprocessable } from "../errors.js";
 import { redactCurrentUserText } from "../log-redaction.js";
@@ -35,6 +35,12 @@ function normalizeIssueListOffset(offset) {
 }
 export function issueService(db) {
     const instanceSettings = instanceSettingsService(db);
+    const issueCreateResults = new WeakMap();
+    let createIssue;
+    function rememberIssueCreateResult(issue, created) {
+        issueCreateResults.set(issue, created);
+        return issue;
+    }
     function redactIssueComment(comment, censorUsernameInLogs) {
         return {
             ...comment,
@@ -298,7 +304,7 @@ export function issueService(db) {
             searchMatch: matchesByIssueId.get(row.id) ?? null,
         }));
     }
-    return {
+    const service = {
         listFollows: async (orgId, userId) => {
             const rows = await db
                 .select({
@@ -553,6 +559,17 @@ export function issueService(db) {
                 .from(issueComments)
                 .where(and(eq(issueComments.orgId, orgId), inArray(issueComments.issueId, issueIds), isNull(issueComments.deletedAt)))
                 .groupBy(issueComments.issueId);
+            const notificationRows = await db
+                .select({
+                issueId: activityLog.entityId,
+                lastExternalActivityAt: sql `MAX(${activityLog.createdAt})`,
+            })
+                .from(activityLog)
+                .where(and(eq(activityLog.orgId, orgId), eq(activityLog.entityType, "issue"), inArray(activityLog.entityId, issueIds), inArray(activityLog.action, [
+                "automation.issue_created_notification",
+                "agent.issue_created_notification",
+            ]), sql `${activityLog.details}->>'userId' = ${contextUserId}`))
+                .groupBy(activityLog.entityId);
             const readRows = await db
                 .select({
                 issueId: issueReadStates.issueId,
@@ -561,6 +578,17 @@ export function issueService(db) {
                 .from(issueReadStates)
                 .where(and(eq(issueReadStates.orgId, orgId), eq(issueReadStates.userId, contextUserId), inArray(issueReadStates.issueId, issueIds)));
             const statsByIssueId = new Map(statsRows.map((row) => [row.issueId, row]));
+            for (const row of notificationRows) {
+                const existing = statsByIssueId.get(row.issueId);
+                statsByIssueId.set(row.issueId, {
+                    ...(existing ?? {
+                        issueId: row.issueId,
+                        myLastCommentAt: null,
+                        lastExternalCommentAt: null,
+                    }),
+                    lastExternalActivityAt: row.lastExternalActivityAt,
+                });
+            }
             const readByIssueId = new Map(readRows.map((row) => [row.issueId, row.myLastReadAt]));
             return withSearchMatches.map((row) => ({
                 ...row,
@@ -568,6 +596,7 @@ export function issueService(db) {
                     myLastCommentAt: statsByIssueId.get(row.id)?.myLastCommentAt ?? null,
                     myLastReadAt: readByIssueId.get(row.id) ?? null,
                     lastExternalCommentAt: statsByIssueId.get(row.id)?.lastExternalCommentAt ?? null,
+                    lastExternalActivityAt: statsByIssueId.get(row.id)?.lastExternalActivityAt ?? null,
                 }),
             }));
         },
@@ -654,9 +683,42 @@ export function issueService(db) {
             const [enriched] = await withIssueLabels(db, [row]);
             return enriched;
         },
+        getByOrigin: async (orgId, originKind, originId) => {
+            const row = await db
+                .select()
+                .from(issues)
+                .where(and(eq(issues.orgId, orgId), eq(issues.originKind, originKind), eq(issues.originId, originId)))
+                .then((rows) => rows[0] ?? null);
+            if (!row)
+                return null;
+            const [enriched] = await withIssueLabels(db, [row]);
+            return enriched;
+        },
+        createWithResult: async (orgId, data) => {
+            const issue = await createIssue(orgId, data);
+            return {
+                issue,
+                created: issueCreateResults.get(issue) ?? true,
+            };
+        },
         create: async (orgId, data) => {
             const { labelIds: inputLabelIds, ...rawIssueData } = data;
             const issueData = { ...rawIssueData };
+            const agentIssueCreationOrigin = issueData.originKind === "agent_issue_creation"
+                && typeof issueData.originId === "string"
+                ? issueData.originId
+                : null;
+            if (agentIssueCreationOrigin) {
+                const existing = await db
+                    .select()
+                    .from(issues)
+                    .where(and(eq(issues.orgId, orgId), eq(issues.originKind, "agent_issue_creation"), eq(issues.originId, agentIssueCreationOrigin)))
+                    .then((rows) => rows[0] ?? null);
+                if (existing) {
+                    const [enriched] = await withIssueLabels(db, [existing]);
+                    return rememberIssueCreateResult(enriched, false);
+                }
+            }
             if (data.assigneeAgentId && data.assigneeUserId) {
                 throw unprocessable("Issue can only have one assignee");
             }
@@ -691,144 +753,160 @@ export function issueService(db) {
             if (data.status === "in_progress" && !data.assigneeAgentId && !data.assigneeUserId) {
                 throw unprocessable("in_progress issues require an assignee");
             }
-            return db.transaction(async (tx) => {
-                let executionWorkspaceSettings = issueData.executionWorkspaceSettings ?? null;
-                if (executionWorkspaceSettings == null && issueData.projectId) {
-                    const project = await tx
-                        .select({ executionWorkspacePolicy: projects.executionWorkspacePolicy })
-                        .from(projects)
-                        .where(and(eq(projects.id, issueData.projectId), eq(projects.orgId, orgId)))
-                        .then((rows) => rows[0] ?? null);
-                    executionWorkspaceSettings =
-                        defaultIssueExecutionWorkspaceSettingsForProject(parseProjectExecutionWorkspacePolicy(project?.executionWorkspacePolicy));
-                }
-                // Legacy fallback: keep old project_workspace_id population for
-                // existing runtime resolution paths. Current run workspace behavior is
-                // configured through executionWorkspaceSettings / executionWorkspaces.
-                let projectWorkspaceId = issueData.projectWorkspaceId ?? null;
-                if (!projectWorkspaceId && issueData.projectId) {
-                    const project = await tx
-                        .select({
-                        executionWorkspacePolicy: projects.executionWorkspacePolicy,
-                    })
-                        .from(projects)
-                        .where(and(eq(projects.id, issueData.projectId), eq(projects.orgId, orgId)))
-                        .then((rows) => rows[0] ?? null);
-                    const projectPolicy = parseProjectExecutionWorkspacePolicy(project?.executionWorkspacePolicy);
-                    projectWorkspaceId = projectPolicy?.defaultProjectWorkspaceId ?? null;
-                    if (!projectWorkspaceId) {
-                        projectWorkspaceId = await tx
-                            .select({ id: projectWorkspaces.id })
-                            .from(projectWorkspaces)
-                            .where(and(eq(projectWorkspaces.projectId, issueData.projectId), eq(projectWorkspaces.orgId, orgId)))
-                            .orderBy(desc(projectWorkspaces.isPrimary), asc(projectWorkspaces.createdAt), asc(projectWorkspaces.id))
-                            .then((rows) => rows[0]?.id ?? null);
+            try {
+                return await db.transaction(async (tx) => {
+                    let executionWorkspaceSettings = issueData.executionWorkspaceSettings ?? null;
+                    if (executionWorkspaceSettings == null && issueData.projectId) {
+                        const project = await tx
+                            .select({ executionWorkspacePolicy: projects.executionWorkspacePolicy })
+                            .from(projects)
+                            .where(and(eq(projects.id, issueData.projectId), eq(projects.orgId, orgId)))
+                            .then((rows) => rows[0] ?? null);
+                        executionWorkspaceSettings =
+                            defaultIssueExecutionWorkspaceSettingsForProject(parseProjectExecutionWorkspacePolicy(project?.executionWorkspacePolicy));
                     }
-                }
-                const [organization] = await tx
-                    .update(organizations)
-                    .set({ issueCounter: sql `${organizations.issueCounter} + 1` })
-                    .where(eq(organizations.id, orgId))
-                    .returning({ issueCounter: organizations.issueCounter, issuePrefix: organizations.issuePrefix });
-                const issueNumber = organization.issueCounter;
-                const identifier = `${organization.issuePrefix}-${issueNumber}`;
-                const values = {
-                    ...issueData,
-                    originKind: issueData.originKind ?? "manual",
-                    goalId: issueData.goalId ?? null,
-                    ...(projectWorkspaceId ? { projectWorkspaceId } : {}),
-                    ...(executionWorkspaceSettings ? { executionWorkspaceSettings } : {}),
-                    orgId,
-                    issueNumber,
-                    identifier,
-                };
-                if (values.status === "in_progress" && !values.startedAt) {
-                    values.startedAt = new Date();
-                }
-                if (values.status === "done") {
-                    values.completedAt = new Date();
-                }
-                if (values.status === "cancelled") {
-                    values.cancelledAt = new Date();
-                }
-                if (values.boardOrder === undefined) {
-                    const statusForOrder = values.status ?? "backlog";
-                    const currentMax = await tx
-                        .select({ value: sql `coalesce(max(${issues.boardOrder}), 0)` })
-                        .from(issues)
-                        .where(and(eq(issues.orgId, orgId), eq(issues.status, statusForOrder)))
-                        .then((rows) => Number(rows[0]?.value ?? 0));
-                    values.boardOrder = currentMax + BOARD_ORDER_STEP;
-                }
-                const resolvedLabelIds = await resolveCreateLabelIds(orgId, issueData, inputLabelIds, tx);
-                const [issue] = await tx.insert(issues).values(values).returning();
-                if (resolvedLabelIds) {
-                    await syncIssueLabels(issue.id, orgId, resolvedLabelIds, tx);
-                }
-                const creationActorType = issue.createdByUserId
-                    ? "human"
-                    : issue.originKind === "automation_execution"
-                        ? "automation"
-                        : issue.createdByAgentId
-                            ? "agent"
-                            : "system";
-                const creationOrigin = creationActorType === "human"
-                    ? "human"
-                    : creationActorType === "automation"
-                        ? "automation"
-                        : "system";
-                await recordProductAnalyticsEvent(tx, {
-                    orgId,
-                    eventName: "issue_created",
-                    occurredAt: issue.createdAt,
-                    sourceTransition: "issue.create",
-                    confidence: "exact",
-                    actorType: creationActorType,
-                    actorId: issue.createdByUserId ?? issue.createdByAgentId ?? null,
-                    entityType: "issue",
-                    entityId: issue.id,
-                    workSurface: "issue",
-                    workId: issue.id,
-                    origin: creationOrigin,
-                    dedupeKey: `issue_created:${issue.id}`,
-                    properties: {
-                        creation_path: issue.originKind,
-                        has_goal_link: issue.goalId !== null,
-                        has_project_link: issue.projectId !== null,
-                        is_sub_issue: issue.parentId !== null,
-                    },
-                });
-                if (issue.createdByUserId && (issue.status === "in_progress" || issue.executionRunId !== null)) {
-                    const workCycleId = `issue:${issue.id}`;
-                    await ensureProductAnalyticsWorkCycle(tx, {
+                    // Legacy fallback: keep old project_workspace_id population for
+                    // existing runtime resolution paths. Current run workspace behavior is
+                    // configured through executionWorkspaceSettings / executionWorkspaces.
+                    let projectWorkspaceId = issueData.projectWorkspaceId ?? null;
+                    if (!projectWorkspaceId && issueData.projectId) {
+                        const project = await tx
+                            .select({
+                            executionWorkspacePolicy: projects.executionWorkspacePolicy,
+                        })
+                            .from(projects)
+                            .where(and(eq(projects.id, issueData.projectId), eq(projects.orgId, orgId)))
+                            .then((rows) => rows[0] ?? null);
+                        const projectPolicy = parseProjectExecutionWorkspacePolicy(project?.executionWorkspacePolicy);
+                        projectWorkspaceId = projectPolicy?.defaultProjectWorkspaceId ?? null;
+                        if (!projectWorkspaceId) {
+                            projectWorkspaceId = await tx
+                                .select({ id: projectWorkspaces.id })
+                                .from(projectWorkspaces)
+                                .where(and(eq(projectWorkspaces.projectId, issueData.projectId), eq(projectWorkspaces.orgId, orgId)))
+                                .orderBy(desc(projectWorkspaces.isPrimary), asc(projectWorkspaces.createdAt), asc(projectWorkspaces.id))
+                                .then((rows) => rows[0]?.id ?? null);
+                        }
+                    }
+                    const [organization] = await tx
+                        .update(organizations)
+                        .set({ issueCounter: sql `${organizations.issueCounter} + 1` })
+                        .where(eq(organizations.id, orgId))
+                        .returning({ issueCounter: organizations.issueCounter, issuePrefix: organizations.issuePrefix });
+                    const issueNumber = organization.issueCounter;
+                    const identifier = `${organization.issuePrefix}-${issueNumber}`;
+                    const values = {
+                        ...issueData,
+                        originKind: issueData.originKind ?? "manual",
+                        goalId: issueData.goalId ?? null,
+                        ...(projectWorkspaceId ? { projectWorkspaceId } : {}),
+                        ...(executionWorkspaceSettings ? { executionWorkspaceSettings } : {}),
                         orgId,
-                        workSurface: "issue",
-                        workId: issue.id,
-                        workCycleId,
-                        actorId: issue.createdByUserId,
-                        startedAt: issue.createdAt,
-                    });
+                        issueNumber,
+                        identifier,
+                    };
+                    if (values.status === "in_progress" && !values.startedAt) {
+                        values.startedAt = new Date();
+                    }
+                    if (values.status === "done") {
+                        values.completedAt = new Date();
+                    }
+                    if (values.status === "cancelled") {
+                        values.cancelledAt = new Date();
+                    }
+                    if (values.boardOrder === undefined) {
+                        const statusForOrder = values.status ?? "backlog";
+                        const currentMax = await tx
+                            .select({ value: sql `coalesce(max(${issues.boardOrder}), 0)` })
+                            .from(issues)
+                            .where(and(eq(issues.orgId, orgId), eq(issues.status, statusForOrder)))
+                            .then((rows) => Number(rows[0]?.value ?? 0));
+                        values.boardOrder = currentMax + BOARD_ORDER_STEP;
+                    }
+                    const resolvedLabelIds = await resolveCreateLabelIds(orgId, issueData, inputLabelIds, tx);
+                    const [issue] = await tx.insert(issues).values(values).returning();
+                    if (resolvedLabelIds) {
+                        await syncIssueLabels(issue.id, orgId, resolvedLabelIds, tx);
+                    }
+                    const creationActorType = issue.createdByUserId
+                        ? "human"
+                        : issue.originKind === "automation_execution"
+                            ? "automation"
+                            : issue.createdByAgentId
+                                ? "agent"
+                                : "system";
+                    const creationOrigin = creationActorType === "human"
+                        ? "human"
+                        : creationActorType === "automation"
+                            ? "automation"
+                            : "system";
                     await recordProductAnalyticsEvent(tx, {
                         orgId,
-                        eventName: "human_work_started",
+                        eventName: "issue_created",
                         occurredAt: issue.createdAt,
                         sourceTransition: "issue.create",
                         confidence: "exact",
-                        actorType: "human",
-                        actorId: issue.createdByUserId,
+                        actorType: creationActorType,
+                        actorId: issue.createdByUserId ?? issue.createdByAgentId ?? null,
                         entityType: "issue",
                         entityId: issue.id,
                         workSurface: "issue",
                         workId: issue.id,
-                        workCycleId,
-                        origin: "human",
-                        dedupeKey: `human_work_started:${workCycleId}`,
-                        properties: { work_surface: "issue", origin: "human" },
+                        origin: creationOrigin,
+                        dedupeKey: `issue_created:${issue.id}`,
+                        properties: {
+                            creation_path: issue.originKind,
+                            has_goal_link: issue.goalId !== null,
+                            has_project_link: issue.projectId !== null,
+                            is_sub_issue: issue.parentId !== null,
+                        },
                     });
+                    if (issue.createdByUserId && (issue.status === "in_progress" || issue.executionRunId !== null)) {
+                        const workCycleId = `issue:${issue.id}`;
+                        await ensureProductAnalyticsWorkCycle(tx, {
+                            orgId,
+                            workSurface: "issue",
+                            workId: issue.id,
+                            workCycleId,
+                            actorId: issue.createdByUserId,
+                            startedAt: issue.createdAt,
+                        });
+                        await recordProductAnalyticsEvent(tx, {
+                            orgId,
+                            eventName: "human_work_started",
+                            occurredAt: issue.createdAt,
+                            sourceTransition: "issue.create",
+                            confidence: "exact",
+                            actorType: "human",
+                            actorId: issue.createdByUserId,
+                            entityType: "issue",
+                            entityId: issue.id,
+                            workSurface: "issue",
+                            workId: issue.id,
+                            workCycleId,
+                            origin: "human",
+                            dedupeKey: `human_work_started:${workCycleId}`,
+                            properties: { work_surface: "issue", origin: "human" },
+                        });
+                    }
+                    const [enriched] = await withIssueLabels(tx, [issue]);
+                    return rememberIssueCreateResult(enriched, true);
+                });
+            }
+            catch (error) {
+                if (!agentIssueCreationOrigin || !isUniqueConstraintConflict(error, "issues_agent_issue_creation_origin_uq")) {
+                    throw error;
                 }
-                const [enriched] = await withIssueLabels(tx, [issue]);
-                return enriched;
-            });
+                const existing = await db
+                    .select()
+                    .from(issues)
+                    .where(and(eq(issues.orgId, orgId), eq(issues.originKind, "agent_issue_creation"), eq(issues.originId, agentIssueCreationOrigin)))
+                    .then((rows) => rows[0] ?? null);
+                if (!existing)
+                    throw error;
+                const [enriched] = await withIssueLabels(db, [existing]);
+                return rememberIssueCreateResult(enriched, false);
+            }
         },
         update: async (id, data, authorization) => {
             const existing = await db
@@ -1483,5 +1561,7 @@ export function issueService(db) {
             }));
         },
     };
+    createIssue = service.create;
+    return service;
 }
 //# sourceMappingURL=issues.js.map