@rudderhq/server 0.5.0 → 0.5.1

package/dist/routes/chats.js

@@ -1,4 +1,4 @@
-import { addChatMessageSchema, cancelChatQueuedMessageSchema, chatAutomationCreateFromStructuredPayload, createChatConversationSchema, createChatQueuedMessageSchema, createSideChatSchema, forkChatConversationSchema, parseCodexInlineVisualDirectives, steerChatQueuedMessageSchema, updateChatConversationSchema, updateChatQueuedMessageSchema, } from "@rudderhq/shared";
+import { addChatMessageSchema, cancelChatQueuedMessageSchema, chatAutomationCreateFromStructuredPayload, chatDraftSchema, createChatConversationSchema, createChatQueuedMessageSchema, createSideChatSchema, forkChatConversationSchema, steerChatQueuedMessageSchema, updateChatConversationSchema, updateChatQueuedMessageSchema, } from "@rudderhq/shared";
 import { Router } from "express";
 import multer from "multer";
 import { randomUUID } from "node:crypto";
@@ -8,9 +8,10 @@ import { logger } from "../middleware/logger.js";
 import { validate } from "../middleware/validate.js";
 import { assertTimeZone } from "../services/automations.scheduler.js";
 import { chatAgentRunService } from "../services/chat-agent-runs.js";
-import { CHAT_ASSISTANT_USER_ERROR_MESSAGE, chatAssistantService, ChatAssistantStreamError, userVisiblePartialBodyFromError, } from "../services/chat-assistant.js";
+import { CHAT_ASSISTANT_USER_ERROR_MESSAGE, chatAssistantErrorForLog, chatAssistantService, ChatAssistantStreamError, userVisiblePartialBodyFromError, } from "../services/chat-assistant.js";
 import { cancelAndReleaseActiveChatGeneration, claimChatGeneration, createChatRuntimeControlCoordinator, getActiveChatGeneration, hasActiveChatGeneration, interruptActiveChatGeneration, steerActiveChatGeneration } from "../services/chat-generation-locks.js";
 import { hashChatGenerationBody } from "../services/chat-generation-protocol.js";
+import { chatSteerMessageService } from "../services/chat-steer-messages.js";
 import { buildChatTitlePromptFromMessages, chatTitleGenerationService, } from "../services/chat-title-generation.js";
 import { chatWorkManifestService } from "../services/chat-work-manifest.js";
 import { validateCron } from "../services/cron.js";
@@ -19,6 +20,8 @@ import { runtimeResultText, sanitizeGeneratedTitle, } from "../services/title-ge
 import { assertBoard, assertCompanyAccess, getActorInfo } from "./authz.js";
 import { createChatBackgroundRuntime, } from "./chat-background-runtime.js";
 import { wakeIssueAssigneeAfterChatConversion } from "./chat-issue-assignment-wakeup.js";
+import { attachGeneratedChatFiles } from "./chats.generated-attachments.js";
+import { isMultipartRequest, paginateChatMessages, positiveIntegerQuery, uploadedMessageFiles, validateUploadedMessageFiles, } from "./chats.helpers.js";
 import { registerChatStreamRoutes } from "./chats.stream-routes.js";
 function chatVisibleOutputAdmissionClosed(error) {
     return error instanceof HttpError
@@ -42,6 +45,7 @@ export function chatRoutes(db, storage, backgroundRuntime = createChatBackground
     const heartbeat = heartbeatService(db);
     const productIntelligence = productIntelligenceService(db);
     const chatTitles = chatTitleGenerationService({ chats: svc, productIntelligence });
+    const steerMessages = chatSteerMessageService(db);
     const sideChats = sideChatService(db);
     const CHAT_ASSISTANT_RECOVERABLE_FAILURE_FALLBACK_MESSAGE = "The assistant reply could not be completed. Rudder saved this attempt for diagnostics; retry when ready.";
     const upload = multer({
@@ -72,28 +76,6 @@ export function chatRoutes(db, storage, backgroundRuntime = createChatBackground
             });
         });
     }
-    function isMultipartRequest(req) {
-        return (req.headers["content-type"] ?? "").toLowerCase().startsWith("multipart/form-data");
-    }
-    function uploadedMessageFiles(req) {
-        const files = req.files;
-        const list = Array.isArray(files) ? files : [];
-        return list.filter((file) => typeof file === "object" &&
-            file !== null &&
-            Buffer.isBuffer(file.buffer));
-    }
-    function validateUploadedMessageFiles(files) {
-        for (const file of files) {
-            const contentType = (file.mimetype || "").toLowerCase();
-            if (!isAllowedContentType(contentType)) {
-                return `Unsupported attachment type: ${contentType || "unknown"}`;
-            }
-            if (file.buffer.length <= 0) {
-                return "Attachment is empty";
-            }
-        }
-        return null;
-    }
     async function assertConversationAccess(req, conversationId) {
         const conversation = await svc.getById(conversationId);
         if (!conversation)
@@ -113,9 +95,6 @@ export function chatRoutes(db, storage, backgroundRuntime = createChatBackground
             return false;
         return Boolean(agent.permissions.canCreateAgents);
     }
-    function stringQuery(value) {
-        return typeof value === "string" && value.trim().length > 0 ? value.trim() : null;
-    }
     function assertChatLocalMutationAllowed(conversation) {
         if (conversation.mutability === "external_bound_chat") {
             throw conflict("Fork this Feishu chat to continue in Rudder");
@@ -141,35 +120,6 @@ export function chatRoutes(db, storage, backgroundRuntime = createChatBackground
         });
         return sanitizeGeneratedTitle(runtimeResultText(result));
     }
-    function positiveIntegerQuery(value, fallback, max) {
-        const parsed = Number(value ?? fallback);
-        if (!Number.isFinite(parsed) || parsed <= 0)
-            return fallback;
-        return Math.min(max, Math.floor(parsed));
-    }
-    function paginateChatMessages(messages, query) {
-        const order = query.order === "newest" ? "newest" : "oldest";
-        const limit = positiveIntegerQuery(query.limit, 50, 500);
-        const cursor = stringQuery(query.cursor);
-        const ordered = order === "newest" ? [...messages].reverse() : messages;
-        const startIndex = cursor
-            ? Math.max(0, ordered.findIndex((message) => message.id === cursor) + 1)
-            : 0;
-        const pageMessages = ordered.slice(startIndex, startIndex + limit);
-        const hasMore = startIndex + pageMessages.length < ordered.length;
-        return {
-            messages: pageMessages,
-            page: {
-                cursor,
-                nextCursor: hasMore && pageMessages.length > 0 ? pageMessages[pageMessages.length - 1].id : null,
-                hasMore,
-                limit,
-                order,
-                returnedMessages: pageMessages.length,
-                totalMessages: messages.length,
-            },
-        };
-    }
     async function assertCanAssignTasks(req, orgId) {
         assertCompanyAccess(req, orgId);
         if (req.actor.type === "board") {
@@ -234,6 +184,40 @@ export function chatRoutes(db, storage, backgroundRuntime = createChatBackground
             }
         }
     }
+    async function preflightChatDraft(req, res, input) {
+        const orgId = req.params.orgId;
+        assertCompanyAccess(req, orgId);
+        const organization = await organizationsSvc.getById(orgId);
+        if (!organization) {
+            res.status(404).json({ error: "Organization not found" });
+            return null;
+        }
+        const contextLinks = input.contextLinks ?? [];
+        await assertContextLinksBelongToCompany(orgId, contextLinks);
+        let preferredAgentId = input.preferredAgentId ?? null;
+        if (preferredAgentId) {
+            const agent = await agentsSvc.getById(preferredAgentId);
+            if (!agent || agent.orgId !== orgId || agent.status === "terminated") {
+                res.status(422).json({ error: "Preferred agent must be available in the same organization" });
+                return null;
+            }
+        }
+        else {
+            const [defaultAgent] = await agentsSvc.list(orgId);
+            if (!defaultAgent) {
+                res.status(422).json({ error: "Chat requires an available agent" });
+                return null;
+            }
+            preferredAgentId = defaultAgent.id;
+        }
+        const availability = await assistantSvc.getDraftChatAssistantAvailability({
+            orgId,
+            preferredAgentId,
+            contextLinks,
+            planMode: input.planMode ?? false,
+        });
+        return { orgId, organization, contextLinks, preferredAgentId, availability };
+    }
     function queueRequestActor(req) {
         if (req.actor.type === "agent") {
             return {
@@ -477,83 +461,15 @@ export function chatRoutes(db, storage, backgroundRuntime = createChatBackground
     async function persistAssistantReply(req, conversation, actor, assistantReply, turnContext, transcript = [], replyingAgentId = assistantReply.replyingAgentId ?? chatReplyingAgentId(conversation), existingMessageId, runId) {
         const createdMessages = [];
         const { chatTurnId, turnVariant } = turnContext;
-        const attachGeneratedFiles = async (message, generatedAttachments) => {
-            const finalDirectives = parseCodexInlineVisualDirectives(assistantReply.body).directives;
-            const inlineVisuals = (assistantReply.inlineVisuals ?? []).filter((visual) => finalDirectives.some((directive) => directive.index === visual.directiveIndex && directive.file === visual.file));
-            const generatedFiles = (generatedAttachments ?? []).filter((generated) => generated.source !== "codex_inline_visual"
-                || inlineVisuals.some((visual) => visual.status === "captured"
-                    && visual.directiveIndex === generated.directiveIndex
-                    && visual.file === generated.directiveFile));
-            if (generatedFiles.length === 0 && inlineVisuals.length === 0)
-                return message;
-            const attachments = [];
-            const attachmentByVisualIndex = new Map();
-            for (const generated of generatedFiles) {
-                if (generated.body.length > MAX_ATTACHMENT_BYTES) {
-                    throw new ChatAssistantStreamError(`Generated attachment exceeds ${MAX_ATTACHMENT_BYTES} bytes`, assistantReply.body, generatedFiles, { partialBodyUserVisible: true });
-                }
-                const stored = await storage.putFile({
-                    orgId: conversation.orgId,
-                    namespace: `chats/${conversation.id}/generated`,
-                    originalFilename: generated.originalFilename,
-                    contentType: generated.contentType,
-                    body: generated.body,
-                });
-                const attachment = await svc.createAttachment({
-                    orgId: conversation.orgId,
-                    conversationId: conversation.id,
-                    messageId: message.id,
-                    provider: stored.provider,
-                    objectKey: stored.objectKey,
-                    contentType: stored.contentType,
-                    byteSize: stored.byteSize,
-                    sha256: stored.sha256,
-                    originalFilename: stored.originalFilename,
-                    createdByAgentId: replyingAgentId,
-                    createdByUserId: null,
-                });
-                const typedAttachment = attachment;
-                const publicAttachment = generated.source === "codex_inline_visual"
-                    ? (({ provider: _provider, objectKey: _objectKey, ...safe }) => safe)(typedAttachment)
-                    : typedAttachment;
-                attachments.push(publicAttachment);
-                if (generated.source === "codex_inline_visual") {
-                    attachmentByVisualIndex.set(generated.directiveIndex, publicAttachment);
-                }
-            }
-            let structuredPayload = message.structuredPayload ?? null;
-            if (inlineVisuals.length > 0) {
-                const persistedMappings = inlineVisuals.map((visual) => {
-                    if (visual.status === "captured") {
-                        const attachment = attachmentByVisualIndex.get(visual.directiveIndex);
-                        if (attachment) {
-                            return {
-                                directiveIndex: visual.directiveIndex,
-                                file: visual.file,
-                                status: "ready",
-                                attachmentId: attachment.id,
-                            };
-                        }
-                    }
-                    return {
-                        directiveIndex: visual.directiveIndex,
-                        file: visual.file,
-                        status: "unavailable",
-                        reason: visual.status === "unavailable" ? visual.reason : "capture_failed",
-                    };
-                });
-                structuredPayload = {
-                    ...(structuredPayload ?? {}),
-                    inlineVisuals: persistedMappings,
-                };
-                await svc.updateMessage(conversation.id, message.id, { structuredPayload });
-            }
-            return {
-                ...message,
-                structuredPayload,
-                attachments: [...(message.attachments ?? []), ...attachments],
-            };
-        };
+        const attachGeneratedFiles = (message, generatedAttachments) => attachGeneratedChatFiles({
+            assistantReply,
+            generatedAttachments,
+            message,
+            conversation,
+            replyingAgentId,
+            storage,
+            chats: svc,
+        });
         const saveAssistantMessage = async (input) => {
             if (existingMessageId) {
                 const updated = await svc.updateMessage(conversation.id, existingMessageId, {
@@ -836,7 +752,8 @@ export function chatRoutes(db, storage, backgroundRuntime = createChatBackground
         if (!message || !generatedAttachments || generatedAttachments.length === 0)
             return message;
         const attachments = [];
-        for (const generated of generatedAttachments) {
+        const publishableAttachments = generatedAttachments.filter((generated) => generated.source !== "codex_inline_visual" && generated.source !== "rudder_inline_visual");
+        for (const generated of publishableAttachments) {
             if (generated.body.length > MAX_ATTACHMENT_BYTES)
                 continue;
             const stored = await storage.putFile({
@@ -1391,51 +1308,38 @@ export function chatRoutes(db, storage, backgroundRuntime = createChatBackground
         res.json(await assistantSvc.enrichConversations(visibleConversations));
     });
     router.post("/orgs/:orgId/chats", validate(createChatConversationSchema), async (req, res) => {
-        const orgId = req.params.orgId;
-        assertCompanyAccess(req, orgId);
-        const organization = await organizationsSvc.getById(orgId);
-        if (!organization) {
-            res.status(404).json({ error: "Organization not found" });
+        const draft = await preflightChatDraft(req, res, req.body);
+        if (!draft)
+            return;
+        if (!draft.availability.available) {
+            res.status(503).json({ error: draft.availability.error });
             return;
-        }
-        const contextLinks = req.body.contextLinks ?? [];
-        await assertContextLinksBelongToCompany(orgId, contextLinks);
-        if (req.body.preferredAgentId) {
-            const agent = await agentsSvc.getById(req.body.preferredAgentId);
-            if (!agent || agent.orgId !== orgId) {
-                res.status(422).json({ error: "Preferred agent must belong to the same organization" });
-                return;
-            }
         }
         const actor = getActorInfo(req);
-        const conversation = await svc.create(orgId, {
+        const result = await svc.createWithInitialMessage(draft.orgId, {
             title: req.body.title,
             summary: req.body.summary ?? null,
-            preferredAgentId: req.body.preferredAgentId ?? null,
-            issueCreationMode: req.body.issueCreationMode ?? organization.defaultChatIssueCreationMode,
+            preferredAgentId: draft.preferredAgentId,
+            issueCreationMode: req.body.issueCreationMode ?? draft.organization.defaultChatIssueCreationMode,
             planMode: req.body.planMode ?? false,
             createdByUserId: actor.actorType === "user" ? actor.actorId : null,
-            contextLinks,
-        });
-        await logActivity(db, {
-            orgId,
-            actorType: actor.actorType,
-            actorId: actor.actorId,
-            agentId: actor.agentId,
-            runId: actor.runId,
-            action: "chat.created",
-            entityType: "chat",
-            entityId: conversation?.id ?? "unknown",
-            details: {
-                title: conversation?.title ?? "New chat",
-                contextLinkCount: contextLinks.length,
-                contextLinks: contextLinks.map((link) => ({
-                    entityType: link.entityType,
-                    entityId: link.entityId,
-                })),
+            contextLinks: draft.contextLinks,
+            initialMessage: {
+                role: actor.actorType === "agent" ? "assistant" : "user",
+                kind: "message",
+                status: "completed",
+                body: req.body.initialMessage.body,
+                replyingAgentId: actor.actorType === "agent" ? actor.agentId : null,
             },
+            activity: actor,
         });
-        res.status(201).json(await assistantSvc.enrichConversation(conversation));
+        res.status(201).json(await assistantSvc.enrichConversation(result.conversation));
+    });
+    router.post("/orgs/:orgId/chats/preflight", validate(chatDraftSchema), async (req, res) => {
+        const draft = await preflightChatDraft(req, res, req.body);
+        if (!draft)
+            return;
+        res.json(draft.availability);
     });
     router.get("/chats/:id", async (req, res) => {
         const conversation = await assertConversationAccess(req, req.params.id);
@@ -1473,10 +1377,14 @@ export function chatRoutes(db, storage, backgroundRuntime = createChatBackground
                 return;
             }
         }
+        if (req.body.preferredAgentId === null) {
+            res.status(422).json({ error: "Chat requires an available agent" });
+            return;
+        }
         if (req.body.preferredAgentId) {
             const agent = await agentsSvc.getById(req.body.preferredAgentId);
-            if (!agent || agent.orgId !== existing.orgId) {
-                res.status(422).json({ error: "Preferred agent must belong to the same organization" });
+            if (!agent || agent.orgId !== existing.orgId || agent.status === "terminated") {
+                res.status(422).json({ error: "Preferred agent must be available in the same organization" });
                 return;
             }
         }
@@ -1513,7 +1421,7 @@ export function chatRoutes(db, storage, backgroundRuntime = createChatBackground
             return;
         }
         await assertSideChatMutationAllowed(req, existing);
-        const messages = await svc.listMessages(existing.id, { includeTranscript: false });
+        const messages = await svc.listRecentUserMessages(existing.id, 5);
         const prompt = buildChatTitlePromptFromMessages(messages);
         if (!prompt) {
             throw unprocessable("No chat messages available to generate a title");
@@ -1610,34 +1518,51 @@ export function chatRoutes(db, storage, backgroundRuntime = createChatBackground
         });
         res.status(201).json(await assistantSvc.enrichConversation(sideChat));
     });
-    router.post("/chats/:id/side-chat/complete", async (req, res) => {
+    router.delete("/chats/:id/side-chat", async (req, res) => {
         assertBoard(req);
         const existing = await assertConversationAccess(req, req.params.id);
         if (!existing || existing.conversationKind !== "side_chat") {
             res.status(404).json({ error: "Side Chat not found" });
             return;
         }
+        if (existing.sideChatState === "kept" || existing.messengerVisible) {
+            throw conflict("A kept Side Chat is a normal Messenger chat");
+        }
+        if (hasActiveChatGeneration(existing.id)) {
+            cancelAndReleaseActiveChatGeneration(existing.id);
+        }
+        const attachments = await svc.listAttachmentsForConversation(existing.id);
         const userId = boardUserId(req);
-        const sideChat = await sideChats.complete({
+        const destroyed = await sideChats.destroy({
             conversationId: req.params.id,
             userId,
         });
+        for (const attachment of attachments) {
+            try {
+                if (!await svc.assetHasAttachments(attachment.assetId)) {
+                    await storage.deleteObject(attachment.orgId, attachment.objectKey);
+                }
+            }
+            catch (err) {
+                logger.warn({ err, conversationId: existing.id, attachmentId: attachment.id }, "failed to delete Side Chat attachment object");
+            }
+        }
         const actor = getActorInfo(req);
         await logActivity(db, {
-            orgId: sideChat.orgId,
+            orgId: existing.orgId,
             actorType: actor.actorType,
             actorId: actor.actorId,
             agentId: actor.agentId,
             runId: actor.runId,
-            action: "chat.side_chat_completed",
+            action: "chat.side_chat_destroyed",
             entityType: "chat",
-            entityId: sideChat.id,
+            entityId: existing.id,
             details: {
-                sourceConversationId: sideChat.forkedFromConversationId,
-                sourceMessageId: sideChat.forkedFromMessageId,
+                sourceConversationId: existing.forkedFromConversationId,
+                sourceMessageId: existing.forkedFromMessageId,
             },
         });
-        res.json(await assistantSvc.enrichConversation(sideChat));
+        res.json(destroyed);
     });
     router.post("/chats/:id/side-chat/keep", async (req, res) => {
         assertBoard(req);
@@ -1676,8 +1601,9 @@ export function chatRoutes(db, storage, backgroundRuntime = createChatBackground
             return;
         }
         assertChatLocalMutationAllowed(existing);
-        if (existing.conversationKind === "side_chat") {
-            throw conflict("Side Chat audit records cannot be deleted");
+        if (existing.conversationKind === "side_chat"
+            && (!existing.messengerVisible || existing.sideChatState !== "kept")) {
+            throw conflict("Close the Side Chat tab to destroy this temporary chat");
         }
         if (hasActiveChatGeneration(existing.id)) {
             if (req.query.cancelActive === "true") {
@@ -1776,7 +1702,7 @@ export function chatRoutes(db, storage, backgroundRuntime = createChatBackground
         }
         const latestGeneration = await svc.getLatestGeneration(conversation.id);
         if (latestGeneration && latestGeneration.status !== "completed") {
-            throw conflict("Queued follow-ups remain parked after a stopped or failed reply");
+            throw conflict("Queue remains parked after a stopped or failed reply");
         }
         const item = await svc.claimNextQueuedMessage(conversation.id);
         if (item) {
@@ -1859,24 +1785,26 @@ export function chatRoutes(db, storage, backgroundRuntime = createChatBackground
         await assertSideChatMutationAllowed(req, conversation);
         const active = getActiveChatGeneration(conversation.id);
         const requestActor = queueRequestActor(req);
+        const activityActor = getActorInfo(req);
         const controlActionId = req.body.controlActionId ?? randomUUID();
         const expectedGenerationId = req.body.expectedActiveGenerationId
             ?? active?.generationId
             ?? null;
         if (!expectedGenerationId) {
-            const scheduled = await svc.scheduleSteerContinuation({
+            const scheduled = await steerMessages.scheduleContinuation({
                 orgId: conversation.orgId,
                 conversationId: conversation.id,
                 itemId: req.params.itemId,
                 controlActionId,
                 requestActor,
+                actor: activityActor,
             });
             wakeServerQueue();
             res.json({
                 item: scheduled.item,
                 result: "scheduled_next",
                 disposition: "continuation_pending",
-                controlActionId,
+                controlActionId: scheduled.action.id,
                 activeGenerationId: scheduled.action.expectedGenerationId ?? null,
                 queueVersion: scheduled.item.version,
                 transcriptEventId: null,
@@ -1891,7 +1819,7 @@ export function chatRoutes(db, storage, backgroundRuntime = createChatBackground
         const expectedControlVersion = req.body.expectedControlVersion
             ?? queueSnapshot.activeControlVersion
             ?? 0;
-        const started = await svc.beginSteerControlAction({
+        const startedControl = await steerMessages.beginControlAction({
             orgId: conversation.orgId,
             conversationId: conversation.id,
             itemId: req.params.itemId,
@@ -1900,7 +1828,9 @@ export function chatRoutes(db, storage, backgroundRuntime = createChatBackground
             expectedAttemptEpoch,
             expectedControlVersion,
             requestActor,
+            actor: activityActor,
         });
+        const started = startedControl;
         const durableControlActionId = started.action.id;
         const durableGenerationId = started.action.expectedGenerationId ?? expectedGenerationId;
         const durableAttemptEpoch = started.action.expectedAttemptEpoch ?? expectedAttemptEpoch;
@@ -2189,6 +2119,10 @@ export function chatRoutes(db, storage, backgroundRuntime = createChatBackground
         }
         const releaseGeneration = claimChatGeneration(conversation.id, null, null);
         if (!releaseGeneration) {
+            if (req.body.editUserMessageId) {
+                res.status(409).json({ error: "Stop the current response before editing this message" });
+                return;
+            }
             const item = await svc.createQueuedMessage({
                 orgId: conversation.orgId,
                 conversationId: conversation.id,
@@ -2276,7 +2210,10 @@ export function chatRoutes(db, storage, backgroundRuntime = createChatBackground
             res.status(201).json({ messages: createdMessages });
         }
         catch (err) {
-            logger.warn({ err, conversationId: conversation.id }, "chat assistant reply failed");
+            logger.warn({
+                err: chatAssistantErrorForLog(err),
+                conversationId: conversation.id,
+            }, "chat assistant reply failed");
             if (err instanceof HttpError) {
                 throw err;
             }
@@ -2312,6 +2249,7 @@ export function chatRoutes(db, storage, backgroundRuntime = createChatBackground
         isMultipartRequest,
         uploadedMessageFiles,
         validateUploadedMessageFiles,
+        preflightChatDraft,
         logChatMessagesAdded,
         assertContextLinksBelongToCompany,
         turnContextFromUserMessage,