@rudderhq/server 0.3.6-canary.9 → 0.4.0

package/dist/routes/chats.js

@@ -1,4 +1,4 @@
-import { addChatMessageSchema, chatAutomationCreateFromStructuredPayload, createChatConversationSchema, formatMessengerTitle, updateChatConversationSchema } from "@rudderhq/shared";
+import { addChatMessageSchema, cancelChatQueuedMessageSchema, chatAutomationCreateFromStructuredPayload, createChatConversationSchema, createChatQueuedMessageSchema, forkChatConversationSchema, steerChatQueuedMessageSchema, updateChatConversationSchema, updateChatQueuedMessageSchema } from "@rudderhq/shared";
 import { Router } from "express";
 import multer from "multer";
 import { randomUUID } from "node:crypto";
@@ -11,11 +11,13 @@ import { validate } from "../middleware/validate.js";
 import { assertTimeZone } from "../services/automations.scheduler.js";
 import { chatAgentRunService } from "../services/chat-agent-runs.js";
 import { CHAT_ASSISTANT_USER_ERROR_MESSAGE, chatAssistantService, ChatAssistantStreamError, userVisiblePartialBodyFromError, } from "../services/chat-assistant.js";
-import { cancelAndReleaseActiveChatGeneration, claimChatGeneration, hasActiveChatGeneration } from "../services/chat-generation-locks.js";
+import { cancelAndReleaseActiveChatGeneration, claimChatGeneration, getActiveChatGeneration, hasActiveChatGeneration } from "../services/chat-generation-locks.js";
+import { buildChatTitlePromptFromMessages, chatTitleGenerationService, } from "../services/chat-title-generation.js";
 import { validateCron } from "../services/cron.js";
 import { accessService, agentService, automationService, chatService, goalService, heartbeatService, issueService, logActivity, operatorProfileService, organizationService, productIntelligenceService, projectService, } from "../services/index.js";
 import { sanitizeStartupContextPromptForPersistence } from "../services/runtime-kernel/heartbeat.core.js";
 import { summarizeRuntimeSkillsForTrace } from "../services/runtime-trace-metadata.js";
+import { runtimeResultText, sanitizeGeneratedTitle, } from "../services/title-generation.js";
 import { assertBoard, assertCompanyAccess, getActorInfo } from "./authz.js";
 import { wakeIssueAssigneeAfterChatConversion } from "./chat-issue-assignment-wakeup.js";
 import { registerChatStreamRoutes } from "./chats.stream-routes.js";
@@ -34,9 +36,7 @@ export function chatRoutes(db, storage) {
     const operatorProfiles = operatorProfileService(db);
     const heartbeat = heartbeatService(db);
     const productIntelligence = productIntelligenceService(db);
-    const CHAT_TITLE_SOURCE_LIMIT = 1600;
-    const CHAT_TITLE_MAX_LENGTH = 80;
-    const CHAT_TITLE_REGENERATION_MESSAGE_LIMIT = 12;
+    const chatTitles = chatTitleGenerationService({ chats: svc, productIntelligence });
     const CHAT_ASSISTANT_RECOVERABLE_FAILURE_FALLBACK_MESSAGE = "The assistant reply could not be completed. Rudder saved this attempt for diagnostics; retry when ready.";
     const upload = multer({
         storage: multer.memoryStorage(),
@@ -109,113 +109,12 @@ export function chatRoutes(db, storage) {
     function stringQuery(value) {
         return typeof value === "string" && value.trim().length > 0 ? value.trim() : null;
     }
-    function buildChatTitlePrompt(body, sourceLabel = "First user message") {
-        const normalized = body.replace(/\s+/g, " ").trim();
-        const source = normalized.length > CHAT_TITLE_SOURCE_LIMIT
-            ? `${normalized.slice(0, CHAT_TITLE_SOURCE_LIMIT)}\n\n[Input truncated for title generation.]`
-            : normalized;
-        return [
-            "Generate a concise title for this chat.",
-            "Rules:",
-            "- Return only the title text.",
-            "- No quotes, markdown, emoji, or trailing punctuation.",
-            `- Maximum ${CHAT_TITLE_MAX_LENGTH} characters.`,
-            "",
-            `${sourceLabel}:`,
-            source,
-        ].join("\n");
-    }
-    function runtimeResultText(result) {
-        if (!result || typeof result !== "object")
-            return "";
-        const candidate = result;
-        if (candidate.timedOut === true || candidate.signal !== null || candidate.exitCode !== 0)
-            return "";
-        for (const key of ["output", "stdout", "text", "message", "summary"]) {
-            const value = candidate[key];
-            if (typeof value === "string" && value.trim().length > 0)
-                return value;
-        }
-        if (candidate.resultJson && typeof candidate.resultJson === "object") {
-            const resultJson = candidate.resultJson;
-            for (const key of ["output", "stdout", "text", "message", "summary"]) {
-                const value = resultJson[key];
-                if (typeof value === "string" && value.trim().length > 0)
-                    return value;
-            }
+    function assertChatLocalMutationAllowed(conversation) {
+        if (conversation.mutability === "external_bound_chat") {
+            throw conflict("Fork this Feishu chat to continue in Rudder");
         }
-        return "";
-    }
-    function sanitizeGeneratedChatTitle(raw) {
-        let title = raw
-            .replace(/^```(?:\w+)?\s*/i, "")
-            .replace(/\s*```$/i, "")
-            .trim()
-            .replace(/^#+\s*/, "")
-            .replace(/^[-*]\s*/, "")
-            .replace(/\s+/g, " ")
-            .trim();
-        title = title.replace(/^["'`]+|["'`]+$/g, "").trim();
-        title = title.replace(/[.!?:;]+$/g, "").trim();
-        if (!title)
-            return null;
-        return title.length > CHAT_TITLE_MAX_LENGTH
-            ? title.slice(0, CHAT_TITLE_MAX_LENGTH).trim()
-            : title;
-    }
-    function fallbackChatTitleFromBody(body) {
-        return formatMessengerTitle(body, { max: CHAT_TITLE_MAX_LENGTH });
-    }
-    function buildChatTitlePromptFromMessages(messages) {
-        const source = messages
-            .filter((message) => message.role === "user" || message.role === "assistant")
-            .slice(-CHAT_TITLE_REGENERATION_MESSAGE_LIMIT)
-            .map((message) => `${message.role}: ${message.body}`)
-            .join("\n\n")
-            .trim();
-        return source ? buildChatTitlePrompt(source, "Conversation excerpt") : null;
-    }
-    function startChatTitleGeneration(conversation, body) {
-        if (conversation.title !== "New chat" || body.trim().length === 0)
-            return;
-        const prompt = buildChatTitlePrompt(body);
-        const fallbackTitle = fallbackChatTitleFromBody(body);
-        void (async () => {
-            if (fallbackTitle) {
-                await svc.updateDefaultTitle(conversation.id, fallbackTitle);
-            }
-            try {
-                const result = await productIntelligence.execute({
-                    orgId: conversation.orgId,
-                    purpose: "lightweight",
-                    feature: "chat_title",
-                    prompt,
-                });
-                const title = sanitizeGeneratedChatTitle(runtimeResultText(result));
-                if (title) {
-                    if (fallbackTitle) {
-                        await svc.replaceSystemGeneratedTitle(conversation.id, fallbackTitle, title);
-                    }
-                    else {
-                        await svc.updateDefaultTitle(conversation.id, title);
-                    }
-                }
-            }
-            catch (error) {
-                logger.warn({
-                    err: error,
-                    conversationId: conversation.id,
-                    orgId: conversation.orgId,
-                }, "Failed to generate chat title with organization lightweight model");
-            }
-        })().catch((error) => {
-            logger.warn({
-                err: error,
-                conversationId: conversation.id,
-                orgId: conversation.orgId,
-            }, "Failed to update chat title");
-        });
     }
+    const startChatTitleGeneration = chatTitles.startAutomaticGeneration;
     async function generateChatTitle(orgId, prompt) {
         const result = await productIntelligence.execute({
             orgId,
@@ -223,7 +122,7 @@ export function chatRoutes(db, storage) {
             feature: "chat_title",
             prompt,
         });
-        return sanitizeGeneratedChatTitle(runtimeResultText(result));
+        return sanitizeGeneratedTitle(runtimeResultText(result));
     }
     function positiveIntegerQuery(value, fallback, max) {
         const parsed = Number(value ?? fallback);
@@ -425,6 +324,7 @@ export function chatRoutes(db, storage) {
         return { chatTurnId: userMessage.chatTurnId, turnVariant: userMessage.turnVariant };
     }
     async function addUserMessage(conversation, body, actor, editUserMessageId) {
+        assertChatLocalMutationAllowed(conversation);
         const userMessage = await svc.addUserChatMessage(conversation.id, conversation.orgId, body, editUserMessageId ?? null);
         await logActivity(db, {
             orgId: conversation.orgId,
@@ -445,6 +345,7 @@ export function chatRoutes(db, storage) {
         return userMessage;
     }
     async function addAgentAuthoredMessage(conversation, body, actor) {
+        assertChatLocalMutationAllowed(conversation);
         if (!actor.agentId) {
             throw forbidden("Agent authentication required");
         }
@@ -475,6 +376,7 @@ export function chatRoutes(db, storage) {
         return message;
     }
     async function attachFilesToUserMessage(conversation, messageId, files, actor) {
+        assertChatLocalMutationAllowed(conversation);
         const attachments = [];
         for (const file of files) {
             const contentType = (file.mimetype || "").toLowerCase();
@@ -1091,6 +993,7 @@ export function chatRoutes(db, storage) {
             res.status(404).json({ error: "Chat conversation not found" });
             return;
         }
+        assertChatLocalMutationAllowed(existing);
         if (req.body.primaryIssueId) {
             const issue = await issuesSvc.getById(req.body.primaryIssueId);
             if (!issue || issue.orgId !== existing.orgId) {
@@ -1137,6 +1040,7 @@ export function chatRoutes(db, storage) {
             res.status(404).json({ error: "Chat conversation not found" });
             return;
         }
+        assertChatLocalMutationAllowed(existing);
         const messages = await svc.listMessages(existing.id, { includeTranscript: false });
         const prompt = buildChatTitlePromptFromMessages(messages);
         if (!prompt) {
@@ -1164,6 +1068,44 @@ export function chatRoutes(db, storage) {
         });
         res.json(updated ? await assistantSvc.enrichConversation(updated) : null);
     });
+    router.post("/chats/:id/fork", validate(forkChatConversationSchema), async (req, res) => {
+        assertBoard(req);
+        const existing = await assertConversationAccess(req, req.params.id);
+        if (!existing) {
+            res.status(404).json({ error: "Chat conversation not found" });
+            return;
+        }
+        const sourceMessageId = req.body.sourceMessageId ?? null;
+        if (!sourceMessageId && hasActiveChatGeneration(existing.id)) {
+            throw conflict("Cannot fork a chat while a reply is in progress");
+        }
+        const actor = getActorInfo(req);
+        const userId = boardUserId(req);
+        const forked = await svc.forkConversation({
+            sourceConversationId: existing.id,
+            orgId: existing.orgId,
+            userId,
+            sourceMessageId,
+            title: req.body.title,
+            createdByUserId: actor.actorType === "user" ? actor.actorId : null,
+        });
+        await logActivity(db, {
+            orgId: existing.orgId,
+            actorType: actor.actorType,
+            actorId: actor.actorId,
+            agentId: actor.agentId,
+            runId: actor.runId,
+            action: "chat.forked",
+            entityType: "chat",
+            entityId: forked?.id ?? "unknown",
+            details: {
+                sourceConversationId: existing.id,
+                sourceMessageId,
+                forkRootConversationId: forked?.forkRootConversationId ?? existing.id,
+            },
+        });
+        res.status(201).json(await assistantSvc.enrichConversation(forked));
+    });
     router.delete("/chats/:id", async (req, res) => {
         assertBoard(req);
         const existing = await assertConversationAccess(req, req.params.id);
@@ -1171,6 +1113,7 @@ export function chatRoutes(db, storage) {
             res.status(404).json({ error: "Chat conversation not found" });
             return;
         }
+        assertChatLocalMutationAllowed(existing);
         if (hasActiveChatGeneration(existing.id)) {
             if (req.query.cancelActive === "true") {
                 cancelAndReleaseActiveChatGeneration(existing.id);
@@ -1209,13 +1152,163 @@ export function chatRoutes(db, storage) {
         });
         res.json(deleted);
     });
+    router.get("/chats/:id/queue", async (req, res) => {
+        const conversation = await assertConversationAccess(req, req.params.id);
+        if (!conversation) {
+            res.status(404).json({ error: "Chat conversation not found" });
+            return;
+        }
+        const active = getActiveChatGeneration(conversation.id);
+        res.json(await svc.getQueueSnapshot(conversation.id, active?.generationId ?? null));
+    });
+    router.post("/chats/:id/queue", validate(createChatQueuedMessageSchema), async (req, res) => {
+        const conversation = await assertConversationAccess(req, req.params.id);
+        if (!conversation) {
+            res.status(404).json({ error: "Chat conversation not found" });
+            return;
+        }
+        assertChatLocalMutationAllowed(conversation);
+        const item = await svc.createQueuedMessage({
+            orgId: conversation.orgId,
+            conversationId: conversation.id,
+            clientMutationId: req.body.clientMutationId,
+            expectedGenerationId: req.body.expectedGenerationId ?? getActiveChatGeneration(conversation.id)?.generationId ?? null,
+            payload: req.body.payload,
+        });
+        const actor = getActorInfo(req);
+        await logActivity(db, {
+            orgId: conversation.orgId,
+            actorType: actor.actorType,
+            actorId: actor.actorId,
+            agentId: actor.agentId,
+            runId: actor.runId,
+            action: "chat.queue.created",
+            entityType: "chat",
+            entityId: conversation.id,
+            details: {
+                queuedMessageId: item.id,
+                position: item.position,
+            },
+        });
+        res.status(201).json(item);
+    });
+    router.post("/chats/:id/queue/next/claim", async (req, res) => {
+        const conversation = await assertConversationAccess(req, req.params.id);
+        if (!conversation) {
+            res.status(404).json({ error: "Chat conversation not found" });
+            return;
+        }
+        assertChatLocalMutationAllowed(conversation);
+        if (hasActiveChatGeneration(conversation.id)) {
+            throw conflict("Cannot dequeue the next message while a reply is in progress");
+        }
+        const latestGeneration = await svc.getLatestGeneration(conversation.id);
+        if (latestGeneration && latestGeneration.status !== "completed") {
+            throw conflict("Queued follow-ups remain parked after a stopped or failed reply");
+        }
+        const item = await svc.claimNextQueuedMessage(conversation.id);
+        if (item) {
+            const actor = getActorInfo(req);
+            await logActivity(db, {
+                orgId: conversation.orgId,
+                actorType: actor.actorType,
+                actorId: actor.actorId,
+                agentId: actor.agentId,
+                runId: actor.runId,
+                action: "chat.queue.claimed",
+                entityType: "chat",
+                entityId: conversation.id,
+                details: {
+                    queuedMessageId: item.id,
+                    position: item.position,
+                },
+            });
+        }
+        res.json({ item });
+    });
+    router.post("/chats/:id/queue/:itemId/release-claim", async (req, res) => {
+        const conversation = await assertConversationAccess(req, req.params.id);
+        if (!conversation) {
+            res.status(404).json({ error: "Chat conversation not found" });
+            return;
+        }
+        assertChatLocalMutationAllowed(conversation);
+        const item = await svc.releaseQueuedMessageClaim({
+            conversationId: conversation.id,
+            itemId: req.params.itemId,
+            reason: "delivery_failed",
+        });
+        res.json({ item });
+    });
+    router.patch("/chats/:id/queue/:itemId", validate(updateChatQueuedMessageSchema), async (req, res) => {
+        const conversation = await assertConversationAccess(req, req.params.id);
+        if (!conversation) {
+            res.status(404).json({ error: "Chat conversation not found" });
+            return;
+        }
+        assertChatLocalMutationAllowed(conversation);
+        const item = await svc.updateQueuedMessage({
+            conversationId: conversation.id,
+            itemId: req.params.itemId,
+            version: req.body.version,
+            payload: req.body.payload,
+        });
+        res.json(item);
+    });
+    router.delete("/chats/:id/queue/:itemId", async (req, res) => {
+        const conversation = await assertConversationAccess(req, req.params.id);
+        if (!conversation) {
+            res.status(404).json({ error: "Chat conversation not found" });
+            return;
+        }
+        assertChatLocalMutationAllowed(conversation);
+        const parsed = cancelChatQueuedMessageSchema.safeParse(req.body ?? {});
+        if (!parsed.success) {
+            res.status(400).json({ error: "Invalid queued message cancel request", details: parsed.error.issues });
+            return;
+        }
+        const item = await svc.cancelQueuedMessage({
+            conversationId: conversation.id,
+            itemId: req.params.itemId,
+            version: parsed.data.version ?? null,
+        });
+        res.json(item);
+    });
+    router.post("/chats/:id/queue/:itemId/steer", validate(steerChatQueuedMessageSchema), async (req, res) => {
+        const conversation = await assertConversationAccess(req, req.params.id);
+        if (!conversation) {
+            res.status(404).json({ error: "Chat conversation not found" });
+            return;
+        }
+        assertChatLocalMutationAllowed(conversation);
+        const active = getActiveChatGeneration(conversation.id);
+        const expected = req.body.expectedActiveGenerationId ?? null;
+        const result = !active?.generationId
+            ? "closing"
+            : expected && expected !== active.generationId
+                ? "stale_generation"
+                : "unsupported";
+        const item = await svc.markQueuedMessageSteerFallback({
+            conversationId: conversation.id,
+            itemId: req.params.itemId,
+            reason: result,
+            activeGenerationId: active?.generationId ?? null,
+        });
+        res.json({
+            item,
+            result: result === "unsupported" ? "queued_fallback" : result,
+            activeGenerationId: active?.generationId ?? null,
+            queueVersion: item.version,
+            transcriptEventId: null,
+        });
+    });
     router.get("/chats/:id/messages", async (req, res) => {
         const conversation = await assertConversationAccess(req, req.params.id);
         if (!conversation) {
             res.status(404).json({ error: "Chat conversation not found" });
             return;
         }
-        if (!hasActiveChatGeneration(conversation.id)) {
+        if (conversation.mutability !== "external_bound_chat" && !hasActiveChatGeneration(conversation.id)) {
             await svc.markInterruptedStreamingMessages(conversation.id);
         }
         const includeTranscript = req.query.includeTranscript === "true";
@@ -1246,6 +1339,7 @@ export function chatRoutes(db, storage) {
             return;
         }
         const actor = getActorInfo(req);
+        assertChatLocalMutationAllowed(conversation);
         if (actor.actorType === "agent") {
             if (req.body.editUserMessageId) {
                 res.status(422).json({ error: "Agent-authored chat messages cannot edit operator messages" });
@@ -1260,16 +1354,34 @@ export function chatRoutes(db, storage) {
             res.status(503).json({ error: assistantAvailability.error });
             return;
         }
-        const releaseGeneration = claimChatGeneration(conversation.id);
+        const releaseGeneration = claimChatGeneration(conversation.id, null, null);
         if (!releaseGeneration) {
-            res.status(409).json({ error: "A chat reply is already being generated for this conversation" });
+            const item = await svc.createQueuedMessage({
+                orgId: conversation.orgId,
+                conversationId: conversation.id,
+                clientMutationId: `message:${randomUUID()}`,
+                expectedGenerationId: getActiveChatGeneration(conversation.id)?.generationId ?? null,
+                payload: {
+                    body: req.body.body,
+                    attachmentIds: [],
+                    skillRefs: [],
+                    projectId: null,
+                    accessMode: null,
+                    model: null,
+                    effort: null,
+                    metadata: {
+                        source: "messages_endpoint_during_active_generation",
+                    },
+                },
+            });
+            res.status(202).json({ queued: item });
             return;
         }
         let chatObservation = null;
         try {
             const userMessage = await addUserMessage(conversation, req.body.body, actor, req.body.editUserMessageId ?? null);
             if (!req.body.editUserMessageId) {
-                startChatTitleGeneration(conversation, req.body.body);
+                startChatTitleGeneration(conversation, userMessage);
             }
             const turnContext = turnContextFromUserMessage(userMessage);
             chatObservation = buildChatObservabilityContext(conversation, {
@@ -1473,6 +1585,7 @@ export function chatRoutes(db, storage) {
         operatorProfiles,
         heartbeat,
         assertConversationAccess,
+        assertChatLocalMutationAllowed,
         boardUserId,
         assertCanAssignTasks,
         runSingleFileUpload,