@rudderhq/cli 0.2.4-canary.0 → 0.2.5-canary.0

package/dist/index.js

@@ -155,7 +155,7 @@ var init_constants = __esm({
       "deliverable",
       "background"
     ];
-    AUTOMATION_STATUSES = ["active", "paused", "archived"];
+    AUTOMATION_STATUSES = ["active", "paused"];
     AUTOMATION_CONCURRENCY_POLICIES = ["coalesce_if_active", "always_enqueue", "skip_if_active"];
     AUTOMATION_CATCH_UP_POLICIES = ["skip_missed", "enqueue_missed_with_cap"];
     AUTOMATION_TRIGGER_SIGNING_MODES = ["bearer", "hmac_sha256"];
@@ -6472,6 +6472,8 @@ var DESKTOP_UPDATE_QUIT_ARG = "--rudder-update-quit";
 var STABLE_SEMVER_RE = /^[0-9]+\.[0-9]+\.[0-9]+$/;
 var CANARY_SEMVER_RE = /^[0-9]+\.[0-9]+\.[0-9]+-canary\.[0-9]+$/;
 var CLI_REGISTRY_LATEST_URL = "https://registry.npmjs.org/@rudderhq%2fcli/latest";
+var LEGACY_UPDATE_QUIT_GRACE_MS = 1e4;
+var UPDATE_QUIT_FORCE_DELAY_MS = 1e3;
 var DESKTOP_APP_NAME = "Rudder";
 var DESKTOP_METADATA_FILE = ".rudder-desktop-install.json";
 var DESKTOP_CHECKSUM_ASSET_NAME = "SHASUMS256.txt";
@@ -7026,6 +7028,30 @@ async function requestDesktopQuit(executablePath, target) {
     await rm2(responsePath, { force: true });
   }
 }
+function processExists(pid) {
+  try {
+    process.kill(pid, 0);
+    return true;
+  } catch (error) {
+    const code = typeof error === "object" && error && "code" in error ? String(error.code) : "";
+    return code === "EPERM";
+  }
+}
+function readUpdateQuitPid(response) {
+  if (!response?.ok || response.status !== "quitting") return null;
+  return typeof response.pid === "number" && Number.isInteger(response.pid) && response.pid > 0 ? response.pid : null;
+}
+function isLegacyUnconfirmedUpdateQuit(response) {
+  return Boolean(response?.ok && response.status === "quitting" && !readUpdateQuitPid(response));
+}
+async function waitForProcessExit(pid, timeoutMs = 2e4, intervalMs = 250) {
+  const startedAt = Date.now();
+  while (Date.now() - startedAt < timeoutMs) {
+    if (!processExists(pid)) return true;
+    await delay(intervalMs);
+  }
+  return !processExists(pid);
+}
 async function removePathWithRetry(targetPath, attempts = 5) {
   for (let attempt = 0; attempt < attempts; attempt += 1) {
     try {
@@ -7038,6 +7064,7 @@ async function removePathWithRetry(targetPath, attempts = 5) {
   return false;
 }
 async function prepareForDesktopReplace(paths, target, options = {}) {
+  const forceQuit = options.forceQuitDesktopProcesses ?? forceQuitDesktopProcesses;
   const hasManagedExecutable = await pathExists(paths.executablePath);
   if (hasManagedExecutable) {
     let quitResponse = await requestDesktopQuit(paths.executablePath, target);
@@ -7053,14 +7080,32 @@ async function prepareForDesktopReplace(paths, target, options = {}) {
         `Rudder Desktop has ${quitResponse.totalRuns} active run${quitResponse.totalRuns === 1 ? "" : "s"}. Stop active work, then rerun start.`
       );
     }
-    await delay(1e3);
+    const quitPid = readUpdateQuitPid(quitResponse);
+    if (quitPid) {
+      p13.log.info(`Waiting for existing Rudder Desktop process ${quitPid} to exit before replacing it.`);
+      if (!await waitForProcessExit(quitPid)) {
+        p13.log.warn(`Rudder Desktop process ${quitPid} did not exit in time; attempting force-quit fallback.`);
+        forceQuit(target);
+        await delay(options.updateQuitForceDelayMs ?? UPDATE_QUIT_FORCE_DELAY_MS);
+      }
+    } else if (isLegacyUnconfirmedUpdateQuit(quitResponse)) {
+      const graceMs = options.legacyUpdateQuitGraceMs ?? LEGACY_UPDATE_QUIT_GRACE_MS;
+      p13.log.warn(
+        `Existing Rudder Desktop acknowledged update quit without a process id; waiting ${Math.ceil(graceMs / 1e3)}s before force-quit fallback.`
+      );
+      await delay(graceMs);
+      forceQuit(target);
+      await delay(options.updateQuitForceDelayMs ?? UPDATE_QUIT_FORCE_DELAY_MS);
+    } else {
+      await delay(options.updateQuitForceDelayMs ?? UPDATE_QUIT_FORCE_DELAY_MS);
+    }
   } else if (!isRunningInsideDesktopExecutable()) {
-    forceQuitDesktopProcesses(target);
+    forceQuit(target);
   }
   const replacePath = target.platform === "windows" ? paths.installRoot : paths.appPath;
   if (await removePathWithRetry(replacePath)) return;
-  forceQuitDesktopProcesses(target);
-  await delay(1e3);
+  forceQuit(target);
+  await delay(options.updateQuitForceDelayMs ?? UPDATE_QUIT_FORCE_DELAY_MS);
   if (await removePathWithRetry(replacePath, 6)) return;
   throw new Error(`Failed to replace existing Rudder Desktop at ${replacePath}. Close Rudder and rerun start.`);
 }
@@ -9780,6 +9825,18 @@ var AGENT_CLI_CAPABILITIES = [
     requiresRunId: false,
     attachesRunIdWhenAvailable: false
   },
+  {
+    id: "agent.skills.create",
+    command: "rudder agent skills create [agent-id] --name <name> [--enable]",
+    category: "agent",
+    description: "Create an agent-private skill package under AGENT_HOME/skills.",
+    mutating: true,
+    contract: "agent-v1",
+    requiresOrgId: false,
+    requiresAgentId: false,
+    requiresRunId: false,
+    attachesRunIdWhenAvailable: true
+  },
   {
     id: "agent.skills.enable",
     command: "rudder agent skills enable <agent-id> <selection-ref...>",
@@ -9868,7 +9925,7 @@ var AGENT_CLI_CAPABILITIES = [
     id: "agent.icons",
     command: "rudder agent icons",
     category: "agent",
-    description: "List allowed agent icon names for create and hire payloads.",
+    description: "List legacy named agent icons for compatibility/debugging; normal create and hire payloads should omit icon.",
     mutating: false,
     contract: "compat",
     requiresOrgId: false,
@@ -10394,6 +10451,9 @@ function registerIssueCommands(program) {
           reopen: opts.reopen
         });
         const comment = await ctx.api.post(`/api/issues/${issueId}/comments`, payload);
+        if (!isIssueCommentResponse(comment)) {
+          throw new Error("Issue comment request completed without a persisted comment response");
+        }
         printOutput(comment, { json: ctx.json });
       } catch (err) {
         handleCommandError(err);
@@ -10681,6 +10741,11 @@ function parseReviewDecision(value) {
   }
   throw new Error("Invalid review decision. Use approve, request_changes, needs_followup, or blocked.");
 }
+function isIssueCommentResponse(value) {
+  return Boolean(
+    value && typeof value.id === "string" && value.id.trim().length > 0 && typeof value.issueId === "string" && value.issueId.trim().length > 0 && typeof value.body === "string"
+  );
+}
 function filterIssueRows(rows, match) {
   if (!match?.trim()) return rows;
   const needle = match.trim().toLowerCase();
@@ -11094,6 +11159,58 @@ function registerAgentCommands(program) {
     })
   );
   const skills = agent.command("skills").description("Agent skill selection operations");
+  addCommonClientOptions(
+    skills.command("create").description(getAgentCliCapabilityById("agent.skills.create").description).argument("[agent-id]", "Agent ID; defaults to RUDDER_AGENT_ID").requiredOption("--name <name>", "Skill display name").option("--slug <slug>", "Skill short name").option("--description <text>", "Skill description").option("--markdown <markdown>", "Full SKILL.md content").option("--markdown-file <path>", "Read full SKILL.md content from a local file").option("--enable", "Enable the created private skill for future runs").action(async (agentIdArg, opts) => {
+      try {
+        const ctx = resolveCommandContext(opts);
+        const agentId = agentIdArg?.trim() || ctx.agentId;
+        if (!agentId) {
+          throw new Error("Agent ID is required. Pass [agent-id] or set RUDDER_AGENT_ID.");
+        }
+        if (opts.markdown && opts.markdownFile) {
+          throw new Error("Pass only one of --markdown or --markdown-file.");
+        }
+        const markdown = opts.markdownFile ? await fs14.readFile(path18.resolve(opts.markdownFile), "utf8") : opts.markdown;
+        const payload = organizationSkillCreateSchema.parse({
+          name: opts.name,
+          slug: opts.slug?.trim() || null,
+          description: opts.description?.trim() || null,
+          markdown: markdown ?? null
+        });
+        const created = await ctx.api.post(
+          `/api/agents/${encodeURIComponent(agentId)}/skills/private`,
+          payload
+        );
+        if (!created) {
+          throw new Error("Failed to create agent skill");
+        }
+        let enabledSnapshot = null;
+        if (opts.enable) {
+          enabledSnapshot = await ctx.api.post(
+            `/api/agents/${encodeURIComponent(agentId)}/skills/enable`,
+            { skills: [created.selectionKey] }
+          );
+        }
+        const result = { created, enabledSnapshot };
+        if (ctx.json) {
+          printOutput(result, { json: true });
+          return;
+        }
+        console.log(
+          formatInlineRecord({
+            key: created.key,
+            selectionKey: created.selectionKey,
+            sourceClass: created.sourceClass,
+            sourcePath: created.sourcePath,
+            enabled: Boolean(enabledSnapshot?.desiredSkills.includes(created.selectionKey)),
+            detail: opts.enable ? "Created and enabled. Future runs will load this skill." : "Created, not enabled. Future runs will not load it until enabled."
+          })
+        );
+      } catch (err) {
+        handleCommandError(err);
+      }
+    })
+  );
   addCommonClientOptions(
     skills.command("enable").description(getAgentCliCapabilityById("agent.skills.enable").description).argument("<agentId>", "Agent ID").argument("<selectionRefs...>", "Skill selection refs to enable").action(async (agentId, selectionRefs, opts) => {
       try {
@@ -12031,11 +12148,47 @@ async function runCli(argv = process.argv) {
   }
 }
 
+// src/stdio.ts
+async function flushWritableStream(stream) {
+  if (stream.destroyed || stream.writable === false) return;
+  await new Promise((resolve, reject) => {
+    let settled = false;
+    const cleanup = () => {
+      stream.off?.("error", onError);
+    };
+    const finish = (error) => {
+      if (settled) return;
+      settled = true;
+      cleanup();
+      if (error && !isBrokenPipeError(error)) reject(error);
+      else resolve();
+    };
+    const onError = (error) => {
+      finish(error);
+    };
+    stream.once?.("error", onError);
+    try {
+      stream.write("", finish);
+    } catch (error) {
+      finish(error instanceof Error ? error : new Error(String(error)));
+    }
+  });
+}
+async function flushProcessOutputBeforeExit(streams = {}) {
+  const stdout = streams.stdout ?? process.stdout;
+  const stderr = streams.stderr ?? process.stderr;
+  await Promise.all([
+    flushWritableStream(stdout),
+    flushWritableStream(stderr)
+  ]);
+}
+function isBrokenPipeError(error) {
+  return error.code === "EPIPE";
+}
+
 // src/index.ts
 void runCli(process.argv).then(async (exitCode) => {
-  if (process.stdout.writableNeedDrain) {
-    await new Promise((resolve) => process.stdout.once("drain", resolve));
-  }
+  await flushProcessOutputBeforeExit();
   process.exit(exitCode);
 });
 export {