@rubytech/create-realagent-code 0.1.570 → 0.1.572

package/payload/platform/services/claude-session-manager/dist/http-server.js

@@ -1122,11 +1122,12 @@ export function buildHttpApp(deps) {
         const initialMessage = typeof body.initialMessage === 'string' && body.initialMessage.length > 0
             ? body.initialMessage
             : undefined;
-        // Task 1483 — a WhatsApp passive account-manager spawn. `passive` selects the
+        // Task 1483 — a WhatsApp passive account-manager spawn selects the
         // work-create-only, no-reply surface; `targetAccountId` (shape-gated like an
-        // account dir) scopes the spawn to the sub-account. Both are ignored unless
-        // the role is public (passive rides the public restricted path).
-        const passive = body.passive === true;
+        // account dir) scopes the spawn to the sub-account. Task 2334 — the flag
+        // itself is read once, by `parseSpawnRole` above, and reaches every site in
+        // this handler as `agentRole === 'passive'`. A second read here would be a
+        // second definition of the same invariant.
         const targetAccountId = typeof body.targetAccountId === 'string' && /^[A-Za-z0-9_-]{1,64}$/.test(body.targetAccountId)
             ? body.targetAccountId
             : undefined;
@@ -1225,7 +1226,15 @@ export function buildHttpApp(deps) {
             ? `array(${body.dormantPlugins.length})`
             : body.dormantPlugins == null ? 'absent' : typeof body.dormantPlugins;
         const initialMessageBytes = typeof body.initialMessage === 'string' ? Buffer.byteLength(body.initialMessage, 'utf8') : 0;
-        deps.logger(`spawn-request senderId=${senderId || 'missing'} userId=${userId ? userId.slice(0, 8) : 'absent'} role=${role || 'missing'} channel=${channel || 'missing'} permissionMode=${typeof body.permissionMode === 'string' ? body.permissionMode : 'default'} channels=${Array.isArray(body.channels) ? body.channels.length : 0} attachmentDir=${typeof body.attachmentDir === 'string' ? 'set' : 'absent'} aboutOwner=${aboutOwnerShape} dormantPlugins=${dormantPluginsShape} tunnelUrl=${typeof body.tunnelUrl === 'string' ? 'set' : (body.tunnelUrl === null ? 'null' : 'absent')} initialMessageBytes=${initialMessageBytes}`);
+        // Task 2334 — `passive` and `specialist` sit beside `role=` because the three
+        // together are what the boundary parse resolves a persona from. Without them
+        // the line could not answer whether a passive-flagged specialist ever arrived,
+        // which is the question this task had to trace through the issuers instead.
+        // `body.passive === true` is the WIRE shape, deliberately not the resolved
+        // role: this line reports what was sent, and `role=` already reports what it
+        // resolved to. `specialist` is the shape-gated value, so a body whose field
+        // failed the slug pattern reports `absent` — what every downstream site sees.
+        deps.logger(`spawn-request senderId=${senderId || 'missing'} userId=${userId ? userId.slice(0, 8) : 'absent'} role=${role || 'missing'} passive=${body.passive === true} specialist=${specialist ?? 'absent'} channel=${channel || 'missing'} permissionMode=${typeof body.permissionMode === 'string' ? body.permissionMode : 'default'} channels=${Array.isArray(body.channels) ? body.channels.length : 0} attachmentDir=${typeof body.attachmentDir === 'string' ? 'set' : 'absent'} aboutOwner=${aboutOwnerShape} dormantPlugins=${dormantPluginsShape} tunnelUrl=${typeof body.tunnelUrl === 'string' ? 'set' : (body.tunnelUrl === null ? 'null' : 'absent')} initialMessageBytes=${initialMessageBytes}`);
         if (!senderId || parsedRole === null || agentRole === null || !CHANNELS.includes(channel)) {
             // Task 2325 — emitted only when the ROLE is what failed. The guard also
             // covers a missing senderId and a bad channel, and naming those
@@ -1264,10 +1273,13 @@ export function buildHttpApp(deps) {
         }
         // Task 1489 — a passive intake spawn rides role:'public' on this path but is
         // a trusted, sub-account-bound account manager, not an anonymous visitor. It
-        // is exempt from the anonymous-visitor limiter: `!passive` keeps a manager's
-        // requirement burst from being throttled, and keeps that burst from consuming
-        // (or being throttled by) the shared per-sender/global anonymous budget.
-        if (role === 'public' && !passive) {
+        // is exempt from the anonymous-visitor limiter: keeping a manager's
+        // requirement burst out of the limiter stops it being throttled, and stops it
+        // consuming (or being throttled by) the shared per-sender/global anonymous
+        // budget. Task 2334 — the exemption is expressed as `agentRole === 'public'`,
+        // which is exactly "the wire role was public and the passive resolution did
+        // not fire", rather than re-deriving that from the raw flag.
+        if (agentRole === 'public') {
             const decision = deps.publicSpawnLimiter.admit(senderId, channel);
             if (!decision.admitted) {
                 deps.logger(`spawn-rate-limited senderId=${senderId} channel=${channel} scope=${decision.scope} window=${decision.windowMs} cap=${decision.cap}`);
@@ -1328,7 +1340,11 @@ export function buildHttpApp(deps) {
         // assignment so the task always lands on a real admin. Undefined only when the
         // install has no live house admin at all (genuine drift — no edge is written).
         let assignedAdminUserId;
-        if (passive && role === 'public' && !specialist && targetAccountId) {
+        // Task 2334 — the three conjuncts this replaced (passive + role:'public' +
+        // no specialist) were the resolution rule restated. `agentRole === 'passive'`
+        // IS that rule, so the transcript scope can no longer diverge from the
+        // work-MCP graph scope, which reads the same resolved role in the spawner.
+        if (agentRole === 'passive' && targetAccountId) {
             const accountsRoot = join(dirname(deps.platformRoot), 'data', 'accounts');
             const accountJsonPath = join(accountsRoot, targetAccountId, 'account.json');
             if (!existsSync(accountJsonPath)) {
@@ -1401,7 +1417,11 @@ export function buildHttpApp(deps) {
                 // notify so its work-create is not logged as anonymous `role=public`
                 // activity and its exit does not emit a spurious webchat no-record. It
                 // gets the one-shot auto-close instead.
-                if (!passive) {
+                //
+                // Task 2334 — the resolved role. For a wire role of 'admin' this now
+                // enters the branch where the raw flag skipped it; both callees return
+                // immediately on `role !== 'public'` (:847, :877), so nothing changes.
+                if (agentRole !== 'passive') {
                     // Task 2271 — `spawnCwd` here is the re-scoped value, so the audit
                     // follows a public-agent session into its own account's slug.
                     attachPublicAudit(deps, tracker.sessionId, parsedRole.role, spawnCwd);
@@ -1418,8 +1438,13 @@ export function buildHttpApp(deps) {
                     }
                 }
                 attachSpecialistEndTurnAutoArchive(deps, tracker.sessionId, tracker.specialist);
-                attachPassiveEndTurnAutoClose(deps, tracker.sessionId, passive);
-                attachPassiveSpawnToolsCensus(deps, spawnCwd, tracker.sessionId, passive, Boolean(assignedAdminUserId));
+                // Task 2334 — the RESOLVED role, not the raw flag. `parseSpawnRole`
+                // already applied the Task 1483 invariant (a passive spawn rides
+                // role:'public' and is never a specialist); reading the raw boolean
+                // here re-derived it, and got it wrong for a passive flag on an admin
+                // spawn, which the invariant says to ignore and this attached anyway.
+                attachPassiveEndTurnAutoClose(deps, tracker.sessionId, agentRole === 'passive');
+                attachPassiveSpawnToolsCensus(deps, spawnCwd, tracker.sessionId, agentRole === 'passive', Boolean(assignedAdminUserId));
             },
             onUrlCaptured: notifyUrlCaptured,
             tunnelUrlOverride,