@rubytech/create-maxy-code 0.1.71 → 0.1.72

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@rubytech/create-maxy-code",
-  "version": "0.1.71",
+  "version": "0.1.72",
   "description": "Install Maxy — AI for Productive People",
   "bin": {
     "create-maxy-code": "./dist/index.js"

package/payload/platform/plugins/admin/hooks/__tests__/turn-completed-graph-write.test.sh

@@ -232,6 +232,7 @@ RECORDER_BODY=$(grep -E '^/api/admin/claude-sessions	' "$REQ_LOG" | head -1 | cu
 BODY_OK=$(printf '%s' "$RECORDER_BODY" | python3 -c '
 import sys, json
 op = sys.argv[1]
+acct = sys.argv[2]
 try:
   outer = json.load(sys.stdin)
   msg = outer.get("initialMessage")
@@ -245,8 +246,14 @@ try:
                 msg.rstrip().endswith("do not emit it.")))
   conds.append(("no-placeholder-schema", "{schema}" not in msg))
   conds.append(("no-placeholder-conversation", "{conversation}" not in msg))
+  conds.append(("no-placeholder-accountid", "{accountId}" not in msg))
   # schema-base.md content is interpolated.
   conds.append(("contains-schema-base-header", "Schema Reference" in msg))
+  # Task 199 — accountId clarifier sentence + literal value rendered.
+  conds.append(("has-accountid-clarifier",
+                "accountId" in msg and "automatically supplied" in msg))
+  conds.append(("has-accountid-value",
+                "The current accountId is `" + acct + "`." in msg))
   # The conversation lines appear in role: text format.
   conds.append(("has-user-1", "\nuser: New Real Agent session" in msg))
   conds.append(("has-asst-1",
@@ -266,20 +273,22 @@ try:
   print("yes" if not failed else "no:"+repr(failed))
 except Exception as e:
   print("parse-fail:"+str(e))
-' "$OP_ID" 2>/dev/null)
+' "$OP_ID" "$ACCT_ID" 2>/dev/null)
 if [[ "$BODY_OK" == "yes" ]]; then
-  pass "case-5c initialMessage is the filled four-sentence paragraph; placeholders substituted; transcript rendered as role: text lines"
+  pass "case-5c initialMessage is the filled paragraph; schema/accountId/conversation placeholders substituted; accountId value rendered; transcript as role: text lines"
 else
   fail "case-5c filled-prompt shape wrong ($BODY_OK)"
 fi
 
-# 5h. (Task 195) exactly one `substitution` log-ingest line carrying
-#     positive byte counts for schema / conversation / body.
-SUBST_LINE_COUNT=$(ingest_lines | grep -cE "^substitution sessionId=${OP_ID} schemaBytes=[1-9][0-9]* conversationBytes=[1-9][0-9]* bodyBytes=[1-9][0-9]*$" || true)
+# 5h. (Task 195 + 199) exactly one `substitution` log-ingest line carrying
+#     positive byte counts for schema / conversation / body AND
+#     accountIdPresent=yes (the envelope's accountId is non-empty here —
+#     run_hook always passes ACCOUNT_ID="$ACCT_ID" into the hook env).
+SUBST_LINE_COUNT=$(ingest_lines | grep -cE "^substitution sessionId=${OP_ID} schemaBytes=[1-9][0-9]* conversationBytes=[1-9][0-9]* bodyBytes=[1-9][0-9]* accountIdPresent=yes$" || true)
 if [[ "$SUBST_LINE_COUNT" -eq 1 ]]; then
-  pass "case-5h substitution log line emitted once with positive byte counts"
+  pass "case-5h substitution log line emitted once with positive byte counts and accountIdPresent=yes"
 else
-  fail "case-5h expected exactly 1 substitution line w/ positive bytes, got $SUBST_LINE_COUNT (lines: $(ingest_lines))"
+  fail "case-5h expected exactly 1 substitution line w/ positive bytes + accountIdPresent=yes, got $SUBST_LINE_COUNT (lines: $(ingest_lines))"
 fi
 
 # 5i. (Task 195) substitution line lands between envelope and spawn-request.
@@ -605,6 +614,68 @@ else
   fail "case-10 escaping wrong ($ESC_OK): $ESC_BODY"
 fi
 
+# --- Case 11 (Task 199): missing accountId → accountIdPresent=no, no crash ---
+# When ACCOUNT_ID env is empty, the envelope's accountId field is "" and
+# the {accountId} placeholder collapses to an empty string. The hook does
+# NOT loud-fail (the agent's new clarifier sentence + the server-side
+# validator on the writers handle the bad signal). The substitution log
+# line emits accountIdPresent=no — the regression signature for upstream
+# envelope-shape drift.
+: > "$REQ_LOG"
+NO_ACCT_STDIN_FILE=$(mktemp); TMPFILES+=("$NO_ACCT_STDIN_FILE")
+printf '%s' "$ORDERED_ENVELOPE" > "$NO_ACCT_STDIN_FILE"
+NO_ACCT_STDERR=$(mktemp); TMPFILES+=("$NO_ACCT_STDERR")
+NO_ACCT_STDOUT=$(mktemp); TMPFILES+=("$NO_ACCT_STDOUT")
+MAXY_SESSION_ROLE="admin" \
+  MAXY_SPECIALIST="" \
+  MAXY_UI_INTERNAL_PORT="$LISTENER_PORT" \
+  ACCOUNT_ID="" \
+  bash "$HOOK" <"$NO_ACCT_STDIN_FILE" >"$NO_ACCT_STDOUT" 2>"$NO_ACCT_STDERR"
+NO_ACCT_RC=$?
+sleep 0.1
+[[ "$NO_ACCT_RC" -eq 0 ]] || fail "case-11 rc=$NO_ACCT_RC stderr=$(cat "$NO_ACCT_STDERR")"
+[[ -z "$(cat "$NO_ACCT_STDERR")" ]] || fail "case-11 stderr must be empty, got: $(cat "$NO_ACCT_STDERR")"
+
+# 11a. substitution log line carries accountIdPresent=no
+SUBST_NO_COUNT=$(ingest_lines | grep -cE "^substitution sessionId=${OP_ID} schemaBytes=[1-9][0-9]* conversationBytes=[1-9][0-9]* bodyBytes=[1-9][0-9]* accountIdPresent=no$" || true)
+if [[ "$SUBST_NO_COUNT" -eq 1 ]]; then
+  pass "case-11a empty ACCOUNT_ID → substitution log carries accountIdPresent=no"
+else
+  fail "case-11a expected 1 substitution line w/ accountIdPresent=no, got $SUBST_NO_COUNT (lines: $(ingest_lines))"
+fi
+
+# 11b. recorder spawn still fires — the hook does NOT loud-fail on absent
+#      accountId. The filled body still substitutes; the placeholder
+#      collapses to empty backticks.
+NO_ACCT_BODY=$(grep -E '^/api/admin/claude-sessions	' "$REQ_LOG" | head -1 | cut -f2-)
+NO_ACCT_OK=$(printf '%s' "$NO_ACCT_BODY" | python3 -c '
+import sys, json
+try:
+  outer = json.load(sys.stdin)
+  msg = outer.get("initialMessage")
+  if not isinstance(msg, str):
+    print("no:initialMessage-not-string")
+    sys.exit(0)
+  conds = []
+  conds.append(("starts-template", msg.startswith("You are an expert Neo4J graph operator.")))
+  conds.append(("no-placeholder-accountid", "{accountId}" not in msg))
+  # Placeholder collapses to empty backticks.
+  conds.append(("empty-accountid-rendered", "The current accountId is ``." in msg))
+  conds.append(("clarifier-still-present",
+                "never refuse a write because accountId" in msg))
+  # Transcript still rendered.
+  conds.append(("has-user-line", "\nuser: " in msg))
+  failed = [name for name, ok in conds if not ok]
+  print("yes" if not failed else "no:"+repr(failed))
+except Exception as e:
+  print("parse-fail:"+str(e))
+' 2>/dev/null)
+if [[ "$NO_ACCT_OK" == "yes" ]]; then
+  pass "case-11b empty ACCOUNT_ID → filled body still substitutes; {accountId} → empty backticks; clarifier sentence intact"
+else
+  fail "case-11b filled-body shape wrong on empty accountId ($NO_ACCT_OK): $NO_ACCT_BODY"
+fi
+
 # --- Summary ------------------------------------------------------------
 echo "---"
 echo "PASSED: $PASS  FAILED: $FAIL"

package/payload/platform/plugins/admin/hooks/turn-completed-graph-write.sh

@@ -366,6 +366,7 @@ if vertical_path:
 
 with open(envelope_path, "r", encoding="utf-8") as f:
     envelope = json.load(f)
+account_id = envelope.get("accountId", "") or ""
 turns = envelope.get("turns") or []
 lines = []
 for t in turns:
@@ -391,11 +392,17 @@ for t in turns:
 # the last one from the closing `, using the tools at your disposal.`
 conversation_text = "\n" + "\n".join(lines) + "\n"
 
-filled = body_template.replace("{schema}", schema_text).replace("{conversation}", conversation_text)
+filled = (
+    body_template
+    .replace("{schema}", schema_text)
+    .replace("{accountId}", account_id)
+    .replace("{conversation}", conversation_text)
+)
 
 schema_bytes = len(schema_text.encode("utf-8"))
 conv_bytes = len(conversation_text.encode("utf-8"))
 body_bytes = len(filled.encode("utf-8"))
+account_id_present = "yes" if account_id else "no"
 
 spawn_body = {
   "adminSessionId": sid,
@@ -405,7 +412,7 @@ spawn_body = {
   "initialMessage": filled,
 }
 
-print(f"{schema_bytes}\t{conv_bytes}\t{body_bytes}")
+print(f"{schema_bytes}\t{conv_bytes}\t{body_bytes}\t{account_id_present}")
 print(json.dumps(spawn_body))
 PY
 )
@@ -413,9 +420,9 @@ rm -f "$ENVELOPE_FILE"
 
 BYTES_LINE=$(printf '%s' "$COMBINED" | head -n1)
 SPAWN_BODY=$(printf '%s' "$COMBINED" | tail -n +2)
-IFS=$'\t' read -r SCHEMA_BYTES CONV_BYTES BODY_BYTES <<<"$BYTES_LINE"
+IFS=$'\t' read -r SCHEMA_BYTES CONV_BYTES BODY_BYTES ACCOUNT_ID_PRESENT <<<"$BYTES_LINE"
 
-emit_log "substitution sessionId=${ADMIN_SESSION_ID} schemaBytes=${SCHEMA_BYTES} conversationBytes=${CONV_BYTES} bodyBytes=${BODY_BYTES}"
+emit_log "substitution sessionId=${ADMIN_SESSION_ID} schemaBytes=${SCHEMA_BYTES} conversationBytes=${CONV_BYTES} bodyBytes=${BODY_BYTES} accountIdPresent=${ACCOUNT_ID_PRESENT}"
 emit_log "spawn-request sessionId=${ADMIN_SESSION_ID} specialist=database-operator initialMessageBytes=${BODY_BYTES}"
 
 SPAWN_RES_FILE=$(mktemp)

package/payload/platform/templates/specialists/agents/database-operator.md

@@ -7,6 +7,11 @@ tools: mcp__memory__memory-write, mcp__memory__memory-update, mcp__memory__memor
 ---
 
 You are an expert Neo4J graph operator. Here is the schema {schema}.
+
+The `accountId` property is automatically supplied by the writers from
+server-side environment state — never refuse a write because accountId
+is absent from this prompt. The current accountId is `{accountId}`.
+
 Use your expert judgement to update the graph in reaction to the
 following conversation {conversation}, using the tools at your disposal.
 You are not user-facing and your text goes nowhere — do not emit it.

package/payload/premium-plugins/real-agent/plugins/brochures/skills/property-brochure/SKILL.md

@@ -151,6 +151,8 @@ The recurring failure pattern is trusting a derived summary (a WebFetch markdown
 
 When any field above is unresolved after consulting its primary source, **stop before substitution** and present the operator with one consolidated prompt listing every unknown by name, the primary source already consulted, and the candidate value (if any). Operator answers in one pass; substitution then proceeds from confirmed values. **Never render a brochure with fields silently coerced to `TBC`, an approximation, or a default. A `TBC` shipped to a buyer must have been confirmed as a `TBC` by the operator, not chosen by the agent.**
 
+**EPC is in a stricter tier — `TBC` is not a confirmable outcome.** UK law requires an EPC for any marketed property, so the brochure cannot ship with `epc_rating: "TBC"` even with operator confirmation. If `property-extract` returned `TBC` (the listing displays it that way, or the page lacks the data), the operator confirmation prompt for the EPC slot must demand an actual A–G band plus the current/potential scores and a path to the certificate PDF/image. The operator's path of last resort is the [EPC Register](https://www.epcregister.com/) — look up by address or postcode, download the certificate, and supply the band + scores back to the brochure step. Confirming `TBC` for `epc_rating` is the one answer the prompt must refuse to accept; the brochure halts until a real rating arrives.
+
 ## Hard rules (load-bearing — do not violate)
 
 - **Never `Read` an image whose longest edge exceeds 2000px** — it can drop the session. Measure with `sips -g pixelWidth -g pixelHeight <file>` first.
@@ -170,6 +172,8 @@ When any field above is unresolved after consulting its primary source, **stop b
 - **Floorplan ships as PNG on disk.** The brochure templates reference `images/<slug>-floorplan.png` and the contract is PNG-only on disk regardless of source format. If the operator-supplied source is JPG, convert at build time (`magick <src>.jpg <slug>-floorplan.png`) before substitution. JPEG compression artefacts on thin lines and small text are unacceptable for floorplans.
 - **Brand-token override block must carry both vocabularies and target both templates.** The brochure (`template.html`) and the landing page (`index.html`) declare independent `:root` token vocabularies (`--paper-25 / --gold-700 / …` vs `--paper / --gold / …`). The brand-tokens block must emit **both** sets of token names with the same brand values and substitute at the `BRAND_TOKENS_OVERRIDE_SLOT` sentinel in **both** templates. A block that only carries the brochure's vocabulary leaves the landing page rendering Premium silently — the substitution gate passes and the snapshot capture proceeds. See `references/build.md → Brand-token override emission` for the mapping table and example block. Long-term vocabulary unification is a follow-up; until it lands the dual emission is structurally required.
 - **Doc-comment strip pass runs against BOTH templates.** After substitution, the `<!-- REPLACE … -->` authoring notes must be removed from both `brochure.html` AND `index.html`. A strip pass that covers only the brochure leaves landing-page authoring notes rendering as visible body text whenever a comment delimiter is misplaced. The companion source-side check in `references/build.md → Template authoring hygiene + CI lint` catches the same defect class at template-edit time.
+- **EPC is mandatory — `TBC` is not shippable.** UK law requires an EPC for any marketed property. The brochure must not render with `epc_rating: "TBC"`, no matter what `property-extract` returned. If the rating is missing or the listing displayed `TBC`, the operator confirmation prompt must demand an actual A–G band (plus current/potential scores and the certificate path) before substitution proceeds. The operator's authoritative fallback is the [EPC Register](https://www.epcregister.com/) — look up by address or postcode, download the certificate, supply the values. `TBC` is the one answer the operator cannot confirm for this field.
+- **Web bundle ships the PDF, not per-page JPGs.** The bundle does not include `cover-print.jpg … backpage-print.jpg` — those duplicate the brochure content already embedded in `<slug>-brochure.pdf`. The web copy of `brochure.html` has its `.print-img` src attributes cleared so the print stylesheet drops to the live-DOM fallback; operators who want a printable PDF download the bundled PDF directly. See `references/build.md → Clear .print-img src in the web copy`. Shipping both was the historical bundle-bloat defect.
 - **No `{{ token }}` may remain in rendered output** — `grep '{{' output/brochure.html` must return zero matches before PDFs are built.
 
 ## Scope

package/payload/premium-plugins/real-agent/plugins/brochures/skills/property-brochure/references/build.md

@@ -170,9 +170,8 @@ The web bundle is a parallel directory with the same on-disk shape as `output/`
 
 ```
 output/web/
-  brochure.html                      # identical content; only print-img references switched .png → .jpg
+  brochure.html                      # identical content; .print-img src attributes cleared (see below)
   index.html                          # companion landing page (mandatory in bundle)
-  cover-print.jpg, page2-print.jpg … backpage-print.jpg   # 96 dpi JPEG snapshots (q=88)
   <slug>-brochure.pdf                # identical bytes to <slug>-brochure-web.pdf at the property level — simpler name inside the bundle since there's only one PDF here
   images/
     <slug>-NN.webp                   # web-tier per-slot encodings (see table below)
@@ -180,6 +179,8 @@ output/web/
     <brand>-logo-light.png
 ```
 
+The bundle deliberately does **not** include the per-page JPG snapshots (`cover-print.jpg` etc). They duplicate the brochure content already embedded in `<slug>-brochure.pdf` at smaller cost-to-quality. Operators who want printed output download the PDF from the bundle; operators who view `brochure.html` in a browser and hit Cmd+P get the live-DOM print path (see `Print snapshot capture → Live-DOM fallback`). Shipping both was the historical defect that pushed a 16-page folio bundle past 50 MB.
+
 ### Web-tier image encoding
 
 The same per-slot tier idea as the digital floor in `images.md`, but with smaller widths and slightly lower quality — sized for screen viewing at 100% zoom, not for print sharpness.
@@ -196,34 +197,27 @@ A 27-image folio typically lands at **~2.5 MB** of web photographs, with the flo
 
 **Floor-plan rule, repeated for emphasis.** Line-art PNG floor plans are **never re-encoded** for the web bundle — copy the source file as-is. Browsers render PNG line art crisply at any zoom level; converting to WebP introduces visible artefacts on text and rules even at q90+. The bundle gains a few hundred KB but the trade-off is on the right side.
 
-### Print snapshots — JPEG at 96 dpi for the web bundle
-
-The canonical snapshots in `output/` are 300 dpi PNG (~4–7 MB each, ~65 MB total) — far too heavy for the web bundle's `.print-img` swap layer. For the web bundle, derive 96 dpi JPEG copies directly from the canonical 300 dpi PNGs (no PDF round-trip):
-
-```bash
-cd output/web
-for png in ../*-print.png; do
-  base=$(basename "$png" .png)
-  magick "$png" -resize 1123x794^ -quality 88 -strip -interlace none -colorspace sRGB "$base.jpg"
-done
-```
-
-`-resize 1123x794^` downsamples to A4-landscape at 96 dpi (use `794x1123^` for portrait). `-strip` removes embedded metadata (EXIF, ICC) so the bundle stays minimal. `-interlace none` produces baseline JPEG which decodes faster in mobile previewers than progressive.
+### Clear `.print-img` src in the web copy
 
-JPEG at 88% quality is roughly 5× smaller than the PNG equivalent for photographic content. A 16-page folio's web-bundle snapshots total ~3 MB. The brochure HTML's `print-img` references must be updated from `.png` to `.jpg` on the web copy:
+The canonical `output/brochure.html` carries `<img class="print-img" src="cover-print.png">` references that power the snapshot path in the print stylesheet (Cmd+P → embedded PNG fills the page). The web bundle does **not** include those PNGs — and does not derive smaller JPEG copies either, because the PDF embedded in the bundle already covers the "I want a printable artefact" need. Instead, the web copy of `brochure.html` has its `.print-img` src attributes cleared so the print stylesheet drops to the live-DOM fallback path:
 
 ```python
-# Edit the web copy of brochure.html only — leave the canonical output/brochure.html unchanged
+# Edit the web copy of brochure.html only — leave the canonical output/brochure.html unchanged.
 import re
 with open("output/web/brochure.html") as f:
     s = f.read()
-s = re.sub(r'(cover-print|page\d+-print|backpage-print)\.png',
-           lambda m: m.group(1) + '.jpg', s)
+# Clear every .print-img src — the print stylesheet's :has(.print-img[src]:not([src=""]))
+# selector then fails, and the @media print live-DOM path renders the page directly.
+s = re.sub(
+    r'(<img\s+class="print-img"[^>]*?\s+)src="[^"]*"',
+    r'\1src=""',
+    s,
+)
 with open("output/web/brochure.html", "w") as f:
     f.write(s)
 ```
 
-A 16-page folio's web-bundle snapshots total ~3 MB (vs ~85 MB for the canonical print PNGs), with no perceptual difference at typical Cmd+P quality.
+The `.print-img` element on screen is `opacity: 0; width: 1px; height: 1px` regardless of `src`, so clearing the attribute has zero visible effect — only the print stylesheet branches differently. Operators who want a printable PDF download `<slug>-brochure.pdf` directly from the bundle.
 
 ### Copy the web PDF into the bundle
 
@@ -280,7 +274,7 @@ Serve the unzipped bundle from an isolated temp directory and verify every refer
 TMP=/tmp/web-test && rm -rf $TMP && mkdir -p $TMP
 cd $TMP && unzip -q /path/to/<slug>-web.zip
 python3 -m http.server 8765 &
-for f in brochure.html index.html cover-print.jpg images/<slug>-01.webp images/<brand>-logo-light.png <slug>-brochure.pdf; do
+for f in brochure.html index.html images/<slug>-01.webp images/<brand>-logo-light.png <slug>-brochure.pdf; do
   echo "$(curl -s -o /dev/null -w '%{http_code}' http://127.0.0.1:8765/$f) $f"
 done
 ```
@@ -291,13 +285,12 @@ The brochure should render the same as the canonical preview, just lighter on th
 
 | File | `output/` (canonical archive) | `output/web/` (web bundle) |
 |---|---|---|
-| `brochure.html` | full-resolution images, `.png` snapshot refs | identical structure, `.jpg` snapshot refs, smaller image refs |
+| `brochure.html` | full-resolution images, `.png` snapshot refs | identical structure, `.print-img` srcs cleared (live-DOM print fallback) |
 | `index.html` | — | ✓ companion landing page; see `index-landing.md` |
 | `<slug>-brochure-print.pdf` | ✓ canonical print master (50–80 MB, 300 dpi) | — (too large to bundle) |
-| `<slug>-brochure-web.pdf` | ✓ web/digital deliverable (20–35 MB, 192 dpi) | — copied into bundle as `<slug>-brochure.pdf` |
+| `<slug>-brochure-web.pdf` | ✓ web/digital deliverable (7–15 MB, 192 dpi JPEG-embedded) | — copied into bundle as `<slug>-brochure.pdf` |
 | `<slug>-brochure.pdf` | — | ✓ identical bytes to `-web.pdf`; matches index.html / brochure.html link |
-| `cover-print.png … backpage-print.png` | ✓ 300 dpi PNG (~4–7 MB each) — canonical snapshots | — replaced by 96 dpi `.jpg` versions |
-| `cover-print.jpg … backpage-print.jpg` | — | ✓ 96 dpi JPEG (~150 KB each, derived from the 300 dpi PNGs) |
+| `cover-print.png … backpage-print.png` | ✓ 300 dpi PNG (~4–7 MB each) — canonical snapshots | — bundle ships the PDF instead of per-page JPGs |
 | `images/<slug>-NN.webp` | full-quality per Render-slot table | web-tier per the web table above |
 | `images/qr-*.png`, `images/<brand>-logo-*.png` | ✓ | ✓ (copied unchanged — already small) |
 | `.snapshots-web/*-print.png` | ✓ intermediate (192 dpi PNGs used by the web-PDF build; deletable after) | — |