@rubytech/create-maxy-code 0.1.63 → 0.1.65

package/payload/platform/plugins/preval/skills/property-preval/references/__tests__/adherence.test.py

@@ -1,373 +0,0 @@
-"""Adherence-gate tests for property-preval (Tasks 157 + 163).
-
-Covers:
-
-  Task 157 provenance causes (agent didn't invent the input):
-    - cover-hero-not-subject     (slug heuristic; complements 156's symlink check)
-    - agent-listings-invented    (status set when source property.json had null)
-    - market-summary-invented    (origin missing or "agent-invented")
-    - brand-invented             (brand.name without operator override)
-    - log-destination-unavailable (observability emit-or-abort)
-
-  Task 163 causes (replaces 156's sqft gates after EPC removal):
-    - epc-certificate-not-supplied  (any of the three operator-paste EPC
-                                     fields missing — render.py + hook)
-    - observability-missing tool=<name>  (one of the 12 expected
-                                          [property-data] tool=<name> log
-                                          lines absent within the budget)
-
-Plus the PreToolUse hook red-team (blocks the same causes before
-inputs.json reaches disk).
-
-Run with:  python3 references/__tests__/adherence.test.py
-"""
-from __future__ import annotations
-import json, os, struct, subprocess, sys, tempfile, unittest, zlib
-from pathlib import Path
-
-HERE = Path(__file__).resolve().parent
-REFERENCES = HERE.parent
-PLUGIN_ROOT = REFERENCES.parent.parent.parent
-HOOK = PLUGIN_ROOT / "hooks" / "preval-prompt-required.sh"
-
-sys.path.insert(0, str(REFERENCES))
-from render import (  # noqa: E402
-    _assert_inputs,
-    _assert_observability_logs,
-    EXPECTED_PROPERTY_DATA_TOOLS,
-    PrevalAbort,
-)
-
-
-def _write_png(path: Path, w: int = 1600, h: int = 1200) -> None:
-    """Minimal valid PNG large enough to clear Task 156's 1200x800 gate."""
-    def chunk(tag: bytes, data: bytes) -> bytes:
-        return struct.pack(">I", len(data)) + tag + data + struct.pack(">I", zlib.crc32(tag + data) & 0xffffffff)
-    sig = b"\x89PNG\r\n\x1a\n"
-    ihdr = struct.pack(">IIBBBBB", w, h, 8, 2, 0, 0, 0)
-    raw = b"".join(b"\x00" + b"\x00\x00\x00" * w for _ in range(h))
-    idat = zlib.compress(raw)
-    path.write_bytes(sig + chunk(b"IHDR", ihdr) + chunk(b"IDAT", idat) + chunk(b"IEND", b""))
-
-
-def _complete_inputs(tmp: Path) -> dict:
-    """An inputs.json that PASSES every 156 + 157 gate."""
-    hero = tmp / "hero.png"
-    _write_png(hero)
-    return {
-        "out_dir": str(tmp),
-        "filename_stem": "subject",
-        "address": "9 Phoenix Drive, Bishop's Stortford, CM23 2UJ",
-        "postcode": "CM23 2UJ",
-        "generated": "19 May 2026",
-        "brand": {
-            "name": "Muvin",
-            "tagline": "Estate Agents",
-            "primary": "#000", "primary_dark": "#000", "accent": "#000",
-            "paper": "#fff", "paper_banded": "#fff", "rule": "#000",
-        },
-        "subject": {
-            "cover_hero": str(hero),
-            "total_floor_area_m2": 93.2,
-            "current_energy_rating": "C",
-            "lodgement_date": "2018-04-21",
-        },
-        "valuation": {
-            "avg_asking": 500000, "asking_psf": 450, "avg_sold": 480000,
-            "sold_psf": 440, "sold_psf_low": 400, "sold_psf_high": 480,
-            "sold_comps": [], "asking_comps": [],
-        },
-        "area": {
-            "crime_rating": "Low", "flood_risk": "Low", "council_tax_band_d": 2000,
-            "population": 1000, "crime_breakdown": [], "council_tax_bands": [],
-            "headline": "",
-        },
-        "demand_trend": {
-            "demand_rating": "High", "dom": 30, "turnover_pct": 5, "for_sale": 10,
-            "growth_series": [], "growth_psf_series": [],
-            "rental": {"demand_rating": "High", "dom": 20, "turnover_pct": 4, "for_rent": 5},
-            "type_dist": [],
-        },
-        "market_summary": {
-            "headline": "Bishop's Stortford is selling.",
-            "paragraphs": ["The market is active.", "Prices held flat YoY."],
-            "demand_gauge_position": "62%",
-            "price_growth_note": "Up 3% YoY.",
-            "demand_note": "High demand.",
-            "origin": "operator",
-        },
-        "agent_listings": [
-            {
-                "address": "1 Some Road, CM23",
-                "price": 600000,
-                "status": "Sold",
-                "slug": "1-some-road",
-                "origin": "operator",
-            }
-        ],
-        "agent_overrides": {
-            "brand_selected_by_operator": True,
-            "listings_status_curated": False,
-        },
-    }
-
-
-class TestAdherenceGate(unittest.TestCase):
-    def setUp(self):
-        self._tmp = tempfile.TemporaryDirectory()
-        self.tmp = Path(self._tmp.name)
-
-    def tearDown(self):
-        self._tmp.cleanup()
-
-    def _assert_aborts(self, inputs: dict, cause: str):
-        with self.assertRaises(PrevalAbort) as ctx:
-            _assert_inputs(inputs)
-        self.assertEqual(ctx.exception.cause, cause)
-        self.assertFalse(any(self.tmp.glob("*.pdf")))
-
-    def test_clean_run_passes(self):
-        _assert_inputs(_complete_inputs(self.tmp))
-
-    def test_cover_hero_not_subject(self):
-        # Plant the hero PNG in a sister property's folder to trigger the
-        # 157 slug heuristic. 156's symlink check passes (real file, not
-        # a symlink); only the 157 cause should fire.
-        sister = self.tmp / "estate-agents" / "muvin" / "properties" / "07-the-old-orchard-rye-street-cm23"
-        sister.mkdir(parents=True)
-        bad_hero = sister / "hero.png"
-        _write_png(bad_hero)
-        inputs = _complete_inputs(self.tmp)
-        inputs["subject"]["cover_hero"] = str(bad_hero)
-        self._assert_aborts(inputs, "cover-hero-not-subject")
-
-    def test_cover_hero_subject_match_passes(self):
-        subject_dir = self.tmp / "estate-agents" / "muvin" / "properties" / "9-phoenix-drive-cm23-2uj"
-        subject_dir.mkdir(parents=True)
-        good_hero = subject_dir / "hero.png"
-        _write_png(good_hero)
-        inputs = _complete_inputs(self.tmp)
-        inputs["subject"]["cover_hero"] = str(good_hero)
-        _assert_inputs(inputs)
-
-    def test_agent_listings_invented_status(self):
-        source = self.tmp / "source.json"
-        source.write_text(json.dumps({"status": None, "address": "1 Some Road"}))
-        inputs = _complete_inputs(self.tmp)
-        inputs["agent_listings"][0]["origin"] = str(source)
-        inputs["agent_overrides"]["listings_status_curated"] = False
-        self._assert_aborts(inputs, "agent-listings-invented")
-
-    def test_agent_listings_curated_override_passes(self):
-        source = self.tmp / "source.json"
-        source.write_text(json.dumps({"status": None, "address": "1 Some Road"}))
-        inputs = _complete_inputs(self.tmp)
-        inputs["agent_listings"][0]["origin"] = str(source)
-        inputs["agent_overrides"]["listings_status_curated"] = True
-        _assert_inputs(inputs)
-
-    def test_market_summary_invented_missing_origin(self):
-        inputs = _complete_inputs(self.tmp)
-        inputs["market_summary"].pop("origin")
-        self._assert_aborts(inputs, "market-summary-invented")
-
-    def test_market_summary_invented_explicit(self):
-        inputs = _complete_inputs(self.tmp)
-        inputs["market_summary"]["origin"] = "agent-invented"
-        self._assert_aborts(inputs, "market-summary-invented")
-
-    def test_brand_invented(self):
-        inputs = _complete_inputs(self.tmp)
-        inputs["agent_overrides"]["brand_selected_by_operator"] = False
-        self._assert_aborts(inputs, "brand-invented")
-
-    def test_epc_certificate_not_supplied_missing_m2(self):
-        inputs = _complete_inputs(self.tmp)
-        del inputs["subject"]["total_floor_area_m2"]
-        self._assert_aborts(inputs, "epc-certificate-not-supplied")
-
-    def test_epc_certificate_not_supplied_missing_rating(self):
-        inputs = _complete_inputs(self.tmp)
-        inputs["subject"]["current_energy_rating"] = None
-        self._assert_aborts(inputs, "epc-certificate-not-supplied")
-
-    def test_epc_certificate_not_supplied_missing_lodgement(self):
-        inputs = _complete_inputs(self.tmp)
-        inputs["subject"]["lodgement_date"] = ""
-        self._assert_aborts(inputs, "epc-certificate-not-supplied")
-
-
-class TestPreToolUseHook(unittest.TestCase):
-    def _run_hook(self, tool_name: str, file_path: str, content_obj: dict) -> tuple[int, str]:
-        payload = json.dumps({
-            "tool_name": tool_name,
-            "tool_input": {"file_path": file_path, "content": json.dumps(content_obj)},
-        })
-        result = subprocess.run(
-            ["bash", str(HOOK)],
-            input=payload,
-            capture_output=True,
-            text=True,
-        )
-        return result.returncode, result.stderr
-
-    def test_hook_blocks_market_summary_invented(self):
-        with tempfile.TemporaryDirectory() as tmp:
-            inputs = _complete_inputs(Path(tmp))
-            inputs["market_summary"]["origin"] = "agent-invented"
-            code, stderr = self._run_hook(
-                "Write",
-                f"{tmp}/preval/CM232UJ-2026-05-19/inputs.json",
-                inputs,
-            )
-            self.assertEqual(code, 2, msg=stderr)
-            self.assertIn("market-summary-invented", stderr)
-
-    def test_hook_blocks_brand_invented(self):
-        with tempfile.TemporaryDirectory() as tmp:
-            inputs = _complete_inputs(Path(tmp))
-            inputs["agent_overrides"]["brand_selected_by_operator"] = False
-            code, stderr = self._run_hook(
-                "Write",
-                f"{tmp}/preval/CM232UJ-2026-05-19/inputs.json",
-                inputs,
-            )
-            self.assertEqual(code, 2, msg=stderr)
-            self.assertIn("brand-invented", stderr)
-
-    def test_hook_passthrough_unrelated_path(self):
-        code, _ = self._run_hook(
-            "Write",
-            "/tmp/some-other-file.json",
-            {"hello": "world"},
-        )
-        self.assertEqual(code, 0)
-
-    def test_hook_passthrough_unrelated_tool(self):
-        code, _ = self._run_hook(
-            "Bash",
-            "/whatever/preval/inputs.json",
-            {},
-        )
-        self.assertEqual(code, 0)
-
-    def test_hook_blocks_epc_certificate_not_supplied(self):
-        with tempfile.TemporaryDirectory() as tmp:
-            inputs = _complete_inputs(Path(tmp))
-            inputs["subject"]["current_energy_rating"] = None
-            code, stderr = self._run_hook(
-                "Write",
-                f"{tmp}/preval/CM232UJ-2026-05-19/inputs.json",
-                inputs,
-            )
-            self.assertEqual(code, 2, msg=stderr)
-            self.assertIn("epc-certificate-not-supplied", stderr)
-            self.assertIn("current_energy_rating", stderr)
-
-
-class TestObservability(unittest.TestCase):
-    def test_log_destination_unavailable_aborts(self):
-        from render import _pick_log_path
-        ro = Path("/dev/null/cannot-write-here")
-        old_home = os.environ.get("HOME")
-        with tempfile.TemporaryDirectory() as tmp:
-            holder = Path(tmp) / "not-a-dir"
-            holder.write_text("")
-            os.environ["HOME"] = str(holder)
-            try:
-                with self.assertRaises(PrevalAbort) as ctx:
-                    _pick_log_path(ro)
-                self.assertEqual(ctx.exception.cause, "log-destination-unavailable")
-            finally:
-                if old_home is not None:
-                    os.environ["HOME"] = old_home
-                else:
-                    del os.environ["HOME"]
-
-
-class TestObservabilityWatchdog(unittest.TestCase):
-    """Task 163 — 12-call PropertyData fan-out watchdog."""
-
-    def setUp(self):
-        self._tmp = tempfile.TemporaryDirectory()
-        self.tmp = Path(self._tmp.name)
-        self.log_path = self.tmp / "preval.log"
-
-    def tearDown(self):
-        self._tmp.cleanup()
-
-    def _write_log(self, present_tools: list[str]) -> None:
-        lines = [
-            f"[property-data] tool={name} account=local postcode=CM232UJ status=ok ms=42"
-            for name in present_tools
-        ]
-        self.log_path.write_text("\n".join(lines) + "\n")
-
-    def test_all_12_present_passes(self):
-        self._write_log(list(EXPECTED_PROPERTY_DATA_TOOLS))
-        _assert_observability_logs(self.log_path, deadline_s=0.0)
-
-    def test_missing_growth_psf_aborts(self):
-        present = [t for t in EXPECTED_PROPERTY_DATA_TOOLS if t != "property-data-growth-psf"]
-        self._write_log(present)
-        with self.assertRaises(PrevalAbort) as ctx:
-            _assert_observability_logs(self.log_path, deadline_s=0.0)
-        self.assertEqual(
-            ctx.exception.cause,
-            "observability-missing tool=property-data-growth-psf",
-        )
-        self.assertIn("property-data-growth-psf", ctx.exception.hint)
-
-    def test_missing_flood_risk_aborts(self):
-        present = [t for t in EXPECTED_PROPERTY_DATA_TOOLS if t != "property-data-flood-risk"]
-        self._write_log(present)
-        with self.assertRaises(PrevalAbort) as ctx:
-            _assert_observability_logs(self.log_path, deadline_s=0.0)
-        self.assertEqual(
-            ctx.exception.cause,
-            "observability-missing tool=property-data-flood-risk",
-        )
-
-    def test_polls_until_late_arriving_line_lands(self):
-        """The watchdog must keep polling within the budget; a late arrival
-        before the deadline is a pass, not an abort. Wall-clock waits are
-        replaced by injected _now/_sleep so the test stays fast."""
-        present = [t for t in EXPECTED_PROPERTY_DATA_TOOLS if t != "property-data-prices"]
-        self._write_log(present)
-        ticks = iter([0.0, 1.0, 2.0])  # never reaches deadline_s=10
-        appended = []
-
-        def fake_sleep(s):
-            appended.append(s)
-            with self.log_path.open("a") as f:
-                f.write(
-                    "[property-data] tool=property-data-prices account=local postcode=CM232UJ status=ok ms=99\n"
-                )
-
-        _assert_observability_logs(
-            self.log_path,
-            deadline_s=10.0,
-            poll_s=2.0,
-            _now=lambda: next(ticks),
-            _sleep=fake_sleep,
-        )
-        self.assertEqual(appended, [2.0])
-
-    def test_unreadable_log_aborts_at_deadline(self):
-        """A log path that can't be read is treated as missing tools — abort
-        once the budget elapses, name a missing tool. No silent skip."""
-        # Don't write the log file at all.
-        ticks = iter([0.0, 100.0])
-        with self.assertRaises(PrevalAbort) as ctx:
-            _assert_observability_logs(
-                self.log_path,
-                deadline_s=60.0,
-                poll_s=2.0,
-                _now=lambda: next(ticks),
-                _sleep=lambda s: None,
-            )
-        self.assertTrue(ctx.exception.cause.startswith("observability-missing tool="))
-
-
-if __name__ == "__main__":
-    unittest.main()