@rubytech/create-maxy-code 0.1.58 → 0.1.59

package/payload/platform/services/claude-session-manager/dist/http-server.js

@@ -8,14 +8,13 @@
 //   POST   /resume              { senderId, role, channel, sessionId } -> Session
 //   POST   /:id/stop            -> 204 (kill PTY; idempotent on already-dead row)
 //                                 404 if no row matches any of the 4 keys
-//   DELETE /:id                 -> 204 (rmSync JSONL + sidecar + subdir)
+//   DELETE /:id                 -> 204 (rmSync JSONL + subdir)
 //                                 409 if PTY still alive
 //                                 404 if no transcript on disk
 //   POST   /:id/input           { text }
 //   GET    /:id/log             -> { jsonlPath, sizeBytes, exists }
 //   GET    /:id/log?follow=1    -> streamed file content (current + new)
 //   GET    /:id/meta            -> SessionMeta payload
-//   PATCH  /:id                 { displayName } -> 204 (writes sidecar)
 //   POST   /:id/archive         { mode }
 //
 // Any of the four ids — intrinsic sessionId, bridgeSessionId, bridgeSuffix,
@@ -24,10 +23,9 @@
 // manager does not know.
 import { Hono } from 'hono';
 import { stream } from 'hono/streaming';
-import { existsSync, statSync, createReadStream, watchFile, unwatchFile, rmSync, writeFileSync, mkdirSync, renameSync, readFileSync, openSync, readSync, closeSync } from 'node:fs';
-import { createHash } from 'node:crypto';
+import { existsSync, statSync, createReadStream, watchFile, unwatchFile, rmSync, mkdirSync, renameSync, readFileSync } from 'node:fs';
 import { spawnClaudeSession, stopSession, PERMISSION_MODES } from './pty-spawner.js';
-import { readJsonlSession, readSidecar, sidecarPathFor } from './jsonl-enumerator.js';
+import { readJsonlSession } from './jsonl-enumerator.js';
 import { claudeStateRoot, projectSlugForCwd } from './jsonl-path.js';
 import { basename, join } from 'node:path';
 const ROLES = ['admin', 'public'];
@@ -116,7 +114,6 @@ function parseSpecialistDomains(raw) {
 // bridgeSuffix, or pid (numeric). All resolve to a sessionId via watcher.
 const SESSION_ID_PATTERN = /^[A-Za-z0-9_-]{1,128}$/;
 const LIST_TAIL_BYTES = 64 * 1024;
-const DISPLAY_NAME_MAX = 256;
 function timed(logger, method, path, status, ms) {
     logger(`api method=${method} path=${path} outcome=${status} ms=${ms}`);
 }
@@ -140,98 +137,18 @@ function resolveRow(watcher, id) {
     }
     return undefined;
 }
-// Recorder-only auto-archive (Task 114; discriminator updated Task 131).
-// The database-operator session run by `turn-completed-graph-write.sh`
-// is structurally identical to a user-facing admin session — Task 131
-// brings it byte-for-byte close to a Sidebar-shape spawn (real
-// senderId, hidden=false). Its deterministic single-turn lifecycle is
-// enforced here: as soon as the recorder's JSONL contains an assistant
-// message whose `stop_reason === "end_turn"`, the manager stops the PTY
-// against itself and lets the normal archive path run. Recorder
-// detection keys on `originatingSessionId` presence, the one field
-// that is set only for recorder spawns.
+// Task 147 — auto-archive for the database-operator specialist on
+// `end_turn`. The recorder is a Sidebar-equivalent admin spawn whose only
+// override is the specialist value. Once its JSONL contains an assistant
+// message with `stop_reason === "end_turn"`, stop the PTY and let the
+// normal archive path run. No tool-call tally, no recorder-only log
+// surfaces — the Sidebar's `pty-spawned … jsonl … end_turn …
+// auto-archive` lines cover the lifecycle.
 const END_TURN_SIGNATURE = '"stop_reason":"end_turn"';
-/** Hash tool arguments for log correlation without leaking content
- *  (Task 129). Uses sha256(JSON.stringify(args)).slice(0,8). */
-function argHash(toolArgs) {
-    let serialized;
-    try {
-        serialized = JSON.stringify(toolArgs ?? null);
-    }
-    catch {
-        serialized = '<unserializable>';
-    }
-    return createHash('sha256').update(serialized).digest('hex').slice(0, 8);
-}
-/** Sanitize a record's error string for the log line. Strip newlines,
- *  cap at 200 chars. */
-function sanitizeErr(value) {
-    if (typeof value !== 'string')
-        return String(value ?? 'unknown');
-    return value.replace(/[\r\n\t]+/g, ' ').slice(0, 200);
-}
-/** Per-recorder JSONL observer (Task 129). Parses newly-appended bytes
- *  on each modify event and emits one `[turn-recorder] tool-call …` line
- *  per JSONL record carrying a `tool_use` content block, and one
- *  `[turn-recorder] tool-result …` line per record carrying a
- *  `tool_result` content block. Maintains the session's `recorderTally`
- *  as side-effect so `attachRecorderAutoArchive` can read final counts
- *  at `write-complete` time.
- *
- *  Position tracking lives on the StoredSession (`recorderJsonlPosition`)
- *  so re-entry on a modify storm cannot double-emit the same record. */
-function readNewRecords(jsonlPath, fromPos) {
-    if (!existsSync(jsonlPath))
-        return { records: [], newPos: fromPos };
-    const size = statSync(jsonlPath).size;
-    if (size <= fromPos)
-        return { records: [], newPos: fromPos };
-    let buf;
-    try {
-        const fd = openSync(jsonlPath, 'r');
-        try {
-            buf = Buffer.alloc(size - fromPos);
-            readSync(fd, buf, 0, buf.length, fromPos);
-        }
-        finally {
-            closeSync(fd);
-        }
-    }
-    catch {
-        return { records: [], newPos: fromPos };
-    }
-    const text = buf.toString('utf8');
-    // If the last line lacks a newline it is a partial append; rewind so
-    // we re-read it on the next modify.
-    const lastNl = text.lastIndexOf('\n');
-    const completeText = lastNl === -1 ? '' : text.slice(0, lastNl + 1);
-    const advance = Buffer.byteLength(completeText, 'utf8');
-    const lines = completeText.split('\n').filter((l) => l.length > 0);
-    const records = [];
-    for (const line of lines) {
-        try {
-            records.push(JSON.parse(line));
-        }
-        catch {
-            // skip malformed jsonl line — recorder may truncate
-        }
-    }
-    return { records, newPos: fromPos + advance };
-}
-function attachRecorderAutoArchive(deps, session) {
-    // Task 131 — recorder discriminator switched from senderId to
-    // originatingSessionId. The recorder's senderId is now the operator's
-    // accountId (Sidebar-shape parity); originatingSessionId is the only
-    // structural marker that this session is a recorder.
-    if (!session.originatingSessionId)
-        return;
-    if (!session.recorderTally) {
-        deps.logger(`[turn-recorder] auto-archive-attach-skipped recorderSessionId=${session.sessionId} reason=missing-recorder-tally`);
+const AUTO_ARCHIVE_SPECIALIST = 'database-operator';
+function attachSpecialistEndTurnAutoArchive(deps, session) {
+    if (session.specialist !== AUTO_ARCHIVE_SPECIALIST)
         return;
-    }
-    const op = session.originatingSessionId;
-    const rec = session.sessionId;
-    const tally = session.recorderTally;
     let archived = false;
     function endTurnSeen(jsonlPath) {
         try {
@@ -242,72 +159,7 @@ function attachRecorderAutoArchive(deps, session) {
             return false;
         }
     }
-    // Drain newly-appended JSONL records, emit one line per tool_use /
-    // tool_result content block, and update the running tally. The record
-    // shape follows Claude Code's transcript: top-level `type`, a `message`
-    // object with `content[]`, each block carrying `type: 'tool_use' |
-    // 'tool_result'`. Tool results carry `is_error: boolean` on the block;
-    // when absent we treat the call as `ok`.
-    function drainJsonl(jsonlPath) {
-        const startedAtMs = new Map();
-        const { records, newPos } = readNewRecords(jsonlPath, session.recorderJsonlPosition ?? 0);
-        session.recorderJsonlPosition = newPos;
-        for (const rec0 of records) {
-            if (!rec0 || typeof rec0 !== 'object')
-                continue;
-            const top = rec0;
-            const ts = typeof top.timestamp === 'string' ? Date.parse(top.timestamp) : Date.now();
-            const message = top.message;
-            if (!message || typeof message !== 'object')
-                continue;
-            const content = message.content;
-            if (!Array.isArray(content))
-                continue;
-            for (const block of content) {
-                if (!block || typeof block !== 'object')
-                    continue;
-                const b = block;
-                if (b.type === 'tool_use') {
-                    tally.calls += 1;
-                    const name = typeof b.name === 'string' ? b.name : 'unknown';
-                    const id = typeof b.id === 'string' ? b.id : '';
-                    if (id)
-                        startedAtMs.set(id, ts);
-                    deps.logger(`[turn-recorder] tool-call sessionId=${op} recorderSessionId=${rec} tool=${name} argHash=${argHash(b.input)}`);
-                }
-                else if (b.type === 'tool_result') {
-                    const isError = b.is_error === true;
-                    if (isError)
-                        tally.errors += 1;
-                    else
-                        tally.oks += 1;
-                    const useId = typeof b.tool_use_id === 'string' ? b.tool_use_id : '';
-                    const startMs = useId ? startedAtMs.get(useId) : undefined;
-                    const elapsedMs = startMs ? Math.max(0, ts - startMs) : 0;
-                    // Tool name is not on the result block; the call line that
-                    // preceded it already named the tool — leave `tool=unknown`
-                    // here rather than guess. Operators correlate via the
-                    // adjacent argHash + tool_use_id ordering.
-                    let line = `[turn-recorder] tool-result sessionId=${op} recorderSessionId=${rec} tool=unknown outcome=${isError ? 'error' : 'ok'} ms=${elapsedMs}`;
-                    if (isError) {
-                        const errText = typeof b.content === 'string'
-                            ? b.content
-                            : Array.isArray(b.content)
-                                ? b.content
-                                    .map((c) => c && typeof c === 'object' && 'text' in c
-                                    ? String(c.text ?? '')
-                                    : '')
-                                    .join(' ')
-                                : '';
-                        line += ` err=${JSON.stringify(sanitizeErr(errText))}`;
-                    }
-                    deps.logger(line);
-                }
-            }
-        }
-    }
     function tryArchive(jsonlPath) {
-        drainJsonl(jsonlPath);
         if (archived)
             return;
         if (!existsSync(jsonlPath))
@@ -315,22 +167,7 @@ function attachRecorderAutoArchive(deps, session) {
         if (!endTurnSeen(jsonlPath))
             return;
         archived = true;
-        // Spec §52-53 — `write-complete` precedes `auto-archive` on the
-        // end-turn path. Read the running tally; if zero successful tool
-        // calls also emit `write-empty` (§65). On `tally.oks === 0` the
-        // `write-empty` reason is the cheapest derivable one. The richer
-        // reasons (`tool-surface-missing`, `no-extractable-entities`) are
-        // emitted earlier on dedicated paths; this is the catch-all.
-        deps.logger(`[turn-recorder] write-complete sessionId=${op} recorderSessionId=${rec} toolCalls=${tally.calls} toolOks=${tally.oks} toolErrors=${tally.errors}`);
-        if (tally.oks === 0) {
-            const reason = tally.calls === 0
-                ? 'no-extractable-entities'
-                : tally.errors > 0 && tally.errors === tally.calls
-                    ? 'tool-errors-only'
-                    : 'no-extractable-entities';
-            deps.logger(`[turn-recorder] write-empty sessionId=${op} recorderSessionId=${rec} reason=${reason}`);
-        }
-        deps.logger(`[turn-recorder] auto-archive sessionId=${op} recorderSessionId=${rec} reason=end-turn archivedAt=${new Date().toISOString()}`);
+        deps.logger(`auto-archive sessionId=${session.sessionId} specialist=${AUTO_ARCHIVE_SPECIALIST} reason=end-turn archivedAt=${new Date().toISOString()}`);
         void stopSession({ store: deps.store, killGraceMs: deps.killGraceMs, logger: deps.logger }, session.sessionId);
     }
     if (session.jsonlPath)
@@ -384,18 +221,15 @@ export function buildHttpApp(deps) {
         deps.logger(`[fs-watcher] live-row-jsonl-attached sessionId=${event.sessionId} path=${event.row.jsonlPath}`);
         attachPublicAudit(deps, live);
     });
-    function liveDisplayName(s, sidecarName) {
-        if (sidecarName && sidecarName.trim())
-            return sidecarName.trim();
+    function liveDisplayName(s) {
         if (s.jsonlPath && existsSync(s.jsonlPath)) {
             const enriched = readJsonlSession(deps.spawnCwd, s.sessionId, LIST_TAIL_BYTES, deps.logger);
             if (enriched?.aiTitle?.trim())
                 return enriched.aiTitle.trim();
         }
-        return s.sessionId.slice(0, 8);
+        return null;
     }
     function toLivePayload(s) {
-        const sidecar = s.jsonlPath ? readSidecar(s.jsonlPath) : null;
         const hasJsonl = s.jsonlPath !== null && existsSync(s.jsonlPath);
         return {
             sessionId: s.sessionId,
@@ -407,7 +241,7 @@ export function buildHttpApp(deps) {
             channel: s.channel,
             jsonlPath: s.jsonlPath,
             status: 'alive',
-            displayName: liveDisplayName(s, sidecar?.displayName),
+            displayName: liveDisplayName(s),
             lastMessageAt: null,
             turnCount: 0,
             capped: false,
@@ -417,7 +251,7 @@ export function buildHttpApp(deps) {
         };
     }
     function toArchivedPayload(row, senderId) {
-        let displayName = row.sessionId.slice(0, 8);
+        let displayName = null;
         let lastMessageAt = null;
         let turnCount = 0;
         let capped = false;
@@ -471,8 +305,8 @@ export function buildHttpApp(deps) {
         const specialist = typeof body.specialist === 'string' && /^[A-Za-z0-9_-]{1,64}$/.test(body.specialist)
             ? body.specialist
             : undefined;
-        const originatingSessionId = typeof body.originatingSessionId === 'string' && body.originatingSessionId.length > 0
-            ? body.originatingSessionId
+        const model = typeof body.model === 'string' && /^[A-Za-z0-9._-]{1,64}$/.test(body.model)
+            ? body.model
             : undefined;
         const aboutOwnerShape = body.aboutOwner == null ? 'absent' : (typeof body.aboutOwner === 'object' ? 'object' : typeof body.aboutOwner);
         const dormantPluginsShape = Array.isArray(body.dormantPlugins)
@@ -512,7 +346,7 @@ export function buildHttpApp(deps) {
             : body.tunnelUrl === null
                 ? null
                 : undefined;
-        const result = await spawnClaudeSession({ ...deps, store: deps.store, watcher: deps.watcher, onSessionReady: (s) => { attachPublicAudit(deps, s); attachRecorderAutoArchive(deps, s); }, tunnelUrlOverride }, {
+        const result = await spawnClaudeSession({ ...deps, store: deps.store, watcher: deps.watcher, onSessionReady: (s) => { attachPublicAudit(deps, s); attachSpecialistEndTurnAutoArchive(deps, s); }, tunnelUrlOverride }, {
             senderId,
             role: role,
             channel: channel,
@@ -525,7 +359,7 @@ export function buildHttpApp(deps) {
             specialistDomains,
             hidden,
             specialist,
-            originatingSessionId,
+            model,
         });
         if (!result.ok) {
             if ('rejected' in result) {
@@ -535,18 +369,6 @@ export function buildHttpApp(deps) {
                 }
                 return c.json({ error: 'operator-slots-reserved', total: result.rejected.total, reserve: result.rejected.reserve, totalCap: result.rejected.totalCap }, 503);
             }
-            // Task 129 — recorder preflight failures return distinct HTTP codes
-            // so the loopback caller can route the error to the correct named
-            // log line. The spawn-failure log was already emitted inside the
-            // preflight before returning.
-            if (result.reason === 'missing-originating-session-id') {
-                timed(deps.logger, 'POST', '/spawn', 400, Date.now() - start);
-                return c.json({ error: 'missing-originating-session-id' }, 400);
-            }
-            if (result.reason === 'tool-surface-missing') {
-                timed(deps.logger, 'POST', '/spawn', 503, Date.now() - start);
-                return c.json({ error: 'tool-surface-missing', detail: result.stderrTail }, 503);
-            }
             timed(deps.logger, 'POST', '/spawn', 500, Date.now() - start);
             return c.json({ error: 'spawn-failed', reason: result.reason, stderrTail: result.stderrTail }, 500);
         }
@@ -568,8 +390,8 @@ export function buildHttpApp(deps) {
     // watcher's `idle | busy | gone`. `agentLabel` is the resolution
     // `agent ?? cachedAgentSetting`; the UI maps null → "admin",
     // non-null → the specialist name. `firstPrompt` is the resolved
-    // displayName (sidecar → ai-title → 8-char slice) so the row title is
-    // computed once on the server, not by every browser tab.
+    // displayName (tail.aiTitle verbatim, else null — Task 146) so the row
+    // title is computed once on the server, not by every browser tab.
     app.get('/events', (c) => {
         const start = Date.now();
         const clientIp = c.req.header('x-forwarded-for') ?? 'loopback';
@@ -583,10 +405,6 @@ export function buildHttpApp(deps) {
                 if (enriched)
                     firstPrompt = enriched.displayName;
             }
-            if (!firstPrompt) {
-                const sidecar = row.jsonlPath ? readSidecar(row.jsonlPath) : null;
-                firstPrompt = sidecar?.displayName ?? row.sessionId.slice(0, 8);
-            }
             return {
                 sessionId: row.sessionId,
                 live: row.state === 'live',
@@ -757,7 +575,7 @@ export function buildHttpApp(deps) {
             : body.tunnelUrl === null
                 ? null
                 : undefined;
-        const result = await spawnClaudeSession({ ...deps, store: deps.store, watcher: deps.watcher, onSessionReady: (s) => { attachPublicAudit(deps, s); attachRecorderAutoArchive(deps, s); }, tunnelUrlOverride }, {
+        const result = await spawnClaudeSession({ ...deps, store: deps.store, watcher: deps.watcher, onSessionReady: (s) => { attachPublicAudit(deps, s); attachSpecialistEndTurnAutoArchive(deps, s); }, tunnelUrlOverride }, {
             senderId,
             role: role,
             channel: channel,
@@ -822,51 +640,6 @@ export function buildHttpApp(deps) {
         timed(deps.logger, 'GET', `/${id}/meta`, 200, Date.now() - start);
         return c.json(payload, 200);
     });
-    app.patch('/:sessionId', async (c) => {
-        const start = Date.now();
-        const id = c.req.param('sessionId');
-        if (!SESSION_ID_PATTERN.test(id)) {
-            timed(deps.logger, 'PATCH', `/${id}`, 400, Date.now() - start);
-            return c.json({ error: 'invalid-session-id' }, 400);
-        }
-        let body;
-        try {
-            body = await c.req.json();
-        }
-        catch {
-            timed(deps.logger, 'PATCH', `/${id}`, 400, Date.now() - start);
-            return c.json({ error: 'body-not-json' }, 400);
-        }
-        if (typeof body.displayName !== 'string' || body.displayName.length === 0 || body.displayName.length > DISPLAY_NAME_MAX) {
-            timed(deps.logger, 'PATCH', `/${id}`, 400, Date.now() - start);
-            return c.json({ error: 'invalid-displayName', detail: { maxLen: DISPLAY_NAME_MAX } }, 400);
-        }
-        const row = resolveRow(deps.watcher, id);
-        if (!row || !row.jsonlPath) {
-            timed(deps.logger, 'PATCH', `/${id}`, 404, Date.now() - start);
-            return c.json({ error: 'session-not-found' }, 404);
-        }
-        const sidecarPath = sidecarPathFor(row.jsonlPath);
-        const prior = readSidecar(row.jsonlPath)?.displayName ?? null;
-        try {
-            writeFileSync(sidecarPath, JSON.stringify({ displayName: body.displayName }, null, 2) + '\n', 'utf8');
-        }
-        catch (err) {
-            const msg = err instanceof Error ? err.message : String(err);
-            deps.logger(`rename-failed sessionId=${row.sessionId.slice(0, 8)} message=${msg}`);
-            timed(deps.logger, 'PATCH', `/${id}`, 500, Date.now() - start);
-            return c.json({ error: 'sidecar-write-failed', detail: msg }, 500);
-        }
-        deps.logger(`rename sessionId=${row.sessionId.slice(0, 8)} from=${prior ?? ''} to=${body.displayName}`);
-        if (prior === null) {
-            // First write — sidebar's auto-stamp from `/spawn`. Distinct log so
-            // an operator can grep this to confirm the brand-stamped label path
-            // ran, separately from manual renames via the modal. Task 120.
-            deps.logger(`sidecar-displayname-stamped sessionId=${row.sessionId.slice(0, 8)} displayName=${body.displayName}`);
-        }
-        timed(deps.logger, 'PATCH', `/${id}`, 200, Date.now() - start);
-        return c.json({ ok: true, displayName: body.displayName }, 200);
-    });
     app.post('/:sessionId/archive', async (c) => {
         const start = Date.now();
         const id = c.req.param('sessionId');
@@ -901,11 +674,8 @@ export function buildHttpApp(deps) {
         const slugDir = join(claudeStateRoot(), 'projects', slug);
         const archiveDir = join(slugDir, 'archive');
         const fileName = `${row.sessionId}.jsonl`;
-        const sidecarName = `${row.sessionId}.meta.json`;
         const fromJsonl = mode === 'archive' ? join(slugDir, fileName) : join(archiveDir, fileName);
         const toJsonl = mode === 'archive' ? join(archiveDir, fileName) : join(slugDir, fileName);
-        const fromSidecar = mode === 'archive' ? join(slugDir, sidecarName) : join(archiveDir, sidecarName);
-        const toSidecar = mode === 'archive' ? join(archiveDir, sidecarName) : join(slugDir, sidecarName);
         if (!existsSync(fromJsonl)) {
             timed(deps.logger, 'POST', `/${id}/archive`, 404, Date.now() - start);
             return c.json({ error: 'session-not-found' }, 404);
@@ -914,8 +684,6 @@ export function buildHttpApp(deps) {
             if (mode === 'archive')
                 mkdirSync(archiveDir, { recursive: true });
             renameSync(fromJsonl, toJsonl);
-            if (existsSync(fromSidecar))
-                renameSync(fromSidecar, toSidecar);
         }
         catch (err) {
             const msg = err instanceof Error ? err.message : String(err);
@@ -964,7 +732,6 @@ export function buildHttpApp(deps) {
             timed(deps.logger, 'DELETE', `/${id}`, 404, Date.now() - start);
             return c.json({ error: 'session-not-found' }, 404);
         }
-        const sidecarPath = sidecarPathFor(row.jsonlPath);
         const subdir = join(claudeStateRoot(), 'projects', projectSlugForCwd(deps.spawnCwd), sessionId);
         let bytes = 0;
         try {
@@ -976,8 +743,6 @@ export function buildHttpApp(deps) {
         try {
             if (existsSync(row.jsonlPath))
                 rmSync(row.jsonlPath);
-            if (existsSync(sidecarPath))
-                rmSync(sidecarPath);
             if (existsSync(subdir))
                 rmSync(subdir, { recursive: true, force: true });
         }