@rubytech/create-maxy-code 0.1.567 → 0.1.568

package/dist/__tests__/brand-agent-root.test.js

@@ -0,0 +1,91 @@
+// Task 2460 — the brand root is no longer a registration surface. It was
+// written once at install and never pruned, so a retired template stayed
+// registered forever: clare-craig carries `archive-ingest-operator.md` as a
+// dangling symlink into a template that no longer exists, and Task 2416 had to
+// strip its roster line by hand on five installs while the link survived.
+// Ceasing to write it is not enough, because every existing install already
+// carries the links.
+import test from "node:test";
+import assert from "node:assert/strict";
+import { mkdtempSync, mkdirSync, writeFileSync, rmSync, symlinkSync, readdirSync, existsSync } from "node:fs";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+import { clearBrandAgentRoot } from "../brand-agent-root.js";
+/** A temp brand root with an empty `agents/` under it, plus a collector for the
+ *  one line the function emits. */
+function makeRoot() {
+    const root = mkdtempSync(join(tmpdir(), "t2460-brand-root-"));
+    const agentsDir = join(root, "agents");
+    mkdirSync(agentsDir, { recursive: true });
+    const lines = [];
+    return { root, agentsDir, lines, log: (l) => lines.push(l) };
+}
+test("removes every markdown symlink and counts them", () => {
+    const { root, agentsDir, lines, log } = makeRoot();
+    try {
+        const target = join(root, "database-operator.md");
+        writeFileSync(target, "---\n");
+        symlinkSync(target, join(agentsDir, "database-operator.md"));
+        // The dangling case, which is what clare-craig actually carries.
+        symlinkSync(join(root, "gone.md"), join(agentsDir, "archive-ingest-operator.md"));
+        const result = clearBrandAgentRoot(agentsDir, log);
+        assert.deepEqual(result, { removed: 2, kept: [] });
+        assert.deepEqual(readdirSync(agentsDir), []);
+        // The link goes, never the template it pointed at.
+        assert.ok(existsSync(target));
+        assert.deepEqual(lines, ["  [brand-agent-root] op=brand-agent-root-cleared removed=2 kept="]);
+    }
+    finally {
+        rmSync(root, { recursive: true, force: true });
+    }
+});
+test("keeps a regular file and names it", () => {
+    const { root, agentsDir, lines, log } = makeRoot();
+    try {
+        writeFileSync(join(agentsDir, "hand-written.md"), "---\n");
+        const result = clearBrandAgentRoot(agentsDir, log);
+        assert.deepEqual(result, { removed: 0, kept: ["hand-written.md"] });
+        assert.ok(existsSync(join(agentsDir, "hand-written.md")));
+        assert.deepEqual(lines, ["  [brand-agent-root] op=brand-agent-root-cleared removed=0 kept=hand-written.md"]);
+    }
+    finally {
+        rmSync(root, { recursive: true, force: true });
+    }
+});
+test("leaves non-markdown entries alone", () => {
+    const { root, agentsDir, log } = makeRoot();
+    try {
+        writeFileSync(join(agentsDir, "notes.txt"), "scratch");
+        assert.deepEqual(clearBrandAgentRoot(agentsDir, log), { removed: 0, kept: [] });
+        assert.ok(existsSync(join(agentsDir, "notes.txt")));
+    }
+    finally {
+        rmSync(root, { recursive: true, force: true });
+    }
+});
+test("reports removed=0 on a directory that does not exist", () => {
+    const { root, agentsDir, lines, log } = makeRoot();
+    try {
+        rmSync(agentsDir, { recursive: true, force: true });
+        assert.deepEqual(clearBrandAgentRoot(agentsDir, log), { removed: 0, kept: [] });
+        assert.deepEqual(lines, ["  [brand-agent-root] op=brand-agent-root-cleared removed=0 kept="]);
+    }
+    finally {
+        rmSync(root, { recursive: true, force: true });
+    }
+});
+test("is idempotent: a second run reports removed=0", () => {
+    const { root, agentsDir, lines, log } = makeRoot();
+    try {
+        const target = join(root, "database-operator.md");
+        writeFileSync(target, "---\n");
+        symlinkSync(target, join(agentsDir, "database-operator.md"));
+        clearBrandAgentRoot(agentsDir, log);
+        lines.length = 0;
+        assert.deepEqual(clearBrandAgentRoot(agentsDir, log), { removed: 0, kept: [] });
+        assert.deepEqual(lines, ["  [brand-agent-root] op=brand-agent-root-cleared removed=0 kept="]);
+    }
+    finally {
+        rmSync(root, { recursive: true, force: true });
+    }
+});

package/dist/brand-agent-root.js

@@ -0,0 +1,58 @@
+// Task 2460 — the brand-wide agent root is retired.
+//
+// `$CLAUDE_CONFIG_DIR/agents/` was written once, by the installer, from
+// `platform/templates/specialists/agents/`, and never pruned. Three things
+// followed. A retired template stayed registered forever: on clare-craig,
+// `archive-ingest-operator.md` is a dangling symlink into a template that no
+// longer exists, and Task 2416 had to strip its roster line by hand on five
+// installs while the link survived. A specialist disabled on one account stayed
+// resolvable by name in that account and in every other account on the install,
+// because disabling touches only `<accountDir>/specialists/agents/`. And an
+// authored specialist could never be registered here at all without becoming
+// dispatchable inside every other account on the box.
+//
+// The replacement is one registry per account, mirrored at spawn by
+// `syncAccountAgentRegistry`. Dispatch is unaffected by emptying this root:
+// provisioning copies every template specialist into each account's
+// `specialists/agents/`, which that registry mirrors, and cwd at every spawn is
+// the account whose source is mirrored.
+//
+// This function removes what the old surface left behind. Removal rather than
+// merely ceasing to write, because every existing install already carries the
+// links.
+import { existsSync, lstatSync, readdirSync, unlinkSync } from "node:fs";
+import { join } from "node:path";
+/** Remove every `*.md` symlink under `agentsDir`. A regular file is the
+ *  operator's own and is kept and named, never deleted. Returns the counts and
+ *  logs `op=brand-agent-root-cleared removed=<N> kept=<names>` once, which is
+ *  the per-box record the fleet remediation is tracked against. */
+export function clearBrandAgentRoot(agentsDir, log = () => { }) {
+    let removed = 0;
+    const kept = [];
+    // A missing directory is an install that never had the old surface. Nothing
+    // to clear is a real result, not an error, so it still logs its zero.
+    if (existsSync(agentsDir)) {
+        for (const entry of readdirSync(agentsDir).sort()) {
+            if (!entry.endsWith(".md"))
+                continue;
+            const path = join(agentsDir, entry);
+            let stat;
+            try {
+                // lstat, not stat: the links this clears are frequently dangling, which
+                // is the whole of symptom 2, and stat would throw on exactly those.
+                stat = lstatSync(path);
+            }
+            catch {
+                continue;
+            }
+            if (!stat.isSymbolicLink()) {
+                kept.push(entry);
+                continue;
+            }
+            unlinkSync(path);
+            removed++;
+        }
+    }
+    log(`  [brand-agent-root] op=brand-agent-root-cleared removed=${removed} kept=${kept.join(",")}`);
+    return { removed, kept };
+}

package/dist/index.js

@@ -1,7 +1,7 @@
 #!/usr/bin/env node
 import { execFileSync, spawn, spawnSync } from "node:child_process";
 import { existsSync, mkdirSync, writeFileSync, cpSync, readFileSync, rmSync, readdirSync, appendFileSync, openSync, closeSync, chmodSync, statSync, realpathSync, accessSync, constants as fsConstants } from "node:fs";
-import { registerSpecialistAgentsAt, SpecialistSymlinkCollision } from "./specialist-registration.js";
+import { clearBrandAgentRoot } from "./brand-agent-root.js";
 import { seedBypassPermissionsSettings, assertBypassPermissionsSeed } from "./permissions-seed.js";
 import { resolve, join, dirname } from "node:path";
 import { randomBytes } from "node:crypto";
@@ -3419,14 +3419,13 @@ function setupAccount() {
             env: { ...neo4jEnv, PLATFORM_ROOT: join(INSTALL_DIR, "platform") },
         });
     }
-    // Task 165 — register every bundled specialist subagent at
-    // $CLAUDE_CONFIG_DIR/agents/<name>.md. Claude Code's `--agent <name>`
-    // discovery only resolves under this path; without these symlinks,
-    // every `--agent database-operator` etc. silently runs as the admin
-    // agent on admin IDENTITY/SOUL scaffolding. Symlinks (not copies) so
-    // a `npx -y @rubytech/create-maxy-code` upgrade picks up template
-    // changes without a second seed run.
-    registerSpecialistAgents();
+    // Task 2460 — clear the brand-wide agent root this step used to write.
+    // Every bundled specialist now reaches a session through the per-account
+    // registry that `syncAccountAgentRegistry` mirrors at spawn from
+    // `<accountDir>/specialists/agents/`, which provisioning fills from the same
+    // templates. Runs on every install, so an upgrade removes the links an
+    // earlier install left behind.
+    clearBrandAgentRegistrations();
     // install-time defaults. Stamp `account.json` with the
     // brand's default plugin set + default outputStyle / thinkingView, and
     // write a minimal admin SOUL.md. The agent boots into a working state
@@ -3595,25 +3594,23 @@ function writeEntitlementFromFlag(payload) {
     console.log(line);
     logFile(line);
 }
-// Task 394 — premium-bundle agents register through the native Claude Code
-// subagent registry via `.claude-plugin/plugin.json` manifests emitted by
-// scripts/generate-plugin-manifests.mjs at bundle time, not through a
-// parallel symlink channel. This function still wires the bundled platform
-// specialists (database-operator, project-manager, …) under
-// platform/templates/specialists/agents/, which are not part of a
-// registered plugin and rely on $CLAUDE_CONFIG_DIR/agents/ resolution.
-function registerSpecialistAgents() {
-    try {
-        registerSpecialistAgentsAt(join(INSTALL_DIR, "platform/templates/specialists/agents"), join(CLAUDE_CONFIG_DIR, "agents"), (line) => { console.log(line); logFile(line); });
-    }
-    catch (err) {
-        if (err instanceof SpecialistSymlinkCollision) {
-            console.error(`Setup failed: ${err.message}`);
-            console.error(`  Remove the file and re-run.`);
-            process.exit(1);
-        }
-        throw err;
-    }
+// Task 2460 — the brand root is no longer a registration surface. It was
+// written once and never pruned, which left retired templates registered
+// forever and left a specialist disabled on one account dispatchable in every
+// other account on the install. Bundled platform specialists reach a session
+// through the per-account registry instead; this step removes the links the old
+// surface left behind, which is what closes those two symptoms on an existing
+// install rather than only on a fresh one.
+//
+// Task 394 — premium-bundle agents were never registered here. They resolve
+// through the native Claude Code subagent registry via `.claude-plugin/plugin.json`
+// manifests emitted by scripts/generate-plugin-manifests.mjs at bundle time, so
+// clearing this directory does not touch them.
+function clearBrandAgentRegistrations() {
+    clearBrandAgentRoot(join(CLAUDE_CONFIG_DIR, "agents"), (line) => {
+        console.log(line);
+        logFile(line);
+    });
 }
 // ---------------------------------------------------------------------------
 // Account discovery (shared by installService + the post-install summary)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@rubytech/create-maxy-code",
-  "version": "0.1.567",
+  "version": "0.1.568",
   "description": "Install Maxy — AI for Productive People",
   "bin": {
     "create-maxy-code": "./dist/index.js"

package/payload/platform/plugins/admin/mcp/dist/index.js

@@ -203,6 +203,9 @@ if (ACCOUNT_ID) {
         const roster = runRosterCensus({
             agentsMdPath: resolve(accountDir, "agents", "admin", "AGENTS.md"),
             specialistsAgentsDir: resolve(accountDir, "specialists", "agents"),
+            // Task 2460 — the one directory the CLI resolves a subagent name from,
+            // written at every spawn by syncAccountAgentRegistry.
+            registryDir: resolve(accountDir, ".claude", "agents"),
             durableDirs: [resolve(PLATFORM_ROOT, "templates", "specialists", "agents")],
             durablePluginRoots: [
                 resolve(accountDir, "plugins"),
@@ -727,7 +730,7 @@ eagerTool(server, "account-manage", "Read the account configuration (tier, domai
         };
     }
 });
-eagerTool(server, "capabilities-here", "Returns the live install set on the current account as a single JSON object: enabledPlugins (account config), tier, adminModel, publicModel, installedPlatformSpecialists (disk), installedPremiumSpecialists (disk, gated by brand.shipsPremiumBundles), registeredAgentTypes (Claude Code agent registry under $CLAUDE_CONFIG_DIR/agents/), claudeAiConnectors (the claude.ai account connectors loaded for this client, each with an auth state of connected, needs-auth, or unreachable), and the brand block. Call this whenever you are about to make a claim about what this account can do, what is enabled, or what specialists are dispatchable. A connector listed here exists and is usable: do not deny a connector-backed request (Zoom, Dropbox, Microsoft 365, Cloudflare, Google) just because there is no skill or plugin for it — reach the connector tool, and authenticate it if its state is needs-auth. Do not infer install state from the platform-architecture skill — that skill is the catalogue of what the platform can ship, not what is enabled here.", {}, async () => {
+eagerTool(server, "capabilities-here", "Returns the live install set on the current account as a single JSON object: enabledPlugins (account config), tier, adminModel, publicModel, installedPlatformSpecialists (disk), installedPremiumSpecialists (disk, gated by brand.shipsPremiumBundles), registeredAgentTypes (this account's Claude Code agent registry, <accountDir>/.claude/agents/), claudeAiConnectors (the claude.ai account connectors loaded for this client, each with an auth state of connected, needs-auth, or unreachable), and the brand block. Call this whenever you are about to make a claim about what this account can do, what is enabled, or what specialists are dispatchable. A connector listed here exists and is usable: do not deny a connector-backed request (Zoom, Dropbox, Microsoft 365, Cloudflare, Google) just because there is no skill or plugin for it — reach the connector tool, and authenticate it if its state is needs-auth. Do not infer install state from the platform-architecture skill — that skill is the catalogue of what the platform can ship, not what is enabled here.", {}, async () => {
     if (!ACCOUNT_ID)
         return refuseNoAccount("capabilities-here");
     const requestId = randomUUID();
@@ -745,6 +748,9 @@ eagerTool(server, "capabilities-here", "Returns the live install set on the curr
             platformRoot: PLATFORM_ROOT,
             premiumPluginsRoot,
             claudeConfigDir,
+            // Task 2460 — the account's own agent registry. The brand-wide root
+            // this used to read is retired and cleared on upgrade.
+            agentRegistryDir: resolve(getAccountDir(), ".claude", "agents"),
             // Task 1160 — enumerate the brand client's claude.ai connectors via
             // `claude mcp list`. Never rejects: resolves with whatever output the CLI
             // produced (empty on a missing binary, non-zero exit, or the 12s timeout