@rubytech/create-maxy-code 0.1.470 → 0.1.472

package/dist/__tests__/google-client-id-env.test.js

@@ -0,0 +1,68 @@
+// acceptance gate for GOOGLE_CLIENT_ID / GOOGLE_PUBLIC_BASE stamping in the
+// claude-session-manager systemd unit (Task 1761).
+//
+// This test exists because the first fix stamped only the darwin `.env` mirror
+// and missed this Linux unit, so on the actual (Ubuntu) install the google
+// plugin loaded with an empty GOOGLE_CLIENT_ID, registered nothing usable, and
+// the agent fell back to claude.ai connector advice — the very behaviour the
+// plugin was built to remove. The unit env is the ONLY path the value reaches
+// the MCP server: google is `mcp-manifest: auto`, whose generator discards the
+// declared mcp.env block.
+//
+// Three invariants:
+//   (a) a brand client id AND an install public base emit both Environment lines.
+//   (b) either one missing emits NEITHER line — a client id without a redirect
+//       origin builds a consent URL Google rejects on its byte-for-byte
+//       redirect_uri comparison, so a half-stamp is worse than no stamp.
+//   (c) stamping google never disturbs the outlook pair.
+import test from "node:test";
+import assert from "node:assert/strict";
+import { buildClaudeSessionManagerUnitFile } from "../port-resolution.js";
+const ACCOUNT_ID = "12345678-9abc-def0-1234-56789abcdef0";
+const GOOGLE_ID = "1032860640027-p61l59fnog4mad5o7grginpaps9jnu8c.apps.googleusercontent.com";
+const PUBLIC_BASE = "https://public.sitedesk.online";
+const OUTLOOK_ID = "0fa68fe2-8bec-4007-a0c7-776636fbcf97";
+function build(opts) {
+    return buildClaudeSessionManagerUnitFile({
+        productName: "SiteDesk",
+        brandHostname: "sitedesk-code",
+        installDir: "/home/me/sitedesk-code",
+        persistDir: "/home/me/.sitedesk-code",
+        claudeSessionManagerPort: 19402,
+        brandPort: 19300,
+        maxyUiInternalPort: 19301,
+        accountId: ACCOUNT_ID,
+        cdpPort: 9224,
+        ...opts,
+    });
+}
+test("both values present stamps both Environment lines", () => {
+    const unit = build({ googleClientId: GOOGLE_ID, googlePublicBase: PUBLIC_BASE });
+    assert.ok(unit.includes(`Environment=GOOGLE_CLIENT_ID=${GOOGLE_ID}`));
+    assert.ok(unit.includes(`Environment=GOOGLE_PUBLIC_BASE=${PUBLIC_BASE}`));
+});
+test("a client id with no public base stamps NEITHER line", () => {
+    const unit = build({ googleClientId: GOOGLE_ID });
+    assert.ok(!unit.includes("GOOGLE_CLIENT_ID"), "a half-stamp must not ship");
+    assert.ok(!unit.includes("GOOGLE_PUBLIC_BASE"));
+});
+test("a public base with no client id stamps NEITHER line", () => {
+    const unit = build({ googlePublicBase: PUBLIC_BASE });
+    assert.ok(!unit.includes("GOOGLE_CLIENT_ID"));
+    assert.ok(!unit.includes("GOOGLE_PUBLIC_BASE"));
+});
+test("a brand shipping no google app stamps neither line", () => {
+    const unit = build({});
+    assert.ok(!unit.includes("GOOGLE_CLIENT_ID"));
+    assert.ok(!unit.includes("GOOGLE_PUBLIC_BASE"));
+});
+test("google stamping leaves the outlook pair intact", () => {
+    const unit = build({
+        googleClientId: GOOGLE_ID,
+        googlePublicBase: PUBLIC_BASE,
+        outlookClientId: OUTLOOK_ID,
+    });
+    assert.ok(unit.includes(`Environment=OUTLOOK_CLIENT_ID=${OUTLOOK_ID}`));
+    assert.ok(unit.includes("Environment=OUTLOOK_TENANT_ID=common"));
+    assert.ok(unit.includes(`Environment=GOOGLE_CLIENT_ID=${GOOGLE_ID}`));
+});

package/dist/index.js

@@ -51,6 +51,26 @@ catch (err) {
 }
 const INSTALL_DIR = resolve(process.env.HOME ?? "/root", BRAND.installDir);
 const PERSIST_DIR = resolve(process.env.HOME ?? "/root", BRAND.configDir);
+// Task 1761 — GOOGLE_PUBLIC_BASE is the https origin Google redirects back to
+// after consent. It is a property of THIS INSTALL's tunnel, not of the brand,
+// so it is read from the same cloudflared/tunnel.state the uninstaller reads.
+// Defined once here because BOTH env paths need it: the darwin .env mirror and
+// the Linux systemd unit. Absent tunnel → unset, and google-account-register
+// refuses with an actionable message rather than minting a consent URL whose
+// redirect_uri Google will reject on its byte-for-byte comparison.
+const googlePublicBase = (() => {
+    try {
+        const tunnelState = join(PERSIST_DIR, "cloudflared/tunnel.state");
+        if (!existsSync(tunnelState))
+            return "";
+        const parsed = JSON.parse(readFileSync(tunnelState, "utf-8"));
+        return parsed.domain ? `https://public.${parsed.domain}` : "";
+    }
+    catch {
+        // Unreadable tunnel state is not fatal to the install; the value stays unset.
+        return "";
+    }
+})();
 const LOG_DIR = join(PERSIST_DIR, "logs");
 const LOG_FILE = join(LOG_DIR, `install-${new Date().toISOString().replace(/[:.]/g, "-")}.log`);
 // every `claude plugin` shellout must read/write the per-brand
@@ -3724,24 +3744,6 @@ function installServiceDarwin() {
         // GOOGLE_PUBLIC_BASE is the https origin the consent redirect returns to;
         // it must match the authorized redirect URI on the vendor app byte-for-byte,
         // so it is derived from the brand's public host, not guessed at call time.
-        // GOOGLE_PUBLIC_BASE is the https origin Google redirects back to. It is a
-        // property of THIS INSTALL's tunnel, not of the brand, so it is read from
-        // the same tunnel.state the uninstaller reads. Absent tunnel → the var is
-        // stripped and google-account-register refuses with an actionable message,
-        // rather than a guessed host that would fail Google's byte-for-byte
-        // redirect_uri comparison at the token exchange.
-        let googlePublicBase = "";
-        try {
-            const tunnelState = join(PERSIST_DIR, "cloudflared/tunnel.state");
-            if (existsSync(tunnelState)) {
-                const parsed = JSON.parse(readFileSync(tunnelState, "utf-8"));
-                if (parsed.domain)
-                    googlePublicBase = `https://public.${parsed.domain}`;
-            }
-        }
-        catch {
-            // Unreadable tunnel state is not fatal to the install; the var stays unset.
-        }
         if (BRAND.googleClientId) {
             for (const [key, value] of [
                 ["GOOGLE_CLIENT_ID", BRAND.googleClientId],
@@ -4383,6 +4385,8 @@ function installService() {
         accountId: installAccountId,
         cdpPort: CDP_PORT_BRAND,
         outlookClientId: BRAND.outlookClientId,
+        googleClientId: BRAND.googleClientId,
+        googlePublicBase: googlePublicBase || undefined,
     });
     writeFileSync(join(serviceDir, claudeSessionManagerUnitName), claudeSessionManagerUnit);
     logFile(`  ${claudeSessionManagerUnitName}: CLAUDE_SESSION_MANAGER_PORT=${CLAUDE_SESSION_MANAGER_PORT_BRAND} MAXY_UI_INTERNAL_PORT=${MAXY_UI_INTERNAL_PORT}`);
@@ -4390,6 +4394,10 @@ function installService() {
     // (a non-empty outlookClientId) against what the unit shipped. `stamped=false`
     // while the brand has a value is the mis-stamp signature.
     logFile(`  [installer] op=outlook-client-id brand=${BRAND.hostname} stamped=${BRAND.outlookClientId ? "true" : "false"}`);
+    // Task 1761 — the same standing signal for the Google vendor app. Both parts
+    // are reported because a client id without a public base stamps NEITHER: a
+    // consent URL built without the redirect origin is one Google rejects.
+    logFile(`  [installer] op=google-client-id brand=${BRAND.hostname} stamped=${BRAND.googleClientId && googlePublicBase ? "true" : "false"} clientId=${BRAND.googleClientId ? "set" : "unset"} publicBase=${googlePublicBase || "unset"}`);
     // Task 250 — write the brand-agnostic `claude-ptys.slice` unit. Every
     // brand's session manager drops its per-spawn scope units under this
     // slice. Writing it once per install is idempotent (the content is

package/dist/port-resolution.js

@@ -135,6 +135,12 @@ export function buildClaudeSessionManagerUnitFile(o) {
     const outlookEnv = o.outlookClientId
         ? `\nEnvironment=OUTLOOK_CLIENT_ID=${o.outlookClientId}\nEnvironment=OUTLOOK_TENANT_ID=common`
         : "";
+    // Task 1761 — same contract for the Google vendor app. The client id and the
+    // install's public base land together: a client id without a redirect origin
+    // produces a consent URL Google rejects, so a half-stamp is worse than none.
+    const googleEnv = o.googleClientId && o.googlePublicBase
+        ? `\nEnvironment=GOOGLE_CLIENT_ID=${o.googleClientId}\nEnvironment=GOOGLE_PUBLIC_BASE=${o.googlePublicBase}`
+        : "";
     return `[Unit]
 Description=${o.productName} Claude Session Manager
 After=network.target
@@ -156,7 +162,7 @@ Environment=PLATFORM_ROOT=${o.installDir}/platform
 Environment=MAXY_BRAND_PORT=${o.brandPort}
 Environment=MAXY_UI_INTERNAL_PORT=${o.maxyUiInternalPort}
 Environment=PLATFORM_PORT=${o.maxyUiInternalPort}
-Environment=CDP_PORT=${o.cdpPort}${outlookEnv}
+Environment=CDP_PORT=${o.cdpPort}${outlookEnv}${googleEnv}
 EnvironmentFile=-${o.persistDir}/.env
 StandardOutput=append:${o.persistDir}/logs/server.log
 StandardError=append:${o.persistDir}/logs/server.log

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@rubytech/create-maxy-code",
-  "version": "0.1.470",
+  "version": "0.1.472",
   "description": "Install Maxy — AI for Productive People",
   "bin": {
     "create-maxy-code": "./dist/index.js"

package/payload/platform/config/brand.json

@@ -55,7 +55,7 @@
   },
 
   "plugins": {
-    "core": ["admin", "memory", "docs", "cloudflare", "anthropic", "workflows", "work", "scheduling", "email", "contacts", "projects", "prompt-optimiser", "browser"],
+    "core": ["admin", "memory", "docs", "cloudflare", "anthropic", "workflows", "work", "ledger", "scheduling", "email", "contacts", "projects", "prompt-optimiser", "browser"],
     "defaultEnabled": ["business-assistant", "sales", "web-designer"],
     "available": ["connector", "telegram", "deep-research", "whatsapp", "replicate", "linkedin-import", "notion-import", "obsidian-import", "x-import", "slides"],
     "excluded": ["joblogic"]