@rubytech/create-maxy-code 0.1.47 → 0.1.49

package/dist/__tests__/premium-mcp-discover.test.js

@@ -0,0 +1,85 @@
+// Pure unit tests for the premium-MCP discovery loop. Real tmp dir, no mocks —
+// the discovery function is fs-bound and a mock would just re-state the schema.
+//
+// Tests are ephemeral per the sprint workflow.
+import test from "node:test";
+import assert from "node:assert/strict";
+import { mkdtempSync, mkdirSync, writeFileSync, rmSync } from "node:fs";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+import { findPremiumMcpDirs } from "../lib/premium-mcp-discover.js";
+function makeTree(installDir, files) {
+    for (const [rel, contents] of Object.entries(files)) {
+        const full = join(installDir, rel);
+        mkdirSync(join(full, ".."), { recursive: true });
+        writeFileSync(full, contents);
+    }
+}
+test("findPremiumMcpDirs: returns empty when premium-plugins/ is absent", () => {
+    const dir = mkdtempSync(join(tmpdir(), "premium-mcp-"));
+    try {
+        assert.deepEqual(findPremiumMcpDirs(dir), []);
+    }
+    finally {
+        rmSync(dir, { recursive: true, force: true });
+    }
+});
+test("findPremiumMcpDirs: discovers loop MCP under real-agent bundle", () => {
+    const dir = mkdtempSync(join(tmpdir(), "premium-mcp-"));
+    try {
+        makeTree(dir, {
+            "premium-plugins/real-agent/plugins/loop/mcp/package.json": "{}",
+        });
+        assert.deepEqual(findPremiumMcpDirs(dir), [
+            join(dir, "premium-plugins/real-agent/plugins/loop/mcp"),
+        ]);
+    }
+    finally {
+        rmSync(dir, { recursive: true, force: true });
+    }
+});
+test("findPremiumMcpDirs: ignores plugin dir with no mcp/package.json", () => {
+    const dir = mkdtempSync(join(tmpdir(), "premium-mcp-"));
+    try {
+        makeTree(dir, {
+            "premium-plugins/real-agent/plugins/loop/mcp/package.json": "{}",
+            "premium-plugins/real-agent/plugins/no-mcp/README.md": "noop",
+        });
+        assert.deepEqual(findPremiumMcpDirs(dir), [
+            join(dir, "premium-plugins/real-agent/plugins/loop/mcp"),
+        ]);
+    }
+    finally {
+        rmSync(dir, { recursive: true, force: true });
+    }
+});
+test("findPremiumMcpDirs: covers multiple bundles and plugins by construction", () => {
+    const dir = mkdtempSync(join(tmpdir(), "premium-mcp-"));
+    try {
+        makeTree(dir, {
+            "premium-plugins/real-agent/plugins/loop/mcp/package.json": "{}",
+            "premium-plugins/real-agent/plugins/other/mcp/package.json": "{}",
+            "premium-plugins/another-bundle/plugins/foo/mcp/package.json": "{}",
+        });
+        assert.deepEqual(findPremiumMcpDirs(dir), [
+            join(dir, "premium-plugins/another-bundle/plugins/foo/mcp"),
+            join(dir, "premium-plugins/real-agent/plugins/loop/mcp"),
+            join(dir, "premium-plugins/real-agent/plugins/other/mcp"),
+        ]);
+    }
+    finally {
+        rmSync(dir, { recursive: true, force: true });
+    }
+});
+test("findPremiumMcpDirs: skips bundle missing plugins/ subdir", () => {
+    const dir = mkdtempSync(join(tmpdir(), "premium-mcp-"));
+    try {
+        makeTree(dir, {
+            "premium-plugins/empty-bundle/README.md": "noop",
+        });
+        assert.deepEqual(findPremiumMcpDirs(dir), []);
+    }
+    finally {
+        rmSync(dir, { recursive: true, force: true });
+    }
+});

package/dist/index.js

@@ -14,6 +14,7 @@ import { parseSwVers, isSupportedMacosVersion } from "./macos-version.js";
 import { decideChromiumAction, isSnapConfinedPath } from "./snap-chromium.js";
 import { classifyPortHolder } from "./preflight-port-classifier.js";
 import { parsePluginList, computeInstallActions, computeConfigureActions, parseExternalPlugins, } from "./lib/plugin-install.js";
+import { findPremiumMcpDirs } from "./lib/premium-mcp-discover.js";
 import { pickLanInterface, mergeSmbConf, formatSambaMarker, } from "./samba-provision.js";
 import { networkInterfaces } from "node:os";
 const PAYLOAD_DIR = resolve(import.meta.dirname, "../payload");
@@ -2046,6 +2047,22 @@ function buildPlatform() {
         console.log(`  Installing claude-session-manager dependencies (${csmDir})...`);
         shellRetry("npm", ["install", "--omit=dev", ...NPM_NET_FLAGS], { cwd: csmDir }, 3, 15);
     }
+    // Premium-plugin MCP servers (e.g. real-agent/loop) ship dist/ + package.json
+    // in the payload but no node_modules — npm pack strips them, same reason as
+    // server/. Discover every <installDir>/premium-plugins/<bundle>/plugins/<plugin>/mcp
+    // and install --omit=dev there. dirs=0 in the summary line is itself a signal
+    // when a brand ships premium plugins but the discovery glob is broken.
+    const premiumMcpDirs = findPremiumMcpDirs(INSTALL_DIR);
+    console.log(`  [install] premium-mcp-install dirs=${premiumMcpDirs.length}`);
+    for (const mcpDir of premiumMcpDirs) {
+        const mcpNodeModules = join(mcpDir, "node_modules");
+        if (existsSync(mcpNodeModules)) {
+            console.log(`  Wiping previous ${mcpDir}/node_modules for a clean reinstall...`);
+            rmSync(mcpNodeModules, { recursive: true, force: true });
+        }
+        console.log(`  Installing premium plugin MCP dependencies (${mcpDir})...`);
+        shellRetry("npm", ["install", "--omit=dev", ...NPM_NET_FLAGS], { cwd: mcpDir }, 3, 15);
+    }
 }
 function setupVncViewer() {
     if (!isLinux())

package/dist/lib/premium-mcp-discover.js

@@ -0,0 +1,34 @@
+// Pure premium-plugin MCP directory discovery.
+//
+// Schema (exact, two levels under premium-plugins):
+//
+//   <installDir>/premium-plugins/<bundle>/plugins/<plugin>/mcp/package.json
+//
+// Recursive walks would match nested dirs that aren't real MCP plugins;
+// the explicit walk eliminates that class of false positive. Each level
+// is gated on isDirectory() before descending, so a stray file at any
+// level is ignored.
+import { existsSync, readdirSync } from "node:fs";
+import { join } from "node:path";
+export function findPremiumMcpDirs(installDir) {
+    const root = join(installDir, "premium-plugins");
+    if (!existsSync(root))
+        return [];
+    const out = [];
+    for (const bundle of readdirSync(root, { withFileTypes: true })) {
+        if (!bundle.isDirectory())
+            continue;
+        const pluginsRoot = join(root, bundle.name, "plugins");
+        if (!existsSync(pluginsRoot))
+            continue;
+        for (const plugin of readdirSync(pluginsRoot, { withFileTypes: true })) {
+            if (!plugin.isDirectory())
+                continue;
+            const mcpDir = join(pluginsRoot, plugin.name, "mcp");
+            if (!existsSync(join(mcpDir, "package.json")))
+                continue;
+            out.push(mcpDir);
+        }
+    }
+    return out.sort();
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@rubytech/create-maxy-code",
-  "version": "0.1.47",
+  "version": "0.1.49",
   "description": "Install Maxy — AI for Productive People",
   "bin": {
     "create-maxy-code": "./dist/index.js"

package/payload/platform/plugins/docs/references/deployment.md

@@ -227,6 +227,8 @@ Skills, agents, hooks, and commands directories at the plugin root are auto-disc
 
 **Diagnostic path** — `grep "\[plugin-install\]" ~/.<brand>/logs/install-*.log | tail -50`; compare row count against `cat brand.json | jq '.externalPlugins | length'` plus the on-disk plugin count under `<INSTALL_DIR>/platform/plugins/` and `<INSTALL_DIR>/premium-plugins/`.
 
+**Premium MCP dependency install** — Premium-plugin MCP servers ship `dist/` + `package.json` in the bundle but not `node_modules` (npm pack strips them, same as `server/`). `buildPlatform()` discovers every `<INSTALL_DIR>/premium-plugins/<bundle>/plugins/<plugin>/mcp/package.json` and runs `npm install --omit=dev` there, wiping any prior `node_modules` first. The summary log line `[install] premium-mcp-install dirs=<n>` is emitted before the loop runs, so `dirs=0` is itself a regression signal when a brand ships premium plugins.
+
 ## Running multiple brands on one device
 
 A single Pi or laptop can host more than one brand (for example Maxy and Real Agent) side by side. Each brand runs as its own service on its own port, with its own install directory and its own data. Installing one brand does not touch the other.