@rubytech/create-maxy-code 0.1.460 → 0.1.461

package/payload/platform/plugins/voice-mirror/mcp/dist/tools/voice-retrieve-conditioning.js

@@ -10,9 +10,18 @@
  *   - All callers updated in the same commit.
  *
  * Retrieval order (best to worst):
- *   1. If brief.topic is provided AND keyword search on the per-format corpus
- *      returns ≥K matches → use those (ordered by recency).
- *   2. Otherwise, return the K most-recent per-format corpus nodes.
+ *   1. Corpus nodes whose body carries the most `brief.topic` terms.
+ *   2. Within an equal term count, the most recent.
+ *
+ * `brief.topic` ranks; it never excludes. Until Task 1719 it was applied as
+ * `WHERE toLower(body) CONTAINS toLower($topic)` — a single literal
+ * whole-phrase match — so a multi-word topic ('programme outline training')
+ * matched no body and the walk returned zero exemplars over a non-empty
+ * corpus, while `status` still read "ok" because a style card alone satisfies
+ * `hasData`. Ranking honours this header's original intent (topic hits first,
+ * K backfilled by recency) in one pass: a voice profile conditions on how the
+ * operator writes, not what about, so an off-topic exemplar still carries the
+ * signal and is always worth more than nothing.
  *
  * Embeddings are not used in v1: the corpus is small (single operator's
  * personal writing — typically <500 docs), and recency-with-keyword-filter
@@ -36,6 +45,16 @@ const CHARS_PER_TOKEN = 4;
 function errorResult(error) {
     return { styleCard: null, exemplars: [], status: "error", error };
 }
+/**
+ * Cypher `size()` arrives as a driver Integer, not a JS number, and an Integer
+ * is truthy at zero — so comparing the raw value would count every row as a
+ * topic hit. Narrow it before any arithmetic.
+ */
+function toNumber(value) {
+    if (neo4j.isInt(value))
+        return value.toNumber();
+    return typeof value === "number" ? value : 0;
+}
 export async function voiceRetrieveConditioning(params) {
     const { accountId, userId, brief } = params;
     const scope = brief.scope ?? "personal";
@@ -55,12 +74,18 @@ export async function voiceRetrieveConditioning(params) {
         (length === "long" ? DEFAULT_TOKEN_BUDGET_LONG : DEFAULT_TOKEN_BUDGET_SHORT);
     const charBudget = tokenBudget * CHARS_PER_TOKEN;
     const format = brief.format;
-    const topic = (brief.topic ?? "").trim();
-    const usesTopic = topic.length > 0;
+    // Distinct lowercased topic terms. Lowercasing happens here, once, so the
+    // Cypher compares term-to-body without a per-row toLower on the term. An
+    // absent/blank topic yields [], which scores every row 0 and leaves the
+    // ordering to recency alone — the same walk, no branch.
+    const topicTerms = Array.from(new Set((brief.topic ?? "")
+        .toLowerCase()
+        .split(/\s+/)
+        .filter((t) => t.length > 0)));
     // Body resolution (Task 471): for :KnowledgeDocument with HAS_SECTION
     // children, concatenate child :Section bodies in `position` order (KD.body is
     // null after Task 465 server-slicing); other labels read n.body via the
-    // COALESCE chain. The topic filter runs against the computed body.
+    // COALESCE chain. Topic ranking scores against the computed body.
     const bodyComputeBlock = `WITH n, coalesce(n.dateSent, n.datePublished, n.firstMessageAt, n.dateCreated, n.createdAt) AS ts
          OPTIONAL MATCH (n)-[:HAS_SECTION]->(s:Section)
          WHERE ${notTrashed("s")}
@@ -86,30 +111,29 @@ export async function voiceRetrieveConditioning(params) {
             const profile = await session.run(`OPTIONAL MATCH (p:VoiceProfile {accountId: $accountId, userId: $profileUserId, format: $format})
          RETURN p.styleCard AS styleCard`, { accountId, profileUserId, format });
             const styleCard = profile.records[0]?.get("styleCard") ?? null;
-            const cypher = usesTopic
-                ? `MATCH (n)
-           WHERE ${exemplarWhere}
-           ${bodyComputeBlock}
-           WHERE toLower(body) CONTAINS toLower($topic)
-           RETURN elementId(n) AS id, labels(n) AS labels, body,
-                  coalesce(n.subject, n.title, n.name, '') AS source, ts
-           ORDER BY ts IS NULL, ts DESC
-           LIMIT $k`
-                : `MATCH (n)
+            // `topicScore` counts how many distinct topic terms the body carries and
+            // orders on it. It is a rank, not a predicate: a row scoring 0 stays in
+            // the result set and is simply ordered behind the hits, so the walk
+            // returns up to K exemplars whenever the corpus holds any, whatever the
+            // topic. `ts IS NULL` keeps undated nodes last within an equal score.
+            const cypher = `MATCH (n)
            WHERE ${exemplarWhere}
            ${bodyComputeBlock}
+           WITH n, ts, body,
+                size([t IN $topicTerms WHERE toLower(body) CONTAINS t]) AS topicScore
            RETURN elementId(n) AS id, labels(n) AS labels, body,
-                  coalesce(n.subject, n.title, n.name, '') AS source, ts
-           ORDER BY ts IS NULL, ts DESC
+                  coalesce(n.subject, n.title, n.name, '') AS source, ts, topicScore
+           ORDER BY topicScore DESC, ts IS NULL, ts DESC
            LIMIT $k`;
             const result = await session.run(cypher, {
                 ...exemplarParams,
-                topic,
+                topicTerms,
                 // neo4j-driver serializes a plain JS number as a Cypher float (15 →
                 // 15.0), which LIMIT rejects. Send a Neo4j integer.
                 k: neo4j.int(k),
             });
             let charsUsed = 0;
+            let topicHits = 0;
             const exemplars = [];
             for (const r of result.records) {
                 const body = r.get("body") ?? "";
@@ -128,8 +152,10 @@ export async function voiceRetrieveConditioning(params) {
                     source: (r.get("source") ?? "").slice(0, 200),
                 });
                 charsUsed += truncated.length;
+                if (toNumber(r.get("topicScore")) > 0)
+                    topicHits += 1;
             }
-            return { styleCard, exemplars };
+            return { styleCard, exemplars, topicHits };
         };
         const hasData = (r) => (r.styleCard !== null && r.styleCard.length > 0) || r.exemplars.length > 0;
         const orgLookup = () => lookup(ORG_USER_ID, voiceCorpusWhereWithFormat(format), { accountId, format });
@@ -154,8 +180,15 @@ export async function voiceRetrieveConditioning(params) {
             result = org;
             status = hasData(org) ? "ok" : "no-data";
         }
+        // `topicTerms`/`topicHits` are the pair that makes a thin result legible
+        // without reproducing it: exemplarCount=0 says the scope's corpus is empty,
+        // and topicHits=0 with topicTerms>0 says the exemplars are recency-picked
+        // rather than topic-matched. Before Task 1719 the two were indistinguishable
+        // — a topic that matched nothing and an absent corpus both logged
+        // exemplarCount=0, and only the first was a defect.
         process.stderr.write(`[voice-retrieve] scope=${scope} format=${format} status=${status} ` +
-            `styleCardBytes=${result.styleCard?.length ?? 0} exemplarCount=${result.exemplars.length} tokenBudget=${tokenBudget}\n`);
+            `styleCardBytes=${result.styleCard?.length ?? 0} exemplarCount=${result.exemplars.length} ` +
+            `topicTerms=${topicTerms.length} topicHits=${result.topicHits} tokenBudget=${tokenBudget}\n`);
         return { styleCard: result.styleCard, exemplars: result.exemplars, status };
     }
     catch (err) {

package/payload/platform/plugins/voice-mirror/mcp/dist/tools/voice-retrieve-conditioning.js.map

@@ -1 +1 @@
-{"version":3,"file":"voice-retrieve-conditioning.js","sourceRoot":"","sources":["../../src/tools/voice-retrieve-conditioning.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;;;;;;;;;GA2BG;AACH,OAAO,KAAuB,MAAM,cAAc,CAAC;AACnD,OAAO,EAAE,UAAU,EAAE,MAAM,iBAAiB,CAAC;AAC7C,OAAO,EAAE,UAAU,EAAE,MAAM,wBAAwB,CAAC;AACpD,OAAO,EACL,0BAA0B,EAC1B,mCAAmC,EACnC,WAAW,GAGZ,MAAM,wBAAwB,CAAC;AAEhC,MAAM,0BAA0B,GAAG,MAAM,CAAC;AAC1C,MAAM,yBAAyB,GAAG,MAAM,CAAC;AACzC,MAAM,eAAe,GAAG,CAAC,CAAC;AAgE1B,SAAS,WAAW,CAAC,KAAa;IAChC,OAAO,EAAE,SAAS,EAAE,IAAI,EAAE,SAAS,EAAE,EAAE,EAAE,MAAM,EAAE,OAAO,EAAE,KAAK,EAAE,CAAC;AACpE,CAAC;AAED,MAAM,CAAC,KAAK,UAAU,yBAAyB,CAC7C,MAAuC;IAEvC,MAAM,EAAE,SAAS,EAAE,MAAM,EAAE,KAAK,EAAE,GAAG,MAAM,CAAC;IAC5C,MAAM,KAAK,GAAe,KAAK,CAAC,KAAK,IAAI,UAAU,CAAC;IACpD,6EAA6E;IAC7E,4EAA4E;IAC5E,8EAA8E;IAC9E,8EAA8E;IAC9E,6EAA6E;IAC7E,gFAAgF;IAChF,IAAI,CAAC,SAAS,IAAI,CAAC,KAAK,KAAK,KAAK,IAAI,CAAC,MAAM,CAAC,EAAE,CAAC;QAC/C,OAAO,CAAC,MAAM,CAAC,KAAK,CAClB,kDAAkD,KAAK,cAAc,OAAO,CAAC,SAAS,CAAC,WAAW,OAAO,CAAC,MAAM,CAAC,IAAI,CACtH,CAAC;QACF,OAAO,WAAW,CAAC,0BAA0B,CAAC,CAAC;IACjD,CAAC;IAED,MAAM,MAAM,GAAG,KAAK,CAAC,MAAM,IAAI,OAAO,CAAC;IACvC,MAAM,CAAC,GAAG,MAAM,KAAK,MAAM,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC,CAAC;IACrC,MAAM,WAAW,GACf,MAAM,CAAC,WAAW;QAClB,CAAC,MAAM,KAAK,MAAM,CAAC,CAAC,CAAC,yBAAyB,CAAC,CAAC,CAAC,0BAA0B,CAAC,CAAC;IAC/E,MAAM,UAAU,GAAG,WAAW,GAAG,eAAe,CAAC;IACjD,MAAM,MAAM,GAAG,KAAK,CAAC,MAAM,CAAC;IAC5B,MAAM,KAAK,GAAG,CAAC,KAAK,CAAC,KAAK,IAAI,EAAE,CAAC,CAAC,IAAI,EAAE,CAAC;IACzC,MAAM,SAAS,GAAG,KAAK,CAAC,MAAM,GAAG,CAAC,CAAC;IAEnC,sEAAsE;IACtE,8EAA8E;IAC9E,wEAAwE;IACxE,mEAAmE;IACnE,MAAM,gBAAgB,GAAG;;iBAEV,UAAU,CAAC,GAAG,CAAC;;;;;;;qBAOX,CAAC;IAEpB,4EAA4E;IAC5E,0EAA0E;IAC1E,yEAAyE;IACzE,cAAc;IACd,IAAI,OAA4B,CAAC;IACjC,IAAI,CAAC;QACH,OAAO,GAAG,UAAU,EAAE,CAAC;QAEvB,4EAA4E;QAC5E,yEAAyE;QACzE,uEAAuE;QACvE,sEAAsE;QACtE,MAAM,MAAM,GAAG,KAAK,EAClB,aAAqB,EACrB,aAAqB,EACrB,cAAuC,EAC4B,EAAE;YACrE,MAAM,OAAO,GAAG,MAAM,OAAQ,CAAC,GAAG,CAChC;yCACiC,EACjC,EAAE,SAAS,EAAE,aAAa,EAAE,MAAM,EAAE,CACrC,CAAC;YACF,MAAM,SAAS,GACZ,OAAO,CAAC,OAAO,CAAC,CAAC,CAAC,EAAE,GAAG,CAAC,WAAW,CAAmB,IAAI,IAAI,CAAC;YAElE,MAAM,MAAM,GAAG,SAAS;gBACtB,CAAC,CAAC;mBACS,aAAa;aACnB,gBAAgB;;;;;oBAKT;gBACZ,CAAC,CAAC;mBACS,aAAa;aACnB,gBAAgB;;;;oBAIT,CAAC;YAEf,MAAM,MAAM,GAAG,MAAM,OAAQ,CAAC,GAAG,CAAC,MAAM,EAAE;gBACxC,GAAG,cAAc;gBACjB,KAAK;gBACL,oEAAoE;gBACpE,oDAAoD;gBACpD,CAAC,EAAE,KAAK,CAAC,GAAG,CAAC,CAAC,CAAC;aAChB,CAAC,CAAC;YAEH,IAAI,SAAS,GAAG,CAAC,CAAC;YAClB,MAAM,SAAS,GAAoB,EAAE,CAAC;YACtC,KAAK,MAAM,CAAC,IAAI,MAAM,CAAC,OAAO,EAAE,CAAC;gBAC/B,MAAM,IAAI,GAAI,CAAC,CAAC,GAAG,CAAC,MAAM,CAAmB,IAAI,EAAE,CAAC;gBACpD,IAAI,IAAI,CAAC,MAAM,KAAK,CAAC;oBAAE,SAAS;gBAChC,MAAM,MAAM,GAAI,CAAC,CAAC,GAAG,CAAC,QAAQ,CAAc,IAAI,EAAE,CAAC;gBACnD,MAAM,KAAK,GACT,MAAM,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAChB,CAAC,mBAAmB,EAAE,SAAS,EAAE,YAAY,EAAE,cAAc,CAAC,CAAC,QAAQ,CAAC,CAAC,CAAC,CAC3E,IAAI,MAAM,CAAC,CAAC,CAAC,IAAI,SAAS,CAAC;gBAC9B,MAAM,SAAS,GAAG,UAAU,GAAG,SAAS,CAAC;gBACzC,IAAI,SAAS,IAAI,CAAC;oBAAE,MAAM;gBAC1B,MAAM,SAAS,GAAG,IAAI,CAAC,MAAM,GAAG,SAAS,CAAC,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,EAAE,SAAS,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC;gBAC5E,SAAS,CAAC,IAAI,CAAC;oBACb,MAAM,EAAE,CAAC,CAAC,GAAG,CAAC,IAAI,CAAW;oBAC7B,KAAK;oBACL,IAAI,EAAE,SAAS;oBACf,MAAM,EAAE,CAAE,CAAC,CAAC,GAAG,CAAC,QAAQ,CAAmB,IAAI,EAAE,CAAC,CAAC,KAAK,CAAC,CAAC,EAAE,GAAG,CAAC;iBACjE,CAAC,CAAC;gBACH,SAAS,IAAI,SAAS,CAAC,MAAM,CAAC;YAChC,CAAC;YACD,OAAO,EAAE,SAAS,EAAE,SAAS,EAAE,CAAC;QAClC,CAAC,CAAC;QAEF,MAAM,OAAO,GAAG,CAAC,CAA2D,EAAE,EAAE,CAC9E,CAAC,CAAC,CAAC,SAAS,KAAK,IAAI,IAAI,CAAC,CAAC,SAAS,CAAC,MAAM,GAAG,CAAC,CAAC,IAAI,CAAC,CAAC,SAAS,CAAC,MAAM,GAAG,CAAC,CAAC;QAE7E,MAAM,SAAS,GAAG,GAAG,EAAE,CACrB,MAAM,CAAC,WAAW,EAAE,0BAA0B,CAAC,MAAM,CAAC,EAAE,EAAE,SAAS,EAAE,MAAM,EAAE,CAAC,CAAC;QAEjF,IAAI,MAAgE,CAAC;QACrE,IAAI,MAA2B,CAAC;QAChC,IAAI,KAAK,KAAK,UAAU,EAAE,CAAC;YACzB,MAAM,QAAQ,GAAG,MAAM,MAAM,CAC3B,MAAM,EACN,mCAAmC,CAAC,MAAM,CAAC,EAC3C,EAAE,SAAS,EAAE,MAAM,EAAE,WAAW,EAAE,MAAM,EAAE,CAC3C,CAAC;YACF,IAAI,OAAO,CAAC,QAAQ,CAAC,EAAE,CAAC;gBACtB,MAAM,GAAG,QAAQ,CAAC;gBAClB,MAAM,GAAG,IAAI,CAAC;YAChB,CAAC;iBAAM,CAAC;gBACN,uEAAuE;gBACvE,6CAA6C;gBAC7C,MAAM,GAAG,GAAG,MAAM,SAAS,EAAE,CAAC;gBAC9B,MAAM,GAAG,GAAG,CAAC;gBACb,MAAM,GAAG,OAAO,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,cAAc,CAAC,CAAC,CAAC,SAAS,CAAC;YACrD,CAAC;QACH,CAAC;aAAM,CAAC;YACN,MAAM,GAAG,GAAG,MAAM,SAAS,EAAE,CAAC;YAC9B,MAAM,GAAG,GAAG,CAAC;YACb,MAAM,GAAG,OAAO,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,SAAS,CAAC;QAC3C,CAAC;QAED,OAAO,CAAC,MAAM,CAAC,KAAK,CAClB,0BAA0B,KAAK,WAAW,MAAM,WAAW,MAAM,GAAG;YAClE,kBAAkB,MAAM,CAAC,SAAS,EAAE,MAAM,IAAI,CAAC,kBAAkB,MAAM,CAAC,SAAS,CAAC,MAAM,gBAAgB,WAAW,IAAI,CAC1H,CAAC;QAEF,OAAO,EAAE,SAAS,EAAE,MAAM,CAAC,SAAS,EAAE,SAAS,EAAE,MAAM,CAAC,SAAS,EAAE,MAAM,EAAE,CAAC;IAC9E,CAAC;IAAC,OAAO,GAAG,EAAE,CAAC;QACb,MAAM,OAAO,GAAG,GAAG,YAAY,KAAK,CAAC,CAAC,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC,CAAC,MAAM,CAAC,GAAG,CAAC,CAAC;QACjE,OAAO,CAAC,MAAM,CAAC,KAAK,CAAC,2BAA2B,OAAO,IAAI,CAAC,CAAC;QAC7D,OAAO,WAAW,CAAC,OAAO,CAAC,CAAC;IAC9B,CAAC;YAAS,CAAC;QACT,IAAI,OAAO;YAAE,MAAM,OAAO,CAAC,KAAK,EAAE,CAAC;IACrC,CAAC;AACH,CAAC"}
+{"version":3,"file":"voice-retrieve-conditioning.js","sourceRoot":"","sources":["../../src/tools/voice-retrieve-conditioning.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;GAoCG;AACH,OAAO,KAAuB,MAAM,cAAc,CAAC;AACnD,OAAO,EAAE,UAAU,EAAE,MAAM,iBAAiB,CAAC;AAC7C,OAAO,EAAE,UAAU,EAAE,MAAM,wBAAwB,CAAC;AACpD,OAAO,EACL,0BAA0B,EAC1B,mCAAmC,EACnC,WAAW,GAGZ,MAAM,wBAAwB,CAAC;AAEhC,MAAM,0BAA0B,GAAG,MAAM,CAAC;AAC1C,MAAM,yBAAyB,GAAG,MAAM,CAAC;AACzC,MAAM,eAAe,GAAG,CAAC,CAAC;AAgE1B,SAAS,WAAW,CAAC,KAAa;IAChC,OAAO,EAAE,SAAS,EAAE,IAAI,EAAE,SAAS,EAAE,EAAE,EAAE,MAAM,EAAE,OAAO,EAAE,KAAK,EAAE,CAAC;AACpE,CAAC;AAED;;;;GAIG;AACH,SAAS,QAAQ,CAAC,KAAc;IAC9B,IAAI,KAAK,CAAC,KAAK,CAAC,KAAK,CAAC;QAAE,OAAQ,KAAuB,CAAC,QAAQ,EAAE,CAAC;IACnE,OAAO,OAAO,KAAK,KAAK,QAAQ,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC;AAC/C,CAAC;AAED,MAAM,CAAC,KAAK,UAAU,yBAAyB,CAC7C,MAAuC;IAEvC,MAAM,EAAE,SAAS,EAAE,MAAM,EAAE,KAAK,EAAE,GAAG,MAAM,CAAC;IAC5C,MAAM,KAAK,GAAe,KAAK,CAAC,KAAK,IAAI,UAAU,CAAC;IACpD,6EAA6E;IAC7E,4EAA4E;IAC5E,8EAA8E;IAC9E,8EAA8E;IAC9E,6EAA6E;IAC7E,gFAAgF;IAChF,IAAI,CAAC,SAAS,IAAI,CAAC,KAAK,KAAK,KAAK,IAAI,CAAC,MAAM,CAAC,EAAE,CAAC;QAC/C,OAAO,CAAC,MAAM,CAAC,KAAK,CAClB,kDAAkD,KAAK,cAAc,OAAO,CAAC,SAAS,CAAC,WAAW,OAAO,CAAC,MAAM,CAAC,IAAI,CACtH,CAAC;QACF,OAAO,WAAW,CAAC,0BAA0B,CAAC,CAAC;IACjD,CAAC;IAED,MAAM,MAAM,GAAG,KAAK,CAAC,MAAM,IAAI,OAAO,CAAC;IACvC,MAAM,CAAC,GAAG,MAAM,KAAK,MAAM,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC,CAAC;IACrC,MAAM,WAAW,GACf,MAAM,CAAC,WAAW;QAClB,CAAC,MAAM,KAAK,MAAM,CAAC,CAAC,CAAC,yBAAyB,CAAC,CAAC,CAAC,0BAA0B,CAAC,CAAC;IAC/E,MAAM,UAAU,GAAG,WAAW,GAAG,eAAe,CAAC;IACjD,MAAM,MAAM,GAAG,KAAK,CAAC,MAAM,CAAC;IAC5B,0EAA0E;IAC1E,yEAAyE;IACzE,wEAAwE;IACxE,wDAAwD;IACxD,MAAM,UAAU,GAAG,KAAK,CAAC,IAAI,CAC3B,IAAI,GAAG,CACL,CAAC,KAAK,CAAC,KAAK,IAAI,EAAE,CAAC;SAChB,WAAW,EAAE;SACb,KAAK,CAAC,KAAK,CAAC;SACZ,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,MAAM,GAAG,CAAC,CAAC,CAC/B,CACF,CAAC;IAEF,sEAAsE;IACtE,8EAA8E;IAC9E,wEAAwE;IACxE,kEAAkE;IAClE,MAAM,gBAAgB,GAAG;;iBAEV,UAAU,CAAC,GAAG,CAAC;;;;;;;qBAOX,CAAC;IAEpB,4EAA4E;IAC5E,0EAA0E;IAC1E,yEAAyE;IACzE,cAAc;IACd,IAAI,OAA4B,CAAC;IACjC,IAAI,CAAC;QACH,OAAO,GAAG,UAAU,EAAE,CAAC;QAEvB,4EAA4E;QAC5E,yEAAyE;QACzE,uEAAuE;QACvE,sEAAsE;QACtE,MAAM,MAAM,GAAG,KAAK,EAClB,aAAqB,EACrB,aAAqB,EACrB,cAAuC,EAKtC,EAAE;YACH,MAAM,OAAO,GAAG,MAAM,OAAQ,CAAC,GAAG,CAChC;yCACiC,EACjC,EAAE,SAAS,EAAE,aAAa,EAAE,MAAM,EAAE,CACrC,CAAC;YACF,MAAM,SAAS,GACZ,OAAO,CAAC,OAAO,CAAC,CAAC,CAAC,EAAE,GAAG,CAAC,WAAW,CAAmB,IAAI,IAAI,CAAC;YAElE,yEAAyE;YACzE,wEAAwE;YACxE,oEAAoE;YACpE,wEAAwE;YACxE,sEAAsE;YACtE,MAAM,MAAM,GAAG;mBACF,aAAa;aACnB,gBAAgB;;;;;;oBAMT,CAAC;YAEf,MAAM,MAAM,GAAG,MAAM,OAAQ,CAAC,GAAG,CAAC,MAAM,EAAE;gBACxC,GAAG,cAAc;gBACjB,UAAU;gBACV,oEAAoE;gBACpE,oDAAoD;gBACpD,CAAC,EAAE,KAAK,CAAC,GAAG,CAAC,CAAC,CAAC;aAChB,CAAC,CAAC;YAEH,IAAI,SAAS,GAAG,CAAC,CAAC;YAClB,IAAI,SAAS,GAAG,CAAC,CAAC;YAClB,MAAM,SAAS,GAAoB,EAAE,CAAC;YACtC,KAAK,MAAM,CAAC,IAAI,MAAM,CAAC,OAAO,EAAE,CAAC;gBAC/B,MAAM,IAAI,GAAI,CAAC,CAAC,GAAG,CAAC,MAAM,CAAmB,IAAI,EAAE,CAAC;gBACpD,IAAI,IAAI,CAAC,MAAM,KAAK,CAAC;oBAAE,SAAS;gBAChC,MAAM,MAAM,GAAI,CAAC,CAAC,GAAG,CAAC,QAAQ,CAAc,IAAI,EAAE,CAAC;gBACnD,MAAM,KAAK,GACT,MAAM,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAChB,CAAC,mBAAmB,EAAE,SAAS,EAAE,YAAY,EAAE,cAAc,CAAC,CAAC,QAAQ,CAAC,CAAC,CAAC,CAC3E,IAAI,MAAM,CAAC,CAAC,CAAC,IAAI,SAAS,CAAC;gBAC9B,MAAM,SAAS,GAAG,UAAU,GAAG,SAAS,CAAC;gBACzC,IAAI,SAAS,IAAI,CAAC;oBAAE,MAAM;gBAC1B,MAAM,SAAS,GAAG,IAAI,CAAC,MAAM,GAAG,SAAS,CAAC,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,EAAE,SAAS,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC;gBAC5E,SAAS,CAAC,IAAI,CAAC;oBACb,MAAM,EAAE,CAAC,CAAC,GAAG,CAAC,IAAI,CAAW;oBAC7B,KAAK;oBACL,IAAI,EAAE,SAAS;oBACf,MAAM,EAAE,CAAE,CAAC,CAAC,GAAG,CAAC,QAAQ,CAAmB,IAAI,EAAE,CAAC,CAAC,KAAK,CAAC,CAAC,EAAE,GAAG,CAAC;iBACjE,CAAC,CAAC;gBACH,SAAS,IAAI,SAAS,CAAC,MAAM,CAAC;gBAC9B,IAAI,QAAQ,CAAC,CAAC,CAAC,GAAG,CAAC,YAAY,CAAC,CAAC,GAAG,CAAC;oBAAE,SAAS,IAAI,CAAC,CAAC;YACxD,CAAC;YACD,OAAO,EAAE,SAAS,EAAE,SAAS,EAAE,SAAS,EAAE,CAAC;QAC7C,CAAC,CAAC;QAEF,MAAM,OAAO,GAAG,CAAC,CAA2D,EAAE,EAAE,CAC9E,CAAC,CAAC,CAAC,SAAS,KAAK,IAAI,IAAI,CAAC,CAAC,SAAS,CAAC,MAAM,GAAG,CAAC,CAAC,IAAI,CAAC,CAAC,SAAS,CAAC,MAAM,GAAG,CAAC,CAAC;QAE7E,MAAM,SAAS,GAAG,GAAG,EAAE,CACrB,MAAM,CAAC,WAAW,EAAE,0BAA0B,CAAC,MAAM,CAAC,EAAE,EAAE,SAAS,EAAE,MAAM,EAAE,CAAC,CAAC;QAEjF,IAAI,MAIH,CAAC;QACF,IAAI,MAA2B,CAAC;QAChC,IAAI,KAAK,KAAK,UAAU,EAAE,CAAC;YACzB,MAAM,QAAQ,GAAG,MAAM,MAAM,CAC3B,MAAM,EACN,mCAAmC,CAAC,MAAM,CAAC,EAC3C,EAAE,SAAS,EAAE,MAAM,EAAE,WAAW,EAAE,MAAM,EAAE,CAC3C,CAAC;YACF,IAAI,OAAO,CAAC,QAAQ,CAAC,EAAE,CAAC;gBACtB,MAAM,GAAG,QAAQ,CAAC;gBAClB,MAAM,GAAG,IAAI,CAAC;YAChB,CAAC;iBAAM,CAAC;gBACN,uEAAuE;gBACvE,6CAA6C;gBAC7C,MAAM,GAAG,GAAG,MAAM,SAAS,EAAE,CAAC;gBAC9B,MAAM,GAAG,GAAG,CAAC;gBACb,MAAM,GAAG,OAAO,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,cAAc,CAAC,CAAC,CAAC,SAAS,CAAC;YACrD,CAAC;QACH,CAAC;aAAM,CAAC;YACN,MAAM,GAAG,GAAG,MAAM,SAAS,EAAE,CAAC;YAC9B,MAAM,GAAG,GAAG,CAAC;YACb,MAAM,GAAG,OAAO,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,SAAS,CAAC;QAC3C,CAAC;QAED,yEAAyE;QACzE,4EAA4E;QAC5E,0EAA0E;QAC1E,6EAA6E;QAC7E,kEAAkE;QAClE,oDAAoD;QACpD,OAAO,CAAC,MAAM,CAAC,KAAK,CAClB,0BAA0B,KAAK,WAAW,MAAM,WAAW,MAAM,GAAG;YAClE,kBAAkB,MAAM,CAAC,SAAS,EAAE,MAAM,IAAI,CAAC,kBAAkB,MAAM,CAAC,SAAS,CAAC,MAAM,GAAG;YAC3F,cAAc,UAAU,CAAC,MAAM,cAAc,MAAM,CAAC,SAAS,gBAAgB,WAAW,IAAI,CAC/F,CAAC;QAEF,OAAO,EAAE,SAAS,EAAE,MAAM,CAAC,SAAS,EAAE,SAAS,EAAE,MAAM,CAAC,SAAS,EAAE,MAAM,EAAE,CAAC;IAC9E,CAAC;IAAC,OAAO,GAAG,EAAE,CAAC;QACb,MAAM,OAAO,GAAG,GAAG,YAAY,KAAK,CAAC,CAAC,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC,CAAC,MAAM,CAAC,GAAG,CAAC,CAAC;QACjE,OAAO,CAAC,MAAM,CAAC,KAAK,CAAC,2BAA2B,OAAO,IAAI,CAAC,CAAC;QAC7D,OAAO,WAAW,CAAC,OAAO,CAAC,CAAC;IAC9B,CAAC;YAAS,CAAC;QACT,IAAI,OAAO;YAAE,MAAM,OAAO,CAAC,KAAK,EAAE,CAAC;IACrC,CAAC;AACH,CAAC"}

package/payload/platform/plugins/voice-mirror/mcp/scripts/smoke.mjs

@@ -644,6 +644,63 @@ check("voice-distil-profile keeps both structural write anchors", () => {
   assert.equal(anchors?.length, 2, "both write-path anchors retained");
 });
 
+check("both write paths aggregate the sample link in a CALL subquery", () => {
+  // The load-bearing invariant of the zero-record fix. A bare
+  // `WITH p UNWIND $ids ... RETURN elementId(p)` tail collapses the row when the
+  // id list is empty or every id is stale, so records.length === 0 stops meaning
+  // "the anchor missed" and the write reports an identity error for what is a
+  // content condition. The CALL subquery's bare aggregation returns a row over
+  // empty input, which is what keeps the outer row alive. Reverting either tail
+  // reintroduces the bug silently, so pin the shape here.
+  const subqueries = distilSrc.match(/RETURN count\(\*\) AS learned/g);
+  assert.equal(subqueries?.length, 2, "both write paths aggregate with count(*)");
+  // Positive form: each sample UNWIND must sit inside a CALL block. A negative
+  // "no bare UNWIND" regex cannot tell the subquery's own UNWIND from an outer
+  // one, so it fires on correct code.
+  const wrapped = distilSrc.match(
+    /CALL \{\s*\n\s*WITH p\s*\n\s*UNWIND \$(sampleIds|amendIds) AS sid/g,
+  );
+  assert.equal(wrapped?.length, 2, "both sample links are wrapped in a CALL subquery");
+});
+
+check("the zero-resolved write reports content, never identity", () => {
+  // The whole point of the fix: a merged profile with no sources must not reuse
+  // the unknown-:AdminUser wording, and must not tell the caller their id is
+  // wrong. Both messages disclaim identity explicitly.
+  // The messages are built by concatenating template literals, so a sentence can
+  // straddle a `+ ` join in source while being whole at runtime. Flatten the
+  // joins before matching prose, or these assertions test the formatting rather
+  // than the message.
+  const flat = distilSrc.replace(/`\s*\+\s*\n\s*`/g, "");
+  const disclaimers = flat.match(
+    /This is a content condition, not an identity one\./g,
+  );
+  assert.equal(disclaimers?.length, 2, "both zero-resolved messages disclaim identity");
+  assert.ok(
+    /none carried readable text to sample/.test(flat),
+    "the empty-sample cause has its own wording",
+  );
+  assert.ok(
+    /stopped resolving/.test(flat),
+    "the vanished-samples cause has its own wording",
+  );
+});
+
+check("the vanished-samples message does not blame trashing", () => {
+  // A trashed node keeps its elementId, and the write resolves with a bare
+  // `MATCH (s) WHERE elementId(s) = sid` carrying no trash predicate, so it
+  // still resolves and still takes its edge. Only a hard delete can produce the
+  // condition. Naming trashing sends the operator to a trash that cannot hold
+  // the cause, which is the same misattribution the fix removes.
+  const at = distilSrc.indexOf("function noSourcesResolvedMessage");
+  assert.ok(at > -1, "noSourcesResolvedMessage present");
+  const body = distilSrc.slice(at, at + 1200);
+  assert.ok(
+    !/deleted or trashed/.test(body),
+    "must not name trashing as a cause of an unresolved id",
+  );
+});
+
 const retrieveSrc = readFileSync(
   join(TOOLS_SRC, "voice-retrieve-conditioning.ts"),
   "utf-8",
@@ -685,6 +742,59 @@ check("voice-retrieve-conditioning never sets isError", () => {
   );
 });
 
+// Comments stripped, so a check that forbids a Cypher clause cannot be tripped
+// by documentation *describing* that clause. The header of
+// voice-retrieve-conditioning.ts quotes the topic-rank predicate verbatim to
+// explain why it went; that prose must not read as the predicate itself.
+const retrieveCode = retrieveSrc
+  .replace(/\/\*[\s\S]*?\*\//g, "")
+  .replace(/^\s*\/\/.*$/gm, "");
+
+check("voice-retrieve-conditioning topic ranks and never excludes", () => {
+  // The regression guard for the reported defect: brief.topic was applied as a
+  // literal whole-phrase predicate, so a multi-word topic matched no body and
+  // the walk returned zero exemplars over a non-empty corpus. Any predicate
+  // that tests the topic inside a WHERE reintroduces it, whether phrased on
+  // $topic or on the terms — the topic belongs in the ORDER BY alone.
+  assert.ok(
+    !/CONTAINS\s+toLower\(\$topic\)/.test(retrieveCode),
+    "topic must not filter the exemplar walk: a non-matching topic empties a non-empty corpus",
+  );
+  assert.ok(
+    !/WHERE[^\n]*\$topicTerms/.test(retrieveCode),
+    "topic terms must not appear in a WHERE that gates the walk, only in the ranked projection",
+  );
+  assert.ok(
+    /ORDER BY topicScore DESC/.test(retrieveCode),
+    "topic must rank the walk: topicScore orders, recency breaks the tie",
+  );
+});
+
+check("voice-retrieve-conditioning narrows Cypher integers before comparing", () => {
+  // A driver Integer is truthy at zero, so `topicScore > 0` on the raw value
+  // would count every row as a topic hit and make the observability line lie.
+  assert.ok(
+    /toNumber\(r\.get\("topicScore"\)\)\s*>\s*0/.test(retrieveSrc),
+    "topicScore must be narrowed via toNumber() before the hit comparison",
+  );
+});
+
+check("voice-retrieve-conditioning builds distinct lowercased topic terms", () => {
+  // Asserted on the source, never on dist/: dist is a build artifact that
+  // survives a source revert, so a check reading it passes against code that no
+  // longer exists. The parse is what turns a phrase into rankable terms —
+  // lowercased once here so the Cypher compares term-to-body directly, and
+  // de-duplicated so a repeated word cannot inflate topicScore.
+  assert.ok(
+    /\.toLowerCase\(\)[\s\S]{0,60}\.split\(\/\\s\+\/\)/.test(retrieveSrc),
+    "topic must be lowercased and split on whitespace into terms",
+  );
+  assert.ok(
+    /const topicTerms = Array\.from\(\s*new Set\(/.test(retrieveSrc),
+    "topic terms must be de-duplicated so a repeated word cannot inflate topicScore",
+  );
+});
+
 // ---------------------------------------------------------------------------
 // 14. One refusal wording across every gate (Task 1701).
 //     record-feedback and ingest already enforced the rule via an inline

package/payload/platform/plugins/voice-mirror/skills/voice-mirror/SKILL.md

@@ -115,7 +115,7 @@ This runs only on the admin seat (the tool is admin-allowlisted). Accounts witho
 
 ## Flow — drafting-time conditioning
 
-Drafting skills (email composition, Postiz, property-brochure, investor-data-room Stage 3 prose, prospectus) call `voice-retrieve-conditioning` transparently before assembling their prompt. The skill takes a brief — `{topic, format, length, register, scope}` — where `format` is the target corpus format and `scope` picks whose voice to draft in. Default `scope` is `personal` (the calling operator's own voice); a drafting skill whose output goes out under the business name passes `scope: "org"` for the house voice. Email composition stays personal; property-brochure, the investor-data-room Stage 3 business plan, and the prospectus skills request `org`. It returns:
+Drafting skills (email composition, Postiz, property-brochure, investor-data-room Stage 3 prose, prospectus) call `voice-retrieve-conditioning` transparently before assembling their prompt. The skill takes a brief — `{topic, format, length, register, scope}` — where `format` is the target corpus format and `scope` picks whose voice to draft in. Default `scope` is `personal` (the calling operator's own voice); a drafting skill whose output goes out under the business name passes `scope: "org"` for the house voice. Email composition stays personal; property-brochure, the investor-data-room Stage 3 business plan, and the prospectus skills request `org`. `topic` is optional and only ranks the exemplars: its terms sort the corpus by how many they match, and a topic matching nothing still returns the most recent writing. Describe the subject as naturally as you like, because no phrasing can cost you exemplars. It returns:
 
 ```yaml
 styleCard: |
@@ -209,7 +209,9 @@ A value naming no `:AdminUser` on the account is refused, and nothing is written
 
 The tools resolve identity from the spawn environment on their own. Pass `author:` only to attribute content to a different operator on a multi-operator account, and only with that operator's real `:AdminUser` id.
 
-If a tool refuses, the id is wrong. Do not retry with a different guess. The account's real admin identity is the operator's to supply.
+If a tool refuses *on identity*, the id is wrong. Do not retry with a different guess. The account's real admin identity is the operator's to supply.
+
+Not every refusal is an identity refusal. `voice-distil-profile` also refuses when the profile merged but no source content could be linked to it, either because no sampled item carried readable text or because the sampled items stopped resolving mid-run. Those messages say so, and close with "This is a content condition, not an identity one." Changing the id will not fix them, and the `[voice-identity] refuse` line is absent when they fire.
 
 `__org__` is exempt, because the house voice anchors on the business rather than on a person.
 
@@ -222,6 +224,7 @@ If a tool refuses, the id is wrong. Do not retry with a different guess. The acc
 | `[voice-distil] scope=<scope> userId=<id\|__org__> format=<format> skip reason=<below-threshold\|recent\|empty-corpus>` | When the cadence/empty guard fires. |
 | `[voice-distil] scope=<scope> mode=amend userId=<id\|__org__> format=<format> nodeIds=<count> existingProfile=<elementId\|none> eligible=<n> ineligible=<n> exemplars=<n>` | Each amend-mode call. `eligible=0` means surface `ineligible[]` to the operator, never silently no-op. |
 | `[voice-distil] scope=<scope> mode=write userId=<id\|__org__> anchor=<…> format=<format> amended=true amendedFromNodeIds=<count> ...` | Amend-write fired (operator-initiated update persisted). |
+| `[voice-distil] scope=<scope> userId=<id\|__org__> anchor=<…> format=<format> mode=write sources=none attempted=<n> resolved=0 ...` | The profile merged and the style card saved, but no `LEARNED_FROM` edge was written. `attempted=0` means no sampled item carried readable text; `attempted>0` means every sampled item stopped resolving between the walk and the write. Either way the call throws, and the cause is content, not identity. |
 | `[voice-retrieve] scope=<scope> format=<format> status=<ok\|fallback-org\|no-data\|error> styleCardBytes=<n> exemplarCount=<k> tokenBudget=<n>` | Each retrieval. `status=fallback-org` proves the personal→org fallback fired. |
 | `[voice-record-feedback] scope=<scope> userId=<id\|__org__> format=<format> intent="<haiku-summary>" diffBytes=<n>` | Each feedback write. |
 | `[voice-ingest-session-text] sessionId=<id> adminUser=<id> turns=<n> bytes=<n> skipped=<m>` | On-demand session-text capture. |
@@ -229,7 +232,7 @@ If a tool refuses, the id is wrong. Do not retry with a different guess. The acc
 
 **Confirms working:** `[voice-retrieve] exemplarCount≥1` precedes every drafting-skill prompt assembly when the calling skill has not opted out. `[voice-distil]` appears at least once per 30-day window per active format per operator. `[voice-ingest-session-text] turns≥1` appears when the operator asks to capture a session's voice.
 
-**Indicates failure:** `[voice-retrieve] exemplarCount=0` with non-empty corpus → similarity index broken; `[voice-distil] error …` → corpus walk or LLM call failed; absence of `[voice-record-feedback]` after an operator-edit-then-send flow → feedback loop is dead.
+**Indicates failure:** `[voice-retrieve] exemplarCount=0` with non-empty corpus → similarity index broken; `[voice-distil] error …` → corpus walk or LLM call failed; `[voice-distil] … sources=none attempted=0` → the corpus for that format is tagged but holds no readable text, so the profile has a style card and no sources; absence of `[voice-record-feedback]` after an operator-edit-then-send flow → feedback loop is dead.
 
 **Diagnostic path:**
 

package/payload/platform/scripts/__tests__/logs-rotate.test.sh

@@ -0,0 +1,256 @@
+#!/usr/bin/env bash
+# Tests for logs-rotate.sh (Task 1706). Fixture-driven: builds a throwaway logs
+# dir per case, runs the real script against it, asserts on the resulting files.
+# No stubs — gzip/find/wc/date are the real binaries, because the portability of
+# exactly those calls across Linux and darwin is part of what this asserts.
+set -uo pipefail
+
+SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+ROTATE="$SCRIPT_DIR/../logs-rotate.sh"
+
+PASS=0
+FAIL=0
+
+run_case() {
+  local name="$1"; shift
+  echo ""
+  echo "=== CASE: $name ==="
+  if "$@"; then
+    PASS=$((PASS + 1))
+    echo "PASS: $name"
+  else
+    FAIL=$((FAIL + 1))
+    echo "FAIL: $name"
+  fi
+}
+
+# Build a throwaway logs dir. Echoes its path.
+mk_logs_dir() {
+  local d
+  d="$(mktemp -d "${TMPDIR:-/tmp}/logs-rotate-test.XXXXXX")"
+  echo "$d"
+}
+
+# Write a file of exactly $2 bytes at $1. $2 must be a whole number of MiB.
+# bs=1048576 rather than bs=1m/1M: the suffix spellings differ between BSD and
+# GNU dd, and this suite runs on both.
+mk_file_of_size() {
+  local path="$1" bytes="$2" mib
+  mib=$(( bytes / 1048576 ))
+  dd if=/dev/zero bs=1048576 count="$mib" 2>/dev/null | tr '\0' 'x' > "$path"
+}
+
+size_of() { wc -c < "$1" 2>/dev/null | awk '{print $1+0}'; }
+
+# Backdate a path by $2 days. `date -r` is BSD, `date -d @` is GNU.
+backdate() {
+  local path="$1" days="$2" secs
+  secs=$(( $(date +%s) - days * 86400 ))
+  touch -t "$(date -u -r "$secs" +%Y%m%d%H%M 2>/dev/null || date -u -d "@$secs" +%Y%m%d%H%M)" "$path"
+}
+
+case_under_threshold_is_noop() {
+  local d; d="$(mk_logs_dir)"
+  # 63 MiB — just under the 64 MiB threshold, so this also pins the boundary.
+  mk_file_of_size "$d/server.log" $((63 * 1024 * 1024))
+  "$ROTATE" "$d" >/dev/null 2>&1
+  local rc=$?
+  [ "$rc" -eq 0 ] || { echo "  expected exit 0, got $rc"; rm -rf "$d"; return 1; }
+  [ ! -e "$d/server.log.1.gz" ] || { echo "  rotated a 63 MiB file"; rm -rf "$d"; return 1; }
+  [ "$(size_of "$d/server.log")" -eq $((63 * 1024 * 1024)) ] \
+    || { echo "  file was modified"; rm -rf "$d"; return 1; }
+  rm -rf "$d"; return 0
+}
+
+case_over_threshold_rotates_and_truncates() {
+  local d; d="$(mk_logs_dir)"
+  mk_file_of_size "$d/server.log" $((65 * 1024 * 1024))
+  "$ROTATE" "$d" >/dev/null 2>&1
+  [ -f "$d/server.log.1.gz" ] || { echo "  no .1.gz produced"; rm -rf "$d"; return 1; }
+  # The live file must still exist (readers hardcode the path) and be small:
+  # it holds only the marker line.
+  [ -f "$d/server.log" ] || { echo "  live path missing after rotate"; rm -rf "$d"; return 1; }
+  local live; live="$(size_of "$d/server.log")"
+  [ "$live" -lt 4096 ] || { echo "  live file not truncated: $live bytes"; rm -rf "$d"; return 1; }
+  rm -rf "$d"; return 0
+}
+
+case_marker_line_present() {
+  local d; d="$(mk_logs_dir)"
+  mk_file_of_size "$d/server.log" $((65 * 1024 * 1024))
+  "$ROTATE" "$d" >/dev/null 2>&1
+  grep -q '\[logs-rotate\] rotated file=server.log prev-bytes=68157440 prev-file=server.log.1.gz keep=5' "$d/server.log" \
+    || { echo "  marker line absent or malformed:"; cat "$d/server.log"; rm -rf "$d"; return 1; }
+  # The marker must be datable from itself.
+  grep -qE '^[0-9]{4}-[0-9]{2}-[0-9]{2}T[0-9]{2}:[0-9]{2}:[0-9]{2}Z \[logs-rotate\]' "$d/server.log" \
+    || { echo "  marker line not timestamped"; rm -rf "$d"; return 1; }
+  rm -rf "$d"; return 0
+}
+
+case_generation_shift_drops_the_sixth() {
+  local d; d="$(mk_logs_dir)"
+  # Seed 5 existing generations, each identifiable by content.
+  local i
+  for i in 1 2 3 4 5; do echo "gen$i" | gzip -c > "$d/server.log.$i.gz"; done
+  mk_file_of_size "$d/server.log" $((65 * 1024 * 1024))
+  "$ROTATE" "$d" >/dev/null 2>&1
+  # .5.gz must now hold what .4.gz held; the old .5.gz is gone.
+  [ "$(gzip -cd "$d/server.log.5.gz")" = "gen4" ] || { echo "  .5.gz is not the old .4.gz"; rm -rf "$d"; return 1; }
+  [ "$(gzip -cd "$d/server.log.2.gz")" = "gen1" ] || { echo "  .2.gz is not the old .1.gz"; rm -rf "$d"; return 1; }
+  [ ! -e "$d/server.log.6.gz" ] || { echo "  a 6th generation was created"; rm -rf "$d"; return 1; }
+  rm -rf "$d"; return 0
+}
+
+case_lock_held_is_noop_exit_zero() {
+  local d; d="$(mk_logs_dir)"
+  mk_file_of_size "$d/server.log" $((65 * 1024 * 1024))
+  mkdir "$d/.rotate.lock"          # fresh lock, not stale
+  "$ROTATE" "$d" >/dev/null 2>&1
+  local rc=$?
+  [ "$rc" -eq 0 ] || { echo "  expected exit 0 when lock held, got $rc"; rm -rf "$d"; return 1; }
+  [ ! -e "$d/server.log.1.gz" ] || { echo "  rotated despite held lock"; rm -rf "$d"; return 1; }
+  # A held lock must survive the tick that could not take it.
+  [ -d "$d/.rotate.lock" ] || { echo "  another holder's lock was removed"; rm -rf "$d"; return 1; }
+  rm -rf "$d"; return 0
+}
+
+case_stale_lock_is_reclaimed() {
+  local d; d="$(mk_logs_dir)"
+  mk_file_of_size "$d/server.log" $((65 * 1024 * 1024))
+  mkdir "$d/.rotate.lock"
+  backdate "$d/.rotate.lock" 1     # 1 day > STALE_LOCK_MINUTES=30
+  "$ROTATE" "$d" >/dev/null 2>&1
+  [ -f "$d/server.log.1.gz" ] || { echo "  stale lock was not reclaimed"; rm -rf "$d"; return 1; }
+  rm -rf "$d"; return 0
+}
+
+case_missing_logs_dir_is_noop_exit_zero() {
+  "$ROTATE" "/nonexistent/logs/dir/for/test" >/dev/null 2>&1
+  local rc=$?
+  [ "$rc" -eq 0 ] || { echo "  expected exit 0 on missing dir, got $rc"; return 1; }
+  return 0
+}
+
+case_lock_released_on_exit() {
+  local d; d="$(mk_logs_dir)"
+  mk_file_of_size "$d/server.log" $((1 * 1024 * 1024))
+  "$ROTATE" "$d" >/dev/null 2>&1
+  [ ! -e "$d/.rotate.lock" ] || { echo "  lock not released"; rm -rf "$d"; return 1; }
+  rm -rf "$d"; return 0
+}
+
+case_purges_rc_child_older_than_seven_days() {
+  local d; d="$(mk_logs_dir)"
+  echo old > "$d/rc-child-aaaa.log"; backdate "$d/rc-child-aaaa.log" 9
+  echo new > "$d/rc-child-bbbb.log"   # today
+  "$ROTATE" "$d" >/dev/null 2>&1
+  [ ! -e "$d/rc-child-aaaa.log" ] || { echo "  9-day-old rc-child survived"; rm -rf "$d"; return 1; }
+  [ -f "$d/rc-child-bbbb.log" ] || { echo "  today's rc-child was purged"; rm -rf "$d"; return 1; }
+  rm -rf "$d"; return 0
+}
+
+case_purge_does_not_touch_server_log() {
+  local d; d="$(mk_logs_dir)"
+  echo old > "$d/server.log"; backdate "$d/server.log" 90
+  echo x | gzip -c > "$d/server.log.1.gz"; backdate "$d/server.log.1.gz" 90
+  "$ROTATE" "$d" >/dev/null 2>&1
+  [ -f "$d/server.log" ] || { echo "  server.log was purged by age"; rm -rf "$d"; return 1; }
+  [ -f "$d/server.log.1.gz" ] || { echo "  a kept generation was purged by age"; rm -rf "$d"; return 1; }
+  rm -rf "$d"; return 0
+}
+
+case_mcp_stderr_live_file_size_rotates() {
+  local d; d="$(mk_logs_dir)"
+  mk_file_of_size "$d/mcp-memory-stderr-2026-07-17.log" $((65 * 1024 * 1024))
+  "$ROTATE" "$d" >/dev/null 2>&1
+  [ -f "$d/mcp-memory-stderr-2026-07-17.log.1.gz" ] \
+    || { echo "  live mcp stderr log was not size-rotated"; rm -rf "$d"; return 1; }
+  rm -rf "$d"; return 0
+}
+
+# --- Code-review regressions (2026-07-17) -----------------------------------
+
+# A failing gzip must not cost a generation. The shift used to run BEFORE the
+# gzip, so every failure moved .4->.5 ... .1->.2 and wrote nothing to .1 —
+# leaving a hole and dropping the oldest. The trigger is ENOSPC, i.e. exactly
+# the condition rotation exists to prevent: 5 failing ticks destroyed 4 of the
+# 5 retained generations while never truncating the live file.
+case_gzip_failure_preserves_generations() {
+  local d; d="$(mk_logs_dir)"
+  local bin="$d/../bin-$$"; mkdir -p "$bin"
+  printf '#!/bin/sh\nexit 1\n' > "$bin/gzip"; chmod +x "$bin/gzip"
+  local i
+  for i in 1 2 3 4 5; do echo "gen$i" | gzip -c > "$d/server.log.$i.gz"; done
+  mk_file_of_size "$d/server.log" $((65 * 1024 * 1024))
+
+  PATH="$bin:$PATH" "$ROTATE" "$d" >/dev/null 2>&1
+  local rc=$?
+
+  local fail=0
+  for i in 1 2 3 4 5; do
+    if [ "$(gzip -cd "$d/server.log.$i.gz" 2>/dev/null)" != "gen$i" ]; then
+      echo "  .$i.gz should still be gen$i, got: $(gzip -cd "$d/server.log.$i.gz" 2>/dev/null)"; fail=1
+    fi
+  done
+  # The live file must be untouched — a failed rotate never truncates.
+  [ "$(size_of "$d/server.log")" -eq $((65 * 1024 * 1024)) ] \
+    || { echo "  live file was truncated despite gzip failure"; fail=1; }
+  [ "$rc" -eq 0 ] || { echo "  expected exit 0, got $rc"; fail=1; }
+  [ ! -e "$d/server.log.1.gz.tmp" ] || { echo "  temp file left behind"; fail=1; }
+  rm -rf "$d" "$bin"; return $fail
+}
+
+# The mcp stderr tee opens its file at process start and holds the stream for the
+# process's whole life, writing ONLY when the server emits stderr — which a
+# healthy server does not do for days. So a live file's mtime DOES go stale, and
+# deleting it sends every later stderr write to an unlinked inode: invisible
+# exactly when the fault you are chasing finally appears. Never purge these.
+case_never_purges_mcp_stderr_by_age() {
+  local d; d="$(mk_logs_dir)"
+  echo quiet > "$d/mcp-memory-stderr-2026-01-01.log"
+  backdate "$d/mcp-memory-stderr-2026-01-01.log" 90
+  echo x | gzip -c > "$d/mcp-memory-stderr-2026-01-01.log.1.gz"
+  backdate "$d/mcp-memory-stderr-2026-01-01.log.1.gz" 90
+  "$ROTATE" "$d" >/dev/null 2>&1
+  [ -f "$d/mcp-memory-stderr-2026-01-01.log" ] \
+    || { echo "  a 90-day-stale mcp stderr log was purged — it may still be held open"; rm -rf "$d"; return 1; }
+  [ -f "$d/mcp-memory-stderr-2026-01-01.log.1.gz" ] \
+    || { echo "  an mcp generation was purged by age"; rm -rf "$d"; return 1; }
+  rm -rf "$d"; return 0
+}
+
+# rc-child's 16 MiB cap does NOT hold: `written` is in-memory per manager
+# process, so a manager restart resumes appending to the same path. Observed at
+# 54 MB on sitedesk-code (3.25x the cap). A live long-lived session's file has a
+# fresh mtime forever, so age-purge never reaches it — it needs size rotation.
+case_rc_child_size_rotates() {
+  local d; d="$(mk_logs_dir)"
+  mk_file_of_size "$d/rc-child-live-session.log" $((65 * 1024 * 1024))
+  "$ROTATE" "$d" >/dev/null 2>&1
+  [ -f "$d/rc-child-live-session.log.1.gz" ] \
+    || { echo "  an oversized rc-child log was not size-rotated"; rm -rf "$d"; return 1; }
+  local live; live="$(size_of "$d/rc-child-live-session.log")"
+  [ "$live" -lt 4096 ] || { echo "  rc-child live file not truncated: $live"; rm -rf "$d"; return 1; }
+  rm -rf "$d"; return 0
+}
+
+run_case "gzip failure preserves generations"    case_gzip_failure_preserves_generations
+run_case "never purges mcp stderr by age"        case_never_purges_mcp_stderr_by_age
+run_case "rc-child size-rotates"                 case_rc_child_size_rotates
+
+run_case "under threshold is a no-op"            case_under_threshold_is_noop
+run_case "over threshold rotates and truncates"  case_over_threshold_rotates_and_truncates
+run_case "marker line present and timestamped"   case_marker_line_present
+run_case "generation shift drops the sixth"      case_generation_shift_drops_the_sixth
+run_case "lock held is a no-op, exit 0"          case_lock_held_is_noop_exit_zero
+run_case "stale lock is reclaimed"               case_stale_lock_is_reclaimed
+run_case "missing logs dir is a no-op, exit 0"   case_missing_logs_dir_is_noop_exit_zero
+run_case "lock released on exit"                 case_lock_released_on_exit
+run_case "purges rc-child older than 7 days"     case_purges_rc_child_older_than_seven_days
+run_case "purge does not touch server.log"       case_purge_does_not_touch_server_log
+run_case "mcp stderr live file size-rotates"     case_mcp_stderr_live_file_size_rotates
+
+echo ""
+echo "===================="
+echo "PASS: $PASS  FAIL: $FAIL"
+[ "$FAIL" -eq 0 ]