@rubytech/create-maxy-code 0.1.333 → 0.1.334

package/dist/index.js

@@ -1564,6 +1564,28 @@ WantedBy=multi-user.target
     spawnSync("sudo", ["systemctl", "daemon-reload"], { stdio: "inherit" });
     console.log("  [privileged] systemctl enable");
     shell("systemctl", ["enable", serviceName], { sudo: true });
+    // Tear down a legacy-package dedicated Neo4j unit pinning the same port.
+    // The `-code` rewrite packages (`create-<brand>-code`) replace the legacy
+    // `create-<brand>` packages. When migrating a device from legacy to -code,
+    // both packages' dedicated Neo4j units exist (`neo4j-<brand>.service` and
+    // `neo4j-<brand>-code.service`) and both try to bind the same dedicated
+    // bolt port. The legacy unit wins the race (it boots first because it's
+    // alphabetically earlier in systemd's load order), the new unit silently
+    // fails with `bind failed -98 Address already in use`, and the seed step
+    // talks to the legacy instance with the wrong password — auth fails with
+    // a misleading "client is unauthorized" (observed on beacons).
+    if (brandSuffix.endsWith("-code")) {
+        const legacyBrand = brandSuffix.slice(0, -"-code".length);
+        const legacyUnit = `neo4j-${legacyBrand}.service`;
+        const legacyUnitFile = `/etc/systemd/system/${legacyUnit}`;
+        if (existsSync(legacyUnitFile)) {
+            const legacyMsg = `  [neo4j] legacy unit detected (${legacyUnit}) — stopping + disabling so the -code unit owns port ${NEO4J_PORT}`;
+            console.log(legacyMsg);
+            logFile(legacyMsg);
+            shell("systemctl", ["stop", legacyUnit], { sudo: true, bestEffort: true });
+            shell("systemctl", ["disable", legacyUnit], { sudo: true, bestEffort: true });
+        }
+    }
     // skip stop+disable when a peer brand on this host still depends
     // on the apt `neo4j.service` (port 7687). Disabling it would kill the peer's
     // database reproducer on Neo's laptop. The kept-active path is
@@ -2856,7 +2878,29 @@ function writeInstallDefaults(accountId) {
     mkdirSync(publicDir, { recursive: true });
     const publicTemplatesDir = join(INSTALL_DIR, "platform/templates/agents/public");
     const publicIdentityDst = join(publicDir, "IDENTITY.md");
-    cpSync(join(publicTemplatesDir, "IDENTITY.md"), publicIdentityDst);
+    const publicIdentitySrc = join(publicTemplatesDir, "IDENTITY.md");
+    cpSync(publicIdentitySrc, publicIdentityDst);
+    // Defensive verify: a 0-byte IDENTITY.md silently traps the brand server
+    // in STARTING (the reachability auditor logs `reachable=false reason=files
+    // -missing IDENTITY.md:empty` every minute and the splash never clears).
+    // Observed on 192.168.88.16 after a re-install: source 1655 bytes, dest
+    // 0 bytes. Loud-fail here so a corrupt copy can never reach the device's
+    // runtime.
+    try {
+        const srcBytes = statSync(publicIdentitySrc).size;
+        const dstBytes = statSync(publicIdentityDst).size;
+        if (dstBytes === 0 || dstBytes !== srcBytes) {
+            throw new Error(`public-identity copy verify failed: src=${publicIdentitySrc} (${srcBytes} bytes) ` +
+                `dst=${publicIdentityDst} (${dstBytes} bytes). A 0-byte or partial copy traps the brand ` +
+                `server in STARTING forever — re-run the installer after restoring the template, or ` +
+                `report this as a copy regression.`);
+        }
+    }
+    catch (err) {
+        if (err instanceof Error && err.message.startsWith("public-identity copy verify failed"))
+            throw err;
+        throw new Error(`public-identity verify stat failed: ${err instanceof Error ? err.message : String(err)}`);
+    }
     console.log(`  [install-defaults] public-identity path=${publicIdentityDst}`);
     logFile(`  [install-defaults] public-identity path=${publicIdentityDst}`);
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@rubytech/create-maxy-code",
-  "version": "0.1.333",
+  "version": "0.1.334",
   "description": "Install Maxy — AI for Productive People",
   "bin": {
     "create-maxy-code": "./dist/index.js"

package/payload/platform/scripts/lib/provision-account-dir.sh

@@ -145,6 +145,15 @@ SETTINGS_EOF
     [ "$_AGENT_NAME" = "admin" ] && continue
     [ -f "$_AGENT_DIR/IDENTITY.md" ] || continue
     cp "$TEMPLATES_DIR/agents/public/IDENTITY.md" "$_AGENT_DIR/IDENTITY.md"
+    # Defensive verify — a 0-byte cp traps the brand server in STARTING (the
+    # reachability auditor reports `reachable=false reason=files-missing
+    # IDENTITY.md:empty` every minute). Observed on 192.168.88.16 after a
+    # re-install: source 1655 bytes, dest 0 bytes. Loud-fail here so the
+    # operator sees the bad write at install time, not the splash forever.
+    if [ ! -s "$_AGENT_DIR/IDENTITY.md" ]; then
+      echo "  [setup] FATAL agents/$_AGENT_NAME/IDENTITY.md is empty after copy from $TEMPLATES_DIR/agents/public/IDENTITY.md ($(wc -c < "$TEMPLATES_DIR/agents/public/IDENTITY.md") bytes); aborting before the brand server starts" >&2
+      return 1
+    fi
     echo "  agents/$_AGENT_NAME/IDENTITY.md re-synced"
   done