@rubytech/create-maxy-code 0.1.331 → 0.1.332

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (40) hide show
  1. package/package.json +1 -1
  2. package/payload/platform/lib/mcp-spawn-tee/dist/index.d.ts +24 -24
  3. package/payload/platform/lib/mcp-spawn-tee/dist/index.js +109 -75
  4. package/payload/platform/lib/mcp-spawn-tee/dist/index.js.map +1 -1
  5. package/payload/platform/lib/mcp-spawn-tee/src/__tests__/spawn-tee.test.ts +56 -19
  6. package/payload/platform/lib/mcp-spawn-tee/src/index.ts +112 -77
  7. package/payload/platform/neo4j/schema.cypher +58 -4
  8. package/payload/platform/plugins/admin/lib/mcp-spawn-tee/index.js +109 -75
  9. package/payload/platform/plugins/aeo/lib/mcp-spawn-tee/index.js +109 -75
  10. package/payload/platform/plugins/browser/lib/mcp-spawn-tee/index.js +109 -75
  11. package/payload/platform/plugins/contacts/lib/mcp-spawn-tee/index.js +109 -75
  12. package/payload/platform/plugins/contacts/mcp/dist/tools/__tests__/group-create.test.d.ts +2 -0
  13. package/payload/platform/plugins/contacts/mcp/dist/tools/__tests__/group-create.test.d.ts.map +1 -0
  14. package/payload/platform/plugins/contacts/mcp/dist/tools/__tests__/group-create.test.js +112 -0
  15. package/payload/platform/plugins/contacts/mcp/dist/tools/__tests__/group-create.test.js.map +1 -0
  16. package/payload/platform/plugins/contacts/mcp/dist/tools/__tests__/group-manage.test.d.ts +2 -0
  17. package/payload/platform/plugins/contacts/mcp/dist/tools/__tests__/group-manage.test.d.ts.map +1 -0
  18. package/payload/platform/plugins/contacts/mcp/dist/tools/__tests__/group-manage.test.js +102 -0
  19. package/payload/platform/plugins/contacts/mcp/dist/tools/__tests__/group-manage.test.js.map +1 -0
  20. package/payload/platform/plugins/contacts/mcp/dist/tools/group-create.d.ts.map +1 -1
  21. package/payload/platform/plugins/contacts/mcp/dist/tools/group-create.js +7 -2
  22. package/payload/platform/plugins/contacts/mcp/dist/tools/group-create.js.map +1 -1
  23. package/payload/platform/plugins/contacts/mcp/dist/tools/group-manage.d.ts.map +1 -1
  24. package/payload/platform/plugins/contacts/mcp/dist/tools/group-manage.js +5 -4
  25. package/payload/platform/plugins/contacts/mcp/dist/tools/group-manage.js.map +1 -1
  26. package/payload/platform/plugins/email/lib/mcp-spawn-tee/index.js +109 -75
  27. package/payload/platform/plugins/memory/lib/mcp-spawn-tee/index.js +109 -75
  28. package/payload/platform/plugins/memory/references/schema-estate-agent.md +17 -5
  29. package/payload/platform/plugins/outlook/lib/mcp-spawn-tee/index.js +109 -75
  30. package/payload/platform/plugins/quickbooks/lib/mcp-spawn-tee/index.js +109 -75
  31. package/payload/platform/plugins/replicate/lib/mcp-spawn-tee/index.js +109 -75
  32. package/payload/platform/plugins/scheduling/lib/mcp-spawn-tee/index.js +109 -75
  33. package/payload/platform/plugins/telegram/lib/mcp-spawn-tee/index.js +109 -75
  34. package/payload/platform/plugins/url-get/lib/mcp-spawn-tee/index.js +109 -75
  35. package/payload/platform/plugins/whatsapp/lib/mcp-spawn-tee/index.js +109 -75
  36. package/payload/platform/plugins/work/lib/mcp-spawn-tee/index.js +109 -75
  37. package/payload/platform/plugins/workflows/lib/mcp-spawn-tee/index.js +109 -75
  38. package/payload/platform/scripts/seed-neo4j.sh +18 -0
  39. package/payload/premium-plugins/writer-craft/lib/mcp-spawn-tee/index.js +109 -75
  40. package/payload/server/server.js +291 -213
@@ -1,46 +1,46 @@
1
1
  #!/usr/bin/env node
2
2
  /**
3
- * MCP spawn-tee — parent-side stderr capture + lifecycle observability.
3
+ * MCP spawn-tee — in-process stderr capture + lifecycle observability.
4
4
  *
5
5
  * Claude Code spawns each MCP server itself; the platform never holds a
6
- * ChildProcess handle. This wrapper sits between Claude Code and the real
7
- * MCP server: Claude Code runs `node <this> <real-entry>`, and the wrapper
8
- * spawns the real entry with `stdio:['inherit','inherit','pipe']` so stdin
9
- * and stdout (the JSON-RPC channel) pass through byte-identical. Only stderr
10
- * is intercepted, and only for logging.
6
+ * ChildProcess handle. This shim sits between Claude Code and the real MCP
7
+ * server: Claude Code runs `node <this> <real-entry>`, and the shim runs the
8
+ * real entry IN ITS OWN PROCESS via dynamic import() — one node runtime, not
9
+ * two. Before importing, it replaces process.stderr.write with a tee so every
10
+ * stderr byte the server writes is mirrored to the log sinks; stdin and stdout
11
+ * (the JSON-RPC channel) are never touched.
11
12
  *
12
- * Because the wrapper IS the helper's parent, it observes the helper's true
13
- * exit code, signal, and lifetime for every death mode — including a SIGKILL
14
- * or a transport-layer crash that an in-process handler would miss.
13
+ * Claude Code CLI shim (this file) = node running <real-entry> in-process
14
+ * stdin/stdout : untouched (JSON-RPC channel)
15
+ * stderr : process.stderr.write teed → per-date + per-session + passthrough
15
16
  *
16
- * Claude Code CLI → wrapper (this file) child = node <real-entry>
17
- * child stdin/stdout : inherited (Claude Code pipe, untouched)
18
- * child stderr : piped → per-date log + per-session log + passthrough
19
- *
20
- * Destinations (Task 706):
17
+ * Destinations (Task 706) unchanged:
21
18
  * - `${LOG_DIR}/mcp-<name>-stderr-<date>.log` — per-date raw (back-compat;
22
19
  * the in-process mcp-stderr-tee and the [mcp-init-error] probe read it).
23
20
  * - `${LOG_DIR}/mcp-<name>-<SESSION_ID>.log` — per-session raw + lifecycle
24
- * lines; wrapper-only, so it never mixes the enumeration copy with the
25
- * live copy. Authoritative sink. Absent when SESSION_ID is unset
26
- * (enumeration spawn) — then the per-date file is the fallback.
21
+ * lines. Authoritative sink. Absent when SESSION_ID is unset (enumeration
22
+ * spawn) then the per-date file is the fallback.
27
23
  * - `server.log` via the loopback log-ingest route — best-effort mirror of
28
- * the [mcp-helper] lifecycle lines. A dropped POST loses nothing because
29
- * the per-session file already holds the line (written synchronously).
24
+ * the [mcp-helper] lifecycle lines.
30
25
  *
31
- * Lifecycle lines, correlation key `session=<id8> server=<name>`:
26
+ * Lifecycle lines, correlation key `session=<id8> server=<name>` — unchanged:
32
27
  * [mcp-helper] op=spawn ... pid= entry=
33
28
  * [mcp-helper] op=boot ... head=<first stderr bytes>
34
- * [mcp-helper] op=exit ... code= signal= lifetimeMs= stderr-tail= (always)
29
+ * [mcp-helper] op=exit ... code= signal= lifetimeMs= stderr-tail=
30
+ *
31
+ * Process model (Task 989): the shim IS the server's process. op=exit fires
32
+ * from process.on("exit"), so it covers a normal exit, a non-zero exit, an
33
+ * uncaught throw (code 1), and a catchable-signal exit (SIGTERM/SIGINT/SIGHUP,
34
+ * whose handlers record the signal name). An external SIGKILL is uncatchable
35
+ * and leaves no op=exit line — the per-session stderr tail already on disk and
36
+ * Claude Code's own transport-drop are the evidence for that death mode.
35
37
  *
36
- * The wrapper never writes to fd 1 (stdout) — that is the JSON-RPC channel.
37
- * SIGTERM/SIGINT are forwarded to the child so a Claude Code shutdown does
38
- * not orphan it; the child exit code/signal is propagated verbatim.
38
+ * The shim never writes to fd 1 (stdout) — that is the JSON-RPC channel.
39
39
  */
40
40
 
41
- import { spawn } from "node:child_process";
42
41
  import { appendFileSync, mkdirSync } from "node:fs";
43
42
  import { resolve } from "node:path";
43
+ import { pathToFileURL } from "node:url";
44
44
 
45
45
  const SERVER_NAME = process.env.MCP_SPAWN_TEE_NAME ?? "unknown";
46
46
  const LOG_DIR = process.env.LOG_DIR;
@@ -51,8 +51,8 @@ const ENTRY = process.argv[2];
51
51
  const SESSION_ID8 = SESSION_ID ? SESSION_ID.slice(0, 8) : "—";
52
52
  const spawnStamp = Date.now();
53
53
 
54
- // Per-session raw + lifecycle log (Task 706). Wrapper-only. Empty SESSION_ID
55
- // (enumeration spawn) → undefined, and the per-date file is the fallback.
54
+ // Per-session raw + lifecycle log (Task 706). Empty SESSION_ID (enumeration
55
+ // spawn) → undefined, and the per-date file is the fallback.
56
56
  const perSessionPath = LOG_DIR && SESSION_ID
57
57
  ? resolve(LOG_DIR, `mcp-${SERVER_NAME}-${SESSION_ID}.log`)
58
58
  : undefined;
@@ -60,16 +60,28 @@ const perDatePath = LOG_DIR
60
60
  ? resolve(LOG_DIR, `mcp-${SERVER_NAME}-stderr-${new Date(spawnStamp).toISOString().slice(0, 10)}.log`)
61
61
  : undefined;
62
62
 
63
- // Rolling tail of child stderr for op=exit. Capped so a chatty child cannot
63
+ // Rolling tail of entry stderr for op=exit. Capped so a chatty server cannot
64
64
  // grow the buffer without bound.
65
65
  const TAIL_CAP = 2048;
66
66
  let stderrTail = "";
67
67
  let bootEmitted = false;
68
+ let exitEmitted = false;
69
+ let exitSignal: NodeJS.Signals | undefined;
70
+
71
+ // The real stderr writer, captured before the tee replaces it. Lifecycle lines
72
+ // and stderr passthrough both go through this so they are never re-teed into
73
+ // the per-date sink nor recursed back into the patched writer.
74
+ const rawStderrWrite = process.stderr.write.bind(process.stderr);
75
+
76
+ // LOG_DIR is created once, lazily, on the first successful append — not per
77
+ // chunk. teeWrite runs on the server's own stderr hot path now, so a per-call
78
+ // mkdirSync would be two syscalls per log line for nothing.
79
+ let logDirReady = false;
68
80
 
69
81
  function appendSafe(path: string | undefined, data: string | Uint8Array): void {
70
82
  if (!path || !LOG_DIR) return;
71
83
  try {
72
- mkdirSync(LOG_DIR, { recursive: true });
84
+ if (!logDirReady) { mkdirSync(LOG_DIR, { recursive: true }); logDirReady = true; }
73
85
  appendFileSync(path, data);
74
86
  } catch {
75
87
  /* unwritable destination — never mask primary output */
@@ -77,14 +89,15 @@ function appendSafe(path: string | undefined, data: string | Uint8Array): void {
77
89
  }
78
90
 
79
91
  // Best-effort mirror of a lifecycle line to server.log via the loopback
80
- // log-ingest route. Fire-and-forget: the per-session file is authoritative,
81
- // so a dropped POST (unreachable port, process exiting) loses nothing.
92
+ // log-ingest route. Fire-and-forget: the per-session file is authoritative, so
93
+ // a dropped POST loses nothing. On the "exit" event the loop is stopping, so
94
+ // the op=exit mirror may not flush — the per-session line, written sync, holds.
82
95
  function postToServerLog(suffix: string, level: "info" | "error"): void {
83
96
  if (!PLATFORM_PORT) return;
84
97
  try {
85
98
  const ctrl = new AbortController();
86
99
  const t = setTimeout(() => ctrl.abort(), 500);
87
- t.unref?.(); // never let the abort timer keep the wrapper's event loop alive
100
+ t.unref?.(); // never let the abort timer keep the shim's event loop alive
88
101
  void fetch(`http://127.0.0.1:${PLATFORM_PORT}/api/admin/log-ingest`, {
89
102
  method: "POST",
90
103
  headers: { "content-type": "application/json" },
@@ -97,13 +110,14 @@ function postToServerLog(suffix: string, level: "info" | "error"): void {
97
110
  }
98
111
 
99
112
  // Emit one [mcp-helper] lifecycle line: authoritative per-session file (sync,
100
- // survives process.exit), the wrapper's own stderr (journald / Claude Code
101
- // visibility), and a best-effort server.log mirror. `suffix` is the line body
102
- // after the tag and carries no newline (the log-ingest route rejects newlines).
113
+ // survives process.exit), the shim's own stderr via the RAW writer (journald /
114
+ // Claude Code visibility, never re-teed), and a best-effort server.log mirror.
115
+ // `suffix` is the line body after the tag and carries no newline (the
116
+ // log-ingest route rejects newlines).
103
117
  function emitLifecycle(suffix: string, level: "info" | "error"): void {
104
118
  const line = `[mcp-helper] ${suffix}\n`;
105
119
  appendSafe(perSessionPath, line);
106
- try { process.stderr.write(line); } catch { /* stderr closed */ }
120
+ try { rawStderrWrite(line); } catch { /* stderr closed */ }
107
121
  postToServerLog(suffix, level);
108
122
  }
109
123
 
@@ -112,52 +126,73 @@ if (!ENTRY) {
112
126
  process.exit(2);
113
127
  }
114
128
 
115
- const child = spawn(process.execPath, [ENTRY], {
116
- stdio: ["inherit", "inherit", "pipe"],
117
- env: process.env,
118
- });
119
-
120
- emitLifecycle(`op=spawn session=${SESSION_ID8} server=${SERVER_NAME} pid=${child.pid ?? -1} entry=${ENTRY}`, "info");
121
-
122
- child.on("error", (err) => {
123
- const msg = err instanceof Error ? err.message : String(err);
124
- emitLifecycle(`op=error session=${SESSION_ID8} server=${SERVER_NAME} reason=${JSON.stringify(`spawn error: ${msg}`)}`, "error");
125
- process.exit(127);
126
- });
127
-
128
- if (child.stderr) {
129
- child.stderr.on("data", (chunk: Buffer) => {
130
- appendSafe(perDatePath, chunk); // per-date raw (back-compat)
131
- appendSafe(perSessionPath, chunk); // per-session raw (Task 706)
132
- try { process.stderr.write(chunk); } catch { /* stderr closed */ } // passthrough
133
- stderrTail = (stderrTail + chunk.toString("utf8")).slice(-TAIL_CAP);
134
- if (!bootEmitted) {
135
- bootEmitted = true;
136
- const head = chunk.toString("utf8").split("\n")[0].slice(0, 200);
137
- emitLifecycle(`op=boot session=${SESSION_ID8} server=${SERVER_NAME} head=${JSON.stringify(head)}`, "info");
129
+ // Replace process.stderr.write with a tee: mirror every server stderr byte to
130
+ // the per-date and per-session sinks, keep a rolling tail for op=exit, emit
131
+ // op=boot on the first bytes, then pass the write through to the real stderr.
132
+ const teeWrite = ((...args: unknown[]): boolean => {
133
+ const chunk = args[0] as string | Uint8Array;
134
+ appendSafe(perDatePath, chunk); // per-date raw (back-compat)
135
+ appendSafe(perSessionPath, chunk); // per-session raw (Task 706)
136
+ const text = typeof chunk === "string" ? chunk : Buffer.from(chunk).toString("utf8");
137
+ stderrTail = (stderrTail + text).slice(-TAIL_CAP);
138
+ if (!bootEmitted) {
139
+ bootEmitted = true;
140
+ const head = text.split("\n")[0].slice(0, 200);
141
+ emitLifecycle(`op=boot session=${SESSION_ID8} server=${SERVER_NAME} head=${JSON.stringify(head)}`, "info");
142
+ }
143
+ return (rawStderrWrite as (...a: unknown[]) => boolean)(...args); // passthrough
144
+ }) as typeof process.stderr.write;
145
+ process.stderr.write = teeWrite;
146
+
147
+ // Catchable-signal handling. The shim drives the exit ONLY when it is the sole
148
+ // listener for the signal — i.e. the imported entry installed no handler of its
149
+ // own. In that case it records the signal (so op=exit carries signal=<sig>) and
150
+ // exits with 128+signum, mirroring the prior wrapper's exit-status convention.
151
+ //
152
+ // When the entry DID install a handler, the shim defers entirely and records
153
+ // nothing: the entry's handler decides the exit code, and op=exit reflects that
154
+ // exit verbatim. This matches the prior two-process model, where a child that
155
+ // caught the signal and exited cleanly was observed as code=0 signal=— (a clean
156
+ // self-exit), not as a signal death. Setting exitSignal here unconditionally
157
+ // would mislabel every graceful signal-driven shutdown as a signal kill.
158
+ function onSignal(sig: NodeJS.Signals, code: number): () => void {
159
+ return () => {
160
+ if (process.listenerCount(sig) === 1) {
161
+ exitSignal = sig;
162
+ process.exit(code);
138
163
  }
139
- });
164
+ };
140
165
  }
141
-
142
- const forward = (signal: NodeJS.Signals) => { if (!child.killed) child.kill(signal); };
143
- process.on("SIGTERM", () => forward("SIGTERM"));
144
- process.on("SIGINT", () => forward("SIGINT"));
145
-
146
- // Signal number, so a signal-killed child propagates as 128+signum (the
147
- // shell convention). `code` is null on a signal exit, so `128 + (code ?? 0)`
148
- // would collapse every signal to 128 and lose the signal identity in the
149
- // wrapper's own exit status.
150
- const SIGNUM: Record<string, number> = { SIGHUP: 1, SIGINT: 2, SIGQUIT: 3, SIGKILL: 9, SIGTERM: 15 };
151
-
152
- child.on("exit", (code, signal) => {
166
+ process.on("SIGTERM", onSignal("SIGTERM", 143));
167
+ process.on("SIGINT", onSignal("SIGINT", 130));
168
+ process.on("SIGHUP", onSignal("SIGHUP", 129));
169
+
170
+ // op=exit, emitted once from the process "exit" event. Sync-only — the loop is
171
+ // stopping. When a catchable signal caused the exit, report code=— signal=<sig>
172
+ // to match the prior wrapper's format; otherwise code=<exit code> signal=—.
173
+ process.on("exit", (code) => {
174
+ if (exitEmitted) return;
175
+ exitEmitted = true;
153
176
  const lifetimeMs = Date.now() - spawnStamp;
154
177
  const tail = stderrTail.slice(-200);
155
- const level: "info" | "error" = signal || (code ?? 0) !== 0 ? "error" : "info";
178
+ const codeField = exitSignal ? "" : String(code);
179
+ const level: "info" | "error" = exitSignal || code !== 0 ? "error" : "info";
156
180
  emitLifecycle(
157
- `op=exit session=${SESSION_ID8} server=${SERVER_NAME} pid=${child.pid ?? -1} ` +
158
- `code=${code ?? "—"} signal=${signal ?? "—"} lifetimeMs=${lifetimeMs} stderr-tail=${JSON.stringify(tail)}`,
181
+ `op=exit session=${SESSION_ID8} server=${SERVER_NAME} pid=${process.pid} ` +
182
+ `code=${codeField} signal=${exitSignal ?? "—"} lifetimeMs=${lifetimeMs} stderr-tail=${JSON.stringify(tail)}`,
159
183
  level,
160
184
  );
161
- if (signal) process.exit(128 + (SIGNUM[signal] ?? 0));
162
- process.exit(code ?? 0);
185
+ });
186
+
187
+ emitLifecycle(`op=spawn session=${SESSION_ID8} server=${SERVER_NAME} pid=${process.pid} entry=${ENTRY}`, "info");
188
+
189
+ // Run the real MCP server in THIS process. Dynamic import() (not top-level
190
+ // await — this file compiles to CommonJS) loads the ESM entry; a load-time
191
+ // failure mirrors the old child spawn-error path (op=error, exit 127). The
192
+ // op=exit handler is suppressed on this path so op=error stays the sole record.
193
+ import(pathToFileURL(ENTRY).href).catch((err: unknown) => {
194
+ const msg = err instanceof Error ? err.message : String(err);
195
+ exitEmitted = true;
196
+ emitLifecycle(`op=error session=${SESSION_ID8} server=${SERVER_NAME} reason=${JSON.stringify(`import error: ${msg}`)}`, "error");
197
+ process.exit(127);
163
198
  });
@@ -1217,18 +1217,26 @@ CREATE INDEX cloudflare_hostname_account IF NOT EXISTS
1217
1217
  FOR (h:CloudflareHostname) ON (h.accountId);
1218
1218
 
1219
1219
  // ----------------------------------------------------------
1220
- // Estate-agent ontology (Task 358) — Listing-centric model
1220
+ // Estate-agent ontology (Task 358) — Property-centric model
1221
1221
  // documented at platform/plugins/memory/references/schema-estate-agent.md.
1222
1222
  //
1223
+ // :Property is the obligatory top-level node: the physical property, with
1224
+ // its listing events beneath it. It carries the agency parent edge
1225
+ // (:Property)-[:LISTED_BY]->(:Organization {brandSlug}) (the ≥1-adjacency
1226
+ // write-gate parent) and (:Property)-[:HAS_LISTING]->(:Listing) to each of
1227
+ // its listing events. The pre-inversion (:Listing)-[:FOR_PROPERTY]->(:Property)
1228
+ // and (:Listing)-[:LISTED_BY]->(:Organization) edges are retired.
1229
+ //
1223
1230
  // These declarations exist primarily so the memory-write validator's
1224
1231
  // parseLabelsFromSchemaCypher() registers each label on a fresh deploy
1225
1232
  // where no node of the label has yet landed — without them, the first
1226
- // :Listing write from the listing-curator agent is rejected as "unknown
1227
- // label" against an empty db.labels() set.
1233
+ // :Property/:Listing write from the listing-curator agent is rejected as
1234
+ // "unknown label" against an empty db.labels() set.
1228
1235
  //
1229
1236
  // Idempotency contracts mirror schema-estate-agent.md:
1237
+ // :Property — (accountId, slug) on the address-normalised
1238
+ // slug; the obligatory hub.
1230
1239
  // :Listing / :Viewing / :Offer — (accountId, sourceSystem, sourceId)
1231
- // :Property — (accountId, slug)
1232
1240
  // :ImageObject — (accountId, listingSlug, url) for the
1233
1241
  // estate-agent variant, (accountId, name,
1234
1242
  // contentUrl) for the brand-asset variant.
@@ -1237,6 +1245,12 @@ FOR (h:CloudflareHostname) ON (h.accountId);
1237
1245
  // declared at the schema level — uniqueness
1238
1246
  // is enforced at write time by the curator
1239
1247
  // / brand-asset writer's MERGE clause.
1248
+ //
1249
+ // :Property already carries the account index, the (accountId, slug) unique
1250
+ // constraint, and a slot in the entity_search_admin fulltext union (its
1251
+ // n.address is in the ON EACH list) — no new index is added for the hub
1252
+ // inversion. The marketing embedding stays on :Listing; semantic search
1253
+ // targets the listing blurb/description, not the structural hub.
1240
1254
  // ----------------------------------------------------------
1241
1255
 
1242
1256
  CREATE CONSTRAINT listing_account_source_unique IF NOT EXISTS
@@ -1266,6 +1280,46 @@ FOR (p:Property) REQUIRE (p.accountId, p.slug) IS UNIQUE;
1266
1280
  CREATE INDEX property_account IF NOT EXISTS
1267
1281
  FOR (p:Property) ON (p.accountId);
1268
1282
 
1283
+ // Property-hub backfill — relink listing-only estate data deployed before
1284
+ // :Property became obligatory. Three idempotent passes, mirroring the
1285
+ // conversationId one-shot migration pattern above. Installs with no :Listing
1286
+ // nodes (every non-estate brand) match nothing in any pass. The standing
1287
+ // reconcile that proves orphanListings reached 0 is emitted per-deploy by
1288
+ // platform/scripts/seed-neo4j.sh.
1289
+ //
1290
+ // Pass 1 — convert any pre-inversion (:Listing)-[:FOR_PROPERTY]->(:Property)
1291
+ // to the parent-down (:Property)-[:HAS_LISTING]->(:Listing), reusing the
1292
+ // existing :Property, then drop the retired edge. Idempotent: once
1293
+ // FOR_PROPERTY is deleted a re-run matches nothing.
1294
+ MATCH (l:Listing)-[fp:FOR_PROPERTY]->(p:Property)
1295
+ MERGE (p)-[:HAS_LISTING]->(l)
1296
+ DELETE fp;
1297
+
1298
+ // Pass 2 — for every :Listing still lacking a :Property parent, synthesise a
1299
+ // :Property from the listing's address slug and attach
1300
+ // (:Property)-[:HAS_LISTING]->(:Listing). Idempotent: the HAS_LISTING guard
1301
+ // makes re-runs and already-migrated listings no-ops. Listings with a null
1302
+ // slug are deliberately excluded — there is no address key to MERGE on, and a
1303
+ // {slug: null} MERGE would collapse every slug-less listing into one bogus
1304
+ // (accountId, null) :Property. Such listings (a malformed pre-inversion write)
1305
+ // stay visible as orphanListings in the seed-neo4j.sh reconcile; recovering
1306
+ // them needs an address backfill, tracked in .tasks/996-estate-null-slug-listing-property-backfill.md.
1307
+ MATCH (l:Listing)
1308
+ WHERE l.slug IS NOT NULL AND NOT ( (:Property)-[:HAS_LISTING]->(l) )
1309
+ MERGE (p:Property {accountId: l.accountId, slug: l.slug})
1310
+ ON CREATE SET p.address = coalesce(l.displayName, l.addressLine),
1311
+ p.postcode = l.postcode
1312
+ MERGE (p)-[:HAS_LISTING]->(l);
1313
+
1314
+ // Pass 3 — relocate the agency edge from each :Listing onto its :Property
1315
+ // parent. Bound per LISTED_BY edge (one row per edge), so the DELETE never
1316
+ // double-fires on a single relationship regardless of how many listings share
1317
+ // a :Property or how many edges a listing carries. Idempotent: once a
1318
+ // listing's LISTED_BY is moved, a re-run matches nothing.
1319
+ MATCH (p:Property)-[:HAS_LISTING]->(l:Listing)-[old:LISTED_BY]->(o:Organization)
1320
+ MERGE (p)-[:LISTED_BY]->(o)
1321
+ DELETE old;
1322
+
1269
1323
  CREATE CONSTRAINT viewing_account_source_unique IF NOT EXISTS
1270
1324
  FOR (v:Viewing) REQUIRE (v.accountId, v.sourceSystem, v.sourceId) IS UNIQUE;
1271
1325
 
@@ -1,47 +1,47 @@
1
1
  #!/usr/bin/env node
2
2
  "use strict";
3
3
  /**
4
- * MCP spawn-tee — parent-side stderr capture + lifecycle observability.
4
+ * MCP spawn-tee — in-process stderr capture + lifecycle observability.
5
5
  *
6
6
  * Claude Code spawns each MCP server itself; the platform never holds a
7
- * ChildProcess handle. This wrapper sits between Claude Code and the real
8
- * MCP server: Claude Code runs `node <this> <real-entry>`, and the wrapper
9
- * spawns the real entry with `stdio:['inherit','inherit','pipe']` so stdin
10
- * and stdout (the JSON-RPC channel) pass through byte-identical. Only stderr
11
- * is intercepted, and only for logging.
7
+ * ChildProcess handle. This shim sits between Claude Code and the real MCP
8
+ * server: Claude Code runs `node <this> <real-entry>`, and the shim runs the
9
+ * real entry IN ITS OWN PROCESS via dynamic import() — one node runtime, not
10
+ * two. Before importing, it replaces process.stderr.write with a tee so every
11
+ * stderr byte the server writes is mirrored to the log sinks; stdin and stdout
12
+ * (the JSON-RPC channel) are never touched.
12
13
  *
13
- * Because the wrapper IS the helper's parent, it observes the helper's true
14
- * exit code, signal, and lifetime for every death mode — including a SIGKILL
15
- * or a transport-layer crash that an in-process handler would miss.
14
+ * Claude Code CLI shim (this file) = node running <real-entry> in-process
15
+ * stdin/stdout : untouched (JSON-RPC channel)
16
+ * stderr : process.stderr.write teed → per-date + per-session + passthrough
16
17
  *
17
- * Claude Code CLI → wrapper (this file) child = node <real-entry>
18
- * child stdin/stdout : inherited (Claude Code pipe, untouched)
19
- * child stderr : piped → per-date log + per-session log + passthrough
20
- *
21
- * Destinations (Task 706):
18
+ * Destinations (Task 706) unchanged:
22
19
  * - `${LOG_DIR}/mcp-<name>-stderr-<date>.log` — per-date raw (back-compat;
23
20
  * the in-process mcp-stderr-tee and the [mcp-init-error] probe read it).
24
21
  * - `${LOG_DIR}/mcp-<name>-<SESSION_ID>.log` — per-session raw + lifecycle
25
- * lines; wrapper-only, so it never mixes the enumeration copy with the
26
- * live copy. Authoritative sink. Absent when SESSION_ID is unset
27
- * (enumeration spawn) — then the per-date file is the fallback.
22
+ * lines. Authoritative sink. Absent when SESSION_ID is unset (enumeration
23
+ * spawn) then the per-date file is the fallback.
28
24
  * - `server.log` via the loopback log-ingest route — best-effort mirror of
29
- * the [mcp-helper] lifecycle lines. A dropped POST loses nothing because
30
- * the per-session file already holds the line (written synchronously).
25
+ * the [mcp-helper] lifecycle lines.
31
26
  *
32
- * Lifecycle lines, correlation key `session=<id8> server=<name>`:
27
+ * Lifecycle lines, correlation key `session=<id8> server=<name>` — unchanged:
33
28
  * [mcp-helper] op=spawn ... pid= entry=
34
29
  * [mcp-helper] op=boot ... head=<first stderr bytes>
35
- * [mcp-helper] op=exit ... code= signal= lifetimeMs= stderr-tail= (always)
30
+ * [mcp-helper] op=exit ... code= signal= lifetimeMs= stderr-tail=
31
+ *
32
+ * Process model (Task 989): the shim IS the server's process. op=exit fires
33
+ * from process.on("exit"), so it covers a normal exit, a non-zero exit, an
34
+ * uncaught throw (code 1), and a catchable-signal exit (SIGTERM/SIGINT/SIGHUP,
35
+ * whose handlers record the signal name). An external SIGKILL is uncatchable
36
+ * and leaves no op=exit line — the per-session stderr tail already on disk and
37
+ * Claude Code's own transport-drop are the evidence for that death mode.
36
38
  *
37
- * The wrapper never writes to fd 1 (stdout) — that is the JSON-RPC channel.
38
- * SIGTERM/SIGINT are forwarded to the child so a Claude Code shutdown does
39
- * not orphan it; the child exit code/signal is propagated verbatim.
39
+ * The shim never writes to fd 1 (stdout) — that is the JSON-RPC channel.
40
40
  */
41
41
  Object.defineProperty(exports, "__esModule", { value: true });
42
- const node_child_process_1 = require("node:child_process");
43
42
  const node_fs_1 = require("node:fs");
44
43
  const node_path_1 = require("node:path");
44
+ const node_url_1 = require("node:url");
45
45
  const SERVER_NAME = process.env.MCP_SPAWN_TEE_NAME ?? "unknown";
46
46
  const LOG_DIR = process.env.LOG_DIR;
47
47
  const SESSION_ID = process.env.SESSION_ID;
@@ -49,24 +49,37 @@ const PLATFORM_PORT = process.env.PLATFORM_PORT;
49
49
  const ENTRY = process.argv[2];
50
50
  const SESSION_ID8 = SESSION_ID ? SESSION_ID.slice(0, 8) : "—";
51
51
  const spawnStamp = Date.now();
52
- // Per-session raw + lifecycle log (Task 706). Wrapper-only. Empty SESSION_ID
53
- // (enumeration spawn) → undefined, and the per-date file is the fallback.
52
+ // Per-session raw + lifecycle log (Task 706). Empty SESSION_ID (enumeration
53
+ // spawn) → undefined, and the per-date file is the fallback.
54
54
  const perSessionPath = LOG_DIR && SESSION_ID
55
55
  ? (0, node_path_1.resolve)(LOG_DIR, `mcp-${SERVER_NAME}-${SESSION_ID}.log`)
56
56
  : undefined;
57
57
  const perDatePath = LOG_DIR
58
58
  ? (0, node_path_1.resolve)(LOG_DIR, `mcp-${SERVER_NAME}-stderr-${new Date(spawnStamp).toISOString().slice(0, 10)}.log`)
59
59
  : undefined;
60
- // Rolling tail of child stderr for op=exit. Capped so a chatty child cannot
60
+ // Rolling tail of entry stderr for op=exit. Capped so a chatty server cannot
61
61
  // grow the buffer without bound.
62
62
  const TAIL_CAP = 2048;
63
63
  let stderrTail = "";
64
64
  let bootEmitted = false;
65
+ let exitEmitted = false;
66
+ let exitSignal;
67
+ // The real stderr writer, captured before the tee replaces it. Lifecycle lines
68
+ // and stderr passthrough both go through this so they are never re-teed into
69
+ // the per-date sink nor recursed back into the patched writer.
70
+ const rawStderrWrite = process.stderr.write.bind(process.stderr);
71
+ // LOG_DIR is created once, lazily, on the first successful append — not per
72
+ // chunk. teeWrite runs on the server's own stderr hot path now, so a per-call
73
+ // mkdirSync would be two syscalls per log line for nothing.
74
+ let logDirReady = false;
65
75
  function appendSafe(path, data) {
66
76
  if (!path || !LOG_DIR)
67
77
  return;
68
78
  try {
69
- (0, node_fs_1.mkdirSync)(LOG_DIR, { recursive: true });
79
+ if (!logDirReady) {
80
+ (0, node_fs_1.mkdirSync)(LOG_DIR, { recursive: true });
81
+ logDirReady = true;
82
+ }
70
83
  (0, node_fs_1.appendFileSync)(path, data);
71
84
  }
72
85
  catch {
@@ -74,15 +87,16 @@ function appendSafe(path, data) {
74
87
  }
75
88
  }
76
89
  // Best-effort mirror of a lifecycle line to server.log via the loopback
77
- // log-ingest route. Fire-and-forget: the per-session file is authoritative,
78
- // so a dropped POST (unreachable port, process exiting) loses nothing.
90
+ // log-ingest route. Fire-and-forget: the per-session file is authoritative, so
91
+ // a dropped POST loses nothing. On the "exit" event the loop is stopping, so
92
+ // the op=exit mirror may not flush — the per-session line, written sync, holds.
79
93
  function postToServerLog(suffix, level) {
80
94
  if (!PLATFORM_PORT)
81
95
  return;
82
96
  try {
83
97
  const ctrl = new AbortController();
84
98
  const t = setTimeout(() => ctrl.abort(), 500);
85
- t.unref?.(); // never let the abort timer keep the wrapper's event loop alive
99
+ t.unref?.(); // never let the abort timer keep the shim's event loop alive
86
100
  void fetch(`http://127.0.0.1:${PLATFORM_PORT}/api/admin/log-ingest`, {
87
101
  method: "POST",
88
102
  headers: { "content-type": "application/json" },
@@ -95,14 +109,15 @@ function postToServerLog(suffix, level) {
95
109
  }
96
110
  }
97
111
  // Emit one [mcp-helper] lifecycle line: authoritative per-session file (sync,
98
- // survives process.exit), the wrapper's own stderr (journald / Claude Code
99
- // visibility), and a best-effort server.log mirror. `suffix` is the line body
100
- // after the tag and carries no newline (the log-ingest route rejects newlines).
112
+ // survives process.exit), the shim's own stderr via the RAW writer (journald /
113
+ // Claude Code visibility, never re-teed), and a best-effort server.log mirror.
114
+ // `suffix` is the line body after the tag and carries no newline (the
115
+ // log-ingest route rejects newlines).
101
116
  function emitLifecycle(suffix, level) {
102
117
  const line = `[mcp-helper] ${suffix}\n`;
103
118
  appendSafe(perSessionPath, line);
104
119
  try {
105
- process.stderr.write(line);
120
+ rawStderrWrite(line);
106
121
  }
107
122
  catch { /* stderr closed */ }
108
123
  postToServerLog(suffix, level);
@@ -111,49 +126,68 @@ if (!ENTRY) {
111
126
  emitLifecycle(`op=error session=${SESSION_ID8} server=${SERVER_NAME} reason="no entry given (argv[2] missing)"`, "error");
112
127
  process.exit(2);
113
128
  }
114
- const child = (0, node_child_process_1.spawn)(process.execPath, [ENTRY], {
115
- stdio: ["inherit", "inherit", "pipe"],
116
- env: process.env,
117
- });
118
- emitLifecycle(`op=spawn session=${SESSION_ID8} server=${SERVER_NAME} pid=${child.pid ?? -1} entry=${ENTRY}`, "info");
119
- child.on("error", (err) => {
120
- const msg = err instanceof Error ? err.message : String(err);
121
- emitLifecycle(`op=error session=${SESSION_ID8} server=${SERVER_NAME} reason=${JSON.stringify(`spawn error: ${msg}`)}`, "error");
122
- process.exit(127);
129
+ // Replace process.stderr.write with a tee: mirror every server stderr byte to
130
+ // the per-date and per-session sinks, keep a rolling tail for op=exit, emit
131
+ // op=boot on the first bytes, then pass the write through to the real stderr.
132
+ const teeWrite = ((...args) => {
133
+ const chunk = args[0];
134
+ appendSafe(perDatePath, chunk); // per-date raw (back-compat)
135
+ appendSafe(perSessionPath, chunk); // per-session raw (Task 706)
136
+ const text = typeof chunk === "string" ? chunk : Buffer.from(chunk).toString("utf8");
137
+ stderrTail = (stderrTail + text).slice(-TAIL_CAP);
138
+ if (!bootEmitted) {
139
+ bootEmitted = true;
140
+ const head = text.split("\n")[0].slice(0, 200);
141
+ emitLifecycle(`op=boot session=${SESSION_ID8} server=${SERVER_NAME} head=${JSON.stringify(head)}`, "info");
142
+ }
143
+ return rawStderrWrite(...args); // passthrough
123
144
  });
124
- if (child.stderr) {
125
- child.stderr.on("data", (chunk) => {
126
- appendSafe(perDatePath, chunk); // per-date raw (back-compat)
127
- appendSafe(perSessionPath, chunk); // per-session raw (Task 706)
128
- try {
129
- process.stderr.write(chunk);
130
- }
131
- catch { /* stderr closed */ } // passthrough
132
- stderrTail = (stderrTail + chunk.toString("utf8")).slice(-TAIL_CAP);
133
- if (!bootEmitted) {
134
- bootEmitted = true;
135
- const head = chunk.toString("utf8").split("\n")[0].slice(0, 200);
136
- emitLifecycle(`op=boot session=${SESSION_ID8} server=${SERVER_NAME} head=${JSON.stringify(head)}`, "info");
145
+ process.stderr.write = teeWrite;
146
+ // Catchable-signal handling. The shim drives the exit ONLY when it is the sole
147
+ // listener for the signal — i.e. the imported entry installed no handler of its
148
+ // own. In that case it records the signal (so op=exit carries signal=<sig>) and
149
+ // exits with 128+signum, mirroring the prior wrapper's exit-status convention.
150
+ //
151
+ // When the entry DID install a handler, the shim defers entirely and records
152
+ // nothing: the entry's handler decides the exit code, and op=exit reflects that
153
+ // exit verbatim. This matches the prior two-process model, where a child that
154
+ // caught the signal and exited cleanly was observed as code=0 signal=— (a clean
155
+ // self-exit), not as a signal death. Setting exitSignal here unconditionally
156
+ // would mislabel every graceful signal-driven shutdown as a signal kill.
157
+ function onSignal(sig, code) {
158
+ return () => {
159
+ if (process.listenerCount(sig) === 1) {
160
+ exitSignal = sig;
161
+ process.exit(code);
137
162
  }
138
- });
163
+ };
139
164
  }
140
- const forward = (signal) => { if (!child.killed)
141
- child.kill(signal); };
142
- process.on("SIGTERM", () => forward("SIGTERM"));
143
- process.on("SIGINT", () => forward("SIGINT"));
144
- // Signal number, so a signal-killed child propagates as 128+signum (the
145
- // shell convention). `code` is null on a signal exit, so `128 + (code ?? 0)`
146
- // would collapse every signal to 128 and lose the signal identity in the
147
- // wrapper's own exit status.
148
- const SIGNUM = { SIGHUP: 1, SIGINT: 2, SIGQUIT: 3, SIGKILL: 9, SIGTERM: 15 };
149
- child.on("exit", (code, signal) => {
165
+ process.on("SIGTERM", onSignal("SIGTERM", 143));
166
+ process.on("SIGINT", onSignal("SIGINT", 130));
167
+ process.on("SIGHUP", onSignal("SIGHUP", 129));
168
+ // op=exit, emitted once from the process "exit" event. Sync-only — the loop is
169
+ // stopping. When a catchable signal caused the exit, report code=— signal=<sig>
170
+ // to match the prior wrapper's format; otherwise code=<exit code> signal=—.
171
+ process.on("exit", (code) => {
172
+ if (exitEmitted)
173
+ return;
174
+ exitEmitted = true;
150
175
  const lifetimeMs = Date.now() - spawnStamp;
151
176
  const tail = stderrTail.slice(-200);
152
- const level = signal || (code ?? 0) !== 0 ? "error" : "info";
153
- emitLifecycle(`op=exit session=${SESSION_ID8} server=${SERVER_NAME} pid=${child.pid ?? -1} ` +
154
- `code=${code ?? "—"} signal=${signal ?? "—"} lifetimeMs=${lifetimeMs} stderr-tail=${JSON.stringify(tail)}`, level);
155
- if (signal)
156
- process.exit(128 + (SIGNUM[signal] ?? 0));
157
- process.exit(code ?? 0);
177
+ const codeField = exitSignal ? "" : String(code);
178
+ const level = exitSignal || code !== 0 ? "error" : "info";
179
+ emitLifecycle(`op=exit session=${SESSION_ID8} server=${SERVER_NAME} pid=${process.pid} ` +
180
+ `code=${codeField} signal=${exitSignal ?? "—"} lifetimeMs=${lifetimeMs} stderr-tail=${JSON.stringify(tail)}`, level);
181
+ });
182
+ emitLifecycle(`op=spawn session=${SESSION_ID8} server=${SERVER_NAME} pid=${process.pid} entry=${ENTRY}`, "info");
183
+ // Run the real MCP server in THIS process. Dynamic import() (not top-level
184
+ // await — this file compiles to CommonJS) loads the ESM entry; a load-time
185
+ // failure mirrors the old child spawn-error path (op=error, exit 127). The
186
+ // op=exit handler is suppressed on this path so op=error stays the sole record.
187
+ import((0, node_url_1.pathToFileURL)(ENTRY).href).catch((err) => {
188
+ const msg = err instanceof Error ? err.message : String(err);
189
+ exitEmitted = true;
190
+ emitLifecycle(`op=error session=${SESSION_ID8} server=${SERVER_NAME} reason=${JSON.stringify(`import error: ${msg}`)}`, "error");
191
+ process.exit(127);
158
192
  });
159
193
  //# sourceMappingURL=index.js.map