@rubytech/create-maxy-code 0.1.329 → 0.1.331

package/payload/platform/scripts/__tests__/sweep-durability.test.sh

@@ -0,0 +1,103 @@
+#!/usr/bin/env bash
+# Tests for resolve-account-dir.sh under the multi-account managed-service model
+# (Task 983). Registry-membership keep-all: any dir with a valid account.json is
+# a registered account and is NEVER swept; the destructive mv is removed (sweep
+# is log-only this sprint). Boot resolves ACCOUNT_DIR to the single role:"house".
+
+set -uo pipefail
+
+SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+RESOLVER="$SCRIPT_DIR/../lib/resolve-account-dir.sh"
+PASS=0
+FAIL=0
+FAILED_TESTS=()
+
+assert_eq() {
+  if [ "$1" = "$2" ]; then PASS=$((PASS+1));
+  else FAIL=$((FAIL+1)); FAILED_TESTS+=("$3: expected [$2] got [$1]"); fi
+}
+assert_dir_exists() {
+  if [ -d "$1" ]; then PASS=$((PASS+1));
+  else FAIL=$((FAIL+1)); FAILED_TESTS+=("$2: dir missing [$1]"); fi
+}
+assert_dir_absent() {
+  if [ ! -d "$1" ]; then PASS=$((PASS+1));
+  else FAIL=$((FAIL+1)); FAILED_TESTS+=("$2: dir unexpectedly present [$1]"); fi
+}
+
+HOUSE="11111111-1111-1111-1111-111111111111"
+CLIENT_A="22222222-2222-2222-2222-222222222222"
+CLIENT_B="33333333-3333-3333-3333-333333333333"
+ORPHAN="44444444-4444-4444-4444-444444444444"
+
+seed_account() {
+  local root="$1" id="$2" role="$3"
+  mkdir -p "$root/$id"
+  printf '{"accountId":"%s","role":"%s"}\n' "$id" "$role" > "$root/$id/account.json"
+}
+
+# --- Test 1: house + 2 clients + 1 orphan; all registered survive, house resolved, nothing trashed ---
+run_durability() {
+  local tmp; tmp=$(mktemp -d)
+  local accounts="$tmp/data/accounts"
+  mkdir -p "$accounts"
+  seed_account "$accounts" "$CLIENT_A" "client"
+  seed_account "$accounts" "$CLIENT_B" "client"
+  seed_account "$accounts" "$HOUSE" "house"
+  mkdir -p "$accounts/$ORPHAN"  # orphan: no account.json
+
+  local resolved; resolved=$(
+    . "$RESOLVER"
+    ACCOUNTS_DIR="$accounts" USERS_FILE="/nonexistent/users.json" resolve_and_sweep_account_dir >/dev/null 2>&1
+    echo "$ACCOUNT_ID"
+  )
+  assert_eq "$resolved" "$HOUSE" "house-resolved"
+  assert_dir_exists "$accounts/$HOUSE" "house-survives"
+  assert_dir_exists "$accounts/$CLIENT_A" "clientA-survives"
+  assert_dir_exists "$accounts/$CLIENT_B" "clientB-survives"
+  assert_dir_exists "$accounts/$ORPHAN" "orphan-not-trashed"
+  assert_dir_absent "$accounts/.trash" "no-trash-created"
+  rm -rf "$tmp"
+}
+
+# --- Test 2: sole unlabelled account (legacy) resolves as the account ---
+run_sole_legacy() {
+  local tmp; tmp=$(mktemp -d)
+  local accounts="$tmp/data/accounts"
+  mkdir -p "$accounts/$HOUSE"
+  printf '{"accountId":"%s"}\n' "$HOUSE" > "$accounts/$HOUSE/account.json"  # no role
+  local resolved rc
+  resolved=$(
+    . "$RESOLVER"
+    ACCOUNTS_DIR="$accounts" USERS_FILE="/nonexistent/users.json" resolve_and_sweep_account_dir >/dev/null 2>&1
+    echo "$ACCOUNT_ID"
+  )
+  assert_eq "$resolved" "$HOUSE" "sole-legacy-resolved"
+  rm -rf "$tmp"
+}
+
+# --- Test 3: zero-house with multiple candidates aborts (rc != 0) ---
+run_drift_aborts() {
+  local tmp; tmp=$(mktemp -d)
+  local accounts="$tmp/data/accounts"
+  mkdir -p "$accounts"
+  seed_account "$accounts" "$CLIENT_A" "client"
+  seed_account "$accounts" "$CLIENT_B" "client"
+  local rc=0
+  (
+    . "$RESOLVER"
+    ACCOUNTS_DIR="$accounts" USERS_FILE="/nonexistent/users.json" resolve_and_sweep_account_dir >/dev/null 2>&1
+  ) || rc=$?
+  if [ "$rc" -ne 0 ]; then PASS=$((PASS+1)); else FAIL=$((FAIL+1)); FAILED_TESTS+=("drift-aborts: expected non-zero exit"); fi
+  rm -rf "$tmp"
+}
+
+run_durability
+run_sole_legacy
+run_drift_aborts
+
+echo "PASS=$PASS FAIL=$FAIL"
+if [ "$FAIL" -gt 0 ]; then
+  printf '%s\n' "${FAILED_TESTS[@]}"
+  exit 1
+fi

package/payload/platform/scripts/lib/provision-account-dir.sh

@@ -0,0 +1,319 @@
+# provision-account-dir.sh — per-account scaffolding, callable per account.
+# Sourced by setup-account.sh (for the resolved house account) and by the
+# admin-core `account_create` lifecycle tool (for a new client account). Defines
+# `provision_account_dir <account_dir> <account_id> <role>`.
+#
+# The function is pure scaffolding: it creates the account dir layout, writes the
+# Claude Code project settings (hooks only), installs agent identities and the
+# specialist plugin, seeds account.json (stamping accountId + role), seeds
+# enabledPlugins from brand defaults, and stamps the install owner into admins[].
+# It does NO account resolution and NO Neo4j work.
+#
+# Required globals (set by the caller before invoking):
+#   TEMPLATES_DIR  — <project>/templates
+#   PROJECT_DIR    — the platform/ dir
+#   SCRIPT_DIR     — the platform/scripts dir (for lib bootstraps)
+#   USERS_FILE     — $HOME/<brand.configDir>/users.json (owner stamp; optional)
+
+provision_account_dir() {
+  local ACCOUNT_DIR="$1"
+  local ACCOUNT_ID="$2"
+  local ROLE="$3"
+
+  mkdir -p "$ACCOUNT_DIR/agents/admin" "$ACCOUNT_DIR/.claude" "$ACCOUNT_DIR/specialists/.claude-plugin" "$ACCOUNT_DIR/specialists/agents"
+
+  # Claude Code discovers project-level .claude/ relative to the nearest .git
+  # root. Without a .git in the account dir it traverses up to ~/maxy/.git and
+  # misses accountDir/.claude/. Initialise a repo so the account dir IS the root.
+  [ -d "$ACCOUNT_DIR/.git" ] || git init -q "$ACCOUNT_DIR"
+
+  # --- project-level .claude/settings.json (hooks; no allowlist) -------------
+  local ACCOUNT_SETTINGS="$ACCOUNT_DIR/.claude/settings.json"
+  local HOOKS_PATH="\$PLATFORM_ROOT/plugins/admin/hooks"
+  cat > "$ACCOUNT_SETTINGS" << SETTINGS_EOF
+{
+  "permissions": {
+    "defaultMode": "bypassPermissions",
+    "allow": [],
+    "deny": []
+  },
+  "hooks": {
+    "PreToolUse": [
+      {
+        "matcher": "Write",
+        "hooks": [
+          { "type": "command", "command": "bash $HOOKS_PATH/archive-ingest-surface-gate.sh" }
+        ]
+      },
+      {
+        "matcher": "Edit",
+        "hooks": [
+          { "type": "command", "command": "bash $HOOKS_PATH/archive-ingest-surface-gate.sh" }
+        ]
+      },
+      {
+        "matcher": "NotebookEdit",
+        "hooks": [
+          { "type": "command", "command": "bash $HOOKS_PATH/archive-ingest-surface-gate.sh" }
+        ]
+      },
+      {
+        "matcher": "Bash",
+        "hooks": [
+          { "type": "command", "command": "bash $HOOKS_PATH/archive-ingest-surface-gate.sh" }
+        ]
+      },
+      {
+        "hooks": [
+          { "type": "command", "command": "bash $HOOKS_PATH/archive-ingest-surface-gate.sh" }
+        ]
+      },
+      {
+        "matcher": "WebFetch",
+        "hooks": [
+          { "type": "command", "command": "node $HOOKS_PATH/webfetch-preflight.mjs" }
+        ]
+      },
+      {
+        "matcher": "AskUserQuestion",
+        "hooks": [
+          { "type": "command", "command": "bash $HOOKS_PATH/askuserquestion-investigate-gate.sh" }
+        ]
+      }
+    ],
+    "PostToolUse": [
+      {
+        "matcher": "Agent",
+        "hooks": [
+          { "type": "command", "command": "bash $HOOKS_PATH/post-tool-use-agent.sh" }
+        ]
+      },
+      {
+        "matcher": "mcp__.*__.*-(export|import)-parse$",
+        "hooks": [
+          { "type": "command", "command": "bash $HOOKS_PATH/archive-ingest-surface-gate.sh" }
+        ]
+      },
+      {
+        "matcher": "mcp__.*",
+        "hooks": [
+          { "type": "command", "command": "bash $HOOKS_PATH/mcp-tool-missing.sh" }
+        ]
+      },
+      {
+        "matcher": "Write",
+        "hooks": [
+          { "type": "command", "command": "bash $HOOKS_PATH/admin-authoring-observer.sh" }
+        ]
+      },
+      {
+        "matcher": "Edit",
+        "hooks": [
+          { "type": "command", "command": "bash $HOOKS_PATH/admin-authoring-observer.sh" }
+        ]
+      }
+    ],
+    "UserPromptSubmit": [
+      {
+        "hooks": [
+          { "type": "command", "command": "bash $HOOKS_PATH/archive-ingest-surface-gate.sh" },
+          { "type": "command", "command": "bash $HOOKS_PATH/prompt-optimiser-directive.sh" }
+        ]
+      }
+    ],
+    "Stop": [
+      {
+        "hooks": [
+          { "type": "command", "command": "bash $HOOKS_PATH/prompt-optimiser-compliance.sh" }
+        ]
+      }
+    ]
+  }
+}
+SETTINGS_EOF
+
+  # --- agent identities + specialist plugin templates ------------------------
+  cp "$TEMPLATES_DIR/agents/admin/IDENTITY.md" "$ACCOUNT_DIR/agents/admin/IDENTITY.md"
+
+  # On re-provision, re-sync the Rubytech-controlled IDENTITY.md for every
+  # already-existing non-admin agent dir (security-load-bearing). Never create
+  # dirs; never write SOUL/KNOWLEDGE/config.
+  local _AGENT_DIR _AGENT_NAME
+  for _AGENT_DIR in "$ACCOUNT_DIR/agents"/*/; do
+    [ -d "$_AGENT_DIR" ] || continue
+    _AGENT_NAME="$(basename "$_AGENT_DIR")"
+    [ "$_AGENT_NAME" = "admin" ] && continue
+    [ -f "$_AGENT_DIR/IDENTITY.md" ] || continue
+    cp "$TEMPLATES_DIR/agents/public/IDENTITY.md" "$_AGENT_DIR/IDENTITY.md"
+    echo "  agents/$_AGENT_NAME/IDENTITY.md re-synced"
+  done
+
+  cp "$TEMPLATES_DIR/specialists/.claude-plugin/plugin.json" "$ACCOUNT_DIR/specialists/.claude-plugin/plugin.json"
+
+  # Replace core specialist files (no '--'); preserve premium plugin agents.
+  local _existing
+  for _existing in "$ACCOUNT_DIR/specialists/agents/"*.md; do
+    [ -f "$_existing" ] || continue
+    case "$(basename "$_existing")" in
+      *--*) continue ;;
+    esac
+    rm -f "$_existing"
+  done
+
+  local specialist
+  for specialist in "$TEMPLATES_DIR/specialists/agents/"*.md; do
+    [ -f "$specialist" ] && cp "$specialist" "$ACCOUNT_DIR/specialists/agents/$(basename "$specialist")"
+  done
+
+  rm -f "$ACCOUNT_DIR/.claude/agents/"*.md 2>/dev/null || true
+
+  # SOUL.md — user-controlled. Only create if missing. Never overwrite.
+  if [ -f "$ACCOUNT_DIR/agents/admin/SOUL.md" ]; then
+    echo "  agents/admin/SOUL.md preserved ($(wc -c < "$ACCOUNT_DIR/agents/admin/SOUL.md" | tr -d ' ') bytes)"
+  else
+    cp "$TEMPLATES_DIR/agents/admin/SOUL.md" "$ACCOUNT_DIR/agents/admin/SOUL.md"
+    echo "  agents/admin/SOUL.md created ($(wc -c < "$ACCOUNT_DIR/agents/admin/SOUL.md" | tr -d ' ') bytes)"
+  fi
+
+  bash "$SCRIPT_DIR/lib/agents-md-bootstrap.sh" "$ACCOUNT_DIR"
+  bash "$SCRIPT_DIR/lib/admin-skills-bootstrap.sh" "$ACCOUNT_DIR" "$PROJECT_DIR/plugins"
+
+  # --- account.json: create from template, stamp accountId + role ------------
+  local TEMPLATE="$TEMPLATES_DIR/account.json"
+  if [ ! -f "$ACCOUNT_DIR/account.json" ]; then
+    if [ -f "$TEMPLATE" ]; then
+      sed "s/\"accountId\": *\"[^\"]*\"/\"accountId\":\"$ACCOUNT_ID\"/" "$TEMPLATE" \
+        | sed "s/\"tier\": *\"[^\"]*\"/\"tier\":\"solo\"/" \
+        > "$ACCOUNT_DIR/account.json"
+    else
+      echo "ERROR: account.json template not found at $TEMPLATE" >&2
+      return 1
+    fi
+  fi
+
+  # Stamp role on the account.json (idempotent migration + designation). A
+  # pre-existing legacy account.json with no role gets ROLE; an account already
+  # carrying a role keeps it unless ROLE differs (operator-driven via the
+  # lifecycle tools, never here).
+  ACCOUNT_ID="$ACCOUNT_ID" ROLE="$ROLE" python3 - "$ACCOUNT_DIR/account.json" <<'PY'
+import json, os, sys
+path = sys.argv[1]
+role = os.environ["ROLE"]
+acct_id = os.environ["ACCOUNT_ID"]
+with open(path) as f:
+    cfg = json.load(f)
+changed = False
+if not cfg.get("accountId"):
+    cfg["accountId"] = acct_id; changed = True
+if role and cfg.get("role") != role:
+    cfg["role"] = role; changed = True
+if "managedService" not in cfg:
+    cfg["managedService"] = False; changed = True
+if changed:
+    with open(path, "w") as f:
+        json.dump(cfg, f, indent=2); f.write("\n")
+    print(f"  account.json role={cfg.get('role')} stamped")
+PY
+
+  # --- enabledPlugins from brand.json plugins.defaultEnabled -----------------
+  local BRAND_JSON="$PROJECT_DIR/config/brand.json"
+  if [ -f "$BRAND_JSON" ] && [ -f "$ACCOUNT_DIR/account.json" ]; then
+    PROJECT_DIR="$PROJECT_DIR" BRAND_JSON="$BRAND_JSON" ACCOUNT_JSON="$ACCOUNT_DIR/account.json" python3 - <<'PY'
+import json, os, sys
+
+brand_path = os.environ['BRAND_JSON']
+account_path = os.environ['ACCOUNT_JSON']
+plugins_dir = os.path.join(os.environ['PROJECT_DIR'], 'plugins')
+
+with open(brand_path) as f:
+    brand = json.load(f)
+
+plugins_cfg = brand.get('plugins', {})
+default_enabled = plugins_cfg.get('defaultEnabled', [])
+core = set(plugins_cfg.get('core', []))
+
+if not default_enabled:
+    print('  [setup] no defaultEnabled plugins in brand.json — skipping')
+    sys.exit(0)
+
+satisfied = core | set(default_enabled)
+validated = []
+for plugin in default_enabled:
+    plugin_md = os.path.join(plugins_dir, plugin, 'PLUGIN.md')
+    requires = []
+    if os.path.isfile(plugin_md):
+        in_frontmatter = False
+        in_requires = False
+        with open(plugin_md) as f:
+            for line in f:
+                stripped = line.rstrip()
+                if stripped == '---':
+                    if in_frontmatter:
+                        break
+                    in_frontmatter = True
+                    continue
+                if not in_frontmatter:
+                    continue
+                if stripped.startswith('requires:'):
+                    inline = stripped.split(':', 1)[1].strip()
+                    if inline.startswith('['):
+                        requires = [x.strip().strip('"').strip("'") for x in inline.strip('[]').split(',') if x.strip()]
+                        in_requires = False
+                    else:
+                        in_requires = True
+                    continue
+                if in_requires:
+                    if stripped.startswith('  - '):
+                        requires.append(stripped.lstrip(' -').strip())
+                    else:
+                        in_requires = False
+    unmet = [r for r in requires if r not in satisfied]
+    if unmet:
+        print(f'  [setup] WARNING: skipping defaultEnabled plugin "{plugin}" — unmet requires: {unmet}')
+    else:
+        validated.append(plugin)
+
+with open(account_path) as f:
+    account = json.load(f)
+
+existing = account.get('enabledPlugins', [])
+existing_set = set(existing)
+added = [p for p in validated if p not in existing_set]
+account['enabledPlugins'] = existing + added
+
+with open(account_path, 'w') as f:
+    json.dump(account, f, indent=2)
+    f.write('\n')
+
+if not existing:
+    print(f'  [setup] seeded enabledPlugins: {validated}')
+elif added:
+    print(f'  [setup] merged into enabledPlugins: +{added} (existing: {existing})')
+else:
+    print(f'  [setup] enabledPlugins already contains all defaultEnabled entries')
+PY
+  fi
+
+  # --- stamp install owner into admins[] (idempotent) ------------------------
+  if [ -n "${USERS_FILE:-}" ] && [ -f "$USERS_FILE" ]; then
+    local USER_ID
+    USER_ID=$(python3 -c "import json; print(json.load(open('$USERS_FILE'))[0]['userId'])" 2>/dev/null || true)
+    if [ -n "$USER_ID" ] && [ -f "$ACCOUNT_DIR/account.json" ]; then
+      USER_ID="$USER_ID" python3 - "$ACCOUNT_DIR/account.json" <<'PY'
+import json, os, sys
+path = sys.argv[1]
+uid = os.environ["USER_ID"]
+with open(path) as f:
+    cfg = json.load(f)
+cfg.setdefault("admins", [])
+if not any(a.get("userId") == uid for a in cfg["admins"]):
+    cfg["admins"].append({"userId": uid, "role": "owner"})
+    with open(path, "w") as f:
+        json.dump(cfg, f, indent=2); f.write("\n")
+    print(f"  Stamped userId={uid} as owner in account.json admins")
+PY
+    fi
+  fi
+
+  echo "  Account $ACCOUNT_ID at $ACCOUNT_DIR (role=$ROLE)"
+}