@rubytech/create-maxy-code 0.1.28 → 0.1.30

package/dist/__tests__/init-logging.test.js

@@ -0,0 +1,85 @@
+// Coverage for runInitLogging's success and failure branches via injected
+// fs / stderr / exit impls. Task 062 (maxy-code).
+//
+// Brief asked for vitest. Codebase convention is node:test (matches
+// apt-resolve.test.ts, peer-brand-detect.test.ts, etc); the package has no
+// vitest dep and the test runner stanza in package.json invokes
+// `node --test 'dist/__tests__/*.test.js'`.
+import test from "node:test";
+import assert from "node:assert/strict";
+import { runInitLogging } from "../init-logging.js";
+const LOG_DIR = "/tmp/test-task-062-logs";
+const LOG_FILE = "/tmp/test-task-062-logs/install-2026-01-01T00-00-00-000Z.log";
+const PERSIST_DIR = "/tmp/test-task-062-persist";
+test("success path: header written via injected impls, no stderr, no exit", () => {
+    const appendCalls = [];
+    let stderrOut = "";
+    let exitCode = null;
+    runInitLogging({
+        logDir: LOG_DIR,
+        logFile: LOG_FILE,
+        persistDir: PERSIST_DIR,
+        headerLines: ["", "===", "  Maxy Code Install Log", "==="],
+        mkdirSyncImpl: () => { },
+        appendFileSyncImpl: (p, d) => { appendCalls.push([p, d]); },
+        stderrWriteImpl: (c) => { stderrOut += c; },
+        exitImpl: (c) => { exitCode = c; },
+    });
+    assert.equal(appendCalls.length, 1);
+    assert.equal(appendCalls[0][0], LOG_FILE);
+    assert.equal(appendCalls[0][1], "\n===\n  Maxy Code Install Log\n===\n");
+    assert.equal(stderrOut, "");
+    assert.equal(exitCode, null);
+});
+test("failure path: appendFileSync throws → stderr emits FAILED line, exit(1) called", () => {
+    let stderrOut = "";
+    let exitCode = null;
+    runInitLogging({
+        logDir: LOG_DIR,
+        logFile: LOG_FILE,
+        persistDir: PERSIST_DIR,
+        headerLines: ["a"],
+        mkdirSyncImpl: () => { },
+        appendFileSyncImpl: () => { throw new Error("EACCES: permission denied"); },
+        stderrWriteImpl: (c) => { stderrOut += c; },
+        exitImpl: (c) => { exitCode = c; },
+    });
+    assert.ok(stderrOut.includes("[create-maxy] init-logging FAILED reason=EACCES"), `stderr should contain init-logging FAILED line; got: ${JSON.stringify(stderrOut)}`);
+    assert.ok(stderrOut.includes(`log=${LOG_FILE}`));
+    assert.ok(stderrOut.includes(`persist=${PERSIST_DIR}`));
+    assert.equal(exitCode, 1);
+});
+test("failure path: mkdirSync throws → stderr emits FAILED line, exit(1) called", () => {
+    let stderrOut = "";
+    let exitCode = null;
+    let appendCalled = false;
+    runInitLogging({
+        logDir: LOG_DIR,
+        logFile: LOG_FILE,
+        persistDir: PERSIST_DIR,
+        headerLines: ["a"],
+        mkdirSyncImpl: () => { throw new Error("EROFS: read-only file system"); },
+        appendFileSyncImpl: () => { appendCalled = true; },
+        stderrWriteImpl: (c) => { stderrOut += c; },
+        exitImpl: (c) => { exitCode = c; },
+    });
+    assert.equal(appendCalled, false, "appendFileSync must not be invoked when mkdirSync throws");
+    assert.ok(stderrOut.includes("[create-maxy] init-logging FAILED reason=EROFS"));
+    assert.equal(exitCode, 1);
+});
+test("failure path: non-Error thrown value still surfaces as reason", () => {
+    let stderrOut = "";
+    let exitCode = null;
+    runInitLogging({
+        logDir: LOG_DIR,
+        logFile: LOG_FILE,
+        persistDir: PERSIST_DIR,
+        headerLines: ["a"],
+        mkdirSyncImpl: () => { },
+        appendFileSyncImpl: () => { throw "raw-string"; },
+        stderrWriteImpl: (c) => { stderrOut += c; },
+        exitImpl: (c) => { exitCode = c; },
+    });
+    assert.ok(stderrOut.includes("reason=raw-string"));
+    assert.equal(exitCode, 1);
+});

package/dist/index.js

@@ -7,6 +7,7 @@ import { resolveInstallPortFromFs, buildMaxyUnitFile, buildClaudeSessionManagerU
 import { classifyOnboardingReadBack } from "./onboarding-readback.js";
 import { parseOsRelease, isUbuntuLike as isUbuntuLikePure, parseAptCacheCandidate, decideAptResolution, } from "./apt-resolve.js";
 import { findPeerBrandOnDefaultNeo4jPort } from "./peer-brand-detect.js";
+import { runInitLogging } from "./init-logging.js";
 import { requireSupportedPlatform } from "./platform-detect.js";
 import { renderPlist } from "./launchd-plist.js";
 import { installAllBrewPackages } from "./brew-install.js";
@@ -82,15 +83,19 @@ const NPM_NET_FLAGS = [
 // Logging — timestamped to console AND persistent log file
 // ---------------------------------------------------------------------------
 function initLogging() {
-    mkdirSync(LOG_DIR, { recursive: true });
-    appendFileSync(LOG_FILE, [
-        "",
-        "=".repeat(64),
-        `  ${BRAND.productName} Install Log — ${new Date().toISOString()}`,
-        `  Node ${process.version} | ${process.platform} ${process.arch}`,
-        "=".repeat(64),
-        "",
-    ].join("\n") + "\n");
+    runInitLogging({
+        logDir: LOG_DIR,
+        logFile: LOG_FILE,
+        persistDir: PERSIST_DIR,
+        headerLines: [
+            "",
+            "=".repeat(64),
+            `  ${BRAND.productName} Install Log — ${new Date().toISOString()}`,
+            `  Node ${process.version} | ${process.platform} ${process.arch}`,
+            "=".repeat(64),
+            "",
+        ],
+    });
 }
 function logFile(msg) {
     try {
@@ -1896,7 +1901,7 @@ function deployPayload() {
 }
 // Task 030 — register the local + external Claude Code plugins after the
 // payload is on disk. The bundler stamps `.claude-plugin/marketplace.json`
-// at each plugin-tree root (platform/plugins/, premium-plugins/real-agency/
+// at each plugin-tree root (platform/plugins/, premium-plugins/real-agent/
 // plugins/, premium-plugins/) so this function discovers them generically
 // from the install directory rather than hardcoding names.
 //
@@ -1915,7 +1920,7 @@ function registerLocalAndExternalPlugins() {
     // ones are silently skipped (e.g. a brand that ships no premium plugins).
     const candidates = [
         join(INSTALL_DIR, "platform", "plugins"),
-        join(INSTALL_DIR, "premium-plugins", "real-agency", "plugins"),
+        join(INSTALL_DIR, "premium-plugins", "real-agent", "plugins"),
         join(INSTALL_DIR, "premium-plugins"),
     ];
     for (const dir of candidates) {
@@ -3596,8 +3601,14 @@ if (PLATFORM === "darwin") {
 const PLATFORM_HEADER = `[create-maxy] platform=${PLATFORM} arch=${process.arch}` +
     (MACOS_VERSION ? ` macos=${MACOS_VERSION}` : ``) +
     ` version=${PKG_VERSION}`;
-initLogging();
+// Task 062 — emit platform header and the resolved log/persist paths to
+// stdout BEFORE the log file is opened. If initLogging's mkdir or first
+// appendFileSync throws, the operator still sees brand/version/arch and the
+// exact path the log file SHOULD live at, instead of a silent exit between
+// the LOG_DIR mkdir and the first log write.
 console.log(PLATFORM_HEADER);
+console.log(`[create-maxy] log=${LOG_FILE} persist=${PERSIST_DIR}`);
+initLogging();
 console.log("================================================================");
 console.log(`  ${BRAND.productName} — ${BRAND.tagline}.  (${BRAND.hostname} v${PKG_VERSION})`);
 console.log("================================================================");

package/dist/init-logging.js

@@ -0,0 +1,28 @@
+// Installer log-file initialization with diagnostic stderr emission on
+// failure. Extracted from index.ts so the failure path can be covered by
+// node:test without bringing in the rest of the installer's import-time side
+// effects.
+//
+// Task 062 (maxy-code) — operator-observed silent exit between
+// `mkdirSync(LOG_DIR)` and the first `appendFileSync(LOG_FILE, header)`.
+// Both writes are guarded inside the same try/catch; a failure emits a
+// literal `[create-maxy] init-logging FAILED reason=<msg> log=<path>
+// persist=<path>` line to stderr and exits 1 so the operator always has a
+// forensic surface regardless of whether the log file ever opened.
+import { mkdirSync as realMkdirSync, appendFileSync as realAppendFileSync, } from "node:fs";
+export function runInitLogging(opts) {
+    const mkdir = opts.mkdirSyncImpl ?? ((p, o) => { realMkdirSync(p, o); });
+    const append = opts.appendFileSyncImpl ?? ((p, d) => { realAppendFileSync(p, d); });
+    const stderr = opts.stderrWriteImpl ?? ((c) => { process.stderr.write(c); });
+    const exit = opts.exitImpl ?? ((c) => { process.exit(c); });
+    try {
+        mkdir(opts.logDir, { recursive: true });
+        append(opts.logFile, opts.headerLines.join("\n") + "\n");
+    }
+    catch (err) {
+        const msg = err instanceof Error ? err.message : String(err);
+        stderr(`[create-maxy] init-logging FAILED reason=${msg} log=${opts.logFile} persist=${opts.persistDir}\n`);
+        exit(1);
+        return;
+    }
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@rubytech/create-maxy-code",
-  "version": "0.1.28",
+  "version": "0.1.30",
   "description": "Install Maxy — AI for Productive People",
   "bin": {
     "create-maxy-code": "./dist/index.js"

package/payload/platform/plugins/admin/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "admin",
-  "description": "Platform administration plugin. Provides system-status, public-hostname (deterministic Cloudflare public-URL resolver — single call returning the operator's canonical hostname so agents never guess property names on :CloudflareHostname nodes), brand-settings, account-manage, account-update, admin-add, admin-remove, admin-list, admin-update-pin, agent-list, agent-config-read, logs-read, plugin-read, skill-load (one-call resolve+read for SKILL.md by skill name — the canonical primitive for loading a named skill; plugin-read remains the reader for references/* and PLUGIN.md), store-skill (deterministic write counterpart to plugin-read; persists operator-authored skills as plugin files under the active account), render-component, session-reset, session-resume, file-attach, wifi, and action-approval tools (action-pending, action-approve, action-reject, action-edit) for managing the Maxy platform.",
+  "description": "Platform administration plugin. Provides system-status, public-hostname (deterministic Cloudflare public-URL resolver, single call returning the operator's canonical hostname so agents never guess property names on :CloudflareHostname nodes), brand-settings, account-manage, account-update, admin-add, admin-remove, admin-list, admin-update-pin, agent-list, agent-config-read, logs-read, plugin-read, skill-load (one-call resolve+read for SKILL.md by skill name, the canonical primitive for loading a named skill; plugin-read remains the reader for references/* and PLUGIN.md), store-skill (deterministic write counterpart to plugin-read; persists operator-authored skills as plugin files under the active account), session-reset, session-resume, file-attach, wifi, and action-approval tools (action-pending, action-approve, action-reject, action-edit) for managing the Maxy platform. The `render-component` MCP tool is also registered but is exposed to the public agent surface only (Anthropic API runtime); the admin agent on native Claude Code does not call it.",
   "version": "0.1.0",
   "author": {
     "name": "Rubytech LLC"

package/payload/platform/plugins/admin/PLUGIN.md

@@ -1,6 +1,6 @@
 ---
 name: admin
-description: "Platform administration plugin. Provides system-status, public-hostname (deterministic Cloudflare public-URL resolver — single call returning the operator's canonical hostname so agents never guess property names on :CloudflareHostname nodes), brand-settings, account-manage, account-update, admin-add, admin-remove, admin-list, admin-update-pin, agent-list, agent-config-read, logs-read, plugin-read, skill-load (one-call resolve+read for SKILL.md by skill name — the canonical primitive for loading a named skill; plugin-read remains the reader for references/* and PLUGIN.md), store-skill (deterministic write counterpart to plugin-read; persists operator-authored skills as plugin files under the active account), render-component, session-reset, session-resume, file-attach, wifi, and action-approval tools (action-pending, action-approve, action-reject, action-edit) for managing the Maxy platform."
+description: "Platform administration plugin. Provides system-status, public-hostname (deterministic Cloudflare public-URL resolver, single call returning the operator's canonical hostname so agents never guess property names on :CloudflareHostname nodes), brand-settings, account-manage, account-update, admin-add, admin-remove, admin-list, admin-update-pin, agent-list, agent-config-read, logs-read, plugin-read, skill-load (one-call resolve+read for SKILL.md by skill name, the canonical primitive for loading a named skill; plugin-read remains the reader for references/* and PLUGIN.md), store-skill (deterministic write counterpart to plugin-read; persists operator-authored skills as plugin files under the active account), session-reset, session-resume, file-attach, wifi, and action-approval tools (action-pending, action-approve, action-reject, action-edit) for managing the Maxy platform. The `render-component` MCP tool is also registered but is exposed to the public agent surface only (Anthropic API runtime); the admin agent on native Claude Code does not call it."
 tools:
   - name: system-status
     publicAllowlist: false

package/payload/platform/plugins/admin/hooks/onboarding-skill-drift.sh

@@ -1,100 +1,102 @@
 #!/usr/bin/env bash
-# Task 038 Outcome E1 — Stop-event hook that flags the admin agent's
-# onboarding-skill drift pattern: the prior /input carried an
-# `<onboarding-state>` block, but the latest assistant turn did not call
-# `render-component` AND did not end with a `?`-terminated sentence.
+# Task 063 / Task 049. Stop-event hook that flags admin agent onboarding
+# drift on the native Claude Code (PTY) surface. Post-Task-049 there is no
+# `render-component` tool, so the contract is no longer "called render-component";
+# it is "the assistant ends its turn on a prompt the operator can answer".
 #
 # Behaviour:
-#   1. Read the transcript_path from the Stop event JSON on stdin.
+#   1. Read transcript_path from the Stop event JSON on stdin.
 #   2. Walk the JSONL backwards. Find the most recent user event whose
-#      `message.content` (string or text-block array) contains the literal
-#      `<onboarding-state ` marker — that is the injection signature.
+#      `message.content` contains the literal `<onboarding-state ` marker.
 #   3. If no such user event exists in this transcript, fail-open (exit 0).
-#   4. Otherwise, find the most recent assistant event after that injection
-#      event. Extract its tool-use names and the trailing text characters.
-#   5. If the tool-use list does NOT contain `render-component` AND the
-#      trailing prose does NOT end with `?`, the agent has drifted — log
-#      one `[precision-check] rule=onboarding-skill-drift` line to the
-#      admin-side log directory and exit 0.
+#   4. Otherwise, find the most recent assistant event after that injection.
+#      Count assistant turns since the injection so the log line carries a turn number.
+#   5. Evaluate the ends-with-prompt contract on the assistant text:
+#        - PASS when the last non-whitespace character is `?`, OR
+#        - PASS when the trailing block (last ~8 lines) contains a numbered
+#          or bulleted list item (`1. `, `2) `, `- `, `* `).
+#        - FAIL otherwise.
+#   6. Emit `[onboarding-skill-drift] turn=<N> contract=ends-with-prompt
+#      result=<pass|fail> reason=<reason>` on stderr.
 #
-# Exit 0 always — this hook is observation, not enforcement. The
-# precision-check ledger increments via the log line; no retry is forced.
-# Infrastructure failures (jq missing, transcript unreadable) also exit 0
-# so a hook bug never blocks the agent's response.
+# Exit 0 always: this hook is observation, not enforcement. Infrastructure
+# failures (jq missing, transcript unreadable) also exit 0 so a hook bug
+# never blocks the agent's response.
 
 set -uo pipefail
-LOG_TAG="[precision-check]"
+LOG_TAG="[onboarding-skill-drift]"
 
-# fail-open if jq is unavailable — the transcript shape demands JSON parse
 if ! command -v jq >/dev/null 2>&1; then
-  echo "$LOG_TAG rule=onboarding-skill-drift result=skip reason=jq-missing" >&2
+  echo "$LOG_TAG turn=0 contract=ends-with-prompt result=skip reason=jq-missing" >&2
   exit 0
 fi
 
 INPUT=$(cat 2>/dev/null || echo '{}')
 TRANSCRIPT=$(echo "$INPUT" | jq -r '.transcript_path // empty' 2>/dev/null)
 if [ -z "$TRANSCRIPT" ] || [ ! -f "$TRANSCRIPT" ]; then
-  echo "$LOG_TAG rule=onboarding-skill-drift result=skip reason=no-transcript" >&2
+  echo "$LOG_TAG turn=0 contract=ends-with-prompt result=skip reason=no-transcript" >&2
   exit 0
 fi
 
-# Locate the most recent injection signature in user events. The injection
-# block is prepended verbatim to the operator's input on the first /input
-# of an eligible session, so it appears as the leading bytes of a user
-# event's message text. Search backwards to find the last one in this
-# transcript window.
+# Locate the most recent <onboarding-state ...> injection in a user event.
+# The injection block is prepended verbatim to the operator's input on the
+# first /input of an eligible session, so it appears as the leading bytes of
+# the user event's message text. Search backwards for the last one.
 INJECTION_LINE=$(grep -n '<onboarding-state ' "$TRANSCRIPT" 2>/dev/null \
   | grep '"type":"user"' \
   | tail -n 1 \
   | cut -d: -f1)
 
 if [ -z "$INJECTION_LINE" ]; then
-  # No injection in this transcript window — nothing to enforce.
+  # No injection in this transcript window. Nothing to evaluate.
   exit 0
 fi
 
-# Slice the file from just after the injection line to the end; the
-# assistant's response sits in that suffix.
+# Slice the file from just after the injection line.
 TAIL=$(tail -n "+$((INJECTION_LINE + 1))" "$TRANSCRIPT" 2>/dev/null)
 
-# Last assistant message in the suffix.
-ASSISTANT=$(echo "$TAIL" \
-  | grep '"type":"assistant"' \
-  | tail -n 1)
+# Count assistant turns since the injection and pick the most recent.
+ASSISTANT_TURNS=$(echo "$TAIL" | grep -c '"type":"assistant"')
+ASSISTANT=$(echo "$TAIL" | grep '"type":"assistant"' | tail -n 1)
 
 if [ -z "$ASSISTANT" ]; then
-  echo "$LOG_TAG rule=onboarding-skill-drift result=skip reason=no-assistant-turn" >&2
+  echo "$LOG_TAG turn=0 contract=ends-with-prompt result=skip reason=no-assistant-turn" >&2
   exit 0
 fi
 
-# Tool-use names from the assistant event.
-TOOL_USES=$(echo "$ASSISTANT" | jq -r '
-  .message.content // []
-  | map(select(.type == "tool_use") | .name)
-  | join(",")
-' 2>/dev/null)
-
-# Concatenated text content (final character matters for the `?` check).
+# Concatenated text content (final character matters for the `?` check; final
+# block matters for the enumerated-list check).
 ASSISTANT_TEXT=$(echo "$ASSISTANT" | jq -r '
   .message.content // []
   | map(select(.type == "text") | .text)
-  | join(" ")
+  | join("\n")
 ' 2>/dev/null)
 
-HAS_RENDER_COMPONENT=0
-case "$TOOL_USES" in
-  *render-component*) HAS_RENDER_COMPONENT=1 ;;
-esac
-
-# Trim trailing whitespace and check the last non-whitespace character.
+# Trim trailing whitespace and find the last non-whitespace character.
 TRIMMED=$(echo "$ASSISTANT_TEXT" | sed -E 's/[[:space:]]+$//')
 LAST_CHAR=$(echo -n "$TRIMMED" | tail -c 1)
 
-if [ "$HAS_RENDER_COMPONENT" = "0" ] && [ "$LAST_CHAR" != "?" ]; then
-  # Drift detected. Sample is the first 80 chars of the assistant text so
-  # the log line tells the operator what shape of drift fired.
-  SAMPLE=$(echo "$TRIMMED" | head -c 80 | tr '\n' ' ')
-  echo "$LOG_TAG rule=onboarding-skill-drift result=block class=PRECISION sample='${SAMPLE}'" >&2
+# Evaluate the ends-with-prompt contract.
+ENDS_WITH_PROMPT=0
+ENDS_WITH_PROMPT_REASON="neither-question-nor-list"
+
+if [ "$LAST_CHAR" = "?" ]; then
+  ENDS_WITH_PROMPT=1
+  ENDS_WITH_PROMPT_REASON="trailing-question-mark"
+else
+  # Take the last 8 lines and look for a numbered/bulleted list item.
+  TRAIL_LINES=$(echo "$TRIMMED" | tail -n 8)
+  if echo "$TRAIL_LINES" | grep -qE '^[[:space:]]*([0-9]+[.)]|[-*])[[:space:]]+'; then
+    ENDS_WITH_PROMPT=1
+    ENDS_WITH_PROMPT_REASON="trailing-enumerated-list"
+  fi
+fi
+
+if [ "$ENDS_WITH_PROMPT" = "1" ]; then
+  echo "$LOG_TAG turn=$ASSISTANT_TURNS contract=ends-with-prompt result=pass reason=$ENDS_WITH_PROMPT_REASON" >&2
+else
+  SAMPLE=$(echo "$TRIMMED" | tail -c 120 | tr '\n' ' ' | sed 's/[[:space:]]\+/ /g')
+  echo "$LOG_TAG turn=$ASSISTANT_TURNS contract=ends-with-prompt result=fail reason=$ENDS_WITH_PROMPT_REASON sample='${SAMPLE}'" >&2
 fi
 
 exit 0

package/payload/platform/plugins/admin/mcp/dist/index.js

@@ -2743,7 +2743,7 @@ server.tool("premium-deliver", "Deliver a purchased premium plugin. Copies plugi
     "agent templates. Handles both standalone plugins and bundles (auto-detected). Idempotent — " +
     "already-delivered sub-plugins are skipped. Returns a structured result with per-sub-plugin " +
     "status and available templates.", {
-    pluginName: z.string().describe("Name of the premium plugin to deliver (e.g. 'real-agency', 'teaching')"),
+    pluginName: z.string().describe("Name of the premium plugin to deliver (e.g. 'real-agent', 'teaching')"),
 }, async ({ pluginName }) => {
     const TAG = "[premium-deliver]";
     // --- Validate plugin name ---