@rubytech/create-maxy-code 0.1.24 → 0.1.26

package/dist/index.js

@@ -35,8 +35,20 @@ catch (err) {
     process.exit(1);
 }
 const INSTALL_DIR = resolve(process.env.HOME ?? "/root", BRAND.installDir);
-const LOG_DIR = resolve(process.env.HOME ?? "/root", BRAND.configDir, "logs");
+const PERSIST_DIR = resolve(process.env.HOME ?? "/root", BRAND.configDir);
+const LOG_DIR = join(PERSIST_DIR, "logs");
 const LOG_FILE = join(LOG_DIR, `install-${new Date().toISOString().replace(/[:.]/g, "-")}.log`);
+// Task 048 — every `claude plugin` shellout must read/write the per-brand
+// CLAUDE_CONFIG_DIR that the systemd unit at port-resolution.ts:229,286 uses
+// at runtime. Without this override, the installer writes marketplaces and
+// enabledPlugins to $HOME/.claude/settings.json (user-default), and the
+// PTY spawned by the session-manager sees an empty config dir — the
+// onboarding skill never registers, `<onboarding-state>` resolves to
+// "Unknown skill: onboarding", and the operator is stuck at step 6.
+const CLAUDE_CONFIG_DIR = join(PERSIST_DIR, ".claude");
+function claudePluginEnv() {
+    return { ...process.env, CLAUDE_CONFIG_DIR };
+}
 /** Known brand hostnames in the Maxy ecosystem. Each brand ships a main unit
  *  (`<hostname>.service`) and a per-brand edge unit (`<hostname>-edge.service`,
  *  Task 662). Peer-brand detection matches only these filenames — stale units,
@@ -916,7 +928,10 @@ function installClaudeCode() {
         }
     }
     console.log("  Registering Claude plugin marketplaces...");
-    const marketplaceList = spawnSync("claude", ["plugin", "marketplace", "list"], { stdio: "pipe", encoding: "utf-8" });
+    // Task 048 — pre-create the per-brand CLAUDE_CONFIG_DIR so the first
+    // `claude plugin marketplace add` has a directory to write into.
+    mkdirSync(CLAUDE_CONFIG_DIR, { recursive: true });
+    const marketplaceList = spawnSync("claude", ["plugin", "marketplace", "list"], { stdio: "pipe", encoding: "utf-8", env: claudePluginEnv() });
     if (marketplaceList.stderr)
         process.stderr.write(marketplaceList.stderr);
     const listed = marketplaceList.stdout ?? "";
@@ -938,16 +953,16 @@ function installClaudeCode() {
     ];
     for (const { slug, marketplaceName } of MARKETPLACES) {
         if (listed.includes(marketplaceName)) {
-            logFile(`[plugin-marketplace] added ${slug} idempotent=true`);
+            logFile(`[plugin-marketplace] added ${slug} idempotent=true CLAUDE_CONFIG_DIR=${CLAUDE_CONFIG_DIR}`);
             continue;
         }
-        const add = spawnSync("claude", ["plugin", "marketplace", "add", slug], { stdio: "pipe", encoding: "utf-8", timeout: 60_000 });
+        const add = spawnSync("claude", ["plugin", "marketplace", "add", slug], { stdio: "pipe", encoding: "utf-8", timeout: 60_000, env: claudePluginEnv() });
         if (add.status === 0) {
-            logFile(`[plugin-marketplace] added ${slug} idempotent=false`);
+            logFile(`[plugin-marketplace] added ${slug} idempotent=false CLAUDE_CONFIG_DIR=${CLAUDE_CONFIG_DIR}`);
         }
         else {
             const stderrShort = (add.stderr ?? "").split("\n")[0]?.slice(0, 200) ?? "";
-            logFile(`[plugin-marketplace] ERROR add ${slug} exit=${add.status} stderr=${JSON.stringify(stderrShort)}`);
+            logFile(`[plugin-marketplace] ERROR add ${slug} exit=${add.status} stderr=${JSON.stringify(stderrShort)} CLAUDE_CONFIG_DIR=${CLAUDE_CONFIG_DIR}`);
         }
     }
     console.log("  Configuring git to use HTTPS for GitHub (plugin install support)...");
@@ -956,10 +971,10 @@ function installClaudeCode() {
     // server in claude-agent.ts (with --cdp-endpoint) is the single correct path.
     // The plugin creates a shadow server that intermittently handles tool calls
     // without --cdp-endpoint, causing Chrome launch failures on ARM64.
-    const pluginList = spawnSync("claude", ["plugin", "list"], { stdio: "pipe", encoding: "utf-8" });
+    const pluginList = spawnSync("claude", ["plugin", "list"], { stdio: "pipe", encoding: "utf-8", env: claudePluginEnv() });
     if (pluginList.stdout?.includes("playwright")) {
         console.log("  Removing Playwright plugin (replaced by programmatic CDP server)...");
-        spawnSync("claude", ["plugin", "uninstall", "playwright"], { stdio: "inherit" });
+        spawnSync("claude", ["plugin", "uninstall", "playwright"], { stdio: "inherit", env: claudePluginEnv() });
     }
     // Ensure @playwright/mcp and all its dependencies (including playwright-core)
     // are cached. Wipe any stale npx cache for it first — killed installs on Pi
@@ -1922,20 +1937,23 @@ function registerLocalAndExternalPlugins() {
         }
     }
     // Add each local marketplace. Idempotence via `marketplace list` grep.
-    const mkList = spawnSync("claude", ["plugin", "marketplace", "list"], { stdio: "pipe", encoding: "utf-8" });
+    // Task 048 — every `claude plugin …` call carries CLAUDE_CONFIG_DIR so
+    // marketplaces register into the per-brand config dir that the runtime
+    // session-manager unit reads from.
+    const mkList = spawnSync("claude", ["plugin", "marketplace", "list"], { stdio: "pipe", encoding: "utf-8", env: claudePluginEnv() });
     const mkListed = mkList.stdout ?? "";
     for (const { name, dir } of localTrees) {
         if (mkListed.includes(name)) {
-            logFile(`[plugin-marketplace] added ${name} idempotent=true`);
+            logFile(`[plugin-marketplace] added ${name} idempotent=true CLAUDE_CONFIG_DIR=${CLAUDE_CONFIG_DIR}`);
             continue;
         }
-        const add = spawnSync("claude", ["plugin", "marketplace", "add", dir], { stdio: "pipe", encoding: "utf-8", timeout: 60_000 });
+        const add = spawnSync("claude", ["plugin", "marketplace", "add", dir], { stdio: "pipe", encoding: "utf-8", timeout: 60_000, env: claudePluginEnv() });
         if (add.status === 0) {
-            logFile(`[plugin-marketplace] added ${name} source=${dir} idempotent=false`);
+            logFile(`[plugin-marketplace] added ${name} source=${dir} idempotent=false CLAUDE_CONFIG_DIR=${CLAUDE_CONFIG_DIR}`);
         }
         else {
             const stderrShort = (add.stderr ?? "").split("\n")[0]?.slice(0, 200) ?? "";
-            logFile(`[plugin-marketplace] ERROR add ${name} source=${dir} exit=${add.status} stderr=${JSON.stringify(stderrShort)}`);
+            logFile(`[plugin-marketplace] ERROR add ${name} source=${dir} exit=${add.status} stderr=${JSON.stringify(stderrShort)} CLAUDE_CONFIG_DIR=${CLAUDE_CONFIG_DIR}`);
         }
     }
     // Build the desired plugin list = (every local marketplace's plugins) +
@@ -1967,14 +1985,14 @@ function registerLocalAndExternalPlugins() {
     }
     desired.push(...externals);
     // Snapshot what's installed to compute the install set.
-    const pluginList = spawnSync("claude", ["plugin", "list"], { stdio: "pipe", encoding: "utf-8" });
+    const pluginList = spawnSync("claude", ["plugin", "list"], { stdio: "pipe", encoding: "utf-8", env: claudePluginEnv() });
     const installed = parsePluginList(pluginList.stdout ?? "");
     const { toInstall, alreadyInstalled } = computeInstallActions(desired, installed);
     for (const ref of alreadyInstalled) {
         logFile(`[plugin-install] ${ref.name}@${ref.marketplace} idempotent=true`);
     }
     for (const ref of toInstall) {
-        const install = spawnSync("claude", ["plugin", "install", `${ref.name}@${ref.marketplace}`, "--scope", "user"], { stdio: "pipe", encoding: "utf-8", timeout: 120_000 });
+        const install = spawnSync("claude", ["plugin", "install", `${ref.name}@${ref.marketplace}`, "--scope", "user"], { stdio: "pipe", encoding: "utf-8", timeout: 120_000, env: claudePluginEnv() });
         if (install.status === 0) {
             logFile(`[plugin-install] ${ref.name}@${ref.marketplace} idempotent=false`);
         }
@@ -2000,7 +2018,7 @@ function registerLocalAndExternalPlugins() {
         // The piped-stdin form: `echo '/<name>:configure <secret>' | claude --print`
         // is the documented one-shot configure path. We do not log the secret value.
         const cmd = `/${action.plugin.name}:configure ${action.secretValue}`;
-        const configure = spawnSync("claude", ["--print", "--input-format", "text"], { input: cmd, stdio: ["pipe", "pipe", "pipe"], encoding: "utf-8", timeout: 60_000 });
+        const configure = spawnSync("claude", ["--print", "--input-format", "text"], { input: cmd, stdio: ["pipe", "pipe", "pipe"], encoding: "utf-8", timeout: 60_000, env: claudePluginEnv() });
         if (configure.status === 0) {
             logFile(`[plugin-configure] ${action.plugin.name} ok env-var=${action.plugin.configureSecret}`);
         }
@@ -2009,6 +2027,35 @@ function registerLocalAndExternalPlugins() {
             logFile(`[plugin-configure] ERROR ${action.plugin.name} exit=${configure.status} stderr=${JSON.stringify(stderrShort)}`);
         }
     }
+    // Task 048 — post-install assertion. The per-brand CLAUDE_CONFIG_DIR is the
+    // only surface the runtime session-manager reads from; if any expected
+    // marketplace is missing under .claude/plugins/marketplaces/, the operator
+    // will hit "Unknown skill: onboarding" at step 6 of the bring-up. Fail the
+    // install loudly here rather than ship a broken PTY.
+    //
+    // Expected set = 3 Anthropic marketplace names (from the constant in
+    // installClaudeCode) + every parsed localTrees name. Hardcoding the
+    // Anthropic names keeps the assertion independent of `MARKETPLACES` scope.
+    const expectedMarketplaces = new Set([
+        "claude-plugins-official",
+        "knowledge-work-plugins",
+        "claude-for-financial-services",
+        ...localTrees.map(t => t.name),
+    ]);
+    const marketplacesDir = join(CLAUDE_CONFIG_DIR, "plugins", "marketplaces");
+    let actualMarketplaces;
+    try {
+        actualMarketplaces = readdirSync(marketplacesDir);
+    }
+    catch (err) {
+        const msg = err instanceof Error ? err.message : String(err);
+        throw new Error(`Plugin registration produced no marketplaces directory at ${marketplacesDir} — every marketplace add failed (${msg}). Check setup.log for [plugin-marketplace] ERROR lines.`);
+    }
+    const missing = [...expectedMarketplaces].filter(m => !actualMarketplaces.includes(m));
+    if (missing.length > 0) {
+        throw new Error(`Plugin registration incomplete: expected marketplaces ${JSON.stringify([...expectedMarketplaces])} but ${marketplacesDir} contains ${JSON.stringify(actualMarketplaces)}. Missing: ${JSON.stringify(missing)}. Check setup.log for [plugin-marketplace] ERROR lines.`);
+    }
+    logFile(`[plugin-marketplace] assertion ok marketplaces=${JSON.stringify(actualMarketplaces)} CLAUDE_CONFIG_DIR=${CLAUDE_CONFIG_DIR}`);
 }
 function buildPlatform() {
     log("9", TOTAL, "Installing dependencies and building...");

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@rubytech/create-maxy-code",
-  "version": "0.1.24",
+  "version": "0.1.26",
   "description": "Install Maxy — AI for Productive People",
   "bin": {
     "create-maxy-code": "./dist/index.js"

package/payload/platform/plugins/admin/PLUGIN.md

@@ -2,29 +2,52 @@
 name: admin
 description: "Platform administration plugin. Provides system-status, public-hostname (deterministic Cloudflare public-URL resolver — single call returning the operator's canonical hostname so agents never guess property names on :CloudflareHostname nodes), brand-settings, account-manage, account-update, admin-add, admin-remove, admin-list, admin-update-pin, agent-list, agent-config-read, logs-read, plugin-read, skill-load (one-call resolve+read for SKILL.md by skill name — the canonical primitive for loading a named skill; plugin-read remains the reader for references/* and PLUGIN.md), store-skill (deterministic write counterpart to plugin-read; persists operator-authored skills as plugin files under the active account), render-component, session-reset, session-resume, file-attach, wifi, and action-approval tools (action-pending, action-approve, action-reject, action-edit) for managing the Maxy platform."
 tools:
-  - system-status
-  - public-hostname
-  - brand-settings
-  - account-manage
-  - account-update
-  - admin-add
-  - admin-remove
-  - admin-list
-  - admin-update-pin
-  - agent-list
-  - agent-config-read
-  - logs-read
-  - plugin-read
-  - skill-load
-  - store-skill
-  - render-component
-  - session-reset
-  - session-resume
-  - file-attach
-  - action-pending
-  - action-approve
-  - action-reject
-  - action-edit
+  - name: system-status
+    publicAllowlist: false
+  - name: public-hostname
+    publicAllowlist: false
+  - name: brand-settings
+    publicAllowlist: false
+  - name: account-manage
+    publicAllowlist: false
+  - name: account-update
+    publicAllowlist: false
+  - name: admin-add
+    publicAllowlist: false
+  - name: admin-remove
+    publicAllowlist: false
+  - name: admin-list
+    publicAllowlist: false
+  - name: admin-update-pin
+    publicAllowlist: false
+  - name: agent-list
+    publicAllowlist: false
+  - name: agent-config-read
+    publicAllowlist: false
+  - name: logs-read
+    publicAllowlist: false
+  - name: plugin-read
+    publicAllowlist: false
+  - name: skill-load
+    publicAllowlist: false
+  - name: store-skill
+    publicAllowlist: false
+  - name: render-component
+    publicAllowlist: false
+  - name: session-reset
+    publicAllowlist: false
+  - name: session-resume
+    publicAllowlist: false
+  - name: file-attach
+    publicAllowlist: false
+  - name: action-pending
+    publicAllowlist: false
+  - name: action-approve
+    publicAllowlist: false
+  - name: action-reject
+    publicAllowlist: false
+  - name: action-edit
+    publicAllowlist: false
 hidden:
   - remote-auth-status
   - remote-auth-set-password