npm - @rubytech/create-maxy-code - Versions diffs - 0.1.219 → 0.1.222 - Mend

@rubytech/create-maxy-code 0.1.219 → 0.1.222

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (124) hide show

package/payload/platform/plugins/admin/__tests__/admin-can-enumerate.test.sh ADDED Viewed

@@ -0,0 +1,129 @@
+#!/usr/bin/env bash
+# admin-can-enumerate.test.sh
+#
+# Acceptance gate for Task 579. Verifies that a fresh admin session
+# locates a file under <accountDir>/sites/ on the FIRST enumeration
+# attempt — no slug guessing, no `EISDIR`, no false-empty 200s, no
+# "Log directory does not exist" against a path that resolves
+# elsewhere. The gate runs from the installer post-install step against
+# the freshly-deployed payload, before systemd services are restarted
+# into it. A non-zero exit aborts the deploy and the old payload keeps
+# running.
+#
+# Required environment:
+#   CLAUDE_CONFIG_DIR   per-brand .claude directory (e.g. ~/.realagent-code/.claude)
+#   INSTALL_DIR         the brand install root (e.g. ~/realagent-code)
+#
+# Exit codes:
+#   0  pass — admin enumerated and emitted the seeded path within budget
+#   1  fail — one or more assertions tripped (see stderr for the line)
+#   2  setup error — could not seed test account or could not invoke claude
+set -euo pipefail
+CONFIG_DIR="${CLAUDE_CONFIG_DIR:?CLAUDE_CONFIG_DIR not set}"
+INSTALL_DIR="${INSTALL_DIR:?INSTALL_DIR not set}"
+if ! command -v claude >/dev/null 2>&1; then
+  echo "[admin-enumerate-gate] setup-error reason=claude-not-on-path" >&2
+  exit 2
+fi
+if ! command -v jq >/dev/null 2>&1; then
+  echo "[admin-enumerate-gate] setup-error reason=jq-not-on-path" >&2
+  exit 2
+fi
+ACCOUNTS_DIR="$INSTALL_DIR/data/accounts"
+TEST_ACCT_ID="enumerate-gate-$$"
+TEST_ACCT_DIR="$ACCOUNTS_DIR/$TEST_ACCT_ID"
+JSONL_OUT=$(mktemp)
+EXIT=0
+cleanup() {
+  rm -rf "$TEST_ACCT_DIR"
+  if [ "$EXIT" -eq 0 ]; then
+    rm -f "$JSONL_OUT"
+  else
+    echo "[admin-enumerate-gate] evidence-jsonl=$JSONL_OUT" >&2
+  fi
+}
+trap cleanup EXIT
+# Seed: one target site + 5 decoys. Target index.html is the file the
+# agent must locate and emit the absolute path for.
+mkdir -p "$TEST_ACCT_DIR/sites/exp-uk-got-talent"
+echo "<html><body>eXp Has Got Talent</body></html>" > "$TEST_ACCT_DIR/sites/exp-uk-got-talent/index.html"
+for decoy in alpha-corp-careers beta-properties gamma-events delta-news epsilon-portal; do
+  mkdir -p "$TEST_ACCT_DIR/sites/$decoy"
+  echo "<html>decoy</html>" > "$TEST_ACCT_DIR/sites/$decoy/index.html"
+done
+TARGET_PATH="$TEST_ACCT_DIR/sites/exp-uk-got-talent/index.html"
+PROMPT="find the eXp Has Got Talent site in this account and print the absolute path to its index.html"
+# Spawn claude headless against the test account. ACCOUNT_ID + the
+# MAXY_SESSION_ROLE/PLATFORM_ROOT env are what the platform MCPs read
+# to scope themselves; PLATFORM_ROOT resolves the on-disk payload that
+# was just deployed. JSONL goes to a file we parse below.
+ACCOUNT_ID="$TEST_ACCT_ID" \
+MAXY_SESSION_ROLE="admin" \
+PLATFORM_ROOT="$INSTALL_DIR/platform" \
+CLAUDE_CONFIG_DIR="$CONFIG_DIR" \
+  claude -p "$PROMPT" --output-format=stream-json --verbose \
+    > "$JSONL_OUT" 2>&1 \
+  || { echo "[admin-enumerate-gate] setup-error reason=claude-spawn-failed exit=$?" >&2; EXIT=2; exit 2; }
+fail() {
+  echo "[admin-enumerate-gate] FAIL $1" >&2
+  EXIT=1
+}
+# Assertion 1: the target path appears verbatim in some assistant turn
+# or tool-use input. Either as the agent's final message or as an arg
+# passed to a tool.
+if ! grep -F -q "$TARGET_PATH" "$JSONL_OUT"; then
+  fail "correct-path-not-emitted target=$TARGET_PATH"
+fi
+# Assertion 2: zero forbidden error patterns from the surfaces this
+# task fixed.
+FORBIDDEN_HITS=$(grep -E -c "EISDIR|Log directory does not exist|Plugin file not found|page has no readable text content" "$JSONL_OUT" || true)
+if [ "${FORBIDDEN_HITS:-0}" -gt 0 ]; then
+  fail "forbidden-error-patterns=$FORBIDDEN_HITS"
+fi
+# Assertion 3: total tool-use calls from the user prompt to the
+# correct-path emission are at most 3. The earlier failing run issued
+# ~15.
+TOOL_USE_COUNT=$(jq -r 'select(.type=="assistant") | .message.content[]? | select(.type=="tool_use") | .name' < "$JSONL_OUT" 2>/dev/null | wc -l | tr -d ' ' || echo 0)
+if [ "${TOOL_USE_COUNT:-0}" -gt 3 ]; then
+  fail "tool-use-budget-exceeded count=$TOOL_USE_COUNT cap=3"
+fi
+# Assertion 4: the FIRST disk-listing tool call returns an enumeration
+# of <accountDir>/sites/. "Disk-listing" means LS, Glob, or Bash with
+# `ls`. We accept any of those as the first relevant call; what we
+# reject is a Read against a directory path.
+FIRST_DIR_TOOL=$(jq -r 'select(.type=="assistant") | .message.content[]? | select(.type=="tool_use") | {name, input} | @json' < "$JSONL_OUT" 2>/dev/null \
+  | jq -r 'select(.name=="LS" or .name=="Glob" or (.name=="Bash" and (.input.command // "" | test("\\bls\\b")))) | .name' \
+  | head -1)
+if [ -z "$FIRST_DIR_TOOL" ]; then
+  fail "no-disk-listing-tool-call-emitted"
+fi
+# Assertion 5: no Read tool call against a path under <accountDir>/sites/
+# that is a directory (would have produced EISDIR pre-fix; should not
+# even be attempted now).
+BAD_READ=$(jq -r 'select(.type=="assistant") | .message.content[]? | select(.type=="tool_use" and .name=="Read") | .input.file_path // ""' < "$JSONL_OUT" 2>/dev/null \
+  | while read -r p; do
+      [ -n "$p" ] && [ -d "$p" ] && echo "$p"
+    done | head -1)
+if [ -n "$BAD_READ" ]; then
+  fail "read-against-directory path=$BAD_READ"
+fi
+if [ "$EXIT" -eq 0 ]; then
+  echo "[admin-enumerate-gate] PASS target=$TARGET_PATH tool-use-count=$TOOL_USE_COUNT first-dir-tool=$FIRST_DIR_TOOL"
+fi
+exit "$EXIT"

package/payload/platform/plugins/admin/hooks/archive-ingest-surface-gate.sh CHANGED Viewed

@@ -52,8 +52,7 @@
 #    server.log alongside the [whatsapp-ingest] script lines.
 #
 # Exit codes follow Claude Code hook protocol: 0 = allow, 2 = block (stderr
-# message shown to the agent). Fail-closed on terminal stdin to match
-# pre-tool-use.sh.
+# message shown to the agent). Fail-closed on terminal stdin.
 set -uo pipefail

package/payload/platform/plugins/admin/hooks/lib/hook-emit.sh CHANGED Viewed

@@ -130,8 +130,9 @@ PY
 # hook_block_with_emit <agentId> <hookName> <toolName> <reason>
 #                      <userMessage> [durationMs]
-# Convenience wrapper for pre-tool-use.sh: emits the propagation record,
-# echoes the user-facing block message to stderr, and exits 2.
+# Convenience wrapper for any PreToolUse hook that records a block decision:
+# emits the propagation record, echoes the user-facing block message to stderr,
+# and exits 2.
 hook_block_with_emit() {
   local agentId="$1" hookName="$2" toolName="$3" reason="$4"
   local userMessage="$5" durationMs="${6:-0}"

package/payload/platform/plugins/admin/mcp/dist/index.js CHANGED Viewed

@@ -755,8 +755,8 @@ eagerTool(server, "account-update", "Update a user-configurable setting in accou
     }
 });
 // Plugin enable/disable: deterministic write to account.json.enabledPlugins.
-// The pre-tool-use hook denies the agent's direct Edit on account.json,
-// so the agent can no longer toggle enablement by hand-editing the file. This
+// IDENTITY.md doctrine forbids the agent's direct Edit on account.json,
+// so the agent must not toggle enablement by hand-editing the file. This
 // tool is the legitimate path: validates the plugin name, refuses core plugins,
 // confirms the plugin directory exists, and atomically updates the array.
 // Entitlement-bearing fields (tier, purchasedPlugins) are NOT writable here.
@@ -1397,6 +1397,15 @@ eagerTool(server, "logs-read", "Read recent logs. Stream logs (type=agent-stream
     if (!ACCOUNT_ID)
         return refuseNoAccount("logs-read");
     try {
+        // Account-scoped per-session log dir. `<installDir>/data/accounts/
+        // <accountId>/logs/` mirrors the resolution in
+        // `platform/scripts/logs-read.sh`. This dir may not exist on a Pi
+        // where no claude session has yet tee'd stream output — that is NOT
+        // a fatal condition for platform-scoped types like `server` / `vnc`,
+        // which resolve against CONFIG_DIR below. Task 579 — the previous
+        // early-existence check returned "Log directory does not exist" for
+        // every type, including those whose actual target file lived
+        // elsewhere. Each branch now checks its own resolved path.
         const LOG_DIR = resolve(getAccountDir(), "logs");
         // sessionKey is the single identifier on disk.
         // `sessionId` is retained as a legacy alias that maps to the
@@ -1404,7 +1413,12 @@ eagerTool(server, "logs-read", "Read recent logs. Stream logs (type=agent-stream
         const idForResolve = sessionKey ?? sessionId;
         if (idForResolve) {
             if (!existsSync(LOG_DIR)) {
-                return { content: [{ type: "text", text: `Log directory does not exist: ${LOG_DIR}` }] };
+                return {
+                    content: [{
+                            type: "text",
+                            text: `No per-session logs for this account yet (resolved dir does not exist on disk): ${LOG_DIR}. The directory is created on first claude session spawn.`,
+                        }],
+                };
             }
             const prefixMap = {
                 "agent-stream": "claude-agent-stream",
@@ -1443,9 +1457,10 @@ eagerTool(server, "logs-read", "Read recent logs. Stream logs (type=agent-stream
                     }],
             };
         }
-        if (!existsSync(LOG_DIR)) {
-            return { content: [{ type: "text", text: `Log directory does not exist: ${LOG_DIR}` }] };
-        }
+        // Note: no early existence check on LOG_DIR here. Platform-scoped
+        // types (server, vnc, heartbeat) resolve against CONFIG_DIR below
+        // and must run even when the account log dir has not been created
+        // yet. Account-scoped types check LOG_DIR before they reach for it.
         // --- Session-key filtered mode: grep across log files ---
         if (sessionKey) {
             const prefixes = {
@@ -1463,7 +1478,13 @@ eagerTool(server, "logs-read", "Read recent logs. Stream logs (type=agent-stream
             const searchPrefixes = type && type !== "heartbeat" && type !== "server" && type !== "vnc" && prefixes[type]
                 ? { [type]: prefixes[type] }
                 : (type === "server" || type === "vnc") ? {} : prefixes;
-            const allFiles = readdirSync(LOG_DIR).filter(f => f.endsWith(".log"));
+            // LOG_DIR may not exist on a Pi with no per-session logs yet. The
+            // platform-scoped fallback dirs (CONFIG_DIR/logs/) are searched
+            // below; this branch simply contributes nothing rather than
+            // throwing on readdir.
+            const allFiles = existsSync(LOG_DIR)
+                ? readdirSync(LOG_DIR).filter(f => f.endsWith(".log"))
+                : [];
             const sections = [];
             // Search account-scoped prefix-based log files
             for (const [logType, prefix] of Object.entries(searchPrefixes)) {
@@ -1571,13 +1592,24 @@ eagerTool(server, "logs-read", "Read recent logs. Stream logs (type=agent-stream
                 : resolvedType === "public" ? "public-agent-stream-"
                     : resolvedType === "mcp" ? "mcp-"
                         : "claude-agent-stream-";
-        // Find the most recently modified file with the matching prefix
+        // Find the most recently modified file with the matching prefix.
+        // LOG_DIR may not exist yet on a Pi with no per-session logs; return
+        // the resolved path in the error envelope so the operator can
+        // verify on disk in one step rather than re-tracing the resolver.
+        if (!existsSync(LOG_DIR)) {
+            return {
+                content: [{
+                        type: "text",
+                        text: `No per-session logs for this account yet (resolved dir does not exist on disk): ${LOG_DIR}. The directory is created on first claude session spawn.`,
+                    }],
+            };
+        }
         const match = readdirSync(LOG_DIR)
             .filter(f => f.startsWith(prefix) && f.endsWith(".log"))
             .map(f => ({ file: f, mtime: statSync(resolve(LOG_DIR, f)).mtimeMs }))
             .sort((a, b) => b.mtime - a.mtime)[0];
         if (!match) {
-            return { content: [{ type: "text", text: `No log file found for type '${resolvedType}' in ${LOG_DIR}` }] };
+            return { content: [{ type: "text", text: `No log file found for type '${resolvedType}' (resolved dir: ${LOG_DIR}, prefix: ${prefix})` }] };
         }
         const logFile = resolve(LOG_DIR, match.file);
         const result = execFileSync("tail", ["-n", String(lines), logFile], {