@rubytech/create-maxy-code 0.1.188 → 0.1.190

package/payload/platform/plugins/admin/mcp/dist/index.js

@@ -18,7 +18,7 @@ import { createConnection } from "node:net";
 import { homedir, hostname as osHostname } from "node:os";
 import QRCode from "qrcode";
 import { getSession, closeDriver } from "./lib/neo4j.js";
-import { findSkillOwners, computePluginReadHint, loadSkill, parseRequiredInputs } from "./skill-resolution.js";
+import { findSkillOwners, computePluginReadHint, loadSkill, parseRequiredInputs, adminAuthoringSkillBlock, skillSlugFromReadArgs, AUTHORING_DISPATCH_HINT } from "./skill-resolution.js";
 import { resolvePublicHostname } from "./lib/public-hostname.js";
 import { publishSite } from "./tools/publish-site.js";
 function refusalGuidance(kind) {
@@ -1668,6 +1668,16 @@ eagerTool(server, "plugin-read", "Read a plugin definition (PLUGIN.md) or one of
         return refuseNoAccount("plugin-read");
     try {
         const resolvedFile = file ?? "PLUGIN.md";
+        // Task 516 — plugin-read is the raw-SKILL.md read path that would
+        // otherwise bypass the skill-load authoring gate. Block the admin seat
+        // from reading any content-producer-owned authoring skill's files
+        // (SKILL.md or its references); the slug is extracted from the file
+        // path or pluginName. Same fail-open contract as skill-load.
+        const authoringSlug = skillSlugFromReadArgs(pluginName, resolvedFile);
+        if (adminAuthoringSkillBlock(authoringSlug, process.env)) {
+            console.log(`[admin-skill-gate] role=admin skill=${authoringSlug} decision=block reason=content-producer-owned`);
+            return { content: [{ type: "text", text: AUTHORING_DISPATCH_HINT }], isError: true };
+        }
         const pluginPath = resolve(PLATFORM_ROOT, "plugins", pluginName, resolvedFile);
         if (!existsSync(pluginPath)) {
             // when the agent's pluginName/file combination misses
@@ -1796,6 +1806,15 @@ eagerTool(server, "skill-load", "Load a plugin skill's SKILL.md body by skill na
 }, async ({ skillName }) => {
     if (!ACCOUNT_ID)
         return refuseNoAccount("skill-load");
+    // Task 516 — the admin seat may not load content-producer-owned
+    // authoring skills inline; it must dispatch content-producer instead.
+    // The gate is a pure name+env check before any filesystem read, and
+    // fails open for non-admin / unidentified seats (content-producer's own
+    // spawns carry MAXY_SPECIALIST and resolve normally).
+    if (adminAuthoringSkillBlock(skillName, process.env)) {
+        console.log(`[admin-skill-gate] role=admin skill=${skillName} decision=block reason=content-producer-owned`);
+        return { content: [{ type: "text", text: AUTHORING_DISPATCH_HINT }], isError: true };
+    }
     const start = Date.now();
     try {
         const outcome = await loadSkill(PLATFORM_ROOT, skillName);
@@ -1855,7 +1874,7 @@ eagerTool(server, "skill-load", "Load a plugin skill's SKILL.md body by skill na
 // sentinel that read like a successful render to the agent while the
 // chat surface saw nothing. Admin flows now use plain markdown for
 // reviewable artefacts and the `file-presentation` skill for downloadable
-// artefacts (the skill picks `SendUserFile` or `file-attach` by inventory).
+// artefacts (delivered via `SendUserFile`, the native Claude Code surface).
 // The :Component / :KnowledgeDocument
 // persistence pipeline is preserved for historical conversations that
 // already carry the rows; no new conversations write to it.
@@ -2551,99 +2570,6 @@ server.tool("premium-deliver", "Deliver a purchased premium plugin. Copies plugi
         content: [{ type: "text", text: JSON.stringify(output, null, 2) }],
     };
 });
-// ---------------------------------------------------------------------------
-// file-attach — copy a generated file into the attachment store for download
-// ---------------------------------------------------------------------------
-eagerTool(server, "file-attach", "Attach a file from the account directory for delivery to the user on non-PTY chat " +
-    "surfaces (web chat, WhatsApp) where the platform UI mediates attachment rendering. " +
-    "On the native Claude Code PTY surface, `SendUserFile` is the delivery — `file-attach` " +
-    "returns an `attachmentId` envelope only and renders no chip there. Tool selection is " +
-    "by inventory: see the `file-presentation` skill. Copies the file into the attachment " +
-    "store and returns metadata the chat surface uses to present the download. The file " +
-    "must be within the account directory tree. The returned metadata is the operator-visible " +
-    "record of the attachment; quote it back to the user in plain text so they have the " +
-    "filename and size on screen.", {
-    filePath: z.string().describe("Absolute path to the file to attach"),
-}, async ({ filePath }) => {
-    if (!ACCOUNT_ID)
-        return refuseNoAccount("file-attach");
-    const TAG = "[file-attach]";
-    if (!filePath || !filePath.trim()) {
-        return {
-            content: [{ type: "text", text: `${TAG} filePath is required` }],
-            isError: true,
-        };
-    }
-    const accountDir = getAccountDir();
-    // --- Path validation: must be within the account directory ---
-    let resolvedPath;
-    try {
-        const { realpathSync: rp } = await import("node:fs");
-        resolvedPath = rp(filePath);
-        const accountResolved = rp(accountDir);
-        if (!resolvedPath.startsWith(accountResolved + "/")) {
-            const sanitised = filePath.replace(accountDir, "<account>/");
-            console.error(`${TAG} REJECTED path=${sanitised} reason=outside_account_directory`);
-            return {
-                content: [{ type: "text", text: `${TAG} Access denied: file is outside the account directory.` }],
-                isError: true,
-            };
-        }
-    }
-    catch (err) {
-        const code = err.code;
-        if (code === "ENOENT") {
-            console.error(`${TAG} ENOENT path=${filePath}`);
-            return {
-                content: [{ type: "text", text: `${TAG} File not found: ${filePath}` }],
-                isError: true,
-            };
-        }
-        console.error(`${TAG} path validation error: ${err instanceof Error ? err.message : String(err)}`);
-        return {
-            content: [{ type: "text", text: `${TAG} Failed to validate file path: ${err instanceof Error ? err.message : String(err)}` }],
-            isError: true,
-        };
-    }
-    // --- Store in attachment store ---
-    const targetUrl = `http://127.0.0.1:${PLATFORM_PORT}/api/admin/file-attach`;
-    try {
-        const res = await fetch(targetUrl, {
-            method: "POST",
-            headers: { "Content-Type": "application/json" },
-            body: JSON.stringify({ filePath: resolvedPath, accountId: ACCOUNT_ID }),
-        });
-        const result = await res.json();
-        if (!res.ok || result.error) {
-            const msg = result.error || `HTTP ${res.status}`;
-            console.error(`${TAG} store failed url=${targetUrl} status=${res.status} error=${msg}`);
-            return {
-                content: [{ type: "text", text: `${TAG} Failed to attach file: ${msg} (url=${targetUrl})` }],
-                isError: true,
-            };
-        }
-        console.error(`${TAG} attached path=${resolvedPath} size=${result.sizeBytes} mime=${result.mimeType} id=${result.attachmentId}`);
-        return {
-            content: [{
-                    type: "text",
-                    text: JSON.stringify({
-                        attachmentId: result.attachmentId,
-                        filename: result.filename,
-                        sizeBytes: result.sizeBytes,
-                        mimeType: result.mimeType,
-                    }),
-                }],
-        };
-    }
-    catch (err) {
-        const errMsg = err instanceof Error ? err.message : String(err);
-        console.error(`${TAG} fetch failed url=${targetUrl} error=${errMsg}`);
-        return {
-            content: [{ type: "text", text: `${TAG} Failed to attach file: could not reach platform server at ${targetUrl} (${errMsg})` }],
-            isError: true,
-        };
-    }
-});
 // ===================================================================
 // Action approval tools (EU AI Act Article 14 — human oversight)
 //