@rubytech/create-maxy-code 0.1.147 → 0.1.150

package/payload/platform/plugins/admin/hooks/__tests__/pre-turn-graph-pass.test.sh

@@ -0,0 +1,544 @@
+#!/usr/bin/env bash
+# Task 425 — pre-turn-graph-pass UserPromptSubmit hook test suite.
+#
+# Supersedes the Task 419 Stop-hook test suite. A local Python HTTP server
+# stands in for the admin server:
+#   POST /api/admin/log-ingest        → records every line emit_log sent.
+#   GET  /api/admin/post-turn-context → returns the contents of $CTX_FILE,
+#                                       or 500 if $CTX_FILE is missing/empty.
+# Both kinds of request are appended to $REQ_LOG so assertions can see
+# every POST body AND whether the GET was attempted at all.
+#
+# Contract under test:
+#   - Role/specialist gates: exit 0, single trigger-skipped log line, empty
+#     stdout (no additionalContext).
+#   - MAXY_UI_INTERNAL_PORT unset: exit 0, empty stdout. The hook emits its
+#     missing-env diagnostic on its own stderr channel because
+#     /api/admin/log-ingest is unreachable; loud-fail is acceptable.
+#   - Missing-transcript: exit 0, single trigger-skipped log line, empty
+#     stdout.
+#   - Dispatch path (admin + populated JSONL): exit 0, stdout is a JSON
+#     envelope `{"hookSpecificOutput":{"hookEventName":"UserPromptSubmit",
+#     "additionalContext":"..."}}` whose additionalContext begins with
+#     `[system: pre-turn-graph-pass-hook]` and contains `<conversation>` +
+#     `<prior-writes>` blocks, with conversationId interpolated from
+#     CONVERSATION_NODE_ID.
+#   - Prior-writes fetch fails (context endpoint 500): exit 0, dispatch
+#     still fires, `<prior-writes>` block resolves to `(none)`.
+#   - CONVERSATION_NODE_ID unset: exit 0, additionalContext names
+#     `conversationId: <unset>`, and no GET to /api/admin/post-turn-context
+#     is attempted.
+#   - Multi-block assistant turn: conversation walk concatenates `text`
+#     blocks; `tool_use` blocks dropped.
+#   - User turn whose only content is `tool_result` blocks: skipped in
+#     the conversation walk.
+#   - UserPromptSubmit stdin-shape regression: a synthetic UserPromptSubmit
+#     payload produces the documented stdout envelope; a stale Stop-shaped
+#     payload (no hook_event_name, no prompt) also produces the
+#     UserPromptSubmit envelope because the hook keys on
+#     session_id + transcript_path, not on input shape sniffing.
+
+set -u
+
+HOOK="$(cd "$(dirname "$0")/.." && pwd)/pre-turn-graph-pass.sh"
+if [[ ! -x "$HOOK" ]]; then
+  echo "FAIL: $HOOK not executable" >&2
+  exit 1
+fi
+
+OP_ID='aaaaaaaa-1111-2222-3333-bbbbbbbbbbbb'
+CONV_ID='conv-deadbeef-0001'
+
+TMPFILES=()
+LISTENER_PIDS=()
+cleanup_test_state() {
+  for pid in "${LISTENER_PIDS[@]:-}"; do
+    if [[ -n "$pid" ]]; then
+      kill "$pid" 2>/dev/null || true
+      wait "$pid" 2>/dev/null || true
+    fi
+  done
+  for f in "${TMPFILES[@]:-}"; do
+    [[ -n "$f" ]] && rm -f "$f" 2>/dev/null || true
+  done
+}
+trap cleanup_test_state EXIT
+
+PASS=0
+FAIL=0
+pass() { echo "PASS: $1"; PASS=$((PASS + 1)); }
+fail() { echo "FAIL: $1" >&2; FAIL=$((FAIL + 1)); }
+
+start_listener() {
+  REQ_LOG=$(mktemp); TMPFILES+=("$REQ_LOG")
+  CTX_FILE=$(mktemp); TMPFILES+=("$CTX_FILE")
+  : > "$CTX_FILE"
+  LISTENER_PORT=$((39700 + RANDOM % 100))
+  python3 - "$LISTENER_PORT" "$REQ_LOG" "$CTX_FILE" <<'PY' &
+import sys, http.server, json
+port = int(sys.argv[1])
+log_path = sys.argv[2]
+ctx_path = sys.argv[3]
+
+class H(http.server.BaseHTTPRequestHandler):
+  def log_message(self, *a, **k): pass
+  def do_POST(self):
+    n = int(self.headers.get('Content-Length','0') or 0)
+    body = self.rfile.read(n).decode('utf-8','replace')
+    with open(log_path, 'a', encoding='utf-8') as f:
+      f.write('POST\t' + self.path + '\t' + body + '\n')
+    self.send_response(200)
+    self.send_header('Content-Type','application/json')
+    self.end_headers()
+    self.wfile.write(json.dumps({"ok": True}).encode('utf-8'))
+  def do_GET(self):
+    with open(log_path, 'a', encoding='utf-8') as f:
+      f.write('GET\t' + self.path + '\t\n')
+    if self.path.startswith('/api/admin/post-turn-context'):
+      try:
+        with open(ctx_path, 'r', encoding='utf-8') as f:
+          body = f.read()
+      except FileNotFoundError:
+        body = ''
+      if not body.strip():
+        self.send_response(500)
+        self.end_headers()
+        return
+      self.send_response(200)
+      self.send_header('Content-Type','application/json')
+      self.end_headers()
+      self.wfile.write(body.encode('utf-8'))
+    else:
+      self.send_response(404)
+      self.end_headers()
+
+http.server.HTTPServer(('127.0.0.1', port), H).serve_forever()
+PY
+  LISTENER_PIDS+=("$!")
+  for _ in $(seq 1 20); do
+    if curl -sS --max-time 1 -X POST "http://127.0.0.1:${LISTENER_PORT}/ping" -d '{}' >/dev/null 2>&1; then
+      break
+    fi
+    sleep 0.1
+  done
+  : > "$REQ_LOG"
+}
+
+run_hook() {
+  # Args: role, specialist, ui_port, conversation_node_id, stdin_json
+  local role="$1"; local specialist="$2"; local ui_port="$3"
+  local conv="$4"; local stdin_json="$5"
+  local stderr_file; stderr_file=$(mktemp); TMPFILES+=("$stderr_file")
+  local stdout_file; stdout_file=$(mktemp); TMPFILES+=("$stdout_file")
+  local env_cmd=(env)
+  env_cmd+=("MAXY_SESSION_ROLE=${role}")
+  env_cmd+=("MAXY_SPECIALIST=${specialist}")
+  if [[ -n "$ui_port" ]]; then
+    env_cmd+=("MAXY_UI_INTERNAL_PORT=${ui_port}")
+  fi
+  if [[ -n "$conv" ]]; then
+    env_cmd+=("CONVERSATION_NODE_ID=${conv}")
+  fi
+  env_cmd+=("ACCOUNT_ID=acct-test-0001")
+  printf '%s' "$stdin_json" | "${env_cmd[@]}" bash "$HOOK" >"$stdout_file" 2>"$stderr_file"
+  HOOK_RC=$?
+  HOOK_STDERR=$(cat "$stderr_file")
+  HOOK_STDOUT=$(cat "$stdout_file")
+  sleep 0.1
+}
+
+ingest_lines() {
+  grep -E '^POST\s+/api/admin/log-ingest\s+' "$REQ_LOG" 2>/dev/null | python3 -c '
+import sys, json
+for raw in sys.stdin:
+  try:
+    parts = raw.rstrip("\n").split("\t", 2)
+    if len(parts) < 3: continue
+    body = parts[2]
+    d = json.loads(body)
+    if isinstance(d, dict) and isinstance(d.get("line"), str):
+      print(d["line"])
+  except Exception:
+    pass
+' || true
+}
+
+context_get_count() {
+  grep -E '^GET\s+/api/admin/post-turn-context' "$REQ_LOG" 2>/dev/null | wc -l | tr -d ' '
+}
+
+additional_context() {
+  printf '%s' "$HOOK_STDOUT" | python3 -c '
+import sys, json
+try:
+  d = json.load(sys.stdin)
+  out = (d.get("hookSpecificOutput") or {}).get("additionalContext", "")
+  sys.stdout.write(out)
+except Exception:
+  pass
+'
+}
+
+envelope_for() {
+  python3 -c '
+import json, sys
+print(json.dumps({
+    "session_id": sys.argv[1],
+    "transcript_path": sys.argv[2],
+    "cwd": "/tmp",
+    "hook_event_name": "UserPromptSubmit",
+    "prompt": "test prompt body",
+}))
+' "$1" "$2"
+}
+
+write_simple_transcript() {
+  local out="$1"; shift
+  python3 - "$out" "$@" <<'PY'
+import sys, json
+out = sys.argv[1]
+records = []
+i = 2
+while i + 1 < len(sys.argv):
+    u, a = sys.argv[i], sys.argv[i+1]
+    records.append({
+        "type": "user",
+        "timestamp": "2026-05-26T10:00:00.000Z",
+        "message": {"role": "user", "content": u},
+    })
+    records.append({
+        "type": "assistant",
+        "timestamp": "2026-05-26T10:00:01.000Z",
+        "message": {
+            "id": "msg_a",
+            "role": "assistant",
+            "content": [{"type": "text", "text": a}],
+        },
+    })
+    i += 2
+with open(out, "w", encoding="utf-8") as f:
+    for r in records:
+        f.write(json.dumps(r) + "\n")
+PY
+}
+
+DIRECTIVE_TOKEN='[system: pre-turn-graph-pass-hook]'
+
+# ---------------------------------------------------------------------------
+# Case 1: role != admin → trigger-skipped reason=role-not-admin
+# ---------------------------------------------------------------------------
+start_listener
+TRANSCRIPT_BASIC=$(mktemp); TMPFILES+=("$TRANSCRIPT_BASIC")
+write_simple_transcript "$TRANSCRIPT_BASIC" "hello" "hi there"
+ENV_BASIC=$(envelope_for "$OP_ID" "$TRANSCRIPT_BASIC")
+: > "$REQ_LOG"
+run_hook "public" "" "$LISTENER_PORT" "$CONV_ID" "$ENV_BASIC"
+[[ "$HOOK_RC" -eq 0 ]] || fail "case-1 rc=$HOOK_RC"
+if [[ -n "$HOOK_STDOUT" ]]; then
+  fail "case-1 stdout must be empty on role-not-admin, got: $HOOK_STDOUT"
+fi
+if ingest_lines | grep -qE "^trigger-skipped sessionId=${OP_ID} reason=role-not-admin$"; then
+  pass "case-1 role=public → trigger-skipped reason=role-not-admin"
+else
+  fail "case-1 expected role-not-admin, got: $(ingest_lines)"
+fi
+
+# ---------------------------------------------------------------------------
+# Case 2: MAXY_SPECIALIST set → trigger-skipped reason=is-specialist
+# ---------------------------------------------------------------------------
+: > "$REQ_LOG"
+run_hook "admin" "database-operator" "$LISTENER_PORT" "$CONV_ID" "$ENV_BASIC"
+[[ "$HOOK_RC" -eq 0 ]] || fail "case-2 rc=$HOOK_RC"
+if [[ -n "$HOOK_STDOUT" ]]; then
+  fail "case-2 stdout must be empty on is-specialist, got: $HOOK_STDOUT"
+fi
+if ingest_lines | grep -qE "^trigger-skipped sessionId=${OP_ID} reason=is-specialist specialist=database-operator$"; then
+  pass "case-2 specialist=database-operator → trigger-skipped reason=is-specialist"
+else
+  fail "case-2 expected is-specialist, got: $(ingest_lines)"
+fi
+
+# ---------------------------------------------------------------------------
+# Case 3: MAXY_UI_INTERNAL_PORT unset → exit 0, empty stdout, loud stderr.
+# ---------------------------------------------------------------------------
+: > "$REQ_LOG"
+run_hook "admin" "" "" "$CONV_ID" "$ENV_BASIC"
+[[ "$HOOK_RC" -eq 0 ]] || fail "case-3 rc=$HOOK_RC"
+if [[ -n "$HOOK_STDOUT" ]]; then
+  fail "case-3 stdout must be empty when MAXY_UI_INTERNAL_PORT unset"
+fi
+if [[ "$(ingest_lines | wc -l | tr -d ' ')" == "0" ]]; then
+  pass "case-3 missing MAXY_UI_INTERNAL_PORT → exit 0, no dispatch"
+else
+  fail "case-3 expected no ingest lines (port unset), got: $(ingest_lines)"
+fi
+
+# ---------------------------------------------------------------------------
+# Case 4: transcript_path missing on disk → trigger-skipped reason=missing-transcript
+# ---------------------------------------------------------------------------
+MISSING_PATH="/tmp/pre-turn-graph-pass-does-not-exist-$$.jsonl"
+rm -f "$MISSING_PATH"
+ENV_MISSING=$(envelope_for "$OP_ID" "$MISSING_PATH")
+: > "$REQ_LOG"
+run_hook "admin" "" "$LISTENER_PORT" "$CONV_ID" "$ENV_MISSING"
+[[ "$HOOK_RC" -eq 0 ]] || fail "case-4 rc=$HOOK_RC"
+if [[ -n "$HOOK_STDOUT" ]]; then
+  fail "case-4 stdout must be empty on missing-transcript"
+fi
+if ingest_lines | grep -qE "^trigger-skipped sessionId=${OP_ID} reason=missing-transcript$"; then
+  pass "case-4 missing transcript_path → trigger-skipped reason=missing-transcript"
+else
+  fail "case-4 expected missing-transcript, got: $(ingest_lines)"
+fi
+
+# ---------------------------------------------------------------------------
+# Case 5: Dispatch path → exit 0, UserPromptSubmit JSON envelope, blocks
+#         interpolated, dispatch log emitted.
+# ---------------------------------------------------------------------------
+cat > "$CTX_FILE" <<'JSON'
+{"writes":[{"elementId":"4:abc:1","labels":["KnowledgeDocument"],"properties":{"title":"prior note"}}]}
+JSON
+: > "$REQ_LOG"
+run_hook "admin" "" "$LISTENER_PORT" "$CONV_ID" "$ENV_BASIC"
+[[ "$HOOK_RC" -eq 0 ]] || fail "case-5 expected rc=0, got $HOOK_RC"
+STDOUT_OK=$(printf '%s' "$HOOK_STDOUT" | python3 -c '
+import sys, json
+try:
+  d = json.load(sys.stdin)
+  out = d["hookSpecificOutput"]
+  assert out["hookEventName"] == "UserPromptSubmit"
+  assert isinstance(out["additionalContext"], str)
+  print("OK")
+except Exception as e:
+  print(f"BAD: {e}")
+')
+if [[ "$STDOUT_OK" != "OK" ]]; then
+  fail "case-5 stdout envelope malformed: $STDOUT_OK"
+fi
+CTX_BODY=$(additional_context)
+if ! printf '%s' "$CTX_BODY" | head -n 1 | grep -qF "$DIRECTIVE_TOKEN"; then
+  fail "case-5 additionalContext must begin with $DIRECTIVE_TOKEN"
+fi
+if ! printf '%s' "$CTX_BODY" | grep -q '<conversation>'; then
+  fail "case-5 additionalContext missing <conversation> block"
+fi
+if ! printf '%s' "$CTX_BODY" | grep -q '<prior-writes>'; then
+  fail "case-5 additionalContext missing <prior-writes> block"
+fi
+if ! printf '%s' "$CTX_BODY" | grep -q "conversationId: ${CONV_ID}"; then
+  fail "case-5 additionalContext must interpolate conversationId=${CONV_ID}"
+fi
+if ! printf '%s' "$CTX_BODY" | grep -q '\[user: hello\]'; then
+  fail "case-5 additionalContext must carry user turn '[user: hello]'"
+fi
+if ! printf '%s' "$CTX_BODY" | grep -q '\[assistant: hi there\]'; then
+  fail "case-5 additionalContext must carry assistant turn '[assistant: hi there]'"
+fi
+if ! printf '%s' "$CTX_BODY" | grep -q 'KnowledgeDocument'; then
+  fail "case-5 additionalContext <prior-writes> must include fetched labels"
+fi
+if ingest_lines | grep -qE "^dispatch sessionId=${OP_ID} conversationId=${CONV_ID} "; then
+  pass "case-5 dispatch path → exit 0 + JSON envelope with conversation, prior-writes, conversationId"
+else
+  fail "case-5 expected dispatch log line, got: $(ingest_lines)"
+fi
+
+# ---------------------------------------------------------------------------
+# Case 6: Prior-writes fetch fails (500) → exit 0, prior-writes=(none).
+# ---------------------------------------------------------------------------
+: > "$CTX_FILE"
+: > "$REQ_LOG"
+run_hook "admin" "" "$LISTENER_PORT" "$CONV_ID" "$ENV_BASIC"
+[[ "$HOOK_RC" -eq 0 ]] || fail "case-6 expected rc=0, got $HOOK_RC"
+CTX_BODY=$(additional_context)
+PRIOR_BODY=$(printf '%s' "$CTX_BODY" | awk '/<prior-writes>/{flag=1;next}/<\/prior-writes>/{flag=0}flag' | tr -d '[:space:]')
+if [[ "$PRIOR_BODY" == "(none)" ]]; then
+  pass "case-6 context endpoint 500 → dispatch still fires, prior-writes = (none)"
+else
+  fail "case-6 expected prior-writes=(none), got [$PRIOR_BODY]"
+fi
+
+# ---------------------------------------------------------------------------
+# Case 7: CONVERSATION_NODE_ID unset → conversationId:<unset>, no context GET.
+# ---------------------------------------------------------------------------
+cat > "$CTX_FILE" <<'JSON'
+{"writes":[]}
+JSON
+: > "$REQ_LOG"
+run_hook "admin" "" "$LISTENER_PORT" "" "$ENV_BASIC"
+[[ "$HOOK_RC" -eq 0 ]] || fail "case-7 expected rc=0, got $HOOK_RC"
+CTX_BODY=$(additional_context)
+if ! printf '%s' "$CTX_BODY" | grep -q 'conversationId: <unset>'; then
+  fail "case-7 additionalContext must contain 'conversationId: <unset>'"
+fi
+GET_COUNT=$(context_get_count)
+if [[ "$GET_COUNT" == "0" ]]; then
+  pass "case-7 CONVERSATION_NODE_ID unset → no GET /api/admin/post-turn-context attempted"
+else
+  fail "case-7 expected zero context GETs, got: $GET_COUNT"
+fi
+
+# ---------------------------------------------------------------------------
+# Case 8: Multi-block assistant turn → text concatenated, tool_use dropped.
+# ---------------------------------------------------------------------------
+T_MULTI=$(mktemp); TMPFILES+=("$T_MULTI")
+python3 - "$T_MULTI" <<'PY'
+import sys, json
+out = sys.argv[1]
+records = [
+    {
+        "type": "user",
+        "timestamp": "2026-05-26T10:00:00.000Z",
+        "message": {"role": "user", "content": "go"},
+    },
+    {
+        "type": "assistant",
+        "timestamp": "2026-05-26T10:00:01.000Z",
+        "message": {
+            "id": "msg_a",
+            "role": "assistant",
+            "content": [
+                {"type": "text", "text": "part-one "},
+                {"type": "tool_use", "id": "tu_1", "name": "Read", "input": {}},
+                {"type": "text", "text": "part-two"},
+            ],
+        },
+    },
+]
+with open(out, "w", encoding="utf-8") as f:
+    for r in records:
+        f.write(json.dumps(r) + "\n")
+PY
+ENV_MULTI=$(envelope_for "$OP_ID" "$T_MULTI")
+cat > "$CTX_FILE" <<'JSON'
+{"writes":[]}
+JSON
+: > "$REQ_LOG"
+run_hook "admin" "" "$LISTENER_PORT" "$CONV_ID" "$ENV_MULTI"
+[[ "$HOOK_RC" -eq 0 ]] || fail "case-8 expected rc=0, got $HOOK_RC"
+CTX_BODY=$(additional_context)
+if ! printf '%s' "$CTX_BODY" | grep -q '\[assistant: part-one part-two\]'; then
+  fail "case-8 expected concatenated assistant text '[assistant: part-one part-two]'"
+fi
+if printf '%s' "$CTX_BODY" | grep -q '"tool_use"'; then
+  fail "case-8 tool_use block must not appear in additionalContext"
+fi
+if printf '%s' "$CTX_BODY" | grep -q '\[assistant: part-one part-two\]'; then
+  pass "case-8 multi-block assistant turn → text concatenated, tool_use dropped"
+fi
+
+# ---------------------------------------------------------------------------
+# Case 9: User turn with only tool_result blocks → skipped in conversation walk.
+# ---------------------------------------------------------------------------
+T_TRONLY=$(mktemp); TMPFILES+=("$T_TRONLY")
+python3 - "$T_TRONLY" <<'PY'
+import sys, json
+out = sys.argv[1]
+records = [
+    {
+        "type": "user",
+        "timestamp": "2026-05-26T10:00:00.000Z",
+        "message": {"role": "user", "content": "real user turn"},
+    },
+    {
+        "type": "assistant",
+        "timestamp": "2026-05-26T10:00:01.000Z",
+        "message": {
+            "id": "msg_a",
+            "role": "assistant",
+            "content": [{"type": "text", "text": "assistant reply"}],
+        },
+    },
+    {
+        "type": "user",
+        "timestamp": "2026-05-26T10:00:02.000Z",
+        "message": {
+            "role": "user",
+            "content": [
+                {"type": "tool_result", "tool_use_id": "tu_x", "content": "tool plumbing payload"},
+            ],
+        },
+    },
+]
+with open(out, "w", encoding="utf-8") as f:
+    for r in records:
+        f.write(json.dumps(r) + "\n")
+PY
+ENV_TRONLY=$(envelope_for "$OP_ID" "$T_TRONLY")
+: > "$REQ_LOG"
+run_hook "admin" "" "$LISTENER_PORT" "$CONV_ID" "$ENV_TRONLY"
+[[ "$HOOK_RC" -eq 0 ]] || fail "case-9 expected rc=0, got $HOOK_RC"
+CTX_BODY=$(additional_context)
+CONV_BLOCK=$(printf '%s' "$CTX_BODY" | awk '/<conversation>/{flag=1;next}/<\/conversation>/{flag=0}flag')
+if ! printf '%s' "$CONV_BLOCK" | grep -q '\[user: real user turn\]'; then
+  fail "case-9 conversation block must include real user turn"
+fi
+if printf '%s' "$CONV_BLOCK" | grep -q 'tool plumbing payload'; then
+  fail "case-9 tool_result-only user record must not appear in conversation walk"
+fi
+TR_LINES=$(printf '%s\n' "$CONV_BLOCK" | grep -cE '\[user:' || true)
+if [[ "$TR_LINES" == "1" ]]; then
+  pass "case-9 tool_result-only user record skipped in conversation walk"
+else
+  fail "case-9 expected exactly one [user: ...] line, got $TR_LINES"
+fi
+
+# ---------------------------------------------------------------------------
+# Case 10: UserPromptSubmit shape — directive on stdout only, never stderr;
+#          stdout envelope has hookEventName="UserPromptSubmit".
+# ---------------------------------------------------------------------------
+cat > "$CTX_FILE" <<'JSON'
+{"writes":[]}
+JSON
+: > "$REQ_LOG"
+run_hook "admin" "" "$LISTENER_PORT" "$CONV_ID" "$ENV_BASIC"
+[[ "$HOOK_RC" -eq 0 ]] || fail "case-10 expected rc=0, got $HOOK_RC"
+if printf '%s' "$HOOK_STDERR" | grep -qF "$DIRECTIVE_TOKEN"; then
+  fail "case-10 directive must not appear on stderr (UserPromptSubmit contract is stdout JSON)"
+fi
+HEN=$(printf '%s' "$HOOK_STDOUT" | python3 -c '
+import sys, json
+try:
+  d = json.load(sys.stdin)
+  sys.stdout.write(d["hookSpecificOutput"]["hookEventName"])
+except Exception:
+  pass
+')
+if [[ "$HEN" == "UserPromptSubmit" ]]; then
+  pass "case-10 stdout envelope is well-formed JSON with hookEventName=UserPromptSubmit"
+else
+  fail "case-10 expected hookEventName=UserPromptSubmit, got [$HEN]"
+fi
+
+# ---------------------------------------------------------------------------
+# Case 11: Stop-shaped stdin regression — a CC Stop-hook payload carries
+#          hook_event_name="Stop". The hook must not silently emit a
+#          UserPromptSubmit envelope on a Stop fire. Expect exit 0 with
+#          empty stdout and a `wrong-hook-event` skip line.
+# ---------------------------------------------------------------------------
+ENV_STOP_SHAPED=$(python3 -c '
+import json, sys
+print(json.dumps({
+    "session_id": sys.argv[1],
+    "transcript_path": sys.argv[2],
+    "hook_event_name": "Stop",
+}))
+' "$OP_ID" "$TRANSCRIPT_BASIC")
+: > "$REQ_LOG"
+run_hook "admin" "" "$LISTENER_PORT" "$CONV_ID" "$ENV_STOP_SHAPED"
+[[ "$HOOK_RC" -eq 0 ]] || fail "case-11 expected rc=0, got $HOOK_RC"
+if [[ -n "$HOOK_STDOUT" ]]; then
+  fail "case-11 stdout must be empty on wrong-hook-event Stop, got: $HOOK_STDOUT"
+fi
+if ingest_lines | grep -qE "^trigger-skipped sessionId=${OP_ID} reason=wrong-hook-event event=Stop$"; then
+  pass "case-11 Stop-shaped stdin rejected with wrong-hook-event skip"
+else
+  fail "case-11 expected wrong-hook-event skip, got: $(ingest_lines)"
+fi
+
+# ---------------------------------------------------------------------------
+# Summary
+# ---------------------------------------------------------------------------
+echo
+echo "pre-turn-graph-pass tests: $PASS passed, $FAIL failed"
+[[ "$FAIL" -eq 0 ]]

package/payload/platform/plugins/admin/hooks/__tests__/session-end-retrospective.test.sh

@@ -294,7 +294,7 @@ write_transcript "$T_RELEASE" \
   "assistant|hello|" \
   "user|/end|" \
   "assistant|running retrospective|" \
-  "assistant||tool_use:session-retrospective-mark-complete"
+  "assistant||tool_use:mcp__admin__session-retrospective-mark-complete"
 ENV_REL=$(envelope_for "$OP_ID" "$T_RELEASE")
 : > "$REQ_LOG"
 run_hook "admin" "" "$ENV_REL"
@@ -325,7 +325,7 @@ fi
 T_OTHER=$(mktemp); TMPFILES+=("$T_OTHER")
 write_transcript "$T_OTHER" \
   "user|/end|" \
-  "assistant||tool_use:session-retrospective-mark-complete"
+  "assistant||tool_use:mcp__admin__session-retrospective-mark-complete"
 # Active gate inspects only T_ACTIVE (no sentinel inside).
 T_ACTIVE=$(mktemp); TMPFILES+=("$T_ACTIVE")
 write_transcript "$T_ACTIVE" "user|/end|"

package/payload/platform/plugins/admin/hooks/archive-ingest-surface-gate.sh

@@ -8,7 +8,7 @@
 # blocking the legacy MCP deviation tools mechanically. The retired
 # `whatsapp-export-insight-pass` tool is replaced by Phase 2:
 # `mcp__memory__conversation-archive-derive-insights` — a read-only tool that
-# walks :Section chunks of one named conversation-document :KnowledgeDocument in
+# walks :Section chunks of one named :ConversationArchive in
 # pages and emits per-row proposals. The new tool is NOT in any BLOCK list
 # (the gate is allow-by-default for unrecognised tools) — its writes go
 # through the existing graph-cypher-write surface, gated by the operator per
@@ -154,7 +154,7 @@ fi
 case "$TOOL_NAME" in
   mcp__memory__whatsapp-export-parse|mcp__memory__whatsapp-export-insight-write|mcp__memory__whatsapp-export-insight-pass|mcp__memory__whatsapp-export-preview)
     emit_decision "block" "denied-mcp-legacy" \
-      "Blocked: ${TOOL_NAME} is a retired path. generalised conversation-archive ingest — invoke 'bash platform/plugins/memory/bin/conversation-archive-ingest.sh <archive> --source whatsapp --owner-element-id <id> --participant-person-ids <csv> --scope <admin|public>' once. Normalise, sessionize, classify (mode=chat), and memory-ingest (writes :KnowledgeDocument keyed on conversationIdentity, source=<enum>) all run in-process."
+      "Blocked: ${TOOL_NAME} is a retired path. generalised conversation-archive ingest — invoke 'bash platform/plugins/memory/bin/conversation-archive-ingest.sh <archive> --source whatsapp --owner-element-id <id> --participant-person-ids <csv> --scope <admin|public>' once. Normalise, sessionize, classify (mode=chat), and memory-ingest (writes :ConversationArchive keyed on conversationIdentity, source=<enum>) all run in-process."
     ;;
 esac