@rtorcato/repo-tooling 3.8.3 → 3.8.5

package/dist/cli/commands/setup-presets.js

@@ -212,6 +212,10 @@ export function computeFileList(config) {
     if (config.typescript.enabled) {
         files.push('tsconfig.json', 'reset.d.ts');
     }
+    // Libraries get a bundle-size budget plus the `size-limit` script that runs it
+    // (#382). The scaffold's exports are root-only, so it's always the static form.
+    if (config.projectType === 'library')
+        files.push('.size-limit.json');
     if (config.linting.tool === 'biome' || config.linting.tool === 'both') {
         files.push(BIOME_CONFIG);
     }

package/dist/cli/generators/index.js

@@ -8,7 +8,7 @@ import { ensurePnpmSettings, familyGlob } from './pnpm-workspace.js';
 import { generateGitConfigs } from './git.js';
 import { generateGitHubActions } from './github-actions.js';
 import { generateLintingConfigs } from './linting.js';
-import { generateKnipConfig, generateMiscBaseline, generateVscodeExtensions } from './misc.js';
+import { generateKnipConfig, generateMiscBaseline, generateSizeLimitConfig, generateVscodeExtensions, } from './misc.js';
 import { generatePackageJson } from './package-json.js';
 import { generateReadme } from './readme.js';
 import { generateSecurityConfigs } from './security.js';
@@ -33,6 +33,12 @@ export async function generateConfigs(config, targetDir) {
     await generatePackageJson(config, targetDir);
     // Universal baseline: .editorconfig, .nvmrc, engines.node, knip.json
     await generateMiscBaseline(targetDir);
+    // Bundle-size budget for publishable libraries. getScripts() emits the
+    // matching `size-limit` script, so the budget is runnable from the first
+    // commit rather than an inert file implying enforcement (#382).
+    if (config.projectType === 'library') {
+        await generateSizeLimitConfig(targetDir);
+    }
     // Recommend the editor extensions matching the enabled tools
     await generateVscodeExtensions(config, targetDir);
     // Generate TypeScript configuration

package/dist/cli/generators/package-json.js

@@ -141,6 +141,10 @@ function getScripts(config, opts = {}) {
     // profile fits the dual (cjs+esm) exports the library scaffold emits.
     if (config.projectType === 'library') {
         scripts['attw'] = 'attw --pack';
+        // The budget scaffolded alongside it (generateConfigs) is inert without a
+        // way to run it — a size budget nothing runs implies an enforcement that
+        // isn't there (#382).
+        Object.assign(scripts, SIZE_LIMIT_SCRIPTS);
     }
     // Git hooks
     if (config.gitHooks) {
@@ -169,6 +173,14 @@ function getScripts(config, opts = {}) {
  * refused to compose a chain, both because no target ever created that script
  * (#364).
  */
+/**
+ * The one definition of the `size-limit` script, shared by `getScripts()` (setup)
+ * and the `size-limit` fixer, so the two paths can't drift (#382 — the divergence
+ * behind #371 and #377).
+ */
+export const SIZE_LIMIT_SCRIPTS = { 'size-limit': 'size-limit' };
+/** Shared by the same two paths, for the same reason. */
+export const SIZE_LIMIT_VERSION = '^11.2.0';
 export async function ensureScripts(targetDir, scripts) {
     const pkgPath = path.join(targetDir, 'package.json');
     if (!(await fs.pathExists(pkgPath)))
@@ -352,8 +364,11 @@ function getDependencies(config) {
         deps['lint-staged'] = '^16.0.0';
     }
     // are-the-types-wrong — validate published type resolution for libraries.
+    // size-limit enforces the bundle-size budget scaffolded next to it; without
+    // the dependency the script dies with "command not found" (#382).
     if (config.projectType === 'library') {
         deps['@arethetypeswrong/cli'] = '^0.18.2';
+        deps['size-limit'] = SIZE_LIMIT_VERSION;
     }
     // Commit linting (enforcement) + commitizen (assistance)
     if (config.commitLint) {

package/dist/languages/js/checks.js

@@ -95,7 +95,9 @@ export const FILE_CHECKS = [
         candidates: ['tsconfig.json'],
         expected: `extends "${PACKAGE}/typescript/*"`,
         matcher: /@rtorcato\/(?:js|repo)-tooling\/typescript\//,
-        hint: 'Set `"extends": "@rtorcato/repo-tooling/typescript/base"` in tsconfig.json',
+        // `fix tsconfig`, not `copy tsconfig`: copy drops the whole preset inline,
+        // which carries no `extends` for the matcher above to find (#381).
+        hint: 'Run `npx @rtorcato/repo-tooling fix tsconfig` to scaffold',
     },
     {
         check: 'Biome',

package/dist/languages/js/fixers.js

@@ -11,7 +11,7 @@ import { BIOME_CONFIG, generateBiomeConfig, generateESLintConfig, generatePretti
 import { alignNodeVersion, ensureEnginesNode, ensurePackageManager, generateKnipConfig, generateNvmrc, generateSizeLimitConfig, generateVscodeExtensions, } from '../../cli/generators/misc.js';
 import { scriptsOf } from './ci.js';
 import { usesPnpm } from './checks.js';
-import { composeVerifyScriptFromPkg, ensureScripts } from '../../cli/generators/package-json.js';
+import { SIZE_LIMIT_SCRIPTS, SIZE_LIMIT_VERSION, composeVerifyScriptFromPkg, ensureScripts, } from '../../cli/generators/package-json.js';
 /** Kept in step with the biome branch of getScripts() in package-json.ts. */
 const BIOME_SCRIPTS = {
     lint: 'biome lint .',
@@ -32,6 +32,24 @@ const PRETTIER_SCRIPTS = {
 const KNIP_SCRIPTS = {
     knip: 'knip',
 };
+/**
+ * Add `size-limit` to devDependencies unless the repo already pins it (either
+ * dependency list). Returns true when package.json was written.
+ */
+async function ensureSizeLimitDependency(targetDir) {
+    const pkgPath = path.join(targetDir, 'package.json');
+    if (!(await fs.pathExists(pkgPath)))
+        return false;
+    const pkg = (await fs.readJson(pkgPath));
+    const deps = pkg.dependencies ?? {};
+    const devDeps = { ...(pkg.devDependencies ?? {}) };
+    if (devDeps['size-limit'] || deps['size-limit'])
+        return false;
+    devDeps['size-limit'] = SIZE_LIMIT_VERSION;
+    pkg.devDependencies = devDeps;
+    await fs.writeJson(pkgPath, pkg, { spaces: 2 });
+    return true;
+}
 /** Kept in step with the typescript branch of getScripts() in package-json.ts. */
 const TSCONFIG_SCRIPTS = {
     typecheck: 'tsc --noEmit',
@@ -48,6 +66,7 @@ import { WORKSPACE_FILE, dependsOnEsbuild, ensurePnpmSettings, familyGlob, } fro
 import { generatePostcss } from '../../cli/generators/postcss.js';
 import { generateCypressConfig, generateVitestConfig } from '../../cli/generators/testing.js';
 import { generateTreeshakeCheck, inferSubpathsFromExports } from '../../cli/generators/treeshake.js';
+import { generateTSConfig } from '../../cli/generators/tsconfig.js';
 import { generateTailwind } from '../../cli/generators/tailwind.js';
 import { generateTurborepo } from '../../cli/generators/turborepo.js';
 import { generateNx } from '../../cli/generators/nx.js';
@@ -70,7 +89,12 @@ export function inferProjectConfig(pkg) {
     return {
         projectName: pkg?.name ?? 'project',
         projectType,
-        typescript: { enabled: true, config: projectType === 'nextjs-app' ? 'next' : 'base' },
+        typescript: {
+            enabled: true,
+            // Same mapping the react-app/nextjs-app setup presets use — a react-app on
+            // the base preset has no DOM libs, so `document`/`window` don't typecheck.
+            config: projectType === 'nextjs-app' ? 'next' : projectType === 'react-app' ? 'react' : 'base',
+        },
         linting: {
             tool: 'biome',
             eslintConfig: projectType === 'nextjs-app' ? 'nextjs' : 'base',
@@ -170,9 +194,18 @@ export const FIXERS = [
         appliesTo: ['TypeScript'],
         outputs: ['tsconfig.json', 'package.json (scripts)'],
         canFixDrift: true,
-        async run({ targetDir }) {
-            const result = await copyPreset('tsconfig', targetDir);
-            const filesWritten = [result.target];
+        async run({ targetDir, pkg }) {
+            // Shares generateTSConfig with the setup path — copyPreset used to inline
+            // the whole base preset, which carries no `extends` for doctor's matcher
+            // and threw away the project-type settings setup emits (#381).
+            const config = inferProjectConfig(pkg);
+            // Bun leaves no package.json trace, so inferProjectConfig can't see it; a
+            // bunfig.toml is the signal, and without it this would strip `types: ['bun']`
+            // off a Bun repo by dropping it back onto the base preset.
+            if (await fs.pathExists(path.join(targetDir, 'bunfig.toml')))
+                config.bun = true;
+            await generateTSConfig(config, targetDir);
+            const filesWritten = ['tsconfig.json'];
             // Without `typecheck` the generated CI drops its typecheck job entirely
             // (#377). Shared with non-JS paths, so this is a no-op when there's no
             // package.json to add it to.
@@ -540,13 +573,23 @@ export const FIXERS = [
     },
     {
         target: 'size-limit',
-        description: 'Scaffold a size-limit budget — exports-driven .size-limit.cjs for multi-subpath libraries, else a static .size-limit.json',
+        description: 'Scaffold a size-limit budget — exports-driven .size-limit.cjs for multi-subpath libraries, else a static .size-limit.json — plus the `size-limit` script and devDependency',
         appliesTo: ['size-limit'],
-        outputs: ['.size-limit.cjs', '.size-limit.json'],
+        outputs: ['.size-limit.cjs', '.size-limit.json', 'package.json (devDependencies + scripts)'],
+        // safe-merge: installs the CLI and only fills in a missing script.
+        riskLevel: 'safe-merge',
         canFixDrift: true,
         async run({ targetDir }) {
             const written = await generateSizeLimitConfig(targetDir);
-            return { filesWritten: [written] };
+            const filesWritten = [written];
+            // A budget with nothing to run it is worse than no budget — the file's
+            // presence implies an enforcement that isn't there (#382). The script
+            // needs the CLI installed too, or it dies with "command not found".
+            const installed = await ensureSizeLimitDependency(targetDir);
+            const scripted = await ensureScripts(targetDir, SIZE_LIMIT_SCRIPTS);
+            if (installed || scripted)
+                filesWritten.push('package.json');
+            return { filesWritten };
         },
     },
     {

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@rtorcato/repo-tooling",
-	"version": "3.8.3",
+	"version": "3.8.5",
 	"description": "One CLI to scaffold, audit and fix your repo's whole toolchain — linting, tests, commits, releases & CI.",
 	"type": "module",
 	"keywords": [