@rtcstats/rtcstats-shared 2.6.0 → 2.6.2

package/compression.js

@@ -32,6 +32,11 @@ export function statsCompression(baseStatsInput, newStatsInput, statsIdMap) {
             return;
         }
         Object.keys(report).forEach((name) => {
+            if (name === 'timestamp') {
+                // Deleting it drops the whole report from the delta and the decoder
+                // restores it with the collapsed timestamp. Hits audio remote-*.
+                return;
+            }
             if (report[name] === baseStats[id][name]) {
                 delete delta[id][name];
             } else if (Array.isArray(report[name])) {
@@ -49,7 +54,6 @@ export function statsCompression(baseStatsInput, newStatsInput, statsIdMap) {
                     delete report[name];
                 }
             }
-            // TODO: does this ever happen since we have `timestamp`?
             if (Object.keys(report).length === 0) {
                 delete delta[id];
             }
@@ -145,6 +149,8 @@ export function statsCompression(baseStatsInput, newStatsInput, statsIdMap) {
  */
 export function statsDecompression(baseStatsInput, delta) {
     const baseStats = map2obj(baseStatsInput);
+    // TODO: replace the JSON round-trip and the rename loop below with a hand-rolled
+    // deep copy that decompresses property names while copying, roughly 2x faster.
     const newStats = JSON.parse(JSON.stringify(map2obj(delta)));
 
     // Decompress property names using a static table.
@@ -395,12 +401,17 @@ const methodTable = {
     'MediaStreamTrack.onunmute': 74,
     // HTMLMediaElement
     'HTMLMediaElement.resize': 80,
+    // Decompression-only until the next major version bump, see below.
+    // 'HTMLMediaElement.setSinkId': 81,
+    // 'HTMLMediaElement.setSinkIdOnFailure': 82,
 };
 // Properties that are decompressed but for release purpose not yet compressed.
 // These should be moved to the compression table at major version bumps.
 const methodTableDecompression = {
     1: 'getStats',
     68: 'navigator.mediaDevices.getDisplayMediaOnFailure',
+    81: 'HTMLMediaElement.setSinkId',
+    82: 'HTMLMediaElement.setSinkIdOnFailure',
 };
 const reverseMethodTable = Object.keys(methodTable).reduce((table, method) => {
     table[methodTable[method]] = method;

package/dump.js

@@ -110,6 +110,10 @@ export async function readRTCStatsDump(blob) {
 
         if (method === 'getStats') { // delta-compressed stats
             // statsDecompression does not modify its base stats argument.
+            if (!baseStats[connection_id]) {
+                console.error('stats without baseline');
+                return;
+            }
             value = statsDecompression(baseStats[connection_id], value);
             baseStats[connection_id] = value;
         } else if (method === 'setLocalDescription' && value &&
@@ -201,11 +205,11 @@ export function internalsToRtcstats(data) {
             const tracks = [];
             if (gum.audio_track_info) {
                 const t = JSON.parse(gum.audio_track_info);
-                tracks.push(['audio', t.id, t.label, gum.stream_id]);
+                if (t) tracks.push(['audio', t.id, t.label, gum.stream_id]);
             }
             if (gum.video_track_info) {
                 const t = JSON.parse(gum.video_track_info);
-                tracks.push(['video', t.id, t.label, gum.stream_id]);
+                if (t) tracks.push(['video', t.id, t.label, gum.stream_id]);
             }
             clientTrace.push({type: baseType + 'OnSuccess', value: tracks, timestamp: gum.timestamp, extra: []});
         } else if (gum.audio !== undefined || gum.video !== undefined) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@rtcstats/rtcstats-shared",
-  "version": "2.6.0",
+  "version": "2.6.2",
   "main": "index.js",
   "description": "gather WebRTC API traces and statistics",
   "type": "module",