@rspack/cli 0.3.13 → 0.3.14

package/dist/commands/build.js

@@ -39,14 +39,12 @@ class BuildCommand {
             }
         }), async (options) => {
             const logger = cli.getLogger();
-            // @ts-expect-error
             let createJsonStringifyStream;
             if (options.json) {
                 const jsonExt = await import("@discoveryjs/json-ext");
                 createJsonStringifyStream = jsonExt.default.stringifyStream;
             }
-            // @ts-expect-error
-            const callback = (error, stats) => {
+            const errorHandler = (error, stats) => {
                 if (error) {
                     logger.error(error);
                     process.exit(2);
@@ -61,15 +59,11 @@ class BuildCommand {
                     ? {
                         children: compiler.compilers.map(compiler => compiler.options ? compiler.options.stats : undefined)
                     }
-                    : // @ts-expect-error
-                        compiler.options
-                            ? // @ts-expect-error
-                                compiler.options.stats
-                            : undefined;
-                // @ts-expect-error
+                    : compiler.options
+                        ? compiler.options.stats
+                        : undefined;
                 if (options.json && createJsonStringifyStream) {
-                    // @ts-expect-error
-                    const handleWriteError = error => {
+                    const handleWriteError = (error) => {
                         logger.error(error);
                         process.exit(2);
                     };
@@ -100,10 +94,6 @@ class BuildCommand {
                 }
             };
             const rspackOptions = { ...options, argv: { ...options } };
-            // @ts-expect-error
-            const errorHandler = (err, Stats) => {
-                callback(err, Stats);
-            };
             const compiler = await cli.createCompiler(rspackOptions, "build", errorHandler);
             if (!compiler)
                 return;

package/dist/rspack-cli.d.ts

@@ -7,7 +7,7 @@ export declare class RspackCLI {
     colors: RspackCLIColors;
     program: yargs.Argv;
     constructor();
-    createCompiler(options: RspackBuildCLIOptions, rspackCommand: Command, callback?: (e: Error, res?: Stats | MultiStats) => void): Promise<MultiCompiler & Compiler>;
+    createCompiler(options: RspackBuildCLIOptions, rspackCommand: Command, callback?: (e: Error | null, res?: Stats | MultiStats) => void): Promise<MultiCompiler | Compiler | null>;
     createColors(useColor?: boolean): RspackCLIColors;
     getLogger(): RspackCLILogger;
     run(argv: string[]): Promise<void>;

package/dist/rspack-cli.js

@@ -62,7 +62,6 @@ class RspackCLI {
         const isWatch = Array.isArray(config)
             ? config.some(i => i.watch)
             : config.watch;
-        // @ts-expect-error
         return (0, core_1.rspack)(config, isWatch ? callback : undefined);
     }
     createColors(useColor) {
@@ -90,7 +89,6 @@ class RspackCLI {
         };
     }
     async run(argv) {
-        // @ts-expect-error
         if (semver_1.default.lt(semver_1.default.clean(process.version), "14.0.0")) {
             this.getLogger().warn(`Minimum recommended Node.js version is 14.0.0, current version is ${process.version}`);
         }
@@ -220,10 +218,9 @@ class RspackCLI {
     }
     async loadConfig(options) {
         var _a;
-        let loadedConfig = await (0, loadConfig_1.loadRspackConfig)(options);
+        let loadedConfig = (await (0, loadConfig_1.loadRspackConfig)(options));
         if (options.configName) {
             const notFoundConfigNames = [];
-            // @ts-expect-error
             loadedConfig = options.configName.map((configName) => {
                 let found;
                 if (Array.isArray(loadedConfig)) {
@@ -238,6 +235,8 @@ class RspackCLI {
                 if (!found) {
                     notFoundConfigNames.push(configName);
                 }
+                // WARNING: if config is not found, the program will exit
+                // so assert here is okay to avoid runtime filtering
                 return found;
             });
             if (notFoundConfigNames.length > 0) {
@@ -248,14 +247,12 @@ class RspackCLI {
             }
         }
         if (typeof loadedConfig === "function") {
-            // @ts-expect-error
             loadedConfig = loadedConfig((_a = options.argv) === null || _a === void 0 ? void 0 : _a.env, options.argv);
             // if return promise we should await its result
             if (typeof loadedConfig.then === "function") {
                 loadedConfig = await loadedConfig;
             }
         }
-        // @ts-expect-error
         return loadedConfig;
     }
     isMultipleCompiler(compiler) {

package/dist/utils/loadConfig.d.ts

@@ -1,4 +1,4 @@
 import { RspackCLIOptions } from "../types";
 import { RspackOptions, MultiRspackOptions } from "@rspack/core";
-export type LoadedRspackConfig = undefined | RspackOptions | MultiRspackOptions | ((env: Record<string, any>, argv: Record<string, any>) => RspackOptions | MultiRspackOptions);
+export type LoadedRspackConfig = undefined | RspackOptions | MultiRspackOptions | ((env: Record<string, any>, argv?: Record<string, any>) => RspackOptions | MultiRspackOptions);
 export declare function loadRspackConfig(options: RspackCLIOptions, cwd?: string): Promise<LoadedRspackConfig>;

package/dist/utils/options.d.ts

@@ -75,4 +75,4 @@ export declare const previewOptions: (yargs: yargs.Argv<{}>) => yargs.Argv<yargs
         describe: string;
     };
 }>>;
-export declare function normalizeEnv(argv: any): void;
+export declare function normalizeEnv(argv: yargs.Arguments): void;

package/dist/utils/options.js

@@ -84,15 +84,12 @@ const previewOptions = (yargs) => {
     });
 };
 exports.previewOptions = previewOptions;
-// @ts-expect-error
 function normalizeEnv(argv) {
     var _a;
-    // @ts-expect-error
     function parseValue(previous, value) {
         const [allKeys, val] = value.split(/=(.+)/, 2);
         const splitKeys = allKeys.split(/\.(?!$)/);
         let prevRef = previous;
-        // @ts-expect-error
         splitKeys.forEach((someKey, index) => {
             // https://github.com/webpack/webpack-cli/issues/3284
             if (someKey.endsWith("=")) {

package/dist/utils/profile.js

@@ -131,15 +131,12 @@ class RspackProfileJSCPUProfilePlugin {
     constructor(output) {
         this.output = output;
     }
-    // @ts-expect-error
     apply(compiler) {
         const session = new inspector_1.default.Session();
         session.connect();
         session.post("Profiler.enable");
         session.post("Profiler.start");
-        compiler.hooks.done.tapAsync(RspackProfileJSCPUProfilePlugin.name, 
-        // @ts-expect-error
-        (stats, callback) => {
+        compiler.hooks.done.tapAsync(RspackProfileJSCPUProfilePlugin.name, (_stats, callback) => {
             if (compiler.watchMode)
                 return callback();
             session.post("Profiler.stop", (error, param) => {
@@ -157,11 +154,8 @@ class RspackProfileLoggingPlugin {
     constructor(output) {
         this.output = output;
     }
-    // @ts-expect-error
     apply(compiler) {
-        compiler.hooks.done.tapAsync(RspackProfileLoggingPlugin.name, 
-        // @ts-expect-error
-        (stats, callback) => {
+        compiler.hooks.done.tapAsync(RspackProfileLoggingPlugin.name, (stats, callback) => {
             if (compiler.watchMode)
                 return callback();
             const logging = stats.toJson({

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@rspack/cli",
-  "version": "0.3.13",
+  "version": "0.3.14",
   "license": "MIT",
   "description": "CLI for rspack",
   "bin": {
@@ -37,8 +37,8 @@
     "semver": "6.3.1",
     "webpack-bundle-analyzer": "4.6.1",
     "yargs": "17.6.2",
-    "@rspack/core": "0.3.13",
-    "@rspack/dev-server": "0.3.13"
+    "@rspack/dev-server": "0.3.14",
+    "@rspack/core": "0.3.14"
   },
   "scripts": {
     "build": "rimraf dist/ && tsc -b ./tsconfig.build.json --force",