@rse/ase 0.9.7 → 0.9.9

package/plugin/skills/ase-code-craft/SKILL.md

@@ -2,8 +2,8 @@
 name: ase-code-craft
 argument-hint: "[--help|-h] [--auto|-a] [--dry|-d] [--quick|-Q] [--next|-n <option>[,...]] [<task-id>:] <feature>"
 description: >
-    Craft Source Code:
-    Use when user wants to create or craft a new feature from scratch.
+    Craft Source:
+    Use when user wants to "create", "add", or "craft" a new feature from scratch.
 user-invocable: true
 disable-model-invocation: false
 effort: xhigh
@@ -53,7 +53,9 @@ You *MUST* *NOT* call `Edit`, `Write`, `NotebookEdit`, or any
 filesystem-modifying tool during this entire skill. The *only*
 permitted way to persist artifacts is via `ase_task_save(...)`.
 
-1.  **Reason About Feature**:
+<flow>
+
+1.  <step id="STEP 1: Reason About Feature">
 
     1.  <if condition="
             <feature/> matches the regexp `^[a-zA-Z][a-zA-Z0-9_-]*$`
@@ -69,20 +71,25 @@ permitted way to persist artifacts is via `ase_task_save(...)`.
         </template>
         </if>
 
-    2.  If <feature/> has the format `<id/>: <text/>` where <id/> matches
-        the regexp `^[a-zA-Z][a-zA-Z0-9_-]*$`, then set
-        <feature><text/></feature> and <ase-task-id><id/></ase-task-id>
-        and call the `ase_task_id(id: "<ase-task-id/>", session:
-        "<ase-session-id/>")` tool from the `ase` MCP server to
-        implicitly switch the task. Do not output anything.
+    2.  <if condition="
+            <feature/> has the format `<id/>: <text/>` AND
+            <id/> matches the regexp `^[a-zA-Z][a-zA-Z0-9_-]*$`
+        ">
+        Set <feature><text/></feature> and
+        <ase-task-id><id/></ase-task-id> and call the `ase_task_id(id:
+        "<ase-task-id/>", session: "<ase-session-id/>")` tool from the
+        `ase` MCP server to implicitly switch the task. Do not output
+        anything.
+        </if>
 
-    3.  If <feature/> is empty,
-        ask the user interactively, without a special tool, for the
+    3.  <if condition="<feature/> is empty">
+        Ask the user interactively, without a special tool, for the
         initial feature with a single question:
 
         `**No feature known yet. What is the feature you want to craft?**`
 
         Then set <feature/> to the response of the user.
+        </if>
 
     4.  <if condition="
             <ase-task-id/> is equal `default` and
@@ -109,7 +116,9 @@ permitted way to persist artifacts is via `ase_task_save(...)`.
 
     8.  Do not output anything in this step, unless you asked the user.
 
-2.  **Investigate Code Base**:
+    </step>
+
+2.  <step id="STEP 2: Investigate Code Base">
 
     1.  Check the existing source files for all code which is related to the
         requested new <feature/>.
@@ -117,9 +126,11 @@ permitted way to persist artifacts is via `ase_task_save(...)`.
     2.  Check the architecture of the existing code base to understand the
         overall structures and dynamics.
 
-    3.  Do not output anything in this step.
+    3.  Do not output anything in this STEP 2.
 
-3.  **Internalize Crafting Tenets**:
+    </step>
+
+3.  <step id="STEP 3: Internalize Crafting Tenets">
 
     You *MUST* internalize and honor the following tenets when crafting the new feature.
     Do not output anything.
@@ -174,7 +185,9 @@ permitted way to persist artifacts is via `ase_task_save(...)`.
             Honor the non-functional requirements Performance, Security,
             Scalability, Comprehensibility.
 
-4.  **Find Feature Crafting Approaches**:
+    </step>
+
+4.  <step id="STEP 4: Choose Feature Crafting Approaches">
 
     You *MUST* perform the following sub-steps *internally* and *without
     any output* until and including the recommendation decision. Only
@@ -203,16 +216,14 @@ permitted way to persist artifacts is via `ase_task_save(...)`.
         </template>
 
     5.  Now report each approach with the following <template/>,
-        inlining its pros/cons derived in sub-step 2:
+        inlining its pros/cons derived in sub-step 2, and do not output
+        anything else in this step:
 
         <template>
         ●   **APPROACH A<n/>**<annotation/>: *<summary/>*
         ○   [...]
-        ○   [...]
-        ○   [...]
-        ⊕   *PRO*: [...]
-        ⊖   *CON*: [...]
-        <optional-diagram/>
+        ⊕   **PRO**: [...]
+        ⊖   **CON**: [...]
         </template>
 
         Hints:
@@ -220,23 +231,7 @@ permitted way to persist artifacts is via `ase_task_save(...)`.
         -   Give a short one-sentence <summary/> of the feature
             approach plus *precise* and *ultra brief and concise*
             feature information. Try to keep the number of bullet points
-            (●) in the range of 1-4.
-
-        -   In case of a *complex feature situation* only, visualize
-            it with an optional diagram <optional-diagram/> by building
-            a Mermaid specification <mermaid-spec/> (e.g. `flowchart
-            TB`, `stateDiagram-v2`, `sequenceDiagram`, `classDiagram`,
-            or `erDiagram`, depending on intent) and dispatching the
-            rendering to the `ase-meta-diagram` sub-agent by calling
-            the tool `Agent(name: "ase-meta-diagram", description:
-            "Diagram Rendering", subagent_type: "ase:ase-meta-diagram",
-            prompt: <mermaid-spec/>)`, reproducing its returned fenced
-            code block verbatim. For *current vs. proposed* comparisons,
-            render each side as a *separate* `ase-meta-diagram`
-            invocation and stack the rendered blocks *vertically*
-            (labels `**Before:**` / `**After:**`); never side-by-side.
-            Omit <optional-diagram/> entirely for simple or purely local
-            situations.
+            (`○ [...]`) in the range of 1-4.
 
     6.  Indicate end of reporting by showing the following <template/>:
 
@@ -244,18 +239,28 @@ permitted way to persist artifacts is via `ase_task_save(...)`.
         <ase-tpl-foot title="APPROACHES"/>
         </template>
 
-5.  **Choose Feature Crafting Approach**:
+    7.  <if condition="<getopt-option-auto/> is not equal `true`">
+
+        You *MUST* use the custom `custom-dialog` and *NOT* the
+        `AskUserQuestion`-based `user-dialog` to let the *user
+        interactively choose* the preferred approach A<n/>.
 
-    1.  If <getopt-option-auto/> is equal `false`:
-        Let the *user interactively choose* the preferred feature
-        approach A<n/> with the help of the <user-dialog-tool/> tool.
-        Use the header `Select Approach`, use `A<n/>: <short-summary/>`
-        for the option (where <short-summary/> is an ultra brief summary
-        of the approach A<n/>), and *single-selection* only and provide
-        small *code change previews*. Mark your recommended feature
-        approach with ` ⚝ **RECOMMENDATION** ⚝` here again.
+        Per approach A<n/>, use the option `A<n/>: <short-summary/>`
+        where <short-summary/> is an ultra brief summary of the approach
+        A<n/>. For your recommended approach, use
+        `A<n/>: ⚝ **RECOMMENDATION** ⚝: <short-summary/>` instead.
+
+        Now raise the user dialog:
+
+        <expand name="custom-dialog">
+            Select Approach: Select your preferred crafting approach to follow?
+            A<n/>: <short-summary/>
+            [...]
+        </expand>
+
+        </if>
+        <else>
 
-    2.  If <getopt-option-auto/> is equal `true`:
         Set <n/> to the number of the feature approach A<n/> you recommend.
         Output a hint with the following <template/>:
 
@@ -263,7 +268,11 @@ permitted way to persist artifacts is via `ase_task_save(...)`.
         ⧉ **ASE**: ◉ task: **<ase-task-id/>**, ▶ status: **auto-chosen approach A<n/>**
         </template>
 
-6.  **Compose Feature Crafting Plan**:
+        </else>
+
+    </step>
+
+5.  <step id="STEP 5: Compose Feature Crafting Plan">
 
     1.  *Compose a feature plan* for the chosen feature A<n/> by
         closely aligning to the existing architecture and the existing
@@ -293,7 +302,7 @@ permitted way to persist artifacts is via `ase_task_save(...)`.
         <timestamp-modified/> information and calculate the number of
         words <words/> of <content/>.
 
-    3.  You *MUST* *save* the resulting plan content with the
+    3.  You then *MUST* *save* the resulting plan content with the
         `ase_task_save(id: "<ase-task-id/>", text: "<content/>")`.
 
     4.  Output a hint with the following <template/>:
@@ -307,40 +316,43 @@ permitted way to persist artifacts is via `ase_task_save(...)`.
         Treat <getopt-option-next/> as a comma-separated chronological
         list of pre-selected next-step tokens. *Peek* the *first* token
         as <head/> (or `none` if the list is `none`/empty).
+        Set <args>--int-reuse-task</args>.
 
         1.  <if condition="<head/> is equal `IMPLEMENT`">
             Consume the head: set <getopt-option-next/> to the remaining
-            tokens (joined back with `,`, or `none` if empty). Set
-            <args></args> (empty).
+            tokens (joined back with `,`, or `none` if empty).
             <if condition="<getopt-option-next/> is not equal `none`">
-            Set <args>--next <getopt-option-next/></args> (forward
-            remaining list tokens to the downstream skill).
+                Set <args><args/> --next <getopt-option-next/></args>
             </if>
-            Call the tool `Skill(skill: "ase:ase-task-implement", args: <args/>)`
+            Call the tool `Skill(skill: "ase:ase-task-implement", args: "<args/>")`
             to *implement* the freshly composed plan, bypassing `ase-task-edit`.
             </if>
 
-        2.  <if condition="<head/> is equal `PREFLIGHT`">
+        2.  <elseif condition="<head/> is equal `PREFLIGHT`">
             Consume the head: set <getopt-option-next/> to the remaining
-            tokens (joined back with `,`, or `none` if empty). Set
-            <args></args> (empty).
+            tokens (joined back with `,`, or `none` if empty).
             <if condition="<getopt-option-next/> is not equal `none`">
-            Set <args>--next <getopt-option-next/></args> (forward
-            remaining list tokens to the downstream skill).
+                Set <args><args/> --next <getopt-option-next/></args>
             </if>
-            Call the tool `Skill(skill: "ase:ase-task-preflight", args: <args/>)`
+            Call the tool `Skill(skill: "ase:ase-task-preflight", args: "<args/>")`
             to *preflight* the freshly composed plan, bypassing `ase-task-edit`.
-            </if>
+            </elseif>
 
-        3.  <if condition="
-                <head/> is not equal `IMPLEMENT` AND
-                <head/> is not equal `PREFLIGHT`
-            ">
-            Forward the *entire* (unshifted) list to `ase-task-edit`, which
-            will consume its head itself. Set <args></args> (empty).
-            <if condition="<getopt-option-next/> is not equal `none`">
-            Set <args>--next <getopt-option-next/></args> (append to args).
+        3.  <else>
+            Hand off to `ase-task-edit`.
+            <if condition="<head/> is equal `EDIT`">
+                Consume the head: set <getopt-option-next/> to the remaining
+                tokens (joined back with `,`, or `none` if empty).
             </if>
-            Then call the tool `Skill(skill: "ase:ase-task-edit", args: <args/>)`.
+            All remaining tokens are `ase-task-edit`'s own vocabulary
+            and are forwarded verbatim, so `ase-task-edit` consumes its
+            head itself.
+            <if condition="<getopt-option-next/> is not equal `none`">
+                Set <args><args/> --next <getopt-option-next/></args>
             </if>
+            Then call the tool `Skill(skill: "ase:ase-task-edit", args: "<args/>")`.
+            </else>
+
+    <step>
 
+</flow>

package/plugin/skills/ase-code-craft/help.md

@@ -86,5 +86,5 @@ Craft a feature under a named task and directly hand off to implementation:
 
 ##  SEE ALSO
 
-`ase-code-refactor`, `ase-code-resolve`, `ase-task-edit`,
-`ase-task-preflight`, `ase-task-implement`.
+[`ase-code-refactor`](../ase-code-refactor/help.md), [`ase-code-resolve`](../ase-code-resolve/help.md), [`ase-task-edit`](../ase-task-edit/help.md),
+[`ase-task-preflight`](../ase-task-preflight/help.md), [`ase-task-implement`](../ase-task-implement/help.md).

package/plugin/skills/ase-code-explain/SKILL.md

@@ -71,7 +71,7 @@ code and *explain* it in a *brief*, *standardized*, and *concise* way.
     `sequenceDiagram` for actor/message flow, or `flowchart TB` for
     boxes-and-lines component layouts. Then dispatch the rendering to
     the `ase-meta-diagram` sub-agent by calling the tool `Agent(name:
-    "ase:ase-meta-diagram", description: "Diagram Rendering", subagent_type:
+    "ase-meta-diagram", description: "Diagram Rendering", subagent_type:
     "ase:ase-meta-diagram", prompt: <mermaid-spec/>)` and reproduce its
     returned fenced code block verbatim in the response text. Do *not*
     hand-draw.

package/plugin/skills/ase-code-explain/help.md

@@ -40,4 +40,4 @@ Explain a specific function:
 
 ##  SEE ALSO
 
-`ase-code-insight`, `ase-code-analyze`, `ase-arch-analyze`.
+[`ase-code-insight`](../ase-code-insight/help.md), [`ase-code-analyze`](../ase-code-analyze/help.md), [`ase-arch-analyze`](../ase-arch-analyze/help.md).

package/plugin/skills/ase-code-insight/SKILL.md

@@ -70,7 +70,7 @@ Give *insights* into the project through the source code of $ARGUMENTS.
     Then run the following command...
 
     ```
-    git log --format=format: --name-only --since="1 year ago" | sort | uniq -c | sort -nr | head -10
+    git log --format=format: --name-only --since="1 year ago" | grep -v '^$' | sort | uniq -c | sort -nr | head -10
     ```
 
     ...and then display its result as a table with a table head and

package/plugin/skills/ase-code-insight/help.md

@@ -40,4 +40,4 @@ Get insights into a specific subsystem:
 
 ##  SEE ALSO
 
-`ase-code-explain`, `ase-code-analyze`, `ase-arch-analyze`.
+[`ase-code-explain`](../ase-code-explain/help.md), [`ase-code-analyze`](../ase-code-analyze/help.md), [`ase-arch-analyze`](../ase-arch-analyze/help.md).

package/plugin/skills/ase-code-lint/SKILL.md

@@ -100,10 +100,12 @@ related to a set of code quality aspects.
 
 3.  <step id="STEP 3: Correction">
 
-    1.  You *MUST* call the MCP tool `ase_config_set(key: "agent.skill", val:
-        "ase-docs-proofread", scope: "session:<ase-session-id/>")` of the
-        `ase` MCP server. You *MUST* *NOT* output anything related to
-        this.
+    1.  *Mark this skill as the active edit-capable skill* so that the
+        ASE `pre-tool-use` hook auto-approves the subsequent `Edit`
+        invocations on *any* invocation path (slash command *or* `Skill`
+        tool). Call the `ase_config_set(key: "agent.skill", val:
+        "ase-code-lint", scope: "session:<ase-session-id/>")` tool
+        from the `ase` MCP server. Do not output anything in this substep.
 
     2.  Iterate over all problems:
 
@@ -150,7 +152,7 @@ related to a set of code quality aspects.
                 3.  Append the following <template/> to <diff-file/>:
 
                     <template>
-                    @@ -<line/>,<n/> +<line/>,<m/> @@
+                    @@ -<old-start/>,<n/> +<new-start/>,<m/> @@
                      <context-before/>
                     -<old-text/>
                     +<new-text/>
@@ -158,8 +160,16 @@ related to a set of code quality aspects.
                     </template>
 
                     Hints:
-                    -   The <n/> is the number of lines in <old-text/>.
-                    -   The <m/> is the number of lines in <new-text/>.
+                    -   The <old-start/> is the line of the first hunk line, i.e.,
+                        the line of <context-before/> (one before <line/>).
+                    -   The <new-start/> is the same as <old-start/> (the unchanged
+                        <context-before/> line shares the same start in both files).
+                    -   The <n/> is the total number of old-side hunk lines, i.e.,
+                        the number of lines in <context-before/>, <old-text/>, and
+                        <context-after/> combined.
+                    -   The <m/> is the total number of new-side hunk lines, i.e.,
+                        the number of lines in <context-before/>, <new-text/>, and
+                        <context-after/> combined.
 
                 </for>
 
@@ -190,7 +200,7 @@ related to a set of code quality aspects.
             </template>
 
             </if>
-            <if condition="<getopt-option-auto/> is 'true'">
+            <else>
 
             Report the solution with the following <template/>:
 
@@ -201,13 +211,15 @@ related to a set of code quality aspects.
 
             </template>
 
-            </if>
+            </else>
 
         6.  <if condition="<getopt-option-auto/> is not 'true'">
 
-            Ask the user how to proceed via an interactive user dialog:
+            Let the *user interactively choose* what to do as the next
+            step. For this you *MUST* use the custom `custom-dialog` and
+            not the `AskUserQuestion` based `user-dialog`:
 
-            <expand name="user-dialog">
+            <expand name="custom-dialog">
                 CORRECTION: How would you like to proceed with this proposed correction?
                 ACCEPT: Apply the proposed correction.
                 REJECT: Skip this proposed correction.
@@ -215,19 +227,22 @@ related to a set of code quality aspects.
 
             </if>
 
-            <if condition="<getopt-option-auto/> is 'true'">
+            <else>
 
             Set <result>ACCEPT</result>.
             You *MUST* *NOT* output anything else in this step 6.
 
-            </if>
+            </else>
 
         7.  Check <result/> and dispatch accordingly:
 
             -   <if condition="<result/> is 'ACCEPT'">
                 Invoke the `Edit` tool to apply the changes exactly
-                as shown in the <diff/>. After applying the changes,
-                just continue with the next <item/>.
+                as shown in the <diff/>. The operation will be
+                auto-approved by the ASE `pre-tool-use` hook (which
+                tracks the active skill), so *no* interactive permission
+                prompt will appear. After applying the changes, just
+                continue with the next <item/>.
                 </if>
 
             -   <if condition="<result/> starts with 'OTHER'">
@@ -249,9 +264,11 @@ related to a set of code quality aspects.
 
         </for>
 
-    3.  You *MUST* call the MCP tool `ase_config_delete(key: "agent.skill",
-        scope: "session:<ase-session-id/>")` of the `ase` MCP server.
-        You *MUST* *NOT* output anything related to this.
+    3.  *Clear the active edit-capable skill marker* now that all `Edit`
+        invocations are done, so a later unrelated `Edit` is *not*
+        auto-approved. Call the `ase_config_delete(key: "agent.skill",
+        scope: "session:<ase-session-id/>")` tool from the `ase` MCP
+        server. Do not output anything in this substep.
 
     4.  You *MUST* *NOT* output any further additional explanations or
         summaries at the end of this skill processing, except for the

package/plugin/skills/ase-code-lint/help.md

@@ -63,5 +63,5 @@ Lint a directory, reporting only `MEDIUM` and `HIGH` findings:
 
 ##  SEE ALSO
 
-`ase-code-analyze`, `ase-code-resolve`, `ase-code-refactor`,
-`ase-docs-proofread`.
+[`ase-code-analyze`](../ase-code-analyze/help.md), [`ase-code-resolve`](../ase-code-resolve/help.md), [`ase-code-refactor`](../ase-code-refactor/help.md),
+[`ase-docs-proofread`](../ase-docs-proofread/help.md).