@rsdk/eslint-plugin 6.0.0-next.39 → 6.0.0-next.40

package/eslint.config.cjs

@@ -0,0 +1,3 @@
+const rsdkEslint = require('@rsdk/eslint-plugin');
+
+module.exports = rsdkEslint.createConfig({ tsconfigRootDir: __dirname });

package/index.js

@@ -1,188 +1,282 @@
-module.exports = {
-  configs: {
-    recommended: {
-      parser: '@typescript-eslint/parser',
-      parserOptions: {
-        // Не стоит писать сюда project: 'tsconfig.json`, это ломает работу eslint
-        // В ряде случаев он просто отрабатывает не так как надо, а в некоторых просто падает
-        project: true,
-        sourceType: 'module',
+const js = require('@eslint/js');
+const path = require('node:path');
+const prettierConfig = require('eslint-config-prettier/flat');
+const importX = require('eslint-plugin-import-x');
+const simpleImportSort = require('eslint-plugin-simple-import-sort');
+const globals = require('globals');
+const tseslint = require('typescript-eslint');
+
+const monorepoRoot = path.resolve(__dirname, '../..');
+const noopRule = {
+  create: () => ({}),
+  meta: {
+    docs: {},
+    schema: [],
+    type: 'problem',
+  },
+};
+
+tseslint.plugin.rules['ban-types'] ??= noopRule;
+
+let pluginLoader;
+
+async function loadPlugins() {
+  pluginLoader ??= Promise.all([
+    import('@stylistic/eslint-plugin'),
+    import('eslint-plugin-unicorn'),
+  ]).then(([stylisticModule, unicornModule]) => {
+    const stylistic = stylisticModule.default ?? stylisticModule;
+    const unicorn = unicornModule.default ?? unicornModule;
+
+    unicorn.rules['no-array-for-each'] ??= noopRule;
+    unicorn.rules['no-unsafe-regex'] ??= noopRule;
+
+    return { stylistic, unicorn };
+  });
+
+  return pluginLoader;
+}
+
+const sourceFiles = ['**/*.{js,jsx,cjs,mjs,ts,tsx,cts,mts}'];
+const tsFiles = ['**/*.{ts,tsx,cts,mts}'];
+const importExtensions = [
+  '.ts',
+  '.cts',
+  '.mts',
+  '.tsx',
+  '.js',
+  '.jsx',
+  '.mjs',
+  '.cjs',
+];
+
+const simpleImportSortGroups = [
+  // Node.js builtins.
+  [
+    '^(assert|buffer|child_process|cluster|console|constants|crypto|dgram|dns|domain|events|fs|http|https|module|net|os|path|punycode|querystring|readline|repl|stream|string_decoder|sys|timers|tls|tty|url|util|vm|zlib|freelist|v8|process|async_hooks|http2|perf_hooks)(/.*|$)',
+  ],
+
+  // Packages. `react` related packages come first.
+  ['^react', String.raw`^@?\w`],
+
+  // Internal packages.
+  ['^(@|@company|@ui|components|utils|config|vendored-lib)(/.*|$)'],
+
+  // Side effect imports.
+  [String.raw`^\u0000`],
+
+  // Parent imports. Put `..` last.
+  [String.raw`^\.\.(?!/?$)`, String.raw`^\.\./?$`],
+
+  // Other relative imports. Put same-folder imports and `.` last.
+  [String.raw`^\./(?=.*/)(?!/?$)`, String.raw`^\.(?!/?$)`, String.raw`^\./?$`],
+
+  // Style imports.
+  [String.raw`^.+\.s?css$`],
+];
+
+async function createConfig(options = {}) {
+  const { stylistic, unicorn } = await loadPlugins();
+  const project =
+    options.project === false
+      ? false
+      : (options.project ?? path.join(monorepoRoot, 'tsconfig.lint.json'));
+  const tsconfigRootDir = options.tsconfigRootDir ?? process.cwd();
+  const shouldUsePrettierConfig = options.prettier !== false;
+
+  return tseslint.config(
+    {
+      ignores: [
+        'dist/**',
+        'node_modules/**',
+        '__tests__/fixtures/**',
+        '**/__tests__/fixtures/**',
+        '**/fixtures/**',
+        '.generated/**',
+        'generated/**',
+        'vendor/**',
+      ],
+    },
+    {
+      linterOptions: {
+        reportUnusedDisableDirectives: 'off',
+      },
+    },
+    js.configs.recommended,
+    ...tseslint.configs.recommended,
+    ...(shouldUsePrettierConfig ? [prettierConfig] : []),
+    {
+      files: sourceFiles,
+      languageOptions: {
         ecmaVersion: 2020,
+        globals: {
+          ...globals.node,
+          ...globals.jest,
+        },
+        sourceType: 'module',
       },
-      plugins: [
-        '@typescript-eslint/eslint-plugin',
-        'simple-import-sort',
-        'import',
-        'unicorn',
-        '@stylistic/eslint-plugin',
-        'deprecation',
-      ],
-      extends: [
-        'plugin:@typescript-eslint/eslint-recommended',
-
-        // FIXME: не уверен что его стоит добавлять, но посмотреть в целом стоит
-        // 'plugin:@typescript-eslint/recommended-requiring-type-checking',
-        'plugin:@typescript-eslint/recommended',
-        'plugin:import/typescript',
-        'plugin:prettier/recommended',
-        'plugin:unicorn/all',
-      ],
-      root: true,
-      env: {
-        node: true,
-        jest: true,
+      plugins: {
+        '@stylistic': stylistic,
+        deprecation: {
+          rules: {
+            deprecation: noopRule,
+          },
+        },
+        import: importX,
+        prettier: {
+          rules: {
+            prettier: noopRule,
+          },
+        },
+        'simple-import-sort': simpleImportSort,
+        unicorn,
+      },
+      settings: {
+        'import-x/extensions': importExtensions,
+        'import-x/external-module-folders': [
+          'node_modules',
+          'node_modules/@types',
+        ],
+        'import-x/parsers': {
+          '@typescript-eslint/parser': ['.ts', '.cts', '.mts', '.tsx'],
+        },
+        'import-x/resolver': {
+          node: {
+            extensions: importExtensions,
+          },
+        },
       },
       rules: {
-        'deprecation/deprecation': 'warn',
-        '@typescript-eslint/interface-name-prefix': 'off',
-        '@typescript-eslint/explicit-module-boundary-types': 'off',
-        '@typescript-eslint/no-explicit-any': 'off',
-        '@typescript-eslint/explicit-function-return-type': 'error',
-        'import/no-extraneous-dependencies': [
+        '@stylistic/lines-around-comment': [
           'error',
           {
-            devDependencies: [
-              '**/*.test.ts',
-              '**/*.spec.ts',
-              '**/*.test.e2e.ts',
-              '**/*.spec.e2e.ts',
-              '**/*.e2e*.ts',
-              '**/*e2e.ts',
-              'jest.*.ts',
-              'jest.*.js',
-              '**/jest.*.ts',
-              '**/jest.*.js',
-            ],
+            allowArrayStart: true,
+            allowBlockStart: true,
+            allowClassStart: true,
+            allowEnumStart: true,
+            allowInterfaceStart: true,
+            allowModuleStart: true,
+            allowObjectStart: true,
+            allowTypeStart: true,
+            beforeBlockComment: true,
+            beforeLineComment: true,
           },
         ],
-        '@typescript-eslint/consistent-type-imports': 'error',
-        '@typescript-eslint/member-ordering': 'warn',
-        '@typescript-eslint/lines-between-class-members': [
+        'lines-around-comment': 'off',
+        '@stylistic/lines-between-class-members': [
           'warn',
           'always',
           {
-            exceptAfterSingleLine: true,
             exceptAfterOverload: true,
+            exceptAfterSingleLine: true,
           },
         ],
-        '@typescript-eslint/padding-line-between-statements': [
+        '@stylistic/padding-line-between-statements': [
           'warn',
-          { blankLine: 'always', prev: ['const', 'let', 'var'], next: '*' },
+          { blankLine: 'always', next: '*', prev: ['const', 'let', 'var'] },
           {
             blankLine: 'any',
-            prev: ['const', 'let', 'var'],
             next: ['const', 'let', 'var', 'if'],
+            prev: ['const', 'let', 'var'],
           },
         ],
-        '@stylistic/lines-around-comment': [
-          'error',
-          {
-            beforeBlockComment: true,
-            beforeLineComment: true,
-            allowBlockStart: true,
-            allowObjectStart: true,
-            allowArrayStart: true,
-            allowClassStart: true,
-            allowEnumStart: true,
-            allowInterfaceStart: true,
-            allowModuleStart: true,
-            allowTypeStart: true,
-          }
-        ],
-        'import/no-cycle': 'error',
         'import/first': 'error',
         'import/newline-after-import': 'error',
+        'import/no-cycle': 'error',
         'import/no-duplicates': 'error',
-        'sort-imports': 'off',
+        'no-negated-condition': 'off',
+        'no-nested-ternary': 'off',
+        'require-yield': 'off',
         'simple-import-sort/imports': [
           'error',
           {
-            groups: [
-              // Node.js builtins. You could also generate this regex if you use a `.js` config.
-              // For example: `^(${require("module").builtinModules.join("|")})(/|$)`
-              [
-                '^(assert|buffer|child_process|cluster|console|constants|crypto|dgram|dns|domain|events|fs|http|https|module|net|os|path|punycode|querystring|readline|repl|stream|string_decoder|sys|timers|tls|tty|url|util|vm|zlib|freelist|v8|process|async_hooks|http2|perf_hooks)(/.*|$)',
-              ],
-
-              // Packages. `react` related packages come first.
-              ['^react', '^@?\\w'],
-
-              // Internal packages.
-              ['^(@|@company|@ui|components|utils|config|vendored-lib)(/.*|$)'],
-
-              // Side effect imports.
-              ['^\\u0000'],
-
-              // Parent imports. Put `..` last.
-              ['^\\.\\.(?!/?$)', '^\\.\\./?$'],
-
-              // Other relative imports. Put same-folder imports and `.` last.
-              ['^\\./(?=.*/)(?!/?$)', '^\\.(?!/?$)', '^\\./?$'],
-
-              // Style imports.
-              ['^.+\\.s?css$'],
-            ],
-          },
-        ],
-        '@typescript-eslint/naming-convention': [
-          'error',
-          {
-            selector: ['classMethod', 'accessor', 'parameterProperty'],
-            format: ['camelCase'],
+            groups: simpleImportSortGroups,
           },
         ],
-
-        // unicorn
+        'sort-imports': 'off',
+        'unicorn/better-regex': 'off',
         'unicorn/custom-error-definition': 'off',
-
-        // Очень странная мотивация у этого правила, у меня может быть метод который подсчитывает количество товаров в заказе и собственно массив заказов
+        'unicorn/filename-case': 'off',
+        'unicorn/name-replacements': 'off',
         'unicorn/no-array-callback-reference': 'off',
-
-        // просто спорное правило
+        'unicorn/no-array-method-this-argument': 'off',
         'unicorn/no-array-reduce': 'off',
         'unicorn/no-keyword-prefix': 'off',
-        'no-negated-condition': 'off',
-        'no-nested-ternary': 'off',
-
-        // глупость, так как null хотя бы является валидным сериализуемым значением
         'unicorn/no-null': 'off',
-
-        // Как правило, удобнее сгруппировать методы в namespace
         'unicorn/no-static-only-class': 'off',
-
-        // дублирует правило @typescript-eslint/no-this-alias
         'unicorn/no-this-assignment': 'off',
-
-        // портит regex например /\/?([\w\-_]+:[\w\-_]+)$/gi.exec(tag)?.[1]
-        'unicorn/better-regex': 'off',
         'unicorn/no-unused-properties': 'off',
-        '@typescript-eslint/no-unused-vars': [
-          'error',
-          { varsIgnorePattern: '^_', argsIgnorePattern: '^_' },
-        ],
-
-        // Пытался как-то консистентно эту историю организовать, но это около невозможно потому что порты например нет смысла делить
         'unicorn/numeric-separators-style': 'off',
         'unicorn/prefer-json-parse-buffer': 'error',
-
-        // пока мы не переехали на esm смысла нет
         'unicorn/prefer-module': 'off',
-
-        // мешает делать typeguard `(var: MyInterface | undefined): var is MyInterface => Boolean(var)`
         'unicorn/prefer-native-coercion-functions': 'off',
-
-        // иногда проще делать Array.from, а там где `spread` лучше, там и так понятно
         'unicorn/prefer-spread': 'off',
-
-        // не нашёл гибкой конфигурации чтобы он не ругался на `param` например
         'unicorn/prevent-abbreviations': 'off',
-
-        // мешает делать case: return some(a, b, c)
         'unicorn/switch-case-braces': ['error', 'avoid'],
-
-        // некорректный парсинг, ругается на любой вызов метода find
-        'unicorn/no-array-method-this-argument': 'off',
       },
     },
+    {
+      files: tsFiles,
+      languageOptions: {
+        parserOptions: {
+          ...(project === false ? {} : { project }),
+          tsconfigRootDir,
+        },
+      },
+      rules: {
+        '@typescript-eslint/consistent-type-imports': 'error',
+        '@typescript-eslint/explicit-function-return-type': 'error',
+        '@typescript-eslint/explicit-module-boundary-types': 'off',
+        '@typescript-eslint/member-ordering': 'warn',
+        '@typescript-eslint/naming-convention': [
+          'error',
+          {
+            format: ['camelCase'],
+            selector: ['classMethod', 'accessor', 'parameterProperty'],
+          },
+        ],
+        '@typescript-eslint/no-empty-object-type': 'off',
+        '@typescript-eslint/no-explicit-any': 'off',
+        '@typescript-eslint/no-require-imports': 'off',
+        '@typescript-eslint/no-unsafe-function-type': 'off',
+        '@typescript-eslint/no-unused-expressions': [
+          'error',
+          {
+            allowShortCircuit: true,
+            allowTaggedTemplates: true,
+            allowTernary: true,
+          },
+        ],
+        '@typescript-eslint/no-unused-vars': [
+          'error',
+          { argsIgnorePattern: '^_', varsIgnorePattern: '^_' },
+        ],
+      },
+    },
+    {
+      files: ['**/*.{js,jsx,cjs,mjs}'],
+      rules: {
+        '@typescript-eslint/no-require-imports': 'off',
+      },
+    },
+    {
+      files: [
+        '**/src/bin/*.{ts,tsx,cts,mts}',
+        '**/src/bin/**/*.{ts,tsx,cts,mts}',
+      ],
+      rules: {
+        '@stylistic/lines-around-comment': 'off',
+        'lines-around-comment': 'off',
+      },
+    },
+  );
+}
+
+module.exports = {
+  configs: {
+    get recommended() {
+      return createConfig();
+    },
   },
+  createConfig,
 };

package/lint-workspaces.js

@@ -0,0 +1,81 @@
+const { spawnSync } = require('node:child_process');
+const fs = require('node:fs');
+const path = require('node:path');
+
+const root = path.resolve(__dirname, '../..');
+const eslintBin = path.join(root, 'node_modules/.bin/eslint');
+const passThroughArgs = process.argv.slice(2);
+const sourceRoots = ['examples', 'packages', 'test'];
+const ignoredSegments = new Set([
+  '.generated',
+  'dist',
+  '__fixtures__',
+  'fixtures',
+  'generated',
+  'node_modules',
+  'vendor',
+]);
+const lintExtensions = new Set(['.ts', '.cts', '.mts', '.tsx']);
+const chunkSize = 200;
+
+function shouldSkipDirectory(name) {
+  return ignoredSegments.has(name);
+}
+
+function collectSourceFiles(directory, files) {
+  let entries;
+
+  try {
+    entries = fs.readdirSync(directory, { withFileTypes: true });
+  } catch {
+    return;
+  }
+
+  for (const entry of entries) {
+    const absolutePath = path.join(directory, entry.name);
+
+    if (entry.isDirectory()) {
+      if (!shouldSkipDirectory(entry.name)) {
+        collectSourceFiles(absolutePath, files);
+      }
+
+      continue;
+    }
+
+    if (!entry.isFile()) continue;
+    if (!absolutePath.split(path.sep).includes('src')) continue;
+    if (!lintExtensions.has(path.extname(entry.name))) continue;
+
+    files.push(path.relative(root, absolutePath));
+  }
+}
+
+const files = [];
+
+for (const sourceRoot of sourceRoots) {
+  collectSourceFiles(path.join(root, sourceRoot), files);
+}
+
+if (files.length === 0) {
+  process.exit(0);
+}
+
+let exitCode = 0;
+
+for (let index = 0; index < files.length; index += chunkSize) {
+  const chunk = files.slice(index, index + chunkSize);
+  const result = spawnSync(eslintBin, [...passThroughArgs, ...chunk], {
+    cwd: root,
+    stdio: 'inherit',
+  });
+
+  if (result.error) {
+    throw result.error;
+  }
+
+  if (result.status && result.status > exitCode) {
+    exitCode = result.status;
+  }
+}
+
+process.exit(exitCode);

package/package.json

@@ -1,23 +1,26 @@
 {
   "name": "@rsdk/eslint-plugin",
-  "version": "6.0.0-next.39",
+  "role": "library",
+  "version": "6.0.0-next.40",
   "description": "",
   "main": "index.js",
+  "dependencies": {
+    "@eslint/js": "^10.0.1",
+    "@stylistic/eslint-plugin": "^5.10.0",
+    "eslint-config-prettier": "^10.1.8",
+    "eslint-plugin-import-x": "^4.17.1",
+    "eslint-plugin-simple-import-sort": "^13.0.0",
+    "eslint-plugin-unicorn": "^65.0.0",
+    "globals": "^17.7.0",
+    "typescript-eslint": "^8.62.0"
+  },
+  "peerDependencies": {
+    "eslint": "^10.6.0",
+    "typescript": "5.7.3"
+  },
   "publishConfig": {
     "access": "public"
   },
   "license": "Apache License 2.0",
-  "peerDependencies": {
-    "@typescript-eslint/eslint-plugin": "^7.18.0",
-    "@typescript-eslint/parser": "^7.18.0",
-    "eslint": "^8.57.0",
-    "eslint-config-prettier": "^9.1.0",
-    "eslint-formatter-codeframe": "^7.32.1",
-    "eslint-plugin-deprecation": "^3.0.0",
-    "eslint-plugin-import": "^2.31.0",
-    "eslint-plugin-prettier": "^5.2.1",
-    "eslint-plugin-simple-import-sort": "^12.1.1",
-    "eslint-plugin-unicorn": "^56.0.1"
-  },
-  "gitHead": "5f69b147fc5e27544356c43087b313c4a7b34392"
+  "gitHead": "c220f82159e8e31cf90b2e4078e3570282d01021"
 }