@rsdk/depdoc.cli 6.0.0-next.42 → 6.0.0-next.43

package/src/model/diagnostics.ts

@@ -12,7 +12,7 @@ import {
   getExpectedSection,
 } from './expected';
 import { isExternal } from './placement';
-import { getEffectiveRule, isWorkspaceRole } from './rules';
+import { getEffectiveRule, isWorkspaceRole, matchesPatterns } from './rules';
 import type {
   DependencyRule,
   DependencyViolation,
@@ -42,6 +42,57 @@ function hasCollectedPackageUsage(workspace: WorkspaceFacts): boolean {
   return workspace.sourceUsage.size > 0 || workspace.dtsImports.size > 0;
 }
 
+function getRuleMatches(rule: DependencyRule): string[] {
+  return Array.isArray(rule.match) ? rule.match : [rule.match];
+}
+
+function getConcreteRuleMatches(rule: DependencyRule): string[] {
+  return getRuleMatches(rule).filter((match) => !match.includes('*'));
+}
+
+function getWorkspacePatternLabel(rule: DependencyRule): string {
+  if (!rule.workspace) return '<all>';
+
+  return Array.isArray(rule.workspace)
+    ? rule.workspace.join(', ')
+    : rule.workspace;
+}
+
+function getRuleTargetWorkspaces(
+  rule: DependencyRule,
+  workspaces: WorkspaceFacts[],
+): WorkspaceFacts[] {
+  if (!rule.workspace) return workspaces;
+
+  return workspaces.filter(
+    (workspace) =>
+      matchesPatterns(workspace.name, rule.workspace!) ||
+      matchesPatterns(workspace.location, rule.workspace!),
+  );
+}
+
+function expectedHasDependency(
+  expected: ExpectedWorkspace | undefined,
+  depIdent: string,
+): boolean {
+  if (!expected) return false;
+
+  return SECTIONS.some((section) => expected.sections[section].has(depIdent));
+}
+
+function workspaceHasDependencySignal(
+  workspace: WorkspaceFacts,
+  expected: ExpectedWorkspace | undefined,
+  depIdent: string,
+): boolean {
+  return (
+    workspace.sourceUsage.has(depIdent) ||
+    workspace.dtsImports.has(depIdent) ||
+    collectActualDependencyNames(workspace).has(depIdent) ||
+    expectedHasDependency(expected, depIdent)
+  );
+}
+
 export function compareManifest(
   expected: ExpectedWorkspace,
   violations: DependencyViolation[],
@@ -330,6 +381,59 @@ export function validateBasicShape(
   }
 }
 
+export function collectStaleRuleViolations(
+  workspaces: WorkspaceFacts[],
+  expectedByLocation: Map<string, ExpectedWorkspace>,
+  rules: DependencyRule[],
+): DependencyViolation[] {
+  const violations: DependencyViolation[] = [];
+
+  rules.forEach((rule) => {
+    const concreteMatches = getConcreteRuleMatches(rule);
+    if (concreteMatches.length === 0) return;
+
+    const targetWorkspaces = getRuleTargetWorkspaces(rule, workspaces);
+    const workspaceLabel = getWorkspacePatternLabel(rule);
+
+    for (const depIdent of concreteMatches) {
+      if (targetWorkspaces.length === 0) {
+        violations.push({
+          code: 'stale-rule',
+          workspace: '<root>',
+          workspaceLocation: '.',
+          dependency: depIdent,
+          message:
+            `${depIdent} has a workspace-scoped depdoc.yml rule, but no workspace matches ${workspaceLabel}`,
+        });
+        continue;
+      }
+
+      const isUsed = targetWorkspaces.some((workspace) =>
+        workspaceHasDependencySignal(
+          workspace,
+          expectedByLocation.get(workspace.location),
+          depIdent,
+        ),
+      );
+      if (isUsed) continue;
+
+      const workspace = rule.workspace ? targetWorkspaces[0]! : workspaces[0]!;
+
+      violations.push({
+        code: 'stale-rule',
+        workspace: rule.workspace ? getWorkspaceLabel(workspace) : '<root>',
+        workspaceLocation: rule.workspace ? workspace.location : '.',
+        dependency: depIdent,
+        message: rule.workspace
+          ? `${depIdent} has a depdoc.yml rule scoped to ${workspaceLabel}, but no matching usage or declaration was found`
+          : `${depIdent} has a depdoc.yml rule, but no matching usage or declaration was found`,
+      });
+    }
+  });
+
+  return violations;
+}
+
 export function dedupeViolations(
   violations: DependencyViolation[],
 ): DependencyViolation[] {

package/src/model/engine.ts

@@ -5,7 +5,12 @@
  * diagnostics. It must not read files, execute Yarn, or inspect `node_modules`;
  * those concerns belong to collectors and the runner.
  */
-import { compareManifest, dedupeViolations, validateBasicShape } from './diagnostics';
+import {
+  collectStaleRuleViolations,
+  compareManifest,
+  dedupeViolations,
+  validateBasicShape,
+} from './diagnostics';
 import { emptySections } from './expected';
 import { propagatePeers } from './peer-propagation';
 import {
@@ -111,6 +116,7 @@ export function deriveDependencyModel(
   violations.push(
     ...collectUnconstrainedVersionViolations(workspaces, expected, rules),
   );
+  violations.push(...collectStaleRuleViolations(workspaces, expected, rules));
 
   return {
     violations: dedupeViolations(violations),

package/src/model/types.ts

@@ -25,6 +25,7 @@ export interface DependencyRule {
 
 export interface DependencyModelConfig {
   version?: number;
+  ignoredImports?: string[];
   rules?: DependencyRule[];
   doctor?: DoctorConfig;
 }
@@ -55,6 +56,7 @@ export interface DependencyViolation {
     | 'root-only'
     | 'root-only-usage'
     | 'unconstrained-version'
+    | 'stale-rule'
     | 'mirror'
     | 'stale'
     | 'dist-missing';

package/src/runner.ts

@@ -33,7 +33,11 @@ export function runDependencyModel(
   const config = loadConfig(rootDir, options.depdocYamlPath);
   const rules = config.rules ?? [];
   const withDts = options.withDts === true;
-  const contexts = loadWorkspaces(rootDir, withDts);
+  const contexts = loadWorkspaces(
+    rootDir,
+    withDts,
+    config.ignoredImports ?? [],
+  );
   const packageExtensions = loadPackageExtensions(rootDir);
   const workspaceNames = new Set(
     contexts.filter((ws) => !ws.isRoot).map((ws) => ws.name),