@rpcbase/server 0.207.0 → 0.209.0

package/express/session_middleware.js

@@ -1,4 +1,5 @@
 /* @flow */
+const assert = require("assert")
 const debug = require("debug")
 const session = require("express-session")
 const validator = require("validator")
@@ -7,6 +8,8 @@ const redis_store = require("connect-redis")(session)
 
 
 const {SESSION_STORE_PORT, CONTAINER_MODE, APP_DOMAIN} = process.env
+assert(SESSION_STORE_PORT, "SESSION_STORE_PORT is undefined")
+
 
 const log = debug("rb:session")
 // log.useColors = true
@@ -28,10 +31,6 @@ let session_middleware = null
 // EXTREME WARNING: docker issue
 // when there is synchronous io redis client fails to connect
 setTimeout(async() => {
-  if (!SESSION_STORE_PORT) {
-    return
-  }
-
   const reconnectStrategy = (retries) => {
     log("redis_client::reconnectStrategy::retrying with arg", retries)
     if (retries < 5) {
@@ -97,13 +96,5 @@ setTimeout(async() => {
 
 
 module.exports = (req, res, next) => {
-  if (!SESSION_STORE_PORT) {
-    return next()
-  }
-
-  if (session_middleware) {
-    session_middleware(req, res, next)
-  } else {
-    warn("session middleware not set yet")
-  }
+  session_middleware(req, res, next)
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@rpcbase/server",
-  "version": "0.207.0",
+  "version": "0.209.0",
   "license": "SSPL-1.0",
   "main": "./index.js",
   "bin": {

package/src/auth/sign_in.js

@@ -4,7 +4,6 @@ const debug = require("debug")
 
 const mongoose = require("../../mongoose")
 
-
 const log = debug("rb:auth:signin")
 
 const fail = () => ({
@@ -16,7 +15,7 @@ const sign_in = async({email, password}, ctx) => {
 
   const {req} = ctx
 
-  // find the matching user
+  // find matching user
   const user = await User.findOne({email}, null)
 
   if (!user) {

package/src/client/client_router.js

@@ -13,7 +13,9 @@ const COMPRESSED_EXTENSIONS_MAP = {
   ".svg": "image/svg+xml",
 }
 
-const COMPRESSED_EXTENSIONS = Object.keys(COMPRESSED_EXTENSIONS_MAP)
+const is_development = process.env.NODE_ENV === "development"
+// do not serve compression in dev, the assets are only compressed in the github action
+const COMPRESSED_EXTENSIONS = is_development ? [] : Object.keys(COMPRESSED_EXTENSIONS_MAP)