@rpcbase/server 0.171.0 → 0.173.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@rpcbase/server",
-  "version": "0.171.0",
+  "version": "0.173.0",
   "license": "SSPL-1.0",
   "main": "./index.js",
   "bin": {
@@ -10,10 +10,10 @@
     "test": "echo \"Error: no test specified\" && exit 0"
   },
   "dependencies": {
-    "@rpcbase/agent": "0.29.0",
-    "@rpcbase/std": "0.5.0",
-    "body-parser": "1.20.1",
-    "bull": "4.10.2",
+    "@rpcbase/agent": "0.30.0",
+    "@rpcbase/std": "0.6.0",
+    "body-parser": "1.20.2",
+    "bull": "4.10.4",
     "connect-redis": "6.1.3",
     "cors": "2.8.5",
     "debug": "4.3.4",
@@ -22,13 +22,13 @@
     "express-session": "1.17.3",
     "glob": "8.1.0",
     "lodash": "4.17.21",
-    "mkdirp": "1.0.4",
-    "mongoose": "6.9.0",
+    "mkdirp": "2.1.3",
+    "mongoose": "6.10.0",
     "picocolors": "1.0.0",
     "postmark": "3.0.15",
     "redis": "4.6.4",
     "request-ip": "3.3.0",
     "validator": "13.9.0",
-    "yargs": "17.6.2"
+    "yargs": "17.7.1"
   }
 }

package/queue/register_queue_listener.js

@@ -1,5 +1,7 @@
 /* @flow */
 const debug = require("debug")
+const _get = require("lodash/get")
+const _set = require("lodash/set")
 
 const mongoose = require("../mongoose")
 const queue = require("./index")
@@ -9,19 +11,25 @@ const dispatch_queue = require("./dispatch_queue")
 
 const log = debug("rb:queue:listener")
 
+const RETRY_MINIMUM_DELAY = 10
+const MAX_RETRIES = 16
+const retry_counters = {}
+// TODO: reset retry counters when connection becomes healthy again
+
+
 // Listens for mongodb change events,
 // when a document is created, updated or deleted, dispatch job message
 
 // mongoose middleware used for delete events
 const mongoose_delete_plugin = (schema) => {
   schema.pre("deleteOne", function(next) {
-    throw new Error("rts::deleteOne is deprecated, use findOneAndDelete")
+    throw new Error("rts:deleteOne is deprecated, use findOneAndDelete")
   })
 
   // TODO: add other delete operations
   // https://mongoosejs.com/docs/queries.html
   schema.post("findOneAndDelete", function(doc) {
-    log("queue::findOneAndDelete", "dispatch_doc_change NYI")
+    log("queue:findOneAndDelete", "dispatch_doc_change NYI")
     log("DEL PLUGIN", doc)
     const model_name = this.model.modelName
     dispatch_queue(queue, model_name, "delete", doc)
@@ -50,24 +58,42 @@ const get_dispatch_change_handler = (model_name, filter_fn) => (change) => {
 
 const register_model_emitter = (model_name, filter_fn) => {
   log("registering emitter for", model_name)
+
   const model = mongoose.model(model_name)
   // TODO: implement delete operation fullDocument retrieve,
   // when this is released https://jira.mongodb.org/browse/SERVER-36941
   // this is done via a plugin right now
+  // https://mongodb.github.io/node-mongodb-native/4.9/interfaces/ChangeStreamOptions.html
   const emitter = model.watch({fullDocument: "updateLookup"})
 
   emitter.on("change", get_dispatch_change_handler(model_name, filter_fn))
 
   emitter.on("error", (err) => {
-    log("server::queue::register_queue_listener:: change listener emitter got error", err)
+    log("server:queue:register_queue_listener: change listener emitter got error", err)
   })
 
   emitter.on("close", (arg, arg2) => {
-    // TODO: add exponential backoff retry
-    console.log("queue_listener: emitter closed, model:", model_name, "retrying on next tick6663")
-    process.nextTick(() => {
+    // console.log("close", arg, arg2)
+    // TODO: investigate why we disconnect here and can't reconnect easily
+    const current_retry = _get(retry_counters, model_name, 0)
+    _set(retry_counters, model_name, current_retry + 1)
+
+    if (current_retry > MAX_RETRIES) {
+      console.log("queue listener reached max retries for:", model_name, "exiting with failure")
+      process.exit(1)
+      return
+    }
+
+    const timeout = RETRY_MINIMUM_DELAY + 10 * Math.pow(2, current_retry)
+    console.log("queue_listener: emitter closed, model:", model_name, "retrying in", timeout)
+
+    setTimeout(() => {
       register_model_emitter(model_name, filter_fn)
-    })
+    }, timeout)
+  })
+
+  emitter.on("end", (arg) => {
+    console.log("emitter ENDED", arg)
   })
 }
 
@@ -78,9 +104,10 @@ const register_queue_listener = (filter_fn) => {
   mongoose.plugin(mongoose_delete_plugin)
 
   mongoose.connection.once("open", () => {
-    log("queue_listener mongoose connection opened")
-    const models = mongoose.modelNames()
-    models.forEach((model_name) => register_model_emitter(model_name, filter_fn))
+    process.nextTick(() => {
+      const models = mongoose.modelNames()
+      models.forEach((model_name) => register_model_emitter(model_name, filter_fn))
+    })
   })
 }