@rpcbase/client 0.94.0 → 0.95.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@rpcbase/client",
-  "version": "0.94.0",
+  "version": "0.95.0",
   "scripts": {
     "build-firebase": "webpack -c firebase/webpack.config.js",
     "build": "yarn build-firebase",

package/rts/index.js

@@ -27,7 +27,6 @@ const _local_txn = []
 // TODO: when server disconnects / crashes and loses all server side stored queries
 // the clients must reconnect and re-register those queries, or the page will need to be hard refreshed
 
-
 // add_local_txn
 // when a request is made to the server, we generate (or send if provided) the txn_id
 // if the array becomes longer than the default buffer length we shift the array
@@ -63,7 +62,7 @@ const dispatch_query_payload = (payload) => {
 
   let data
   try {
-    // TODO: zstd / brotli decompression here
+    // TODO: zstd decompression here
     data = JSON.parse(payload.data_buf)
   } catch (err) {
     console.log("Error", err)

package/rts/store/get_collection.js

@@ -25,7 +25,8 @@ const get_collection = (col_name) => {
   if (_cols_store[col_name]) {
     return _cols_store[col_name]
   } else {
-    const col = new PouchDB(col_name, { adapter: "indexeddb" });
+    // https://pouchdb.com/api.html#create_database
+    const col = new PouchDB(col_name, { adapter: "indexeddb", revs_limit: 1 })
     _cols_store[col_name] = col
 
     return col

package/rts/store/index.js

@@ -29,8 +29,6 @@ const log = debug("rb:rts:store")
 //
 //   fn.cancel()
 //
-//   console.log("GOT FN", fn)
-//
 //   console.log("got res", res)
 // _cols_store[col_name].getIndexes().then(function (result) {
 //   console.log("got indexes", result)
@@ -70,7 +68,9 @@ const run_query = async({model_name, query, query_key, options}, callback) => {
     })
 
   if (options.projection) {
-    mapped_docs = mapped_docs.filter((doc) => satisfies_projection(doc, options.projection))
+    mapped_docs = mapped_docs.filter((doc) => {
+      return satisfies_projection(doc, options.projection)
+    })
   }
 
   callback(null, mapped_docs, {source: "cache"})

package/rts/store/satisfies_projection.test.js

@@ -48,3 +48,11 @@ test("missing nested field", () => {
 test("empty", () => {
   expect(satisfies_projection(doc, {field1: 1})).toBe(true)
 })
+
+test("no fields, _id only, empty projection", () => {
+  expect(satisfies_projection({_id: "1012"}, {})).toBe(true)
+})
+
+test("no fields, _id only, mismatching projection", () => {
+  expect(satisfies_projection({_id: "1012"}, {doesntexist: 1})).toBe(false)
+})

package/rts/store/update_docs.js

@@ -7,38 +7,38 @@ const update_docs = async(model_name, data) => {
 
   const all_ids = data.map((doc) => doc._id)
 
-  // console.log("will update cache", model_name, data, all_ids)
-
-  // console.time("find")
-
-  // TODO:
-  // there is also a bulk get which could have different performance than find, try both
-  // https://pouchdb.com/api.html#bulk_get
-
   // https://github.com/pouchdb/pouchdb/tree/master/packages/node_modules/pouchdb-find#dbcreateindexindex--callback
   const {docs: current_docs} = await collection.find({
     selector: {_id: {$in: all_ids}},
     fields: ["_id", "_rev"],
   })
 
-  // console.log("current_docs", current_docs)
+  const current_docs_by_id = current_docs.reduce((acc, val) => {
+    acc[val._id] = val
+    return acc
+  }, {})
+
+  // WARNING: tmp
+  // we don't need to remove docs that aren't present in data because queries are refined with find
 
   const revs_map = {}
   current_docs.forEach((doc) => revs_map[doc._id] = doc._rev)
 
-  const write_docs = data.map((mongo_doc) => {
-    const op = Object.entries(mongo_doc).reduce((new_doc, [key, value]) => {
-      let new_key = key !== "_id" && key.startsWith('_') ? `$_${key}` : key
-      new_doc[new_key] = value
-      return new_doc
-    }, {})
+  const new_docs = data.map((mongo_doc) => {
+    const current_doc = current_docs_by_id[mongo_doc._id] || {}
+
+    const op = Object.entries(mongo_doc)
+      .reduce((new_doc, [key, value]) => {
+        let new_key = key !== "_id" && key.startsWith('_') ? `$_${key}` : key
+        new_doc[new_key] = value
+        return new_doc
+      }, current_doc)
 
     op._rev = revs_map[mongo_doc._id]
     return op
   })
 
-  await collection.bulkDocs(write_docs)
-  // console.timeEnd("find")
+  await collection.bulkDocs(new_docs)
 }
 
 export default update_docs