@rpcbase/client 0.110.0 → 0.111.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@rpcbase/client",
-  "version": "0.110.0",
+  "version": "0.111.0",
   "scripts": {
     "build-firebase": "webpack -c firebase/webpack.config.js",
     "build": "yarn build-firebase",

package/rts/getUseQuery/index.js

@@ -6,6 +6,9 @@ import debug from "debug"
 import _omit from "lodash/omit"
 import LZString from "lz-string"
 
+// TODO: remove this when stable
+import isEqual from "fast-deep-equal/react"
+
 import isEqualValues from "../../isEqualValues"
 import get_uid from "../../auth/get_uid"
 
@@ -50,6 +53,7 @@ const getUseQuery = (register_query) => (
 
   const [source, setSource] = useState()
 
+  const dataRef = useRef(null)
   const [data, setData] = useData({useStorage, storageKey, hasInitiallySetFromStorage})
 
   const [error, setError] = useState()
@@ -69,6 +73,8 @@ const getUseQuery = (register_query) => (
 
   const applyNewData = (newData, context) => {
     setData(newData)
+    // set data in a ref so that it doesn't force re-rendering ie: unsubscribe / resubscribe
+    dataRef.current = newData
 
     // we only save network queries
     if (useStorage && context.source === "network") {
@@ -158,7 +164,11 @@ const getUseQuery = (register_query) => (
         return
       }
 
-      if (!isEqualValues(data, newData)) {
+      if (isEqual(data, newData) && !isEqualValues(data, newData) && __DEV__) {
+        alert("EQUALITY MISMATCH THIS SHOULD NOT HAPPPEND!!!", data, newData)
+      }
+
+      if (!isEqualValues(dataRef.current, newData)) {
         applyContext(context)
         applyNewData(newData, context)
       } else {
@@ -170,8 +180,10 @@ const getUseQuery = (register_query) => (
       log && log("useQuery cleanup unsubscribe()")
       typeof unsubscribe === "function" && unsubscribe()
     }
+
+    // WARNING: do not change the hooks dependencies param or you risk creating infinite loops as it unsubscribes on cleanup
     // TODO: this isnt right we need to update on options change too
-  }, [JSON.stringify(query), data, key])
+  }, [JSON.stringify(query), key])
 
 
   const loadNextPage = useCallback(() => {