@royaloperahouse/chord 1.2.0 → 1.3.0-b-development-chord-development

package/CHANGELOG.md

@@ -1,5 +1,8 @@
 # CHANGELOG
 
+## [1.3.0]
+- Add Static Actvivity Cards as PromoWithTags variant
+
 ## [1.2.0]
 - Card: buttons do not change position on mobiles; 
 
@@ -17,6 +20,9 @@
 ## [0.7.49]
 - Change button behaviour on stream and DED pages
 
+## [0.7.50]
+- Add Static Actvivity Cards
+
 ## [0.7.48]
 - Add background themes to Information component
 

package/README.md

@@ -1,67 +1,122 @@
-# Royal Opera House - chord 
+# Royal Opera House - Front End Design System
 
-Welcome to the Royal Opera House library components  `@royaloperahouse/chord`.
+Welcome to the Royal Opera House Front End Design System, `@royaloperahouse/chord`.
 
 This package is a library of UI components intended to be used in the ROH website.
 
+It uses React, TypeScript, TSDX and Storybook.
 
-## Install
+## Commands
+
+The required package dependencies need to be insalled using `yarn`. Once ready you can issue the following:
+
+To run Lint on the package use:
 
 ```bash
-    npm i --save @royaloperahouse/chord
+yarn lint # you can also use the --fix option to perform automatic fixes
 ```
+
+To run the unit tests (using Jest) use:
+
 ```bash
-    yarn add @royaloperahouse/chord
+yarn test # you can also use the -u option to update snapshots if needed
 ```
 
-## Usage
+To run the unit tests (using Jest) and store them for display in storybook use:
+
+```bash
+yarn test-storybook # you can also use the -u option to update snapshots if needed
+```
+
+To run storybook use:
+
+```bash
+yarn storybook
+```
 
-```javascript
-import {
-  Footer, GlobalStyles, ThemeProvider, ThemeType,
-} from '@royaloperahouse/chord';
+To build a static version of storybook use:
 
+```bash
+yarn build-storybook
 ```
-## Sample
-
-```javascript
-
-import {
-  Footer, GlobalStyles, ThemeProvider, ThemeType,
-} from '@royaloperahouse/chord';
-
-
-const App = ({ children }: InnerProps): React.ReactElement => (
-  <ErrorBoundary>
-    <ThemeProvider theme={ThemeType.Core}>
-      <GlobalStyles />
-      <Wrapper>
-        <Header />
-        <GlobalStyle />
-        <HealthBanner />
-        <ErrorBoundary>
-          <Content>
-            {children}
-          </Content>
-        </ErrorBoundary>
-        <LiveChat />
-      </Wrapper>
-      <Footer data={footerData} />
-    </ThemeProvider>
-  </ErrorBoundary>
-);
 
+This will create a static copy in `./storybook-static`, and there is an index.html page inside the core directory. This allows the site to be previewed directly in the git repository via serving pages (it needs to be configured for that branch).
+
+To deploy the storybook publically:
+
+### Prerequisites
+
+Make sure you have credentials for the *parent* 'Royal Opera House' AWS account in your `~/.aws/credentials` file. The deploy script expects these to be called `[parent]`.
+
+You can get these values at:
+
+AWS 'Your Applications' page -> 'Royal Opera House' -> 'Developer Access' ->
+'Command line or programmatic access'
+
+### Deployment
+
+To deploy, first *build* the storybook as above
+
+then use:
+
+```bash
+yarn deploy-storybook
 ```
 
-## Components
+This will deploy the contents of `./storybook-static` to S3 as a static site accessible at [chord.roh.org.uk](chord.roh.org.uk)
+
+To build the package use:
+
+```bash
+yarn build
+```
+
+To release a new version.
+
+Release will be published in npm (NPM_TOKEN will be required)
+Storybook will be pushed to bitbucket. *** Push will be done Ensure you don't have things pendint to push
+
+```bash
+ NPM_ROH_TOKEN={NPM_TOKEN} RELEASE_VERSION={RELEASE_VERSION} yarn publish-release
+```
+
+
+MORE INFO TO FOLLOW - PARTICULARLY FOR THE CI SETUP AND HOW PACKAGES ARE PUSHED.
+
+# Recommended Use of Package
+
+The package is deployed to NPM, and can be installed using yarn or npm:
+
+```bash
+    npm i --save @royaloperahouse/chord
+```
+```bash
+    yarn add @royaloperahouse/chord
+```
+
+# Processes to follow prior to commits
+
+Before a commit is made you need to do the following:
+
+- Make sure that you are in your own work branch (properly named, including the JIRA ticket number and a short description)
+- `yarn lint` - ensure that you are not introducing errors
+- `yarn test` - ensure that tests are running as expected
+- `yarn test-storybook` - Save the test results to for the static site
+- `yarn build-storybook` - Update the static site
+- Commit your changes in your branch locally
 
-Accordion, Accordions, AltHeader, AnchorTapBar, AnnouncementBanner, BodyText, Card, Cards, Carousel, CinemaBadge, ContactCard, ControlledDropdown, devices, Editorial, Footer, GlobalStyles, Grid, GridItem, Header, HighlightsCarousel, HighlightsCarouselCinema, HighlightsCarouselCore, HighlightsCarouselStream, Icon, ImageWithCaption, Navigation, Overline, PageHeadingCinema, PageHeadingCore, PageHeadingImpact, PageHeadingStream, PeopleListing, PrimaryButton, PromoWithTags, PromoWithTitle, RotatorButtons, SecondaryButton, SecondaryLogo, SectionSplitter, SectionTitle, Sponsorship, StickyBar, StreamBadge, Subtitle, Tab, TabLink, Tabs, TertiaryButton, TextLink, TextOnly, Tickbox, TitleWithCTA, ThemeProvider, TypeTags, Quote
+Next, if you are ready to merge into the main development branch then:
 
-## Types
+- _*ensure that you pull the latest changes from that branch into your new branch, resolving any merge conflicts that may arise*_
+- Commit any merge changes locally
+- Push your branch changes to the origin repo
+- Raise a Pull Request to merge back into the main development branch, AND ensure that the required reviewers are assigned.
+- The reviewers may raise issues, and once resolved, they will be responsible for performing the merge.
 
-AspectRatio, CarouselType, Colors, FooterData, INavigationProps, INavTopProps, TickboxMode, ThemeType
+### Example
 
+There is an example implementation in the example folder. Alternatively there are also integration examples in storybook. Make sure to keep these updated so as to showcase the current components available.
 
-## Documentation
+### Bundle analysis
 
-See Storybook as a reference
+Calculates the real cost of your library using [size-limit](https://github.com/ai/size-limit) with `yarn size` and visulize it with `yarn analyze`.