@roxybrowser/playwright 2.0.2-beta.8 → 2.0.2-beta.9

package/dist/protocol/cdp/backend.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"backend.d.ts","sourceRoot":"","sources":["../../../src/protocol/cdp/backend.ts"],"names":[],"mappings":"AAAA,OAAO,EAAS,KAAK,YAAY,EAAE,MAAM,oBAAoB,CAAC;AA+D9D,OAAO,KAAK,EAIV,qBAAqB,EASrB,aAAa,EAad,MAAM,wBAAwB,CAAC;AAShC,OAAO,KAAK,EAEV,sBAAsB,EACtB,6BAA6B,EAE7B,sBAAsB,EAMvB,MAAM,eAAe,CAAC;AAEvB,OAAO,KAAK,EAAE,oBAAoB,EAAE,MAAM,oBAAoB,CAAC;AAw6B/D,qBAAa,wBAAyB,YAAW,6BAA6B;IAC5E,MAAM,CAAC,OAAO,EAAE,qBAAqB,GAAG,sBAAsB;CAG/D;AAED,qBAAa,iBAAkB,YAAW,sBAAsB;IAMlD,OAAO,CAAC,QAAQ,CAAC,OAAO;IALpC,QAAQ,CAAC,QAAQ,EAAG,KAAK,CAAU;IACnC,QAAQ,CAAC,YAAY,uBAAoB;IAEzC,OAAO,CAAC,KAAK,CAA8B;gBAEd,OAAO,EAAE,qBAAqB;IAErD,OAAO,IAAI,OAAO,CAAC,IAAI,CAAC;IAsBxB,OAAO,IAAI,OAAO,CAAC,sBAAsB,CAAC;IAQ1C,KAAK,IAAI,OAAO,CAAC,IAAI,CAAC;CAc7B;AA2mRD,wBAAsB,uBAAuB,CAC3C,UAAU,EAAE,YAAY,EACxB,WAAW,EAAE,MAAM,EACnB,SAAS,EAAE,MAAM,GAChB,OAAO,CAAC,MAAM,CAAC,CAqEjB;AAED,wBAAsB,sBAAsB,CAAC,QAAQ,EAAE,MAAM,GAAG,OAAO,CAAC,MAAM,GAAG,IAAI,CAAC,CAarF;AAyBD,wBAAgB,2BAA2B,CACzC,OAAO,EAAE,IAAI,CAAC,aAAa,EAAE,SAAS,GAAG,gBAAgB,CAAC,EAC1D,QAAQ,SAAoB,EAC5B,YAAY,oBAAa,GACxB,MAAM,EAAE,CAUV;AAED,wBAAgB,uBAAuB,CACrC,OAAO,EAAE,IAAI,CAAC,aAAa,EAAE,MAAM,GAAG,UAAU,CAAC,EACjD,WAAW,EAAE,MAAM,GAClB,MAAM,EAAE,CAeV;AA0BD,iBAAS,UAAU,CAAC,IAAI,EAAE,MAAM,GAAG,OAAO,CAOzC"}
+{"version":3,"file":"backend.d.ts","sourceRoot":"","sources":["../../../src/protocol/cdp/backend.ts"],"names":[],"mappings":"AAAA,OAAO,EAAS,KAAK,YAAY,EAAE,MAAM,oBAAoB,CAAC;AA+D9D,OAAO,KAAK,EAIV,qBAAqB,EASrB,aAAa,EAad,MAAM,wBAAwB,CAAC;AAShC,OAAO,KAAK,EAEV,sBAAsB,EACtB,6BAA6B,EAE7B,sBAAsB,EAMvB,MAAM,eAAe,CAAC;AAEvB,OAAO,KAAK,EAAE,oBAAoB,EAAE,MAAM,oBAAoB,CAAC;AA46B/D,qBAAa,wBAAyB,YAAW,6BAA6B;IAC5E,MAAM,CAAC,OAAO,EAAE,qBAAqB,GAAG,sBAAsB;CAG/D;AAED,qBAAa,iBAAkB,YAAW,sBAAsB;IAMlD,OAAO,CAAC,QAAQ,CAAC,OAAO;IALpC,QAAQ,CAAC,QAAQ,EAAG,KAAK,CAAU;IACnC,QAAQ,CAAC,YAAY,uBAAoB;IAEzC,OAAO,CAAC,KAAK,CAA8B;gBAEd,OAAO,EAAE,qBAAqB;IAErD,OAAO,IAAI,OAAO,CAAC,IAAI,CAAC;IAuBxB,OAAO,IAAI,OAAO,CAAC,sBAAsB,CAAC;IAQ1C,KAAK,IAAI,OAAO,CAAC,IAAI,CAAC;CAc7B;AAupRD,wBAAsB,uBAAuB,CAC3C,UAAU,EAAE,YAAY,EACxB,WAAW,EAAE,MAAM,EACnB,SAAS,EAAE,MAAM,GAChB,OAAO,CAAC,MAAM,CAAC,CAqEjB;AAED,wBAAsB,sBAAsB,CAAC,QAAQ,EAAE,MAAM,GAAG,OAAO,CAAC,MAAM,GAAG,IAAI,CAAC,CAarF;AAyBD,wBAAgB,2BAA2B,CACzC,OAAO,EAAE,IAAI,CAAC,aAAa,EAAE,SAAS,GAAG,gBAAgB,CAAC,EAC1D,QAAQ,SAAoB,EAC5B,YAAY,oBAAa,GACxB,MAAM,EAAE,CAUV;AAED,wBAAgB,uBAAuB,CACrC,OAAO,EAAE,IAAI,CAAC,aAAa,EAAE,MAAM,GAAG,UAAU,CAAC,EACjD,WAAW,EAAE,MAAM,GAClB,MAAM,EAAE,CAeV;AA0BD,iBAAS,UAAU,CAAC,IAAI,EAAE,MAAM,GAAG,OAAO,CAOzC"}

package/dist/protocol/cdp/backend.js

@@ -544,7 +544,8 @@ export class CdpBrowserAdapter {
         this.state = {
             browserClient,
             version,
-            connection
+            connection,
+            isolatedBrowserContextIds: new Set()
         };
     }
     async browser() {
@@ -580,6 +581,9 @@ class CdpBrowserSession {
             return new CdpBrowserContextAdapter(this.state, undefined, options);
         }
         const response = await this.state.browserClient.Target.createBrowserContext({});
+        // Track the new isolated context so the default context adapter (reuseDefaultUserContext)
+        // can distinguish default-context targets from explicitly isolated ones.
+        this.state.isolatedBrowserContextIds.add(response.browserContextId);
         return new CdpBrowserContextAdapter(this.state, response.browserContextId, options);
     }
     async close() { }
@@ -793,6 +797,9 @@ class CdpBrowserContextAdapter {
                     throw error;
                 }
             }
+            // Remove from the shared set so the default context adapter stops
+            // excluding targets that belonged to this now-disposed context.
+            this.state.isolatedBrowserContextIds.delete(this.browserContextId);
         }
         await Promise.allSettled(pendingPages);
         this.pendingPages.clear();
@@ -831,26 +838,26 @@ class CdpBrowserContextAdapter {
             waitForDebuggerOnStart: !this.options.reuseDefaultUserContext,
             flatten: true
         }).catch(() => { });
-        // Bug fix: await the initial page-initialization promises that were fired
-        // synchronously when attachedToTarget events arrived during setAutoAttach.
-        //
-        // Node.js CDP clients deliver attachedToTarget events in the same message
-        // queue as the setAutoAttach response, so by the time setAutoAttach resolves
-        // all event handlers have already run and pendingPages is fully populated —
-        // but the individual page setup (Page.enable, Runtime.enable, init scripts…)
-        // is still in flight. Awaiting here ensures those complete before
-        // targetDiscoveryReady resolves, so callers who await ready() see pages[]
-        // populated immediately rather than an empty list.
+        // Await pages that were attached synchronously via setAutoAttach events.
+        // In practice Chrome does NOT fire attachedToTarget for pre-existing page
+        // targets from the browser session, so this batch is usually empty — but
+        // it's still needed for targets attached via other mechanisms (workers, etc.).
         const initialPagePromises = Array.from(this.pendingPages.values());
         await Promise.allSettled(initialPagePromises);
         await this.state.browserClient.Target.getTargetInfo?.().catch(() => { });
         await this.state.browserClient.Target.setDiscoverTargets?.({
             discover: true
         });
+        // Explicitly discover and attach to any pre-existing page targets that
+        // setAutoAttach did not fire attachedToTarget for (Chrome's browser-level
+        // setAutoAttach only triggers attachedToTarget for new targets, not for
+        // tabs that were already open before our session connected).
+        // This is the primary mechanism that populates context.pages() after
+        // connectOverCDP — without it, pages() is always empty on connect.
+        await this.discoverTargets();
         this.targetPollTimer = setInterval(() => {
             void this.discoverTargets().catch(() => { });
         }, 100);
-        await this.discoverTargets();
     }
     async handleTargetAttached(event) {
         const { targetInfo } = event;
@@ -916,6 +923,24 @@ class CdpBrowserContextAdapter {
         if (this.closing || !this.matchesTargetInfo(targetInfo)) {
             return;
         }
+        // Skip targets that are already known (attached via setAutoAttach or a prior
+        // discoverTargets call).
+        if (this.pages.has(targetInfo.targetId) || this.pendingPages.has(targetInfo.targetId)) {
+            return;
+        }
+        // Chrome's browser-level setAutoAttach does not fire attachedToTarget for
+        // page targets that were already open before our session connected. Attach
+        // to them explicitly so we can create Page objects for them.
+        let sessionId;
+        try {
+            const result = await this.state.browserClient.Target.attachToTarget({ targetId: targetInfo.targetId, flatten: true });
+            sessionId = result.sessionId;
+        }
+        catch {
+            // Target may have already been attached or closed — skip it.
+            return;
+        }
+        await this.handleTargetAttached({ sessionId, targetInfo, waitingForDebugger: false });
     }
     async handleTargetDetached(targetId, sessionId) {
         const attachedSessionId = this.pageSessionIds.get(targetId);
@@ -948,13 +973,28 @@ class CdpBrowserContextAdapter {
         if (targetInfo.openerId && this.pendingPages.has(targetInfo.openerId)) {
             return true;
         }
-        return !this.browserContextId && !targetInfo.browserContextId;
+        // When we represent the default browser context (no browserContextId), match
+        // all page targets that do NOT belong to a known isolated context.
+        //
+        // Chrome 119+ assigns a non-empty UUID to ALL targets — including those in the
+        // default context — so the old check `!targetInfo.browserContextId` incorrectly
+        // excluded every tab that had been given a default-context UUID, making
+        // context.pages() always empty after connectOverCDP.
+        //
+        // Isolated contexts are tracked in state.isolatedBrowserContextIds (populated
+        // in CdpBrowserSession.newContext when Target.createBrowserContext is called).
+        // Any target NOT in that set belongs to the default context.
+        return !this.browserContextId &&
+            !this.state.isolatedBrowserContextIds.has(targetInfo.browserContextId ?? "");
     }
     matchesBrowserContextTarget(targetInfo) {
         if (targetInfo.browserContextId === this.browserContextId) {
             return true;
         }
-        return !this.browserContextId && !targetInfo.browserContextId;
+        // Same reasoning as matchesTargetInfo: default context adapter accepts all
+        // non-isolated targets regardless of whether browserContextId is a UUID.
+        return !this.browserContextId &&
+            !this.state.isolatedBrowserContextIds.has(targetInfo.browserContextId ?? "");
     }
     async getOrCreatePage(targetId, options = {}) {
         const existing = this.pages.get(targetId);