@rovq/react-native 0.2.1 → 0.2.2

package/android/build.gradle

@@ -6,8 +6,12 @@ plugins {
 // seconds. Inside an app, the React Native integration is added on top of it.
 def insideApp = rootProject.name != 'rovq-engine'
 
-// React Native's app template turns off the Kotlin support built into Android Gradle Plugin 9.
-def usesKotlinPlugin = insideApp && findProperty('android.builtInKotlin') == 'false'
+// Android Gradle Plugin 9 compiles Kotlin itself, unless an app turns that off, as React Native's
+// template does. Earlier versions, used up to React Native 0.87, need the Kotlin plugin, or the
+// Kotlin sources are left out and the app cannot find any of these classes.
+def agpMajor = com.android.Version.ANDROID_GRADLE_PLUGIN_VERSION.tokenize('.')[0].toInteger()
+def usesKotlinPlugin = insideApp &&
+    (agpMajor < 9 || findProperty('android.builtInKotlin') == 'false')
 
 // Rebuilding only changed files fails with "Cannot access ... it is internal" when this package is
 // linked through a symbolic link, as npm's file: dependencies are. Compiling it fully each time

package/android/src/react/java/com/rovq/engine/react/Rovq.kt

@@ -5,10 +5,13 @@ import android.app.Application
 import android.content.pm.PackageInfo
 import android.os.Build
 import android.os.Bundle
+import android.util.Log
 import com.rovq.engine.EngineConfig
 import com.rovq.engine.RovqEngine
 import java.io.File
 
+private const val LOG_TAG = "Rovq"
+
 /** What an app supplies. Everything here ships inside the app, so nothing here is secret. */
 data class RovqConfig(
     val apiUrl: String,
@@ -33,23 +36,33 @@ object Rovq {
     val engineOrNull: RovqEngine?
         get() = instance
 
+    /**
+     * If the settings are unusable, such as a public key in the wrong format, the app still
+     * starts, on the bundle inside it, and accepts no update. A typo must not crash every user's
+     * app. The reason is logged under the tag Rovq. iOS behaves the same.
+     */
     @Synchronized
     fun initialize(application: Application, config: RovqConfig) {
         if (instance != null) return
-        val info = application.packageManager.getPackageInfo(application.packageName, 0)
-        val engine = RovqEngine(
-            File(application.filesDir, "rovq"),
-            EngineConfig(
-                apiUrl = config.apiUrl,
-                deploymentKey = config.deploymentKey,
-                runtimeVersion = config.runtimeVersion,
-                binaryVersion = info.versionName ?: "0",
-                binaryId = binaryIdOf(info),
-                trustedKeys = config.trustedKeys,
-                allowInsecureUrls = config.allowInsecureUrls,
-            ),
-            builtInFiles = ResourceFiles(application),
-        )
+        val engine = try {
+            val info = application.packageManager.getPackageInfo(application.packageName, 0)
+            RovqEngine(
+                File(application.filesDir, "rovq"),
+                EngineConfig(
+                    apiUrl = config.apiUrl,
+                    deploymentKey = config.deploymentKey,
+                    runtimeVersion = config.runtimeVersion,
+                    binaryVersion = info.versionName ?: "0",
+                    binaryId = binaryIdOf(info),
+                    trustedKeys = config.trustedKeys,
+                    allowInsecureUrls = config.allowInsecureUrls,
+                ),
+                builtInFiles = ResourceFiles(application),
+            )
+        } catch (error: Exception) {
+            Log.e(LOG_TAG, "Could not start, so updates are off: ${error.message}", error)
+            return
+        }
         instance = engine
         application.registerActivityLifecycleCallbacks(BackgroundWatcher(engine))
         watchForCrashes(engine)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@rovq/react-native",
-  "version": "0.2.1",
+  "version": "0.2.2",
   "description": "Over-the-air updates for React Native, with signed releases and automatic rollback",
   "keywords": [
     "react-native",