@rotki/eslint-plugin 1.4.0 → 1.5.0

package/dist/index.d.mts

@@ -4,7 +4,7 @@ interface PluginRuleModule<TOptions extends readonly unknown[] = []> extends Rul
     defaultOptions: TOptions;
 }
 
-type Options$6 = [
+type Options$7 = [
     {
         extensions: string[];
         ignoreKeys: string[];
@@ -12,6 +12,11 @@ type Options$6 = [
     }
 ];
 
+interface Options$6 {
+    factories: string[];
+    testFilePattern: string;
+}
+
 type Options$5 = [{
     legacy: boolean;
 }];
@@ -59,7 +64,8 @@ declare const plugin: {
         'no-dot-ts-imports': PluginRuleModule<[]>;
         'no-legacy-library-import': PluginRuleModule<[]>;
         'no-redundant-flex-row': PluginRuleModule<[]>;
-        'no-unused-i18n-keys': PluginRuleModule<Options$6>;
+        'no-shared-pinia': PluginRuleModule<[Options$6]>;
+        'no-unused-i18n-keys': PluginRuleModule<Options$7>;
         'require-jsdoc-on-composable-options': PluginRuleModule<[]>;
     };
 };
@@ -85,7 +91,8 @@ declare const _default: {
         'no-dot-ts-imports': PluginRuleModule<[]>;
         'no-legacy-library-import': PluginRuleModule<[]>;
         'no-redundant-flex-row': PluginRuleModule<[]>;
-        'no-unused-i18n-keys': PluginRuleModule<Options$6>;
+        'no-shared-pinia': PluginRuleModule<[Options$6]>;
+        'no-unused-i18n-keys': PluginRuleModule<Options$7>;
         'require-jsdoc-on-composable-options': PluginRuleModule<[]>;
     };
 } & {
@@ -113,7 +120,8 @@ declare const _default: {
                         'no-dot-ts-imports': PluginRuleModule<[]>;
                         'no-legacy-library-import': PluginRuleModule<[]>;
                         'no-redundant-flex-row': PluginRuleModule<[]>;
-                        'no-unused-i18n-keys': PluginRuleModule<Options$6>;
+                        'no-shared-pinia': PluginRuleModule<[Options$6]>;
+                        'no-unused-i18n-keys': PluginRuleModule<Options$7>;
                         'require-jsdoc-on-composable-options': PluginRuleModule<[]>;
                     };
                 };
@@ -150,7 +158,8 @@ declare const _default: {
                         'no-dot-ts-imports': PluginRuleModule<[]>;
                         'no-legacy-library-import': PluginRuleModule<[]>;
                         'no-redundant-flex-row': PluginRuleModule<[]>;
-                        'no-unused-i18n-keys': PluginRuleModule<Options$6>;
+                        'no-shared-pinia': PluginRuleModule<[Options$6]>;
+                        'no-unused-i18n-keys': PluginRuleModule<Options$7>;
                         'require-jsdoc-on-composable-options': PluginRuleModule<[]>;
                     };
                 };
@@ -187,7 +196,8 @@ declare const _default: {
                         'no-dot-ts-imports': PluginRuleModule<[]>;
                         'no-legacy-library-import': PluginRuleModule<[]>;
                         'no-redundant-flex-row': PluginRuleModule<[]>;
-                        'no-unused-i18n-keys': PluginRuleModule<Options$6>;
+                        'no-shared-pinia': PluginRuleModule<[Options$6]>;
+                        'no-unused-i18n-keys': PluginRuleModule<Options$7>;
                         'require-jsdoc-on-composable-options': PluginRuleModule<[]>;
                     };
                 };
@@ -224,7 +234,8 @@ declare const _default: {
                         'no-dot-ts-imports': PluginRuleModule<[]>;
                         'no-legacy-library-import': PluginRuleModule<[]>;
                         'no-redundant-flex-row': PluginRuleModule<[]>;
-                        'no-unused-i18n-keys': PluginRuleModule<Options$6>;
+                        'no-shared-pinia': PluginRuleModule<[Options$6]>;
+                        'no-unused-i18n-keys': PluginRuleModule<Options$7>;
                         'require-jsdoc-on-composable-options': PluginRuleModule<[]>;
                     };
                 };
@@ -261,7 +272,8 @@ declare const _default: {
                         'no-dot-ts-imports': PluginRuleModule<[]>;
                         'no-legacy-library-import': PluginRuleModule<[]>;
                         'no-redundant-flex-row': PluginRuleModule<[]>;
-                        'no-unused-i18n-keys': PluginRuleModule<Options$6>;
+                        'no-shared-pinia': PluginRuleModule<[Options$6]>;
+                        'no-unused-i18n-keys': PluginRuleModule<Options$7>;
                         'require-jsdoc-on-composable-options': PluginRuleModule<[]>;
                     };
                 };
@@ -298,7 +310,8 @@ declare const _default: {
                         'no-dot-ts-imports': PluginRuleModule<[]>;
                         'no-legacy-library-import': PluginRuleModule<[]>;
                         'no-redundant-flex-row': PluginRuleModule<[]>;
-                        'no-unused-i18n-keys': PluginRuleModule<Options$6>;
+                        'no-shared-pinia': PluginRuleModule<[Options$6]>;
+                        'no-unused-i18n-keys': PluginRuleModule<Options$7>;
                         'require-jsdoc-on-composable-options': PluginRuleModule<[]>;
                     };
                 };

package/dist/index.d.ts

@@ -4,7 +4,7 @@ interface PluginRuleModule<TOptions extends readonly unknown[] = []> extends Rul
     defaultOptions: TOptions;
 }
 
-type Options$6 = [
+type Options$7 = [
     {
         extensions: string[];
         ignoreKeys: string[];
@@ -12,6 +12,11 @@ type Options$6 = [
     }
 ];
 
+interface Options$6 {
+    factories: string[];
+    testFilePattern: string;
+}
+
 type Options$5 = [{
     legacy: boolean;
 }];
@@ -59,7 +64,8 @@ declare const plugin: {
         'no-dot-ts-imports': PluginRuleModule<[]>;
         'no-legacy-library-import': PluginRuleModule<[]>;
         'no-redundant-flex-row': PluginRuleModule<[]>;
-        'no-unused-i18n-keys': PluginRuleModule<Options$6>;
+        'no-shared-pinia': PluginRuleModule<[Options$6]>;
+        'no-unused-i18n-keys': PluginRuleModule<Options$7>;
         'require-jsdoc-on-composable-options': PluginRuleModule<[]>;
     };
 };
@@ -85,7 +91,8 @@ declare const _default: {
         'no-dot-ts-imports': PluginRuleModule<[]>;
         'no-legacy-library-import': PluginRuleModule<[]>;
         'no-redundant-flex-row': PluginRuleModule<[]>;
-        'no-unused-i18n-keys': PluginRuleModule<Options$6>;
+        'no-shared-pinia': PluginRuleModule<[Options$6]>;
+        'no-unused-i18n-keys': PluginRuleModule<Options$7>;
         'require-jsdoc-on-composable-options': PluginRuleModule<[]>;
     };
 } & {
@@ -113,7 +120,8 @@ declare const _default: {
                         'no-dot-ts-imports': PluginRuleModule<[]>;
                         'no-legacy-library-import': PluginRuleModule<[]>;
                         'no-redundant-flex-row': PluginRuleModule<[]>;
-                        'no-unused-i18n-keys': PluginRuleModule<Options$6>;
+                        'no-shared-pinia': PluginRuleModule<[Options$6]>;
+                        'no-unused-i18n-keys': PluginRuleModule<Options$7>;
                         'require-jsdoc-on-composable-options': PluginRuleModule<[]>;
                     };
                 };
@@ -150,7 +158,8 @@ declare const _default: {
                         'no-dot-ts-imports': PluginRuleModule<[]>;
                         'no-legacy-library-import': PluginRuleModule<[]>;
                         'no-redundant-flex-row': PluginRuleModule<[]>;
-                        'no-unused-i18n-keys': PluginRuleModule<Options$6>;
+                        'no-shared-pinia': PluginRuleModule<[Options$6]>;
+                        'no-unused-i18n-keys': PluginRuleModule<Options$7>;
                         'require-jsdoc-on-composable-options': PluginRuleModule<[]>;
                     };
                 };
@@ -187,7 +196,8 @@ declare const _default: {
                         'no-dot-ts-imports': PluginRuleModule<[]>;
                         'no-legacy-library-import': PluginRuleModule<[]>;
                         'no-redundant-flex-row': PluginRuleModule<[]>;
-                        'no-unused-i18n-keys': PluginRuleModule<Options$6>;
+                        'no-shared-pinia': PluginRuleModule<[Options$6]>;
+                        'no-unused-i18n-keys': PluginRuleModule<Options$7>;
                         'require-jsdoc-on-composable-options': PluginRuleModule<[]>;
                     };
                 };
@@ -224,7 +234,8 @@ declare const _default: {
                         'no-dot-ts-imports': PluginRuleModule<[]>;
                         'no-legacy-library-import': PluginRuleModule<[]>;
                         'no-redundant-flex-row': PluginRuleModule<[]>;
-                        'no-unused-i18n-keys': PluginRuleModule<Options$6>;
+                        'no-shared-pinia': PluginRuleModule<[Options$6]>;
+                        'no-unused-i18n-keys': PluginRuleModule<Options$7>;
                         'require-jsdoc-on-composable-options': PluginRuleModule<[]>;
                     };
                 };
@@ -261,7 +272,8 @@ declare const _default: {
                         'no-dot-ts-imports': PluginRuleModule<[]>;
                         'no-legacy-library-import': PluginRuleModule<[]>;
                         'no-redundant-flex-row': PluginRuleModule<[]>;
-                        'no-unused-i18n-keys': PluginRuleModule<Options$6>;
+                        'no-shared-pinia': PluginRuleModule<[Options$6]>;
+                        'no-unused-i18n-keys': PluginRuleModule<Options$7>;
                         'require-jsdoc-on-composable-options': PluginRuleModule<[]>;
                     };
                 };
@@ -298,7 +310,8 @@ declare const _default: {
                         'no-dot-ts-imports': PluginRuleModule<[]>;
                         'no-legacy-library-import': PluginRuleModule<[]>;
                         'no-redundant-flex-row': PluginRuleModule<[]>;
-                        'no-unused-i18n-keys': PluginRuleModule<Options$6>;
+                        'no-shared-pinia': PluginRuleModule<[Options$6]>;
+                        'no-unused-i18n-keys': PluginRuleModule<Options$7>;
                         'require-jsdoc-on-composable-options': PluginRuleModule<[]>;
                     };
                 };

package/dist/index.mjs

@@ -6,7 +6,7 @@ import { statSync, readFileSync } from 'node:fs';
 import { globSync } from 'tinyglobby';
 import { parse } from 'vue-eslint-parser';
 
-const version = "1.4.0";
+const version = "1.5.0";
 const pkg = {
 	version: version};
 
@@ -127,13 +127,13 @@ function createRule({
   meta
 }) {
   return {
-    create: ((context) => {
+    create: (context) => {
       const optionsWithDefault = context.options.map((options, index) => ({
         ...defaultOptions[index] || {},
         ...options || {}
       }));
       return create(context, optionsWithDefault);
-    }),
+    },
     defaultOptions,
     meta
   };
@@ -164,7 +164,7 @@ function defineTemplateBodyVisitor(context, templateBodyVisitor, scriptVisitor,
   );
 }
 
-const RULE_NAME$g = "composable-input-flexibility";
+const RULE_NAME$h = "composable-input-flexibility";
 function checkParamForRef(param) {
   let annotation;
   if (param.type === AST_NODE_TYPES.Identifier && param.typeAnnotation) {
@@ -177,44 +177,73 @@ function checkParamForRef(param) {
   }
   return void 0;
 }
+function getParamName(param) {
+  if (param.type === AST_NODE_TYPES.Identifier)
+    return param.name;
+  if (param.type === AST_NODE_TYPES.AssignmentPattern && param.left.type === AST_NODE_TYPES.Identifier)
+    return param.left.name;
+  return void 0;
+}
+function isWriteReference(reference) {
+  const { identifier } = reference;
+  const parent = identifier.parent;
+  if (parent.type === AST_NODE_TYPES.CallExpression) {
+    return parent.callee.type === AST_NODE_TYPES.Identifier && parent.callee.name === "set" && parent.arguments[0] === identifier;
+  }
+  if (parent.type === AST_NODE_TYPES.MemberExpression && parent.object === identifier && !parent.computed && parent.property.type === AST_NODE_TYPES.Identifier && parent.property.name === "value") {
+    const grandparent = parent.parent;
+    if (grandparent.type === AST_NODE_TYPES.AssignmentExpression)
+      return grandparent.left === parent;
+    return grandparent.type === AST_NODE_TYPES.UpdateExpression;
+  }
+  return false;
+}
+function isWrittenParam(scope, name) {
+  const variable = scope.variables.find((candidate) => candidate.name === name);
+  return variable?.references.some(isWriteReference) ?? false;
+}
 const composableInputFlexibility = createEslintRule({
   create(context) {
     const autofix = context.options[0]?.autofix ?? false;
     return {
       FunctionDeclaration: (node) => {
-        if (!node.id || !isComposableName(node.id.name))
+        if (!node.id || !isComposableName(node.id.name) || !node.body)
           return;
-        checkParams(node.params);
+        checkParams(node.params, node);
       },
       VariableDeclarator: (node) => {
         if (node.id.type !== AST_NODE_TYPES.Identifier || !isComposableName(node.id.name))
           return;
         if (node.init?.type === AST_NODE_TYPES.ArrowFunctionExpression || node.init?.type === AST_NODE_TYPES.FunctionExpression) {
-          checkParams(node.init.params);
+          checkParams(node.init.params, node.init);
         }
       }
     };
-    function checkParams(params) {
+    function checkParams(params, fn) {
+      const scope = context.sourceCode.getScope(fn);
       for (const param of params) {
         const refType = checkParamForRef(param);
-        if (refType) {
-          context.report({
-            ...autofix ? {
+        if (!refType)
+          continue;
+        const name = getParamName(param);
+        if (name && isWrittenParam(scope, name))
+          continue;
+        context.report({
+          ...autofix ? {
+            fix(fixer) {
+              return fixer.replaceText(refType.typeName, "MaybeRefOrGetter");
+            }
+          } : {
+            suggest: [{
               fix(fixer) {
                 return fixer.replaceText(refType.typeName, "MaybeRefOrGetter");
-              }
-            } : {
-              suggest: [{
-                fix(fixer) {
-                  return fixer.replaceText(refType.typeName, "MaybeRefOrGetter");
-                },
-                messageId: "suggestMaybeRefOrGetter"
-              }]
-            },
-            messageId: "preferMaybeRefOrGetter",
-            node: refType
-          });
-        }
+              },
+              messageId: "suggestMaybeRefOrGetter"
+            }]
+          },
+          messageId: "preferMaybeRefOrGetter",
+          node: refType
+        });
       }
     }
   },
@@ -245,10 +274,10 @@ const composableInputFlexibility = createEslintRule({
     ],
     type: "suggestion"
   },
-  name: RULE_NAME$g
+  name: RULE_NAME$h
 });
 
-const RULE_NAME$f = "composable-naming-convention";
+const RULE_NAME$g = "composable-naming-convention";
 function getComposableFunction(node) {
   if (node.type === AST_NODE_TYPES.FunctionDeclaration) {
     if (!node.id || !isComposableName(node.id.name))
@@ -321,10 +350,10 @@ const composableNamingConvention = createEslintRule({
     schema: [],
     type: "suggestion"
   },
-  name: RULE_NAME$f
+  name: RULE_NAME$g
 });
 
-const RULE_NAME$e = "composable-no-default-export";
+const RULE_NAME$f = "composable-no-default-export";
 const composableNoDefaultExport = createEslintRule({
   create(context) {
     let hasComposable = false;
@@ -364,10 +393,10 @@ const composableNoDefaultExport = createEslintRule({
     schema: [],
     type: "problem"
   },
-  name: RULE_NAME$e
+  name: RULE_NAME$f
 });
 
-const RULE_NAME$d = "composable-prefer-shallowref";
+const RULE_NAME$e = "composable-prefer-shallowref";
 const composablePreferShallowref = createEslintRule({
   create(context) {
     const autofix = context.options[0]?.autofix ?? false;
@@ -426,10 +455,10 @@ const composablePreferShallowref = createEslintRule({
     ],
     type: "suggestion"
   },
-  name: RULE_NAME$d
+  name: RULE_NAME$e
 });
 
-const RULE_NAME$c = "composable-require-cleanup";
+const RULE_NAME$d = "composable-require-cleanup";
 const SIDE_EFFECT_CALLS = /* @__PURE__ */ new Set(["addEventListener", "setInterval", "setTimeout"]);
 const SIDE_EFFECT_CONSTRUCTORS = /* @__PURE__ */ new Set(["MutationObserver", "ResizeObserver", "IntersectionObserver"]);
 const CLEANUP_HOOKS = /* @__PURE__ */ new Set(["onUnmounted", "onBeforeUnmount", "onScopeDispose", "tryOnScopeDispose"]);
@@ -523,10 +552,10 @@ const composableRequireCleanup = createEslintRule({
     schema: [],
     type: "problem"
   },
-  name: RULE_NAME$c
+  name: RULE_NAME$d
 });
 
-const RULE_NAME$b = "composable-return-readonly";
+const RULE_NAME$c = "composable-return-readonly";
 const DEFAULT_WRITABLE_PREFIXES = ["model"];
 const REACTIVE_CREATORS = /* @__PURE__ */ new Set(["ref", "shallowRef"]);
 const READONLY_CREATORS = /* @__PURE__ */ new Set(["computed"]);
@@ -643,10 +672,10 @@ const composableReturnReadonly = createEslintRule({
     ],
     type: "suggestion"
   },
-  name: RULE_NAME$b
+  name: RULE_NAME$c
 });
 
-const RULE_NAME$a = "composable-ssr-safety";
+const RULE_NAME$b = "composable-ssr-safety";
 const BROWSER_GLOBALS = /* @__PURE__ */ new Set(["window", "document", "navigator"]);
 const LIFECYCLE_HOOKS = /* @__PURE__ */ new Set(["onMounted", "onBeforeMount"]);
 function isInsideLifecycleHook(node) {
@@ -734,11 +763,11 @@ const composableSsrSafety = createEslintRule({
     schema: [],
     type: "problem"
   },
-  name: RULE_NAME$a
+  name: RULE_NAME$b
 });
 
-const debug$6 = debugFactory("@rotki/eslint-plugin:consistent-ref-type-annotation");
-const RULE_NAME$9 = "consistent-ref-type-annotation";
+const debug$7 = debugFactory("@rotki/eslint-plugin:consistent-ref-type-annotation");
+const RULE_NAME$a = "consistent-ref-type-annotation";
 const FIXABLE_METHODS = /* @__PURE__ */ new Set(["ref", "computed"]);
 function getFixableCallExpression(declaration) {
   const init = declaration.init;
@@ -761,13 +790,13 @@ function checkAssignmentDeclaration(context, source, node, declaration, allowInf
     return;
   const { callee, init } = call;
   const name = callee.name;
-  debug$6(`found ${name}, checking type arguments`);
+  debug$7(`found ${name}, checking type arguments`);
   const initTypeArgs = init.typeArguments;
   const declTypeArgs = getDeclarationTypeArguments(declaration);
   const typeAnnotation = declaration.id.typeAnnotation;
   if (initTypeArgs && !declTypeArgs)
     return;
-  debug$6(`generating report for ${name}`);
+  debug$7(`generating report for ${name}`);
   if (!initTypeArgs && !declTypeArgs) {
     if (!allowInference)
       context.report({ data: { name }, messageId: "missingType", node });
@@ -827,10 +856,10 @@ const consistentRefTypeAnnotation = createEslintRule({
     ],
     type: "problem"
   },
-  name: RULE_NAME$9
+  name: RULE_NAME$a
 });
 
-const RULE_NAME$8 = "max-dependencies";
+const RULE_NAME$9 = "max-dependencies";
 const maxDependencies = createEslintRule({
   create(context, [options]) {
     let dependencyCount = 0;
@@ -890,11 +919,11 @@ const maxDependencies = createEslintRule({
     ],
     type: "suggestion"
   },
-  name: RULE_NAME$8
+  name: RULE_NAME$9
 });
 
-const RULE_NAME$7 = "no-deprecated-classes";
-const debug$5 = debugFactory("@rotki/eslint-plugin:no-deprecated-classes");
+const RULE_NAME$8 = "no-deprecated-classes";
+const debug$6 = debugFactory("@rotki/eslint-plugin:no-deprecated-classes");
 const stringReplacements = /* @__PURE__ */ new Map([
   ["d-block", "block"],
   ["d-flex", "flex"],
@@ -948,7 +977,7 @@ function getRange(node) {
   return node.range;
 }
 function reportReplacement(className, replacement, node, context, source, position = 1) {
-  debug$5(`found replacement ${replacement} for ${className}`);
+  debug$6(`found replacement ${replacement} for ${className}`);
   const initialRange = getRange(node);
   const range = [
     initialRange[0] + position,
@@ -1072,11 +1101,11 @@ const noDeprecatedClasses = createEslintRule({
     schema: [],
     type: "problem"
   },
-  name: RULE_NAME$7
+  name: RULE_NAME$8
 });
 
-const debug$4 = debugFactory("@rotki/eslint-plugin:no-deprecated-components");
-const RULE_NAME$6 = "no-deprecated-components";
+const debug$5 = debugFactory("@rotki/eslint-plugin:no-deprecated-components");
+const RULE_NAME$7 = "no-deprecated-components";
 const vuetify = {
   VApp: true,
   VAppBar: true,
@@ -1129,7 +1158,7 @@ const noDeprecatedComponents = createEslintRule({
           return;
         const replacement = replacements$1[tag];
         if (replacement || legacy && skipInLegacy.has(tag)) {
-          debug$4(`${tag} has been deprecated`);
+          debug$5(`${tag} has been deprecated`);
           context.report({
             data: {
               name: tag
@@ -1138,7 +1167,7 @@ const noDeprecatedComponents = createEslintRule({
             node: element
           });
         } else {
-          debug$4(`${tag} has will be removed`);
+          debug$5(`${tag} has will be removed`);
           context.report({
             data: {
               name: tag
@@ -1181,10 +1210,10 @@ const noDeprecatedComponents = createEslintRule({
     ],
     type: "problem"
   },
-  name: RULE_NAME$6
+  name: RULE_NAME$7
 });
 
-const RULE_NAME$5 = "no-deprecated-props";
+const RULE_NAME$6 = "no-deprecated-props";
 const replacements = {
   RuiRadio: {
     internalValue: "value"
@@ -1251,10 +1280,10 @@ const noDeprecatedProps = createEslintRule({
     schema: [],
     type: "problem"
   },
-  name: RULE_NAME$5
+  name: RULE_NAME$6
 });
 
-const RULE_NAME$4 = "no-dot-ts-imports";
+const RULE_NAME$5 = "no-dot-ts-imports";
 const noDotTsImport = createEslintRule({
   create(context) {
     return {
@@ -1289,10 +1318,10 @@ const noDotTsImport = createEslintRule({
     schema: [],
     type: "problem"
   },
-  name: RULE_NAME$4
+  name: RULE_NAME$5
 });
 
-const RULE_NAME$3 = "no-legacy-library-import";
+const RULE_NAME$4 = "no-legacy-library-import";
 const legacyLibrary = "@rotki/ui-library-compat";
 const newLibrary = "@rotki/ui-library";
 const noLegacyLibraryImport = createEslintRule({
@@ -1325,11 +1354,11 @@ const noLegacyLibraryImport = createEslintRule({
     schema: [],
     type: "problem"
   },
-  name: RULE_NAME$3
+  name: RULE_NAME$4
 });
 
-const RULE_NAME$2 = "no-redundant-flex-row";
-const debug$3 = debugFactory("@rotki/eslint-plugin:no-redundant-flex-row");
+const RULE_NAME$3 = "no-redundant-flex-row";
+const debug$4 = debugFactory("@rotki/eslint-plugin:no-redundant-flex-row");
 function stripImportant(token) {
   return token.replace(/^!/, "").replace(/!$/, "");
 }
@@ -1374,7 +1403,7 @@ function reportRedundant(source, context, sourceCode) {
   for (const token of tokens) {
     if (!isFlexRow(token.text))
       continue;
-    debug$3(`found redundant flex-row token '${token.text}'`);
+    debug$4(`found redundant flex-row token '${token.text}'`);
     const tokenRange = [
       source.contentStart + token.start,
       source.contentStart + token.start + token.text.length
@@ -1438,6 +1467,148 @@ const noRedundantFlexRow = createEslintRule({
     schema: [],
     type: "suggestion"
   },
+  name: RULE_NAME$3
+});
+
+const RULE_NAME$2 = "no-shared-pinia";
+const debug$3 = debugFactory("@rotki/eslint-plugin:no-shared-pinia");
+const DESCRIBE_NAMES = /* @__PURE__ */ new Set(["describe", "fdescribe", "xdescribe", "suite"]);
+const BEFORE_EACH_NAMES = /* @__PURE__ */ new Set(["beforeEach"]);
+const DEFAULT_FACTORIES = ["createPinia", "createCustomPinia", "createTestingPinia"];
+const DEFAULT_TEST_FILE_PATTERN = "\\.(spec|test)\\.[cm]?[jt]sx?$";
+function isFunctionNode(node) {
+  return node.type === "FunctionDeclaration" || node.type === "FunctionExpression" || node.type === "ArrowFunctionExpression";
+}
+function getRootCalleeName(callee) {
+  if (callee.type === "Identifier")
+    return callee.name;
+  if (callee.type === "MemberExpression")
+    return getRootCalleeName(callee.object);
+  if (callee.type === "CallExpression")
+    return getRootCalleeName(callee.callee);
+  return null;
+}
+function callbackOwnerName(fn) {
+  const parent = fn.parent;
+  if (!parent || parent.type !== "CallExpression")
+    return null;
+  return getRootCalleeName(parent.callee);
+}
+function isBeforeEachCallback(fn) {
+  const owner = callbackOwnerName(fn);
+  return owner != null && BEFORE_EACH_NAMES.has(owner);
+}
+function isDescribeCallback(fn) {
+  const owner = callbackOwnerName(fn);
+  return owner != null && DESCRIBE_NAMES.has(owner);
+}
+function nearestFunction(node) {
+  let current = node.parent;
+  while (current) {
+    if (isFunctionNode(current))
+      return current;
+    current = current.parent;
+  }
+  return null;
+}
+function buildTestFileMatcher(pattern) {
+  const regex = new RegExp(pattern, "u");
+  return (filename) => regex.test(filename);
+}
+const noSharedPinia = createEslintRule({
+  create(context, optionsWithDefault) {
+    const options = optionsWithDefault[0] ?? {};
+    const factories = new Set(options.factories ?? DEFAULT_FACTORIES);
+    const isTestFile = buildTestFileMatcher(options.testFilePattern ?? DEFAULT_TEST_FILE_PATTERN);
+    const filename = getFilename(context);
+    if (!isTestFile(filename)) {
+      debug$3(`skipping non-test file '${filename}'`);
+      return {};
+    }
+    let program = null;
+    const candidates = [];
+    const freshContainers = /* @__PURE__ */ new Set();
+    return {
+      CallExpression(node) {
+        const name = getRootCalleeName(node.callee);
+        if (name == null || !factories.has(name) || program == null)
+          return;
+        const enclosing = nearestFunction(node);
+        if (enclosing != null && isBeforeEachCallback(enclosing)) {
+          freshContainers.add(nearestFunction(enclosing) ?? program);
+          return;
+        }
+        if (enclosing != null && !isDescribeCallback(enclosing))
+          return;
+        candidates.push({
+          atModuleScope: enclosing == null,
+          container: enclosing ?? program,
+          factory: name,
+          node
+        });
+      },
+      Program(node) {
+        program = node;
+      },
+      "Program:exit": function() {
+        const isProtected = (container) => {
+          let current = container;
+          while (current != null) {
+            if (freshContainers.has(current))
+              return true;
+            if (current.type === "Program")
+              break;
+            current = nearestFunction(current) ?? program;
+          }
+          return false;
+        };
+        for (const candidate of candidates) {
+          if (isProtected(candidate.container))
+            continue;
+          debug$3(`found shared pinia via '${candidate.factory}' ${candidate.atModuleScope ? "at module scope" : "in describe body"}`);
+          context.report({
+            data: {
+              factory: candidate.factory,
+              location: candidate.atModuleScope ? "at module scope" : "in the `describe` body"
+            },
+            messageId: "sharedPinia",
+            node: candidate.node
+          });
+        }
+      }
+    };
+  },
+  defaultOptions: [
+    {
+      factories: DEFAULT_FACTORIES,
+      testFilePattern: DEFAULT_TEST_FILE_PATTERN
+    }
+  ],
+  meta: {
+    docs: {
+      description: "disallow a Pinia instance shared across tests via `describe`-body or module scope",
+      recommendation: "recommended"
+    },
+    messages: {
+      sharedPinia: "`{{ factory }}()` is called {{ location }}, so the Pinia instance is shared across every test and store state leaks between them. Create a fresh instance per test with `beforeEach(() => setActivePinia(createPinia()))`, or add an inline disable if the shared instance is intentional."
+    },
+    schema: [
+      {
+        additionalProperties: false,
+        properties: {
+          factories: {
+            items: { type: "string" },
+            type: "array"
+          },
+          testFilePattern: {
+            type: "string"
+          }
+        },
+        type: "object"
+      }
+    ],
+    type: "problem"
+  },
   name: RULE_NAME$2
 });
 
@@ -2093,6 +2264,7 @@ const plugin = {
     "no-dot-ts-imports": noDotTsImport,
     "no-legacy-library-import": noLegacyLibraryImport,
     "no-redundant-flex-row": noRedundantFlexRow,
+    "no-shared-pinia": noSharedPinia,
     "no-unused-i18n-keys": noUnusedI18nKeys,
     "require-jsdoc-on-composable-options": requireJsdocOnComposableOptions
   }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@rotki/eslint-plugin",
-  "version": "1.4.0",
+  "version": "1.5.0",
   "type": "module",
   "license": "AGPL-3.0",
   "bugs": {
@@ -28,37 +28,37 @@
     "eslint": "^9.20.0 || ^10.0.0"
   },
   "dependencies": {
-    "@typescript-eslint/utils": "8.60.1",
+    "@typescript-eslint/utils": "8.64.0",
     "debug": "4.4.3",
     "jsonc-eslint-parser": "3.1.0",
     "scule": "1.3.0",
     "tinyglobby": "0.2.17",
     "vue-eslint-parser": "10.4.1",
-    "yaml-eslint-parser": "2.0.0"
+    "yaml-eslint-parser": "2.1.0"
   },
   "devDependencies": {
-    "@commitlint/cli": "21.0.2",
-    "@commitlint/config-conventional": "21.0.2",
-    "@rotki/eslint-config": "6.1.0",
-    "@rotki/eslint-plugin": "1.3.2",
+    "@commitlint/cli": "21.2.1",
+    "@commitlint/config-conventional": "21.2.0",
+    "@rotki/eslint-config": "6.2.0",
+    "@rotki/eslint-plugin": "1.4.0",
     "@types/debug": "4.1.13",
-    "@types/node": "24.13.1",
-    "@typescript-eslint/eslint-plugin": "8.60.1",
-    "@typescript-eslint/parser": "8.60.1",
-    "@typescript-eslint/rule-tester": "8.60.1",
-    "@vitest/coverage-v8": "4.1.8",
+    "@types/node": "24.13.3",
+    "@typescript-eslint/eslint-plugin": "8.64.0",
+    "@typescript-eslint/parser": "8.64.0",
+    "@typescript-eslint/rule-tester": "8.64.0",
+    "@vitest/coverage-v8": "4.1.10",
     "bumpp": "11.1.0",
-    "eslint": "10.4.1",
+    "eslint": "10.7.0",
     "husky": "9.1.7",
-    "lint-staged": "17.0.7",
-    "oxc-minify": "0.135.0",
-    "prettier": "3.8.1",
+    "lint-staged": "17.0.8",
+    "oxc-minify": "0.140.0",
+    "prettier": "3.9.5",
     "rimraf": "6.1.3",
-    "tsx": "4.22.4",
+    "tsx": "4.23.1",
     "typescript": "6.0.3",
     "unbuild": "3.6.1",
-    "vitepress": "2.0.0-alpha.17",
-    "vitest": "4.1.8"
+    "vitepress": "2.0.0-alpha.18",
+    "vitest": "4.1.10"
   },
   "engines": {
     "node": ">=24 <25",