@rotki/eslint-plugin 0.3.2 → 0.5.0

package/dist/index.cjs

@@ -4,6 +4,7 @@ const createDebug = require('debug');
 const node_path = require('node:path');
 const compat = require('eslint-compat-utils');
 const scule = require('scule');
+const utils = require('@typescript-eslint/utils');
 
 function _interopDefaultCompat (e) { return e && typeof e === 'object' && 'default' in e ? e.default : e; }
 
@@ -23,8 +24,8 @@ const createDebug__default = /*#__PURE__*/_interopDefaultCompat(createDebug);
 const compat__namespace = /*#__PURE__*/_interopNamespaceCompat(compat);
 
 const name = "@rotki/eslint-plugin";
-const version = "0.3.2";
-const packageManager = "pnpm@8.15.0";
+const version = "0.5.0";
+const packageManager = "pnpm@9.7.0";
 const type = "module";
 const license = "AGPL-3.0";
 const bugs = {
@@ -63,48 +64,48 @@ const scripts = {
 	"new": "node --experimental-specifier-resolution=node --loader ts-node/esm ./scripts/new-rule.ts",
 	docs: "vitepress dev docs",
 	"docs:build": "pnpm run generate && vitepress build docs",
-	prepare: "husky install",
+	prepare: "husky",
 	typecheck: "tsc --noEmit",
 	release: "bumpp -r --no-push"
 };
 const peerDependencies = {
-	eslint: "^8.0.0 || ^9.0.0"
+	eslint: "^9.0.0"
 };
 const dependencies = {
-	"@typescript-eslint/utils": "6.19.1",
-	debug: "4.3.4",
-	"eslint-compat-utils": "0.4.1",
+	"@typescript-eslint/utils": "8.1.0",
+	debug: "4.3.6",
+	"eslint-compat-utils": "0.5.1",
 	"jsonc-eslint-parser": "2.4.0",
-	scule: "1.2.0",
-	"vue-eslint-parser": "9.4.2",
-	"yaml-eslint-parser": "1.2.2"
+	scule: "1.3.0",
+	"vue-eslint-parser": "9.4.3",
+	"yaml-eslint-parser": "1.2.3"
 };
 const devDependencies = {
-	"@commitlint/cli": "18.6.0",
-	"@commitlint/config-conventional": "18.6.0",
-	"@rotki/eslint-config": "2.4.4",
+	"@commitlint/cli": "19.4.0",
+	"@commitlint/config-conventional": "19.2.2",
+	"@rotki/eslint-config": "3.0.0",
 	"@types/debug": "4.1.12",
-	"@types/eslint": "8.56.2",
+	"@types/eslint": "9.6.0",
 	"@types/node": "20",
-	"@typescript-eslint/eslint-plugin": "6.19.1",
-	"@typescript-eslint/parser": "6.19.1",
-	"@typescript-eslint/rule-tester": "6.19.1",
-	"@vitest/coverage-v8": "^1.2.2",
-	bumpp: "9.3.0",
-	debug: "4.3.4",
-	eslint: "8.56.0",
-	husky: "9.0.7",
-	"lint-staged": "15.2.0",
-	rimraf: "5.0.5",
+	"@typescript-eslint/eslint-plugin": "8.1.0",
+	"@typescript-eslint/parser": "8.1.0",
+	"@typescript-eslint/rule-tester": "8.1.0",
+	"@vitest/coverage-v8": "2.0.5",
+	bumpp: "9.5.1",
+	debug: "4.3.6",
+	eslint: "9.9.0",
+	husky: "9.1.4",
+	"lint-staged": "15.2.9",
+	rimraf: "6.0.1",
 	"ts-node": "10.9.2",
-	typescript: "5.3.3",
+	typescript: "5.5.4",
 	unbuild: "2.0.0",
-	vitepress: "1.0.0-rc.40",
-	vitest: "1.2.2"
+	vitepress: "1.3.2",
+	vitest: "2.0.5"
 };
 const engines = {
 	node: ">=20",
-	pnpm: ">=8 <9"
+	pnpm: ">=9 <10"
 };
 const pkg = {
 	name: name,
@@ -181,6 +182,8 @@ const createEslintRule = RuleCreator(
 function defineTemplateBodyVisitor(context, templateBodyVisitor, scriptVisitor, options) {
   const sourceCode = getSourceCode(context);
   const parserServices = sourceCode.parserServices;
+  if (!parserServices)
+    throw new Error("missing parserServices");
   if (!("defineTemplateBodyVisitor" in parserServices) || parserServices.defineTemplateBodyVisitor == null) {
     const filename = getFilename(context);
     if (node_path.extname(filename) === ".vue") {
@@ -211,8 +214,9 @@ function getStringLiteralValue(node, stringOnly = false) {
       return String(node.value);
     return null;
   }
-  if (node.type === "TemplateLiteral" && node.expressions.length === 0 && node.quasis.length === 1)
+  if (node.type === "TemplateLiteral" && node.expressions.length === 0 && node.quasis.length === 1) {
     return node.quasis[0].value.cooked;
+  }
   return null;
 }
 function getStaticPropertyName(node) {
@@ -254,8 +258,8 @@ function createRecommended(plugin, name, flat) {
   }
 }
 
-const RULE_NAME$3 = "no-deprecated-classes";
-const debug$2 = createDebug__default("@rotki/eslint-plugin:no-deprecated-classes");
+const RULE_NAME$4 = "no-deprecated-classes";
+const debug$3 = createDebug__default("@rotki/eslint-plugin:no-deprecated-classes");
 const replacements$2 = [
   ["d-block", "block"],
   ["d-flex", "flex"],
@@ -315,7 +319,7 @@ function getRange(node) {
   return node.range;
 }
 function reportReplacement(className, replacement, node, context, position = 1) {
-  debug$2(`found replacement ${replacement} for ${className}`);
+  debug$3(`found replacement ${replacement} for ${className}`);
   const source = getSourceCode(context);
   const initialRange = getRange(node);
   const range = [
@@ -419,7 +423,7 @@ const noDeprecatedClasses = createEslintRule({
   meta: {
     docs: {
       description: "disallow the usage of vuetify css classes since they are replaced with tailwindcss",
-      recommended: "recommended"
+      recommendation: "recommended"
     },
     fixable: "code",
     messages: {
@@ -428,11 +432,11 @@ const noDeprecatedClasses = createEslintRule({
     schema: [],
     type: "problem"
   },
-  name: RULE_NAME$3
+  name: RULE_NAME$4
 });
 
-const debug$1 = createDebug__default("@rotki/eslint-plugin:no-deprecated-components");
-const RULE_NAME$2 = "no-deprecated-components";
+const debug$2 = createDebug__default("@rotki/eslint-plugin:no-deprecated-components");
+const RULE_NAME$3 = "no-deprecated-components";
 const vuetify = {
   VApp: true,
   VAppBar: true,
@@ -479,13 +483,13 @@ const noDeprecatedComponents = createEslintRule({
       VElement(element) {
         const tag = scule.pascalCase(element.rawName);
         const sourceCode = getSourceCode(context);
-        if (!("getTemplateBodyTokenStore" in sourceCode.parserServices))
+        if (sourceCode?.parserServices && !("getTemplateBodyTokenStore" in sourceCode.parserServices))
           throw new Error("cannot find getTemplateBodyTokenStore in parserServices");
         if (!hasReplacement$1(tag))
           return;
         const replacement = replacements$1[tag];
         if (replacement || legacy && skipInLegacy.includes(tag)) {
-          debug$1(`${tag} has been deprecated`);
+          debug$2(`${tag} has been deprecated`);
           context.report({
             data: {
               name: tag
@@ -494,7 +498,7 @@ const noDeprecatedComponents = createEslintRule({
             node: element
           });
         } else {
-          debug$1(`${tag} has will be removed`);
+          debug$2(`${tag} has will be removed`);
           context.report({
             data: {
               name: tag
@@ -516,7 +520,7 @@ const noDeprecatedComponents = createEslintRule({
   meta: {
     docs: {
       description: "Removes deprecated classes that do not exist anymore",
-      recommended: "recommended"
+      recommendation: "recommended"
     },
     fixable: "code",
     messages: {
@@ -537,11 +541,11 @@ const noDeprecatedComponents = createEslintRule({
     ],
     type: "problem"
   },
-  name: RULE_NAME$2
+  name: RULE_NAME$3
 });
 
-const debug = createDebug__default("@rotki/eslint-plugin:no-deprecated-props");
-const RULE_NAME$1 = "no-deprecated-props";
+const debug$1 = createDebug__default("@rotki/eslint-plugin:no-deprecated-props");
+const RULE_NAME$2 = "no-deprecated-props";
 const replacements = {
   RuiRadio: {
     internalValue: "value"
@@ -567,16 +571,16 @@ const noDeprecatedProps = createEslintRule({
         const tag = scule.pascalCase(node.parent.parent.rawName);
         if (!hasReplacement(tag))
           return;
-        debug(`${tag} has replacement properties`);
+        debug$1(`${tag} has replacement properties`);
         const propName = getPropName(node);
         const propNameNode = node.directive ? node.key.argument : node.key;
         if (!propName || !propNameNode) {
-          debug("could not get prop name and/or node");
+          debug$1("could not get prop name and/or node");
           return;
         }
         Object.entries(replacements[tag]).forEach(([prop, replacement]) => {
           if (scule.kebabCase(prop) === propName) {
-            debug(`preparing a replacement for ${tag}:${propName} -> ${replacement}`);
+            debug$1(`preparing a replacement for ${tag}:${propName} -> ${replacement}`);
             context.report({
               data: {
                 prop,
@@ -605,10 +609,10 @@ const noDeprecatedProps = createEslintRule({
     schema: [],
     type: "problem"
   },
-  name: RULE_NAME$1
+  name: RULE_NAME$2
 });
 
-const RULE_NAME = "no-legacy-library-import";
+const RULE_NAME$1 = "no-legacy-library-import";
 const legacyLibrary = "@rotki/ui-library-compat";
 const newLibrary = "@rotki/ui-library";
 const noLegacyLibraryImport = createEslintRule({
@@ -640,6 +644,105 @@ const noLegacyLibraryImport = createEslintRule({
     schema: [],
     type: "problem"
   },
+  name: RULE_NAME$1
+});
+
+const debug = createDebug__default("@rotki/eslint-plugin:consistent-ref-type-annotation");
+const RULE_NAME = "consistent-ref-type-annotation";
+const FIXABLE_METHODS = ["ref", "computed"];
+function checkAssignmentDeclaration(context, node, declaration, options) {
+  const source = getSourceCode(context);
+  const { allowInference } = options;
+  let declarationTypeArguments;
+  const init = declaration.init;
+  if (!(init && init.type === utils.TSESTree.AST_NODE_TYPES.CallExpression))
+    return;
+  const callee = init.callee;
+  if (!(callee && callee.type === utils.TSESTree.AST_NODE_TYPES.Identifier))
+    return;
+  if (!Array.prototype.includes.call(FIXABLE_METHODS, callee.name))
+    return;
+  const name = callee.name;
+  debug(`found ${name}, checking type arguments`);
+  const initializationTypeArguments = init.typeArguments;
+  const typeAnnotation = declaration.id.typeAnnotation;
+  if (typeAnnotation) {
+    const typeNode = typeAnnotation.typeAnnotation;
+    if (typeNode && typeNode.type === utils.TSESTree.AST_NODE_TYPES.TSTypeReference)
+      declarationTypeArguments = typeNode.typeArguments;
+  }
+  if (initializationTypeArguments && !declarationTypeArguments)
+    return;
+  debug(`generating report for ${name}`);
+  if (!initializationTypeArguments && !declarationTypeArguments) {
+    if (allowInference) {
+      debug("type inference is allowed");
+    } else {
+      context.report({
+        data: {
+          name
+        },
+        messageId: "missingType",
+        node
+      });
+    }
+    return;
+  }
+  context.report({
+    data: {
+      name
+    },
+    fix(fixer) {
+      const fixes = [];
+      if (!initializationTypeArguments && callee)
+        fixes.push(fixer.insertTextAfter(callee, source.getText(declarationTypeArguments)));
+      if (typeAnnotation)
+        fixes.push(fixer.remove(typeAnnotation));
+      return fixes;
+    },
+    messageId: "inconsistent",
+    node
+  });
+}
+const consistentRefTypeAnnotation = createEslintRule({
+  create(context, optionsWithDefault) {
+    const options = optionsWithDefault[0] || {};
+    const allowInference = options.allowInference;
+    return {
+      VariableDeclaration: (node) => {
+        const declarations = node.declarations;
+        for (const declaration of declarations) {
+          if (declaration.type !== utils.TSESTree.AST_NODE_TYPES.VariableDeclarator)
+            continue;
+          checkAssignmentDeclaration(context, node, declaration, { allowInference });
+        }
+      }
+    };
+  },
+  defaultOptions: [{ allowInference: false }],
+  meta: {
+    docs: {
+      description: "Ensures consistent type annotation position for ref, computed assignments",
+      recommendation: "recommended"
+    },
+    fixable: "code",
+    messages: {
+      inconsistent: `Generic type annotation for the {{ name }} call was not on the right side`,
+      missingType: `variable assignment for {{ name }} is missing the type annotation`
+    },
+    schema: [
+      {
+        additionalProperties: false,
+        properties: {
+          allowInference: {
+            type: "boolean"
+          }
+        },
+        type: "object"
+      }
+    ],
+    type: "problem"
+  },
   name: RULE_NAME
 });
 
@@ -649,6 +752,7 @@ const plugin = {
     version: pkg.version
   },
   rules: {
+    "consistent-ref-type-annotation": consistentRefTypeAnnotation,
     "no-deprecated-classes": noDeprecatedClasses,
     "no-deprecated-components": noDeprecatedComponents,
     "no-deprecated-props": noDeprecatedProps,

package/dist/index.d.cts

@@ -4,18 +4,23 @@ interface PluginRuleModule<TOptions extends readonly unknown[] = []> extends Rul
     defaultOptions: TOptions;
 }
 
-type Options = [{
+type Options$1 = [{
     legacy: boolean;
 }];
 
+type Options = [{
+    allowInference: boolean;
+}];
+
 declare const plugin: {
     meta: {
         name: string;
         version: string;
     };
     rules: {
+        'consistent-ref-type-annotation': PluginRuleModule<Options>;
         'no-deprecated-classes': PluginRuleModule<[]>;
-        'no-deprecated-components': PluginRuleModule<Options>;
+        'no-deprecated-components': PluginRuleModule<Options$1>;
         'no-deprecated-props': PluginRuleModule<[]>;
         'no-legacy-library-import': PluginRuleModule<[]>;
     };
@@ -27,8 +32,9 @@ declare const _default: {
         version: string;
     };
     rules: {
+        'consistent-ref-type-annotation': PluginRuleModule<Options>;
         'no-deprecated-classes': PluginRuleModule<[]>;
-        'no-deprecated-components': PluginRuleModule<Options>;
+        'no-deprecated-components': PluginRuleModule<Options$1>;
         'no-deprecated-props': PluginRuleModule<[]>;
         'no-legacy-library-import': PluginRuleModule<[]>;
     };
@@ -42,8 +48,9 @@ declare const _default: {
                         version: string;
                     };
                     rules: {
+                        'consistent-ref-type-annotation': PluginRuleModule<Options>;
                         'no-deprecated-classes': PluginRuleModule<[]>;
-                        'no-deprecated-components': PluginRuleModule<Options>;
+                        'no-deprecated-components': PluginRuleModule<Options$1>;
                         'no-deprecated-props': PluginRuleModule<[]>;
                         'no-legacy-library-import': PluginRuleModule<[]>;
                     };
@@ -66,8 +73,9 @@ declare const _default: {
                         version: string;
                     };
                     rules: {
+                        'consistent-ref-type-annotation': PluginRuleModule<Options>;
                         'no-deprecated-classes': PluginRuleModule<[]>;
-                        'no-deprecated-components': PluginRuleModule<Options>;
+                        'no-deprecated-components': PluginRuleModule<Options$1>;
                         'no-deprecated-props': PluginRuleModule<[]>;
                         'no-legacy-library-import': PluginRuleModule<[]>;
                     };

package/dist/index.d.mts

@@ -4,18 +4,23 @@ interface PluginRuleModule<TOptions extends readonly unknown[] = []> extends Rul
     defaultOptions: TOptions;
 }
 
-type Options = [{
+type Options$1 = [{
     legacy: boolean;
 }];
 
+type Options = [{
+    allowInference: boolean;
+}];
+
 declare const plugin: {
     meta: {
         name: string;
         version: string;
     };
     rules: {
+        'consistent-ref-type-annotation': PluginRuleModule<Options>;
         'no-deprecated-classes': PluginRuleModule<[]>;
-        'no-deprecated-components': PluginRuleModule<Options>;
+        'no-deprecated-components': PluginRuleModule<Options$1>;
         'no-deprecated-props': PluginRuleModule<[]>;
         'no-legacy-library-import': PluginRuleModule<[]>;
     };
@@ -27,8 +32,9 @@ declare const _default: {
         version: string;
     };
     rules: {
+        'consistent-ref-type-annotation': PluginRuleModule<Options>;
         'no-deprecated-classes': PluginRuleModule<[]>;
-        'no-deprecated-components': PluginRuleModule<Options>;
+        'no-deprecated-components': PluginRuleModule<Options$1>;
         'no-deprecated-props': PluginRuleModule<[]>;
         'no-legacy-library-import': PluginRuleModule<[]>;
     };
@@ -42,8 +48,9 @@ declare const _default: {
                         version: string;
                     };
                     rules: {
+                        'consistent-ref-type-annotation': PluginRuleModule<Options>;
                         'no-deprecated-classes': PluginRuleModule<[]>;
-                        'no-deprecated-components': PluginRuleModule<Options>;
+                        'no-deprecated-components': PluginRuleModule<Options$1>;
                         'no-deprecated-props': PluginRuleModule<[]>;
                         'no-legacy-library-import': PluginRuleModule<[]>;
                     };
@@ -66,8 +73,9 @@ declare const _default: {
                         version: string;
                     };
                     rules: {
+                        'consistent-ref-type-annotation': PluginRuleModule<Options>;
                         'no-deprecated-classes': PluginRuleModule<[]>;
-                        'no-deprecated-components': PluginRuleModule<Options>;
+                        'no-deprecated-components': PluginRuleModule<Options$1>;
                         'no-deprecated-props': PluginRuleModule<[]>;
                         'no-legacy-library-import': PluginRuleModule<[]>;
                     };

package/dist/index.d.ts

@@ -4,18 +4,23 @@ interface PluginRuleModule<TOptions extends readonly unknown[] = []> extends Rul
     defaultOptions: TOptions;
 }
 
-type Options = [{
+type Options$1 = [{
     legacy: boolean;
 }];
 
+type Options = [{
+    allowInference: boolean;
+}];
+
 declare const plugin: {
     meta: {
         name: string;
         version: string;
     };
     rules: {
+        'consistent-ref-type-annotation': PluginRuleModule<Options>;
         'no-deprecated-classes': PluginRuleModule<[]>;
-        'no-deprecated-components': PluginRuleModule<Options>;
+        'no-deprecated-components': PluginRuleModule<Options$1>;
         'no-deprecated-props': PluginRuleModule<[]>;
         'no-legacy-library-import': PluginRuleModule<[]>;
     };
@@ -27,8 +32,9 @@ declare const _default: {
         version: string;
     };
     rules: {
+        'consistent-ref-type-annotation': PluginRuleModule<Options>;
         'no-deprecated-classes': PluginRuleModule<[]>;
-        'no-deprecated-components': PluginRuleModule<Options>;
+        'no-deprecated-components': PluginRuleModule<Options$1>;
         'no-deprecated-props': PluginRuleModule<[]>;
         'no-legacy-library-import': PluginRuleModule<[]>;
     };
@@ -42,8 +48,9 @@ declare const _default: {
                         version: string;
                     };
                     rules: {
+                        'consistent-ref-type-annotation': PluginRuleModule<Options>;
                         'no-deprecated-classes': PluginRuleModule<[]>;
-                        'no-deprecated-components': PluginRuleModule<Options>;
+                        'no-deprecated-components': PluginRuleModule<Options$1>;
                         'no-deprecated-props': PluginRuleModule<[]>;
                         'no-legacy-library-import': PluginRuleModule<[]>;
                     };
@@ -66,8 +73,9 @@ declare const _default: {
                         version: string;
                     };
                     rules: {
+                        'consistent-ref-type-annotation': PluginRuleModule<Options>;
                         'no-deprecated-classes': PluginRuleModule<[]>;
-                        'no-deprecated-components': PluginRuleModule<Options>;
+                        'no-deprecated-components': PluginRuleModule<Options$1>;
                         'no-deprecated-props': PluginRuleModule<[]>;
                         'no-legacy-library-import': PluginRuleModule<[]>;
                     };

package/dist/index.mjs

@@ -2,10 +2,11 @@ import createDebug from 'debug';
 import { extname } from 'node:path';
 import * as compat from 'eslint-compat-utils';
 import { pascalCase, kebabCase } from 'scule';
+import { TSESTree } from '@typescript-eslint/utils';
 
 const name = "@rotki/eslint-plugin";
-const version = "0.3.2";
-const packageManager = "pnpm@8.15.0";
+const version = "0.5.0";
+const packageManager = "pnpm@9.7.0";
 const type = "module";
 const license = "AGPL-3.0";
 const bugs = {
@@ -44,48 +45,48 @@ const scripts = {
 	"new": "node --experimental-specifier-resolution=node --loader ts-node/esm ./scripts/new-rule.ts",
 	docs: "vitepress dev docs",
 	"docs:build": "pnpm run generate && vitepress build docs",
-	prepare: "husky install",
+	prepare: "husky",
 	typecheck: "tsc --noEmit",
 	release: "bumpp -r --no-push"
 };
 const peerDependencies = {
-	eslint: "^8.0.0 || ^9.0.0"
+	eslint: "^9.0.0"
 };
 const dependencies = {
-	"@typescript-eslint/utils": "6.19.1",
-	debug: "4.3.4",
-	"eslint-compat-utils": "0.4.1",
+	"@typescript-eslint/utils": "8.1.0",
+	debug: "4.3.6",
+	"eslint-compat-utils": "0.5.1",
 	"jsonc-eslint-parser": "2.4.0",
-	scule: "1.2.0",
-	"vue-eslint-parser": "9.4.2",
-	"yaml-eslint-parser": "1.2.2"
+	scule: "1.3.0",
+	"vue-eslint-parser": "9.4.3",
+	"yaml-eslint-parser": "1.2.3"
 };
 const devDependencies = {
-	"@commitlint/cli": "18.6.0",
-	"@commitlint/config-conventional": "18.6.0",
-	"@rotki/eslint-config": "2.4.4",
+	"@commitlint/cli": "19.4.0",
+	"@commitlint/config-conventional": "19.2.2",
+	"@rotki/eslint-config": "3.0.0",
 	"@types/debug": "4.1.12",
-	"@types/eslint": "8.56.2",
+	"@types/eslint": "9.6.0",
 	"@types/node": "20",
-	"@typescript-eslint/eslint-plugin": "6.19.1",
-	"@typescript-eslint/parser": "6.19.1",
-	"@typescript-eslint/rule-tester": "6.19.1",
-	"@vitest/coverage-v8": "^1.2.2",
-	bumpp: "9.3.0",
-	debug: "4.3.4",
-	eslint: "8.56.0",
-	husky: "9.0.7",
-	"lint-staged": "15.2.0",
-	rimraf: "5.0.5",
+	"@typescript-eslint/eslint-plugin": "8.1.0",
+	"@typescript-eslint/parser": "8.1.0",
+	"@typescript-eslint/rule-tester": "8.1.0",
+	"@vitest/coverage-v8": "2.0.5",
+	bumpp: "9.5.1",
+	debug: "4.3.6",
+	eslint: "9.9.0",
+	husky: "9.1.4",
+	"lint-staged": "15.2.9",
+	rimraf: "6.0.1",
 	"ts-node": "10.9.2",
-	typescript: "5.3.3",
+	typescript: "5.5.4",
 	unbuild: "2.0.0",
-	vitepress: "1.0.0-rc.40",
-	vitest: "1.2.2"
+	vitepress: "1.3.2",
+	vitest: "2.0.5"
 };
 const engines = {
 	node: ">=20",
-	pnpm: ">=8 <9"
+	pnpm: ">=9 <10"
 };
 const pkg = {
 	name: name,
@@ -162,6 +163,8 @@ const createEslintRule = RuleCreator(
 function defineTemplateBodyVisitor(context, templateBodyVisitor, scriptVisitor, options) {
   const sourceCode = getSourceCode(context);
   const parserServices = sourceCode.parserServices;
+  if (!parserServices)
+    throw new Error("missing parserServices");
   if (!("defineTemplateBodyVisitor" in parserServices) || parserServices.defineTemplateBodyVisitor == null) {
     const filename = getFilename(context);
     if (extname(filename) === ".vue") {
@@ -192,8 +195,9 @@ function getStringLiteralValue(node, stringOnly = false) {
       return String(node.value);
     return null;
   }
-  if (node.type === "TemplateLiteral" && node.expressions.length === 0 && node.quasis.length === 1)
+  if (node.type === "TemplateLiteral" && node.expressions.length === 0 && node.quasis.length === 1) {
     return node.quasis[0].value.cooked;
+  }
   return null;
 }
 function getStaticPropertyName(node) {
@@ -235,8 +239,8 @@ function createRecommended(plugin, name, flat) {
   }
 }
 
-const RULE_NAME$3 = "no-deprecated-classes";
-const debug$2 = createDebug("@rotki/eslint-plugin:no-deprecated-classes");
+const RULE_NAME$4 = "no-deprecated-classes";
+const debug$3 = createDebug("@rotki/eslint-plugin:no-deprecated-classes");
 const replacements$2 = [
   ["d-block", "block"],
   ["d-flex", "flex"],
@@ -296,7 +300,7 @@ function getRange(node) {
   return node.range;
 }
 function reportReplacement(className, replacement, node, context, position = 1) {
-  debug$2(`found replacement ${replacement} for ${className}`);
+  debug$3(`found replacement ${replacement} for ${className}`);
   const source = getSourceCode(context);
   const initialRange = getRange(node);
   const range = [
@@ -400,7 +404,7 @@ const noDeprecatedClasses = createEslintRule({
   meta: {
     docs: {
       description: "disallow the usage of vuetify css classes since they are replaced with tailwindcss",
-      recommended: "recommended"
+      recommendation: "recommended"
     },
     fixable: "code",
     messages: {
@@ -409,11 +413,11 @@ const noDeprecatedClasses = createEslintRule({
     schema: [],
     type: "problem"
   },
-  name: RULE_NAME$3
+  name: RULE_NAME$4
 });
 
-const debug$1 = createDebug("@rotki/eslint-plugin:no-deprecated-components");
-const RULE_NAME$2 = "no-deprecated-components";
+const debug$2 = createDebug("@rotki/eslint-plugin:no-deprecated-components");
+const RULE_NAME$3 = "no-deprecated-components";
 const vuetify = {
   VApp: true,
   VAppBar: true,
@@ -460,13 +464,13 @@ const noDeprecatedComponents = createEslintRule({
       VElement(element) {
         const tag = pascalCase(element.rawName);
         const sourceCode = getSourceCode(context);
-        if (!("getTemplateBodyTokenStore" in sourceCode.parserServices))
+        if (sourceCode?.parserServices && !("getTemplateBodyTokenStore" in sourceCode.parserServices))
           throw new Error("cannot find getTemplateBodyTokenStore in parserServices");
         if (!hasReplacement$1(tag))
           return;
         const replacement = replacements$1[tag];
         if (replacement || legacy && skipInLegacy.includes(tag)) {
-          debug$1(`${tag} has been deprecated`);
+          debug$2(`${tag} has been deprecated`);
           context.report({
             data: {
               name: tag
@@ -475,7 +479,7 @@ const noDeprecatedComponents = createEslintRule({
             node: element
           });
         } else {
-          debug$1(`${tag} has will be removed`);
+          debug$2(`${tag} has will be removed`);
           context.report({
             data: {
               name: tag
@@ -497,7 +501,7 @@ const noDeprecatedComponents = createEslintRule({
   meta: {
     docs: {
       description: "Removes deprecated classes that do not exist anymore",
-      recommended: "recommended"
+      recommendation: "recommended"
     },
     fixable: "code",
     messages: {
@@ -518,11 +522,11 @@ const noDeprecatedComponents = createEslintRule({
     ],
     type: "problem"
   },
-  name: RULE_NAME$2
+  name: RULE_NAME$3
 });
 
-const debug = createDebug("@rotki/eslint-plugin:no-deprecated-props");
-const RULE_NAME$1 = "no-deprecated-props";
+const debug$1 = createDebug("@rotki/eslint-plugin:no-deprecated-props");
+const RULE_NAME$2 = "no-deprecated-props";
 const replacements = {
   RuiRadio: {
     internalValue: "value"
@@ -548,16 +552,16 @@ const noDeprecatedProps = createEslintRule({
         const tag = pascalCase(node.parent.parent.rawName);
         if (!hasReplacement(tag))
           return;
-        debug(`${tag} has replacement properties`);
+        debug$1(`${tag} has replacement properties`);
         const propName = getPropName(node);
         const propNameNode = node.directive ? node.key.argument : node.key;
         if (!propName || !propNameNode) {
-          debug("could not get prop name and/or node");
+          debug$1("could not get prop name and/or node");
           return;
         }
         Object.entries(replacements[tag]).forEach(([prop, replacement]) => {
           if (kebabCase(prop) === propName) {
-            debug(`preparing a replacement for ${tag}:${propName} -> ${replacement}`);
+            debug$1(`preparing a replacement for ${tag}:${propName} -> ${replacement}`);
             context.report({
               data: {
                 prop,
@@ -586,10 +590,10 @@ const noDeprecatedProps = createEslintRule({
     schema: [],
     type: "problem"
   },
-  name: RULE_NAME$1
+  name: RULE_NAME$2
 });
 
-const RULE_NAME = "no-legacy-library-import";
+const RULE_NAME$1 = "no-legacy-library-import";
 const legacyLibrary = "@rotki/ui-library-compat";
 const newLibrary = "@rotki/ui-library";
 const noLegacyLibraryImport = createEslintRule({
@@ -621,6 +625,105 @@ const noLegacyLibraryImport = createEslintRule({
     schema: [],
     type: "problem"
   },
+  name: RULE_NAME$1
+});
+
+const debug = createDebug("@rotki/eslint-plugin:consistent-ref-type-annotation");
+const RULE_NAME = "consistent-ref-type-annotation";
+const FIXABLE_METHODS = ["ref", "computed"];
+function checkAssignmentDeclaration(context, node, declaration, options) {
+  const source = getSourceCode(context);
+  const { allowInference } = options;
+  let declarationTypeArguments;
+  const init = declaration.init;
+  if (!(init && init.type === TSESTree.AST_NODE_TYPES.CallExpression))
+    return;
+  const callee = init.callee;
+  if (!(callee && callee.type === TSESTree.AST_NODE_TYPES.Identifier))
+    return;
+  if (!Array.prototype.includes.call(FIXABLE_METHODS, callee.name))
+    return;
+  const name = callee.name;
+  debug(`found ${name}, checking type arguments`);
+  const initializationTypeArguments = init.typeArguments;
+  const typeAnnotation = declaration.id.typeAnnotation;
+  if (typeAnnotation) {
+    const typeNode = typeAnnotation.typeAnnotation;
+    if (typeNode && typeNode.type === TSESTree.AST_NODE_TYPES.TSTypeReference)
+      declarationTypeArguments = typeNode.typeArguments;
+  }
+  if (initializationTypeArguments && !declarationTypeArguments)
+    return;
+  debug(`generating report for ${name}`);
+  if (!initializationTypeArguments && !declarationTypeArguments) {
+    if (allowInference) {
+      debug("type inference is allowed");
+    } else {
+      context.report({
+        data: {
+          name
+        },
+        messageId: "missingType",
+        node
+      });
+    }
+    return;
+  }
+  context.report({
+    data: {
+      name
+    },
+    fix(fixer) {
+      const fixes = [];
+      if (!initializationTypeArguments && callee)
+        fixes.push(fixer.insertTextAfter(callee, source.getText(declarationTypeArguments)));
+      if (typeAnnotation)
+        fixes.push(fixer.remove(typeAnnotation));
+      return fixes;
+    },
+    messageId: "inconsistent",
+    node
+  });
+}
+const consistentRefTypeAnnotation = createEslintRule({
+  create(context, optionsWithDefault) {
+    const options = optionsWithDefault[0] || {};
+    const allowInference = options.allowInference;
+    return {
+      VariableDeclaration: (node) => {
+        const declarations = node.declarations;
+        for (const declaration of declarations) {
+          if (declaration.type !== TSESTree.AST_NODE_TYPES.VariableDeclarator)
+            continue;
+          checkAssignmentDeclaration(context, node, declaration, { allowInference });
+        }
+      }
+    };
+  },
+  defaultOptions: [{ allowInference: false }],
+  meta: {
+    docs: {
+      description: "Ensures consistent type annotation position for ref, computed assignments",
+      recommendation: "recommended"
+    },
+    fixable: "code",
+    messages: {
+      inconsistent: `Generic type annotation for the {{ name }} call was not on the right side`,
+      missingType: `variable assignment for {{ name }} is missing the type annotation`
+    },
+    schema: [
+      {
+        additionalProperties: false,
+        properties: {
+          allowInference: {
+            type: "boolean"
+          }
+        },
+        type: "object"
+      }
+    ],
+    type: "problem"
+  },
   name: RULE_NAME
 });
 
@@ -630,6 +733,7 @@ const plugin = {
     version: pkg.version
   },
   rules: {
+    "consistent-ref-type-annotation": consistentRefTypeAnnotation,
     "no-deprecated-classes": noDeprecatedClasses,
     "no-deprecated-components": noDeprecatedComponents,
     "no-deprecated-props": noDeprecatedProps,

package/package.json

@@ -1,7 +1,6 @@
 {
   "name": "@rotki/eslint-plugin",
-  "version": "0.3.2",
-  "packageManager": "pnpm@8.15.0",
+  "version": "0.5.0",
   "type": "module",
   "license": "AGPL-3.0",
   "bugs": {
@@ -27,43 +26,43 @@
   },
   "sideEffects": false,
   "peerDependencies": {
-    "eslint": "^8.0.0 || ^9.0.0"
+    "eslint": "^9.0.0"
   },
   "dependencies": {
-    "@typescript-eslint/utils": "6.19.1",
-    "debug": "4.3.4",
-    "eslint-compat-utils": "0.4.1",
+    "@typescript-eslint/utils": "8.1.0",
+    "debug": "4.3.6",
+    "eslint-compat-utils": "0.5.1",
     "jsonc-eslint-parser": "2.4.0",
-    "scule": "1.2.0",
-    "vue-eslint-parser": "9.4.2",
-    "yaml-eslint-parser": "1.2.2"
+    "scule": "1.3.0",
+    "vue-eslint-parser": "9.4.3",
+    "yaml-eslint-parser": "1.2.3"
   },
   "devDependencies": {
-    "@commitlint/cli": "18.6.0",
-    "@commitlint/config-conventional": "18.6.0",
-    "@rotki/eslint-config": "2.4.4",
+    "@commitlint/cli": "19.4.0",
+    "@commitlint/config-conventional": "19.2.2",
+    "@rotki/eslint-config": "3.0.0",
     "@types/debug": "4.1.12",
-    "@types/eslint": "8.56.2",
+    "@types/eslint": "9.6.0",
     "@types/node": "20",
-    "@typescript-eslint/eslint-plugin": "6.19.1",
-    "@typescript-eslint/parser": "6.19.1",
-    "@typescript-eslint/rule-tester": "6.19.1",
-    "@vitest/coverage-v8": "^1.2.2",
-    "bumpp": "9.3.0",
-    "debug": "4.3.4",
-    "eslint": "8.56.0",
-    "husky": "9.0.7",
-    "lint-staged": "15.2.0",
-    "rimraf": "5.0.5",
+    "@typescript-eslint/eslint-plugin": "8.1.0",
+    "@typescript-eslint/parser": "8.1.0",
+    "@typescript-eslint/rule-tester": "8.1.0",
+    "@vitest/coverage-v8": "2.0.5",
+    "bumpp": "9.5.1",
+    "debug": "4.3.6",
+    "eslint": "9.9.0",
+    "husky": "9.1.4",
+    "lint-staged": "15.2.9",
+    "rimraf": "6.0.1",
     "ts-node": "10.9.2",
-    "typescript": "5.3.3",
+    "typescript": "5.5.4",
     "unbuild": "2.0.0",
-    "vitepress": "1.0.0-rc.40",
-    "vitest": "1.2.2"
+    "vitepress": "1.3.2",
+    "vitest": "2.0.5"
   },
   "engines": {
     "node": ">=20",
-    "pnpm": ">=8 <9"
+    "pnpm": ">=9 <10"
   },
   "lint-staged": {
     "*.{js,cjs,ts,vue,yml,json,md}": "eslint"