@roots/bud-compiler 2023.7.18-452 → 2023.7.20-1957

package/lib/service.js

@@ -45,6 +45,7 @@ export class Compiler extends Service {
                 throw error;
             })));
         this.config.parallelism = Math.max(cpus().length - 1, 1);
+        this.logger.info(`parallel compilations: ${this.config.parallelism}`);
         await bud.hooks.fire(`compiler.before`, bud).catch(error => {
             throw error;
         });
@@ -69,6 +70,8 @@ export class Compiler extends Service {
      */
     onError(error) {
         process.exitCode = 1;
+        if (!error)
+            return;
         this.app.server?.appliedMiddleware?.hot?.publish({ error });
         this.app.notifier?.notify({
             group: this.app.label,
@@ -156,11 +159,34 @@ export class Compiler extends Service {
             const parseError = (error) => {
                 let file;
                 const moduleIdent = error.moduleId ?? error.moduleName;
-                const module = this.compilationStats.children
+                /**
+                 * In a perfect world webpack plugins would use the
+                 * `nameForCondition` property to identify the module.
+                 */
+                let module = this.compilationStats.children
                     .flatMap(child => child?.modules)
                     .find(module => module?.id === moduleIdent || module?.name === moduleIdent);
+                /**
+                 * If the module is not found, we try to parse the error message
+                 */
+                if (!moduleIdent) {
+                    const stylelintExtracted = error.message.match(/file:\/\/(.*)\x07(.*)\x1B]8;;/);
+                    if (stylelintExtracted?.[1]) {
+                        module = {
+                            name: stylelintExtracted[2] ?? stylelintExtracted[1],
+                            nameForCondition: stylelintExtracted[1],
+                        };
+                    }
+                }
+                /**
+                 * If the module is still not found, we return the error as-is
+                 */
                 if (!module)
                     return error;
+                /**
+                 * We'll prefer the `nameForCondition` property if it exists,
+                 * otherwise we'll use the `name` property.
+                 */
                 if (module.nameForCondition) {
                     file = module.nameForCondition;
                 }
@@ -174,8 +200,8 @@ export class Compiler extends Service {
             return errors?.map(parseError).filter(Boolean);
         }
         catch (error) {
-            this.app.warn(`error parsing errors`, error);
-            return [];
+            this.logger.warn(`error parsing errors`, error);
+            return errors;
         }
     }
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@roots/bud-compiler",
-  "version": "2023.7.18-452",
+  "version": "2023.7.20-1957",
   "description": "Compilation handler",
   "engines": {
     "node": ">=16"
@@ -61,15 +61,15 @@
   "types": "./lib/index.d.ts",
   "module": "./lib/index.js",
   "devDependencies": {
-    "@roots/bud-api": "2023.7.18-452",
+    "@roots/bud-api": "2023.7.20-1957",
     "@skypack/package-check": "0.2.2",
     "@types/node": "18.16.19",
     "@types/react": "18.2.15"
   },
   "dependencies": {
-    "@roots/bud-dashboard": "2023.7.18-452",
-    "@roots/bud-framework": "2023.7.18-452",
-    "@roots/bud-support": "2023.7.18-452",
+    "@roots/bud-dashboard": "2023.7.20-1957",
+    "@roots/bud-framework": "2023.7.20-1957",
+    "@roots/bud-support": "2023.7.20-1957",
     "react": "18.2.0",
     "tslib": "2.6.0"
   },

package/src/service.tsx

@@ -70,7 +70,9 @@ export class Compiler extends Service implements BudCompiler {
               }),
           ),
         )
+
     this.config.parallelism = Math.max(cpus().length - 1, 1)
+    this.logger.info(`parallel compilations: ${this.config.parallelism}`)
 
     await bud.hooks.fire(`compiler.before`, bud).catch(error => {
       throw error
@@ -87,7 +89,6 @@ export class Compiler extends Service implements BudCompiler {
 
     this.instance.hooks.done.tap(bud.label, (stats: any) => {
       this.onStats(stats)
-
       bud.hooks.fire(`compiler.done`, bud, this.stats).catch(error => {
         throw error
       })
@@ -102,6 +103,7 @@ export class Compiler extends Service implements BudCompiler {
   @bind
   public onError(error: BudErrorClass | webpack.WebpackError) {
     process.exitCode = 1
+    if (!error) return
 
     this.app.server?.appliedMiddleware?.hot?.publish({error})
 
@@ -158,6 +160,7 @@ export class Compiler extends Service implements BudCompiler {
               subtitle: error.file ? `Error in ${error.name}` : error.name,
               title: makeNoticeTitle(child),
             })
+
             this.app.notifier.openEditor(error.file)
           } catch (error) {
             this.logger.error(error)
@@ -214,15 +217,42 @@ export class Compiler extends Service implements BudCompiler {
 
         const moduleIdent = error.moduleId ?? error.moduleName
 
-        const module = this.compilationStats.children
+        /**
+         * In a perfect world webpack plugins would use the
+         * `nameForCondition` property to identify the module.
+         */
+        let module = this.compilationStats.children
           .flatMap(child => child?.modules)
           .find(
             module =>
               module?.id === moduleIdent || module?.name === moduleIdent,
           )
 
+        /**
+         * If the module is not found, we try to parse the error message
+         */
+        if (!moduleIdent) {
+          const stylelintExtracted = error.message.match(
+            /file:\/\/(.*)\x07(.*)\x1B]8;;/,
+          )
+
+          if (stylelintExtracted?.[1]) {
+            module = {
+              name: stylelintExtracted[2] ?? stylelintExtracted[1],
+              nameForCondition: stylelintExtracted[1],
+            }
+          }
+        }
+
+        /**
+         * If the module is still not found, we return the error as-is
+         */
         if (!module) return error
 
+        /**
+         * We'll prefer the `nameForCondition` property if it exists,
+         * otherwise we'll use the `name` property.
+         */
         if (module.nameForCondition) {
           file = module.nameForCondition
         } else if (module.name) {
@@ -236,8 +266,8 @@ export class Compiler extends Service implements BudCompiler {
 
       return errors?.map(parseError).filter(Boolean)
     } catch (error) {
-      this.app.warn(`error parsing errors`, error)
-      return []
+      this.logger.warn(`error parsing errors`, error)
+      return errors
     }
   }
 }